]> git.sesse.net Git - ffmpeg/commitdiff
lavd/pulse_audio_enc: fix error check
authorLukasz Marek <lukasz.m.luki@gmail.com>
Fri, 18 Oct 2013 21:41:19 +0000 (23:41 +0200)
committerStefano Sabatini <stefasab@gmail.com>
Fri, 18 Oct 2013 21:59:27 +0000 (23:59 +0200)
Error check should be done by checking negative value, not non-zero.

Signed-off-by: Lukasz Marek <lukasz.m.luki@gmail.com>
Signed-off-by: Stefano Sabatini <stefasab@gmail.com>
libavdevice/pulse_audio_enc.c

index 25caa65a95863f9cc5e10287d8b6a6d75326c1ce..0a3aa1ad092425c7042bab13222d345066c67e3d 100644 (file)
@@ -105,7 +105,7 @@ static int pulse_write_packet(AVFormatContext *h, AVPacket *pkt)
     if (s->stream_index != pkt->stream_index)
         return 0;
 
-    if ((error = pa_simple_write(s->pa, buf, size, &error))) {
+    if (pa_simple_write(s->pa, buf, size, &error) < 0) {
         av_log(s, AV_LOG_ERROR, "pa_simple_write failed: %s\n", pa_strerror(error));
         return AVERROR(EIO);
     }