String Review. refs #438

diff --git a/modules/visualization/galaktos/plugin.c b/modules/visualization/galaktos/plugin.c
index c6593b930b9b40b992f4d4e9cdaa44edde9c8db0..d22628c973465113951e13c3eb91a6aaca2f34c5 100644 (file)
--- a/modules/visualization/galaktos/plugin.c
+++ b/modules/visualization/galaktos/plugin.c
@@ -82,7 +82,7 @@ static int Open( vlc_object_t *p_this )
     if ( p_filter->input.i_format != VLC_FOURCC('f','l','3','2' )
          || p_filter->output.i_format != VLC_FOURCC('f','l','3','2') )
     {
-        msg_Warn( p_filter, "Bad input or output format" );
+        msg_Warn( p_filter, "bad input or output format" );
         return VLC_EGENERIC;
     }
     if ( !AOUT_FMTS_SIMILAR( &p_filter->input, &p_filter->output ) )
@@ -219,7 +219,7 @@ static void Thread( vlc_object_t *p_this )
         module_Need( p_thread->p_opengl, "opengl provider", NULL, 0 );
     if( p_thread->p_module == NULL )
     {
-        msg_Err( p_thread, "No OpenGL provider found" );
+        msg_Err( p_thread, "no OpenGL provider found" );
         vlc_object_detach( p_thread->p_opengl );
         vlc_object_destroy( p_thread->p_opengl );
         return;

diff --git a/modules/visualization/goom.c b/modules/visualization/goom.c
index 5d558eff234289a9382891239ed6d923164c88a1..1789fd425bd91b91ac0f14f234308df0bfee31ea 100644 (file)
--- a/modules/visualization/goom.c
+++ b/modules/visualization/goom.c
@@ -136,7 +136,7 @@ static int Open( vlc_object_t *p_this )
     if ( p_filter->input.i_format != VLC_FOURCC('f','l','3','2' )
          || p_filter->output.i_format != VLC_FOURCC('f','l','3','2') )
     {
-        msg_Warn( p_filter, "Bad input or output format" );
+        msg_Warn( p_filter, "bad input or output format" );
         return VLC_EGENERIC;
     }
     if ( !AOUT_FMTS_SIMILAR( &p_filter->input, &p_filter->output ) )

diff --git a/modules/visualization/visual/effects.c b/modules/visualization/visual/effects.c
index 5eb2dd630a766abe58dcf8a6616a59d33a631b8d..21324316821039324d0b4391bf78b3ff04f4cc2d 100644 (file)
--- a/modules/visualization/visual/effects.c
+++ b/modules/visualization/visual/effects.c
@@ -95,7 +95,7 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
 
     if( !p_s16_buff )
     {
-        msg_Err(p_aout,"Out of memory");
+        msg_Err(p_aout,"out of memory");
         return -1;
     }
 
@@ -120,7 +120,7 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
         p_effect->p_data=(void *)malloc(i_nb_bands * sizeof(int) );
         if( !p_effect->p_data)
         {
-            msg_Err(p_aout,"Out of memory");
+            msg_Err(p_aout,"out of memory");
             return -1;
         }
         peaks = (int *)p_effect->p_data;
@@ -139,7 +139,7 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     height = (int *)malloc( i_nb_bands * sizeof(int) );
     if( !height)
     {
-        msg_Err(p_aout,"Out of memory");
+        msg_Err(p_aout,"out of memory");
         return -1;
     }
     /* Convert the buffer to int16_t  */
@@ -157,7 +157,7 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     p_state  = visual_fft_init();
     if( !p_state)
     {
-        msg_Err(p_aout,"Unable to initialize FFT transform");
+        msg_Err(p_aout,"unable to initialize FFT transform");
         return -1;
     }
     p_buffs = p_s16_buff;
@@ -391,7 +391,7 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
 
     if( !p_s16_buff )
     {
-        msg_Err(p_aout,"Out of memory");
+        msg_Err(p_aout,"out of memory");
         return -1;
     }
 
@@ -425,7 +425,7 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
         p_effect->p_data=(void *)malloc(i_nb_bands * sizeof(int) );
         if( !p_effect->p_data)
         {
-            msg_Err(p_aout,"Out of memory");
+            msg_Err(p_aout,"out of memory");
             return -1;
         }
         peaks = (int *)p_effect->p_data;
@@ -442,7 +442,7 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     height = (int *)malloc( i_nb_bands * sizeof(int) );
     if( !height)
     {
-        msg_Err(p_aout,"Out of memory");
+        msg_Err(p_aout,"out of memory");
         return -1;
     }
 
@@ -461,7 +461,7 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     p_state  = visual_fft_init();
     if( !p_state)
     {
-        msg_Err(p_aout,"Unable to initialize FFT transform");
+        msg_Err(p_aout,"unable to initialize FFT transform");
         return -1;
     }
     p_buffs = p_s16_buff;

diff --git a/modules/visualization/visual/visual.c b/modules/visualization/visual/visual.c
index cbd0a7c3e465333f17c4c565f199bfb96066ffdb..2e018a5971d805bd76591c821aa27ada4ecc4c38 100644 (file)
--- a/modules/visualization/visual/visual.c
+++ b/modules/visualization/visual/visual.c
@@ -38,7 +38,7 @@
 #define ELIST_TEXT N_( "Effects list" )
 #define ELIST_LONGTEXT N_( \
       "A list of visual effect, separated by commas.\n"  \
-      "Current effects include: dummy, scope, spectrum" )
+      "Current effects include: dummy, scope, spectrum." )
 
 #define WIDTH_TEXT N_( "Video width" )
 #define WIDTH_LONGTEXT N_( \
@@ -261,7 +261,7 @@ static int Open( vlc_object_t *p_this )
 
                 if( ( psz_eoa = strchr( psz_parser, '}') ) == NULL )
                 {
-                   msg_Err( p_filter, "Unable to parse effect list. Aborting");
+                   msg_Err( p_filter, "unable to parse effect list. Aborting");
                    break;
                 }
                 p_effect->psz_args =
@@ -422,7 +422,7 @@ static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
 {
     aout_filter_t     *p_filter = (aout_filter_t *)p_this;
     /* restart this baby */
-    msg_Dbg( p_filter, "We should restart the visual filter" );
+    msg_Dbg( p_filter, "we should restart the visual filter" );
     return VLC_SUCCESS;
 }
 

diff --git a/modules/visualization/xosd.c b/modules/visualization/xosd.c
index 7b90c1d5c0246ece851974c5b7b08f4897452527..21daa92c2e2e8f1efffb7a1e55924cb7a94737b9 100644 (file)
--- a/modules/visualization/xosd.c
+++ b/modules/visualization/xosd.c
@@ -62,24 +62,25 @@ static int PlaylistNext( vlc_object_t *p_this, const char *psz_variable,
  *****************************************************************************/
 #define POSITION_TEXT N_("Flip vertical position")
 #define POSITION_LONGTEXT N_("Display xosd output on the bottom of the " \
-                             "screen instead of the top")
+                             "screen instead of the top.")
 
 #define TXT_OFS_TEXT N_("Vertical offset")
-#define TXT_OFS_LONGTEXT N_("Vertical offset in pixels of the displayed text")
+#define TXT_OFS_LONGTEXT N_("Vertical offset in pixels of the displayed " \
+                            "text (default 30 px).")
 
 #define SHD_OFS_TEXT N_("Shadow offset")
-#define SHD_OFS_LONGTEXT N_("Offset in pixels of the shadow")
+#define SHD_OFS_LONGTEXT N_("Offset in pixels of the shadow (default 2 px).")
 
 #define FONT_TEXT N_("Font")
-#define FONT_LONGTEXT N_("Font used to display text in the xosd output")
-/* FIXME FIXME FIXME: Gettextize */
-#define COLOUR_TEXT ("Colour")
-#define COLOUR_LONGTEXT ("Colour used to display text in the xosd output")
+#define FONT_LONGTEXT N_("Font used to display text in the xosd output.")
+#define COLOUR_TEXT N_("Color")
+#define COLOUR_LONGTEXT N_("Color used to display text in the xosd output.")
 
 vlc_module_begin();
     set_category( CAT_INTERFACE );
     set_subcategory( SUBCAT_INTERFACE_CONTROL );
     set_description( _("XOSD interface") );
+    set_shortname( "XOSD" );
     add_bool( "xosd-position", 1, NULL, POSITION_TEXT, POSITION_LONGTEXT, VLC_TRUE );
     add_integer( "xosd-text-offset", 30, NULL, TXT_OFS_TEXT, TXT_OFS_LONGTEXT, VLC_TRUE );
     add_integer( "xosd-shadow-offset", 2, NULL,