]> git.sesse.net Git - ffmpeg/commitdiff
vaapi_encode: Add flag to mark encoders supporting only constant-quality
authorMark Thompson <sw@jkqxz.net>
Sun, 23 Sep 2018 21:53:00 +0000 (22:53 +0100)
committerMark Thompson <sw@jkqxz.net>
Sat, 27 Oct 2018 18:35:35 +0000 (19:35 +0100)
And set it for MJPEG.

libavcodec/vaapi_encode.c
libavcodec/vaapi_encode.h
libavcodec/vaapi_encode_mjpeg.c

index e01c3c112bab61412cb190dd25835cd7a6d44493..2fe8501287108389542962a8b7a191d21fa63a56 100644 (file)
@@ -1277,7 +1277,8 @@ static av_cold int vaapi_encode_init_rate_control(AVCodecContext *avctx)
         ctx->va_rc_mode = VA_RC_CQP;
         return 0;
     }
-    if (avctx->flags & AV_CODEC_FLAG_QSCALE ||
+    if (ctx->codec->flags & FLAG_CONSTANT_QUALITY_ONLY ||
+        avctx->flags & AV_CODEC_FLAG_QSCALE ||
         avctx->bit_rate <= 0) {
         if (rc_attr.value & VA_RC_CQP) {
             av_log(avctx, AV_LOG_VERBOSE, "Using constant-quality mode.\n");
index 271d4ef518f70eeadf41c23099548b1a106634c2..965fe65c0b63aa30b5cf2f820117135f88a963db 100644 (file)
@@ -251,6 +251,8 @@ typedef struct VAAPIEncodeContext {
 enum {
     // Codec supports controlling the subdivision of pictures into slices.
     FLAG_SLICE_CONTROL         = 1 << 0,
+    // Codec only supports constant quality (no rate control).
+    FLAG_CONSTANT_QUALITY_ONLY = 1 << 1,
 };
 
 typedef struct VAAPIEncodeType {
index fe8439ce88000176117eb999023d9f744278ff9c..79f43473f52ea824822532d3de452e666ce57274 100644 (file)
@@ -476,6 +476,8 @@ static const VAAPIEncodeProfile vaapi_encode_mjpeg_profiles[] = {
 static const VAAPIEncodeType vaapi_encode_type_mjpeg = {
     .profiles              = vaapi_encode_mjpeg_profiles,
 
+    .flags                 = FLAG_CONSTANT_QUALITY_ONLY,
+
     .configure             = &vaapi_encode_mjpeg_configure,
 
     .picture_params_size   = sizeof(VAEncPictureParameterBufferJPEG),