]> git.sesse.net Git - vlc/log
vlc
13 years agoUsed the AVCodecContext given to AVCodecContext::get_buffer() and not the global...
Laurent Aimar [Fri, 24 Jun 2011 20:40:07 +0000 (22:40 +0200)]
Used the AVCodecContext given to AVCodecContext::get_buffer() and not the global one.

It seems that the global one is not in synch when the callback is called.
When MT was in use, non I420 streams were broken.

13 years agoAdd a fourCC for DTS
Jean-Baptiste Kempf [Tue, 21 Jun 2011 23:59:42 +0000 (01:59 +0200)]
Add a fourCC for DTS

13 years agoBluray: changing the module type from access to access_demux
Jean-Baptiste Kempf [Sun, 12 Jun 2011 23:21:04 +0000 (01:21 +0200)]
Bluray: changing the module type from access to access_demux

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agomake.pl: nicer output
Rafaël Carré [Fri, 24 Jun 2011 01:00:03 +0000 (21:00 -0400)]
make.pl: nicer output

13 years agoremove obsolete messages in configure.ac
Rafaël Carré [Fri, 24 Jun 2011 00:52:18 +0000 (20:52 -0400)]
remove obsolete messages in configure.ac

13 years agofix make dist as pointed by linkfanel
Felix Paul Kühne [Thu, 23 Jun 2011 22:35:19 +0000 (00:35 +0200)]
fix make dist as pointed by linkfanel

13 years agomacosx: fixed trivial merge mistake when broke 'advanced open file'
Felix Paul Kühne [Thu, 23 Jun 2011 21:26:21 +0000 (23:26 +0200)]
macosx: fixed trivial merge mistake when broke 'advanced open file'

13 years agoHack to autodetect Harmattan
Rémi Denis-Courmont [Thu, 23 Jun 2011 12:33:54 +0000 (15:33 +0300)]
Hack to autodetect Harmattan

13 years agoDist file for MeeGo 1.2 Harmattan release
Rémi Denis-Courmont [Thu, 23 Jun 2011 11:47:21 +0000 (14:47 +0300)]
Dist file for MeeGo 1.2 Harmattan release

That stuff should be autodetected (wishful thinking) but it's not.

13 years agoDo not ignore *.mak
Rémi Denis-Courmont [Thu, 23 Jun 2011 11:46:46 +0000 (14:46 +0300)]
Do not ignore *.mak

Some checked-in files match that pattern

13 years agocontrib: do not force the software float ABI on ARM
Rémi Denis-Courmont [Thu, 23 Jun 2011 11:56:45 +0000 (14:56 +0300)]
contrib: do not force the software float ABI on ARM

The toolchain defaults should be correct for the target. This fixes
builds on systems using the VFP registers ("hard-float").

13 years agocontribs: tiger: disable valgrind and documentation
Rémi Denis-Courmont [Thu, 23 Jun 2011 12:34:10 +0000 (15:34 +0300)]
contribs: tiger: disable valgrind and documentation

13 years agoChange log severity from Err to Dbg.
Tomer Barletz [Tue, 14 Jun 2011 20:21:52 +0000 (13:21 -0700)]
Change log severity from Err to Dbg.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
13 years agomacosx: re-implemented time slider to fit the new style
Felix Paul Kühne [Thu, 23 Jun 2011 10:00:51 +0000 (12:00 +0200)]
macosx: re-implemented time slider to fit the new style

clean up here and there

13 years agomacosx: added missing backgrounds for the button bar at the bottom of the window
Felix Paul Kühne [Wed, 22 Jun 2011 22:11:32 +0000 (00:11 +0200)]
macosx: added missing backgrounds for the button bar at the bottom of the window

13 years agomacosx: remove no longer needed ui graphics
Felix Paul Kühne [Wed, 22 Jun 2011 21:05:46 +0000 (23:05 +0200)]
macosx: remove no longer needed ui graphics

13 years agomacosx: clean up the resources folder
Felix Paul Kühne [Wed, 22 Jun 2011 20:52:45 +0000 (22:52 +0200)]
macosx: clean up the resources folder

no functional changes

13 years agomacosx: basic UI to have something as a start
Felix Paul Kühne [Wed, 22 Jun 2011 20:14:36 +0000 (22:14 +0200)]
macosx: basic UI to have something as a start

minor functional changes only

13 years agomacosx: new interface graphics
Damien Erambert [Wed, 22 Jun 2011 20:12:48 +0000 (22:12 +0200)]
macosx: new interface graphics

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
13 years agoQt: enable tearOff on Navigation and Bookmarks menus.
Francois Cartegnie [Wed, 22 Jun 2011 15:05:43 +0000 (17:05 +0200)]
Qt: enable tearOff on Navigation and Bookmarks menus.

13 years agomacosx: added missing fspanel graphic
Felix Paul Kühne [Wed, 22 Jun 2011 14:42:02 +0000 (16:42 +0200)]
macosx: added missing fspanel graphic

13 years agoWinCE: skip fsync() replacement
Pierre Ynard [Tue, 21 Jun 2011 23:20:13 +0000 (01:20 +0200)]
WinCE: skip fsync() replacement

13 years agointf-add: list CLI on win32 regardless of stdin
Pierre Ynard [Tue, 21 Jun 2011 23:01:46 +0000 (01:01 +0200)]
intf-add: list CLI on win32 regardless of stdin

Win32 spawns its own console so this is irrelevant

13 years agoRevert "intf-add: update cli interface name"
Pierre Ynard [Tue, 21 Jun 2011 22:45:06 +0000 (00:45 +0200)]
Revert "intf-add: update cli interface name"

Windows still uses the oldrc interface (which is not aliased as cli).
This reverts commit e1eccb1f1e8e087b04023860f6e92d07eafe8a3d.

13 years agoRemove unused intf_thread_t.psz_intf
Rémi Denis-Courmont [Tue, 21 Jun 2011 20:37:50 +0000 (23:37 +0300)]
Remove unused intf_thread_t.psz_intf

13 years agoLua: use submodules for the different interfaces
Rémi Denis-Courmont [Tue, 21 Jun 2011 20:25:01 +0000 (23:25 +0300)]
Lua: use submodules for the different interfaces

This is better than second-guessing module_need().

13 years agoLua: useless #includes
Rémi Denis-Courmont [Tue, 21 Jun 2011 20:24:44 +0000 (23:24 +0300)]
Lua: useless #includes

13 years agoFix typo preventing correct build
Jean-Baptiste Kempf [Tue, 21 Jun 2011 19:09:37 +0000 (21:09 +0200)]
Fix typo preventing correct build

13 years agoFix previous commit
Rémi Denis-Courmont [Tue, 21 Jun 2011 16:53:53 +0000 (19:53 +0300)]
Fix previous commit

13 years agoAppend version to Fremantle distribution
Rémi Denis-Courmont [Tue, 21 Jun 2011 16:49:36 +0000 (19:49 +0300)]
Append version to Fremantle distribution

13 years agoFrontrow Plugin: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 13:07:13 +0000 (15:07 +0200)]
Frontrow Plugin: Crush PNGs

13 years agoWebUI: typo fix
Jean-Baptiste Kempf [Tue, 21 Jun 2011 13:06:37 +0000 (15:06 +0200)]
WebUI: typo fix

13 years agoMac OS X: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:50:11 +0000 (14:50 +0200)]
Mac OS X: Crush PNGs

13 years agoVLC icons: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:38:52 +0000 (14:38 +0200)]
VLC icons: Crush PNGs

13 years agoDefault skin: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:38:42 +0000 (14:38 +0200)]
Default skin: Crush PNGs

13 years agoOSDmenu: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:38:21 +0000 (14:38 +0200)]
OSDmenu: Crush PNGs

13 years agoMaemo: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:38:07 +0000 (14:38 +0200)]
Maemo: Crush PNGs

13 years agoQt4: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:37:25 +0000 (14:37 +0200)]
Qt4: Crush PNGs

13 years agoWebUI: Crush PNGs
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:23:59 +0000 (14:23 +0200)]
WebUI: Crush PNGs

13 years agoWebUI: actually distribute the files...
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:32:47 +0000 (14:32 +0200)]
WebUI: actually distribute the files...

*cough* *cough*
There is a lot of images/ressource to remove, IMVHO

13 years agoLUA HTTP UI - Adjustments
Elminster2031 [Mon, 20 Jun 2011 21:35:15 +0000 (17:35 -0400)]
LUA HTTP UI - Adjustments

This patch makes some minor adjustments to the UI operation.

1) Add VLC Icons
2) Re-arrange Viewer / Library windows
3) Re-define some button names
4) Change some icons to improve clairity
5) Long press on Prev / Next buttons now seek back / forward

More to come later, including EQ, VLM UI, Maybe Mosaic.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoMention webUI in NEWS
Jean-Baptiste Kempf [Tue, 21 Jun 2011 12:01:09 +0000 (14:01 +0200)]
Mention webUI in NEWS

13 years agomacosx: new fullscreen controller panel graphics
Damien Erambert [Tue, 21 Jun 2011 09:58:04 +0000 (11:58 +0200)]
macosx: new fullscreen controller panel graphics

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
13 years agointf-add: update cli interface name
Rémi Denis-Courmont [Mon, 20 Jun 2011 17:10:00 +0000 (20:10 +0300)]
intf-add: update cli interface name

13 years agointf-add: do not list CLI if stdin is not a TTY (fix #4955)
Rémi Denis-Courmont [Mon, 20 Jun 2011 17:07:48 +0000 (20:07 +0300)]
intf-add: do not list CLI if stdin is not a TTY (fix #4955)

13 years agoRespect --no-playliust-autostart (fix #3541)
Rémi Denis-Courmont [Mon, 20 Jun 2011 16:54:06 +0000 (19:54 +0300)]
Respect --no-playliust-autostart (fix #3541)

13 years agoPlaylist: create playlist-autostart just once
Rémi Denis-Courmont [Mon, 20 Jun 2011 16:51:51 +0000 (19:51 +0300)]
Playlist: create playlist-autostart just once

13 years agoTurn --services-discovery into a string advanced option
Rémi Denis-Courmont [Sat, 28 May 2011 14:20:53 +0000 (17:20 +0300)]
Turn --services-discovery into a string advanced option

Modules list was intended for plain static module names. It does not
work right for most SD plugins, including:
 - LUA (dependent on string chain),
 - udev (submodules),
 - media directories (submodules).

It works but is totally useless for those plugins that are fast,
including XCB screen capture and Windows optical drives.

For network-based discovery and MTP, it could be used to prefetch
items. But this is not necessarily a good idea as it sends extra
network traffic and consumes memory even when the services discovery
is not used. Furthermore, podcast can prevent Qt4 and Skins2 UI from
starting, as it depends on HTTP which depends on libproxy which
depends on Xlib.

13 years agoDeprecate vlc_object_alive()
Rémi Denis-Courmont [Mon, 20 Jun 2011 16:30:44 +0000 (19:30 +0300)]
Deprecate vlc_object_alive()

The biggest landmark of thread-unsafety.

13 years agoDeprecate playlist_IsServicesDiscoveryLoaded()
Rémi Denis-Courmont [Mon, 20 Jun 2011 16:25:05 +0000 (19:25 +0300)]
Deprecate playlist_IsServicesDiscoveryLoaded()

With the introduction, initially for LUA SD, of the chain syntax to
the services discovery, there is no way to canonicalize the name of
a services discovery object. Thus, they cannot be compared reliably,
and therefore, playlist_IsServicesDiscoveryLoaded() does not operate
correctly. I won't remove it today because too many interfaces call it.
But you should know that this function does _not_ actually work, and I
see no way to fix it (other than remove LUA SD).

Futhermore, this function is fundamentally prone to a race condition,
when it is used to toggle an SD (this is admittedly a minor problem).

13 years agocontribs: updated NDAPI sdk location, which also includes nice sample code now
Felix Paul Kühne [Mon, 20 Jun 2011 15:50:17 +0000 (17:50 +0200)]
contribs: updated NDAPI sdk location, which also includes nice sample code now

13 years agomacosx: fixed incorrect URL creation (closes #4966)
Felix Paul Kühne [Mon, 20 Jun 2011 15:34:15 +0000 (17:34 +0200)]
macosx: fixed incorrect URL creation (closes #4966)

13 years agoNew LUA Web Interface
Elminster2031 [Wed, 15 Jun 2011 19:40:58 +0000 (15:40 -0400)]
New LUA Web Interface

This patch removes the existing interface and replaces it with a cleaner more
user-friendly interface.

Screenshots are available here: http://www.archmageinc.com/vlc

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoWeb intf: new CSS and images for the updated interface
Elminster2031 [Mon, 20 Jun 2011 09:54:00 +0000 (11:54 +0200)]
Web intf: new CSS and images for the updated interface

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoWeb intf: Add jQuery, jQueryUI and jQuery jstree modules
Elminster2031 [Mon, 20 Jun 2011 09:52:15 +0000 (11:52 +0200)]
Web intf: Add jQuery, jQueryUI and jQuery jstree modules

And the corresponding ui theme

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoQt: equalizer, more consistency in format
Akash Mehrotra [Sun, 19 Jun 2011 19:33:08 +0000 (01:03 +0530)]
Qt: equalizer, more consistency in format

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agomkv: Avoid duplicating the entire vector.
Hugo Beauzée-Luyssen [Tue, 24 May 2011 09:43:59 +0000 (11:43 +0200)]
mkv: Avoid duplicating the entire vector.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoSVCD: remove the useless debug option and associated text
Jean-Baptiste Kempf [Fri, 17 Jun 2011 23:03:21 +0000 (01:03 +0200)]
SVCD: remove the useless debug option and associated text

Seriously, this is WTF-code

13 years agolinsys SDI: change shortnames
Jean-Baptiste Kempf [Fri, 17 Jun 2011 22:35:17 +0000 (00:35 +0200)]
linsys SDI: change shortnames

13 years agoVisual: remove 5 translation text
Jean-Baptiste Kempf [Fri, 17 Jun 2011 22:31:01 +0000 (00:31 +0200)]
Visual: remove 5 translation text

It is a bit ridiculous to have 34 translations needed for such a small
module...

13 years agoMpeg-TS demuxer: fix typo and use one less string
Jean-Baptiste Kempf [Fri, 17 Jun 2011 15:00:55 +0000 (17:00 +0200)]
Mpeg-TS demuxer: fix typo and use one less string

13 years agoRun installed vlc-cache-gen rather than build-tree libtool script
Rémi Denis-Courmont [Sun, 19 Jun 2011 17:13:41 +0000 (20:13 +0300)]
Run installed vlc-cache-gen rather than build-tree libtool script

This ensures we use the installed libvlc(core) run-time, and might
fix some obscure crashes.

13 years ago*.lua: handle recv() returning nil
Rafaël Carré [Sun, 19 Jun 2011 16:21:48 +0000 (12:21 -0400)]
*.lua: handle recv() returning nil

13 years agovlclua_net_recv() : do like [b0d7c77b1] did for vlclua_fd_read()
Rafaël Carré [Sun, 19 Jun 2011 16:15:42 +0000 (12:15 -0400)]
vlclua_net_recv() : do like [b0d7c77b1] did for vlclua_fd_read()

13 years agoremove warnings
Rafaël Carré [Sun, 19 Jun 2011 15:52:18 +0000 (11:52 -0400)]
remove warnings

13 years agoinit_rand48(): only run once
Rafaël Carré [Sun, 19 Jun 2011 15:52:00 +0000 (11:52 -0400)]
init_rand48(): only run once

13 years agostream_out_select: no need for a tmp buffer to msg_Info()
Rafaël Carré [Sun, 19 Jun 2011 15:51:26 +0000 (11:51 -0400)]
stream_out_select: no need for a tmp buffer to msg_Info()

13 years agoUse correct type for vlc_atomic_dec
Rafaël Carré [Sun, 19 Jun 2011 04:57:18 +0000 (00:57 -0400)]
Use correct type for vlc_atomic_dec

13 years agobluray: fix compilation according to last libbluray commits. (the values can be tuned).
Rémi Duraffort [Sun, 19 Jun 2011 12:12:24 +0000 (14:12 +0200)]
bluray: fix compilation according to last libbluray commits. (the values can be tuned).

13 years agoCreate and copy the meta array only if the copied item does have one.
Rémi Duraffort [Sun, 19 Jun 2011 09:41:56 +0000 (11:41 +0200)]
Create and copy the meta array only if the copied item does have one.

13 years agogoom: simplify.
Rémi Duraffort [Sun, 19 Jun 2011 09:41:00 +0000 (11:41 +0200)]
goom: simplify.

13 years agomodplug: use var_Inherit when applicable.
Rémi Duraffort [Sun, 19 Jun 2011 09:12:05 +0000 (11:12 +0200)]
modplug: use var_Inherit when applicable.

13 years agolua: remove debug printf and update the doc
Rémi Duraffort [Sat, 18 Jun 2011 16:16:18 +0000 (18:16 +0200)]
lua: remove debug printf and update the doc

13 years agolua playlist: add custom metadata to extra metadata instead of input item information.
Rémi Duraffort [Sat, 18 Jun 2011 14:55:03 +0000 (16:55 +0200)]
lua playlist: add custom metadata to extra metadata instead of input item information.

Fix #4822 and #4823.

13 years agoAdd libvlc_media_list_player_retain() to libvlc.
Alexey Sokolov [Tue, 31 May 2011 08:00:20 +0000 (15:00 +0700)]
Add libvlc_media_list_player_retain() to libvlc.

There was only release() before.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
13 years agolua: fix warning
Rémi Duraffort [Sat, 18 Jun 2011 13:31:16 +0000 (15:31 +0200)]
lua: fix warning

13 years agolua: fix object leaks.
Rémi Duraffort [Sat, 18 Jun 2011 13:27:48 +0000 (15:27 +0200)]
lua: fix object leaks.

13 years agorc: remove uneeded cast.
Rémi Duraffort [Sat, 18 Jun 2011 13:26:15 +0000 (15:26 +0200)]
rc: remove uneeded cast.

13 years agoQt4: don't keep reference to toAscii() temporary array
Rémi Denis-Courmont [Sat, 18 Jun 2011 09:57:56 +0000 (12:57 +0300)]
Qt4: don't keep reference to toAscii() temporary array

(See also previous commit)

13 years agoQt4: never assign qtu() to a variable
Rémi Denis-Courmont [Sat, 18 Jun 2011 09:53:35 +0000 (12:53 +0300)]
Qt4: never assign qtu() to a variable

As far as I understand, this breaks C++ object scoping. qtu() creates
a temporary anonymous QByteArray from its QString parameter. That array
is destroyed at the end of the expression, thus the return value of
qtu() becomes a dangling pointer.

13 years agoQt4: use QString or QByteArray instead of strdup()/free()
Rémi Denis-Courmont [Sat, 18 Jun 2011 09:53:12 +0000 (12:53 +0300)]
Qt4: use QString or QByteArray instead of strdup()/free()

13 years agodvdnav: also white-list *.img files (fixes #4951)
Rémi Denis-Courmont [Sat, 18 Jun 2011 09:05:28 +0000 (12:05 +0300)]
dvdnav: also white-list *.img files (fixes #4951)

13 years agoWin32: fsync() replacement
Rémi Denis-Courmont [Sat, 18 Jun 2011 08:49:36 +0000 (11:49 +0300)]
Win32: fsync() replacement

13 years agoSmall simplification
Rémi Denis-Courmont [Sat, 18 Jun 2011 08:48:26 +0000 (11:48 +0300)]
Small simplification

13 years agolua: remove spurious strdup (a string is valid as long as it stays on the stack)
Rémi Duraffort [Fri, 17 Jun 2011 21:26:57 +0000 (23:26 +0200)]
lua: remove spurious strdup (a string is valid as long as it stays on the stack)

13 years agoAdd serbian translator
Christophe Mutricy [Thu, 16 Jun 2011 22:47:48 +0000 (23:47 +0100)]
Add serbian translator

13 years agoNews
Rémi Denis-Courmont [Thu, 16 Jun 2011 18:08:42 +0000 (21:08 +0300)]
News

13 years agoOpenMAX DL: scaling and combined YUV->RGB + scaling
Rémi Denis-Courmont [Thu, 16 Jun 2011 18:07:08 +0000 (21:07 +0300)]
OpenMAX DL: scaling and combined YUV->RGB + scaling

13 years agoUpdate LIST
Rémi Denis-Courmont [Thu, 16 Jun 2011 14:47:13 +0000 (17:47 +0300)]
Update LIST

13 years agoVideo chroma conversions using OpenMAX DL v1.0.2 IP CS(*)
Rémi Denis-Courmont [Thu, 16 Jun 2011 14:43:20 +0000 (17:43 +0300)]
Video chroma conversions using OpenMAX DL v1.0.2 IP CS(*)

* Development layer / Image processing / Color space conversion

CFLAGS and LIBS must be tweaked manually to use this.

13 years agoARM NEON: fix smurf in conversions from YV12 to YUY2
Rémi Denis-Courmont [Thu, 16 Jun 2011 14:36:22 +0000 (17:36 +0300)]
ARM NEON: fix smurf in conversions from YV12 to YUY2

13 years agoDxVA2: Add the GUIDs for MPEG-4 Part 2
Jean-Baptiste Kempf [Thu, 16 Jun 2011 11:09:23 +0000 (13:09 +0200)]
DxVA2: Add the GUIDs for MPEG-4 Part 2

Not used yet. It should also support H.263

13 years agoDxVA2: add the GUID for H264/VLD With FMO/ASO
Jean-Baptiste Kempf [Thu, 16 Jun 2011 10:51:13 +0000 (12:51 +0200)]
DxVA2: add the GUID for H264/VLD With FMO/ASO

As per the updated specification of December 2010

13 years agodbus: use the correct volume variables
Rafaël Carré [Wed, 15 Jun 2011 21:12:26 +0000 (17:12 -0400)]
dbus: use the correct volume variables

13 years agoupdate: factorize using macro
Rafaël Carré [Wed, 15 Jun 2011 21:11:57 +0000 (17:11 -0400)]
update: factorize using macro

also fix a memleak in an error path

13 years agocorrect comments
Rafaël Carré [Wed, 15 Jun 2011 05:15:49 +0000 (01:15 -0400)]
correct comments

13 years agosystem_Init(): remove unused arguments
Rafaël Carré [Wed, 15 Jun 2011 04:29:25 +0000 (00:29 -0400)]
system_Init(): remove unused arguments

darwin relied on argv[0] as a fallback to retrieve executable name,
but this can't work anymore as:
- libvlc_new() can be given anything as argc/argv
- libvlc_new() inserts "libvlc" at position 0 anyway

13 years agocli.lua: handles ^D in the console (rvlc)
Rafaël Carré [Wed, 15 Jun 2011 03:55:16 +0000 (23:55 -0400)]
cli.lua: handles ^D in the console (rvlc)

13 years agovlc-thumb: use pthread conditions
Rafaël Carré [Wed, 15 Jun 2011 03:25:25 +0000 (23:25 -0400)]
vlc-thumb: use pthread conditions

Also use a static boolean if the condition has been signaled
before we start waiting on it: libvlc_MediaPlayerSnapshotTaken event
is serialized with libvlc_video_take_snapshot() so when the function
returns the event already happened.

13 years agoremove outdated comment
Rafaël Carré [Wed, 15 Jun 2011 02:30:17 +0000 (22:30 -0400)]
remove outdated comment