qtpalette: make the color_* variables unsigned again

This fixes segmentation faults due to out of bounds writes, when
color_start is interpreted as negative number.

This regression was introduced in commit 57631f.

Reviewed-by: Mats Peterson <matsp888@yahoo.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

avcodec/wavpackenc: Check the number of channels

They are stored in a byte, thus more than 255 is not possible

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/wavpackenc: Headers are per channel

Fixes: 1b8b83a53bfa751f01b1daa65a4758db/signal_sigabrt_7ffff6ae7cb7_7488_403f71d1a2565b598d01b6cb110fac8f.aiff
Fixes: assertion failure
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avformat/dfa: Fix packet leak on error

Fixes: 07fa81f300736485e585b63e7b1cd155/signal_sigabrt_7ffff6ae7cb7_16_94ee815791a1357826524072db5bc2dc.dfa
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavf/matroskadec: Normalize noncompliant A_QUICKTIME/V_QUICKTIME private data

This patch adds a new static function get_qt_codec() that takes care of
the initial retrieval of the fourcc and codec ID for A_QUICKTIME and
V_QUICKTIME. It also normalizes noncompliant private data found in some
older files that incorrectly starts with the fourcc by expanding/shifting
the data by 4 bytes, and storing the data size at the start. This is
necessary in order for the rest of the code in the A_QUICKTIME and
V_QUICKTIME blocks (and most likely other code as well) to correctly
parse the private data.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/ac3enc: Remove duplicate #include

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/aacdec_template: Check id_map

Fixes index out of bounds error
Fixes: aac_index_out_of_bounds.wmv
Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/dvdec: Fix "left shift of negative value -254"

Fixes: dvdec_left_shift.avi
Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/g2meet: Check for ff_els_decode_bit() failure in epic_decode_run_length()

Fixes invalid shift
Fixes: g2m_left_shift_2.wmv
Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

fate: fix sub-cc font

lavc/ccaption_dec: improve default style

Use monospaced font, and a black box outline.

avcodec/mjpegdec: Fix negative shift

Fixes: mjpeg_left_shift.avi
Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavc/x264: Add compatibility values for coder options.

Fixes ticket #5142.

lavf/concatdec: do not access packet if av_read_frame returned error

Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Marton Balint <cus@passwd.hu>

lavc/ccaption_dec: fix ASS tags

avcodec/mss2: Check for repeat overflow

Fixes: mss2_left_shift.wmv
Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/codec_desc: Add ff_aac_profiles to aac_latm

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avf_showspectrum: Silence "deprecated pixel format" warning

avfilter/avf_showspectrum: set color range to frame

Signed-off-by: Paul B Mahol <onemda@gmail.com>

libvpx: Support setting color range for vp9.

Pass through color range to vp9 encoder. Parse color range in libvpxdec.c.

Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Sasi Inguva <isasi@google.com>
Signed-off-by: James Almer <jamrial@gmail.com>

avformat: Add integer fps from 31 to 60 to get_std_framerate()

Fixes Ticket 5106

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

doc/encoders: fix typo in AAC encoder documentation

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>

lavc/ccaption_dec: simplify rollup cases

lavc/ccaption_dec: check for bprint completeness outside the loop

lavc/ccaption_dec: mark row and font as const in capture_screen()

lavc/ccaption_dec: fix mixed declarations and code warning

lavc/ccaption_dec: check for bprint completeness only at the end

lavc/ccaption_dec: implement font styles

lavc/ccaption_dec: simplify by incrementing cursor_column inside write_char()

lavc/ccaption_dec: simplify by passing screen into write_char()

lavc/ccaption_dec: extract capture_screen() for future use

unlike reap_screen(), capture_screen() can be used to populate buffer
without touching the timestamps. this is useful for upcoming commits
which implement a real time caption stream.

lavc/ccaption_dec: clear buffer before populating with screen contents

lavc/ccaption_dec: centralize buffer_changed=1 into reap_screen

lavc/ccaption_dec: rename screen_changed to buffer_changed

lavc/ccaption_dec: extract ass time base into constant

lavc/ccaption_dec: combine ROLLUP modes as they are identical

Revert "lavc/ccaption_dec: reap_screen() is responsible for clearing output buffer and signaling screen_changed"

This reverts commit 53ee84f811c3a3e55c688116d41310e76d285d9e.

Revert "lavc/ccaption_dec: implement "erase non displayed memory""

This reverts commit 26abdd61a39735c7907297e9b5c8bfe5255be555.

Revert "lavc/ccaption_dec: reap_screen is not necessary when clearing screen or buffer"

This reverts commit fe225b113b0553cdcf1a1d2fbdbe37c467d7951b.

lavc/libvpxenc: Improve documentation for option cpu-used.

Fixes ticket #5140.
Reviewed-by: James Zern

avformat/movenc: Check that pkt duration is within 32bit range

Durations outside are not supported

Fixes Ticket5114
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

configure: Use libgcrypt-config's cflags

Signed-off-by: James Almer <jamrial@gmail.com>

avformat/ivfenc: fix division by zero

Fixes Ticket 5115

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavc/ccaption_dec: reap_screen is not necessary when clearing screen or buffer

configure: Use libgcrypt-config if available

Signed-off-by: Ricardo Constantino <wiiaboo@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavc/ccaption_dec: implement "erase non displayed memory"

lavc/ccaption_dec: reap_screen() is responsible for clearing output buffer and signaling screen_changed

moves the screen_changed bit and the bprint_clear into reap_screen() so
the logic is centralized and callers do not need to touch the bit or the
buffer before calling reap_screen()

x86/float_dsp: zero extend offset from ff_scalarproduct_float_sse

Reviewed-by: Christophe Gisquet <christophe.gisquet@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

x86/float_dsp: zero extend len from ff_butterflies_float_sse implicitly

Reviewed-by: Christophe Gisquet <christophe.gisquet@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

x86/float_dsp: remove len check from ff_butterflies_float_sse

The function documentation explicitly mentions it needs to be a multiple of 4.

Reviewed-by: Christophe Gisquet <christophe.gisquet@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

lavc/ccaption_dec: remove unused return value from internal functions

lavc/ccaption_dec: clean up whitespace

avfilter/avf_showspectrum: add cool color map

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avfilter/avf_showfreqs: fix possible null pointer dereference

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avformat/mov: Simplify format checking code

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

In many older QuickTime files, the audio format, or "fourcc", is
0x00000000. The QuickTime File Format Specification states the following
regarding this situation:

"This format descriptor should not be used, but may be found in some
files. Samples are assumed to be stored in either 'raw ' or 'twos'
format, depending on the sample size field in the sound description."

MPlayer handles this logic by itself, but FFmpeg/FFplay currently does
not.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavf/mov: Audio and fourcc 0x00000000

In many older QuickTime files, the audio format, or "fourcc", is
0x00000000. The QuickTime File Format Specification states the following
regarding this situation:

"This format descriptor should not be used, but may be found in some
files. Samples are assumed to be stored in either 'raw ' or 'twos'
format, depending on the sample size field in the sound description."

MPlayer handles this logic by itself, but FFmpeg/FFplay currently does
not.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

avfilter/avf_showspectrum: add option to draw legend

Signed-off-by: Paul B Mahol <onemda@gmail.com>

ffmpeg: check fclose return values

In the spirit of commit a956840cbc. Simple method to reproduce:
pass -vstats_file /dev/full to ffmpeg.

All raw fclose usages in ffmpeg.c taken care of here.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

lavfi/avf_showspectrum: replace pow(x, 0.25) by sqrt(sqrt(x))

This is faster; precision assured as result is a float.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

configure: remove unused bulitin check

Signed-off-by: James Almer <jamrial@gmail.com>

lavu: rename and move ff_parity to av_parity

av_popcount is not defined in intmath.h.

Reviewed-by: ubitux
Signed-off-by: James Almer <jamrial@gmail.com>

lavc/g729dec: use ff_parity()

lavc/ccaption_dec: use ff_parity()

lavu: add ff_parity()

lavc/ccaption_dec: fix always true condition

No idea why this wasn't ever detected by a static analyzer.

lavu/common: add an explanation to FF_CEIL_RSHIFT()

lavf/uncodedframecrcenc: use FF_CEIL_RSHIFT()

lavfi/deshake: use FF_CEIL_RSHIFT()

lavu/common: fix FF_CEIL_RSHIFT() range comment

x86/intmath: add sse optimized av_clipf and av_clipd

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

avfilter/formats: fix leak of formats on error

Signed-off-by: Paul B Mahol <onemda@gmail.com>

ffmpeg: replace log2 by av_log2

Slight change in output deemed irrelevant here.

Reviewed-by: Hendrik Leppkes <h.leppkes@gmail.com>
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avcodec/utils: Check bits_per_raw_sample on video encoder open

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/mpegvideo_enc: Clip bits_per_raw_sample within valid range

Fixes out of array read
Fixes: test_case-mdc.264 (b47be15a120979f5a1a945c938cbef33)
Found-by: Tyson Smith <twsmith@mozilla.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

libavcodec/ccaption_dec: clean up and standardize white space

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

configure: use warn() for mips unknown cpu warning

Found-by: ubitux
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

mips: display a warning message when using an unknown CPU

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec: Remove libstagefright

It serves absolutely no purpose other than to confuse potentional
Android developers about how to use hardware acceleration properly
on the the platform. The stagefright "API" is not public, and the
MediaCodec API is the proper way to do this.

Furthermore, stagefright support in avcodec needs a series of
magic incantations and version-specific stuff, such that
using it actually provides downsides compared just using the actual
Android frameworks properly, in that it is a lot more work and confusion
to get it even running. It also leads to a lot of misinformation, like
these sorts of comments (in [1]) that are absolutely incorrect.

[1] http://stackoverflow.com/a/29362353/3115956

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>

avfilter/vf_pad: fix direct padding

Signed-off-by: Paul B Mahol <onemda@gmail.com>

lavf/matroskadec: correct codec_tag for "SMI" SVQ3 files

This corrects the codec_tag for some SVQ3 files

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavfi/af_compensationdelay: replace pow(x,0.5) by sqrt(x)

sqrt is faster, and is sometimes more accurate depending on the libm.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

ffmpeg: check return value of avio_closep for progress report

avio_closep is not guaranteed to succeed, and its return value can
contain information regarding failure of preceding writes and silent
loss of data (man 2 close, man fclose). Users should know when the
progress was not successfully logged, and so a diagnostic is printed
here.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avpacket: fix size check in packet_alloc

The previous check only caught sizes from -AV_INPUT_BUFFER_PADDING_SIZE
to -1.

This fixes ubsan runtime error: signed integer overflow: 2147483647 + 32
cannot be represented in type 'int'

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

parser: add av_assert1 to make sure the codec matches

Otherwise this can have some surprising effects (crashes), so let's
better not allow it.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

lavf/matroskaenc: Assume 48kHz sample rate for Opus initial padding.

Analyzed by Timothy B. Terriberry in Mozilla bug 1227153.
Fixes ticket #5121.

avcodec/motion_est: Fix mv_penalty table size

Fixes out of array read

Found-by: Tyson Smith <twsmith@mozilla.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

libavcodec/ccaption_dec: remove unnecessary include

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avfilter/avf_avectorscope: add line drawing support

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avfilter/window_func: add tukey window function

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avfilter/avf_showspectrum: use av_clip/lrintf

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avfilter/avf_showspectrum: add yet another color map

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avcodec/dxv: Check idx in dxv_decompress_dxt5()

Fixes potential out of array read

No testcase available

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/dxv: Check idx in CHECKPOINT()

Fixes out of array read

Fixes Ticket5098
Fixes Ticket5099

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavc/pcm_tablegen: slight speedup of table generation

This gets rid of some branches to speed up table generation slightly
(impact higher on mulaw than alaw). Tables are identical to before,
tested with FATE.

Sample benchmark (Haswell, GNU/Linux+gcc):
old:
 313494 decicycles in build_alaw_table,    4094 runs,      2 skips
 315959 decicycles in build_alaw_table,    8190 runs,      2 skips

 323599 decicycles in build_ulaw_table,    4095 runs,      1 skips
 318849 decicycles in build_ulaw_table,    8188 runs,      4 skips

new:
 261902 decicycles in build_alaw_table,    4096 runs,      0 skips
 266519 decicycles in build_alaw_table,    8192 runs,      0 skips

 209657 decicycles in build_ulaw_table,    4096 runs,      0 skips
 232656 decicycles in build_ulaw_table,    8192 runs,      0 skips

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avcodec/h264_slice: Fix integer overflow in implicit weight computation

Fixes mozilla bug 1230423

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

swscale/utils: Use normal bilinear scaler if fast cannot be used due to tiny dimensions

Fixes Ticket4960

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/h264_refs: Fix and add back trace code removed in e1c5170c638e39a8017827339ac687c5f6ff9b35