]>
git.sesse.net Git - mlt/log
Christian Marillat [Wed, 25 Jul 2012 06:58:32 +0000 (08:58 +0200)]
vdpau compilation fix for ffmpeg 0.11
In file included from producer_avformat.c:157:0:
vdpau.c: In function ‘vdpau_get_buffer’:
vdpau.c:162:10: error: ‘AVFrame’ has no member named ‘age’
vdpau.c:169:10: error: ‘AVFrame’ has no member named ‘age’
Dan Dennedy [Wed, 25 Jul 2012 03:53:00 +0000 (20:53 -0700)]
Merge pull request #4 from mcfrisk/coverity
A few Coverity fixes
Mikko Rapeli [Tue, 24 Jul 2012 17:55:47 +0000 (19:55 +0200)]
mlt_consumer_start(): check return value from mlt_properties_get_int()
Fixes Coverity CID 709343: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "mlt_properties_get_int(properties, "frame_rate_num")" which may be zero has undefined behavior
On this path, function call "mlt_properties_get_int(properties, "frame_rate_num")" has return value of 0
442 int frame_duration =
1000000 / mlt_properties_get_int( properties, "frame_rate_num" ) *
443 mlt_properties_get_int( properties, "frame_rate_den" );
Mikko Rapeli [Tue, 24 Jul 2012 17:44:53 +0000 (19:44 +0200)]
mlt_consumer_start(): get mutex before accessing put_active
Fixes Coverity CID 709355: Data race condition (MISSING_LOCK)
Accessing variable "self->put_active" (mlt_consumer_s.put_active) requires the mlt_consumer_s.put_mutex lock.
411 self->put_active = 1;
Mikko Rapeli [Tue, 24 Jul 2012 17:35:14 +0000 (19:35 +0200)]
mlt_consumer_new(): handle return value from mlt_consumer_init()
If init() fails return NULL. Fixes Coverity CID 709325.
At conditional (1): "self != NULL" taking the true branch.
339 if ( self != NULL )
CID 709325: Unchecked return value (CHECKED_RETURN)
Calling function "mlt_consumer_init" without checking return value (as is done elsewhere 10 out of 11 times).
No check of the return value of "mlt_consumer_init(self, NULL, profile)".
340 mlt_consumer_init( self, NULL, profile );
Mikko Rapeli [Tue, 24 Jul 2012 17:19:24 +0000 (19:19 +0200)]
mlt_consumer.c: watch out for null pointer
Fixes Coverity CID 709393: Dereference before null check (REVERSE_INULL)
Directly dereferencing pointer "profile".
235 profile->sample_aspect_num = mlt_properties_get_int( properties, "sample_aspect_num" );
Dereferencing "profile" before a null check.
236 if ( profile )
Mikko Rapeli [Mon, 23 Jul 2012 12:28:38 +0000 (14:28 +0200)]
mlt_cache.c: watch out for null pointer
Fixes Coverity CID 709346: Dereference after null check (FORWARD_NULL)
Comparing "result" to null implies that "result" might be null.
449 if ( result && result->data )
450 result->refcount++;
Dereferencing null variable "result".
451 mlt_log( NULL, MLT_LOG_DEBUG, "%s: get %d = %p, %p\n", __FUNCTION__, cache->count - 1, *hit, result->data );
452
Mikko Rapeli [Mon, 23 Jul 2012 12:26:19 +0000 (14:26 +0200)]
mlt_cache.c: check for null pointer
Fixes CID 709392: Dereference before null check (REVERSE_INULL).
Mikko Rapeli [Mon, 2 Jul 2012 18:44:08 +0000 (21:44 +0300)]
riff.cc: Fail if lseek() fails
Fixes Coverity CID 709362: Argument cannot be negative (NEGATIVE_RETURNS)
Function "lseek(this->fd, 0LL, 0)" returns a negative number.
Assigning: signed variable "pos" = "lseek".
...
"pos" is passed to a parameter that cannot be negative.
548 fail_if( lseek( fd, pos, SEEK_SET ) == ( off_t ) - 1 );
Mikko Rapeli [Mon, 2 Jul 2012 18:39:46 +0000 (21:39 +0300)]
riff.cc: Initialize data in constructor
Fixes Coverity CID 709444: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""length"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""name"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""offset"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""parent"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""type"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""written"" is not initialized in this constructor nor in any functions that it calls.
Dan Dennedy [Tue, 24 Jul 2012 06:12:04 +0000 (23:12 -0700)]
fix crash when switching image formats with alpha
This happens when switching from image format with distinct alpha
channel (yuv422) to one with embedded alpha channel (rgb24a).
Reported-by: j-b-m
Dan Dennedy [Tue, 24 Jul 2012 06:09:52 +0000 (23:09 -0700)]
fix memory read error found by valgrind
Dan Dennedy [Mon, 23 Jul 2012 06:29:52 +0000 (23:29 -0700)]
fix memory leak and missing unlock (coverity-709377 & 709354)
Dan Dennedy [Mon, 23 Jul 2012 04:16:02 +0000 (21:16 -0700)]
fix possible divide by zero (coverity-709344)
Dan Dennedy [Mon, 23 Jul 2012 04:11:46 +0000 (21:11 -0700)]
remove dead code (coverity-709337)
Dan Dennedy [Mon, 23 Jul 2012 04:08:22 +0000 (21:08 -0700)]
remove dead code (coverity-709335 & 709336)
Dan Dennedy [Mon, 23 Jul 2012 04:05:25 +0000 (21:05 -0700)]
remove dead code (coverity-709334)
Dan Dennedy [Mon, 23 Jul 2012 04:02:54 +0000 (21:02 -0700)]
fix faulty image format tests (coverity-709330, 709331, & 709332)
Dan Dennedy [Mon, 23 Jul 2012 02:16:49 +0000 (19:16 -0700)]
fix memory leak (coverity-709387, 709388, & 709389)
Dan Dennedy [Mon, 23 Jul 2012 16:21:55 +0000 (09:21 -0700)]
fix crash on null pointer
reported by Mikko Rapeli
Dan Dennedy [Mon, 23 Jul 2012 16:18:34 +0000 (09:18 -0700)]
initialze with calloc instead of memberwise (future-proofing)
Dan Dennedy [Mon, 23 Jul 2012 16:16:11 +0000 (09:16 -0700)]
fix uninitialized memory in mlt_events
Dan Dennedy [Sun, 22 Jul 2012 15:37:34 +0000 (08:37 -0700)]
fix regression building on 32-bit
Dan Dennedy [Mon, 23 Jul 2012 01:59:26 +0000 (18:59 -0700)]
fix uninitialized memory (coverity-709434)
Dan Dennedy [Mon, 23 Jul 2012 01:58:04 +0000 (18:58 -0700)]
fix out-of-bounds read (coverity-709368)
Dan Dennedy [Mon, 23 Jul 2012 01:44:14 +0000 (18:44 -0700)]
fix memory leak (coverity-710866)
Dan Dennedy [Mon, 23 Jul 2012 01:42:23 +0000 (18:42 -0700)]
fix memory leak (coverity-710865)
Dan Dennedy [Mon, 23 Jul 2012 01:39:54 +0000 (18:39 -0700)]
fix memory leak (coverity-710864)
Dan Dennedy [Mon, 23 Jul 2012 01:37:28 +0000 (18:37 -0700)]
fix memory leak (coverity-710863)
Dan Dennedy [Mon, 23 Jul 2012 01:34:44 +0000 (18:34 -0700)]
fix uninitialized var (coverity-709434)
Dan Dennedy [Mon, 23 Jul 2012 00:39:08 +0000 (17:39 -0700)]
fix uninitialized var (coverity-709433)
Dan Dennedy [Mon, 23 Jul 2012 00:35:53 +0000 (17:35 -0700)]
fix uninitialized array (coverity-709432)
Dan Dennedy [Mon, 23 Jul 2012 00:34:16 +0000 (17:34 -0700)]
fix uninitialized vars (coverity-709430 & 709431)
Dan Dennedy [Mon, 23 Jul 2012 00:32:51 +0000 (17:32 -0700)]
fix memory leak (coverity-709391)
Dan Dennedy [Mon, 23 Jul 2012 00:20:23 +0000 (17:20 -0700)]
remove unused function (coverity-709390)
Dan Dennedy [Mon, 23 Jul 2012 00:12:33 +0000 (17:12 -0700)]
fix memory leak (coverity-709386)
Dan Dennedy [Mon, 23 Jul 2012 00:06:16 +0000 (17:06 -0700)]
fix file handle leak (coverity-709383)
Dan Dennedy [Mon, 23 Jul 2012 00:03:26 +0000 (17:03 -0700)]
fix memory leak (coverity-709382)
Dan Dennedy [Mon, 23 Jul 2012 00:01:25 +0000 (17:01 -0700)]
fix file handle leak (coverity-709381)
Dan Dennedy [Sun, 22 Jul 2012 23:59:09 +0000 (16:59 -0700)]
fix memory leak (coverity-709380)
Dan Dennedy [Sun, 22 Jul 2012 23:58:49 +0000 (16:58 -0700)]
add Service::get_profile() returns mlt_profile
Dan Dennedy [Sun, 22 Jul 2012 23:47:05 +0000 (16:47 -0700)]
fix memory leak (coverity-709379)
Dan Dennedy [Sun, 22 Jul 2012 23:31:36 +0000 (16:31 -0700)]
fix memory leak (coverity-709378)
Dan Dennedy [Sun, 22 Jul 2012 23:28:08 +0000 (16:28 -0700)]
fix memory leak (coverity-709376)
Dan Dennedy [Sun, 22 Jul 2012 23:24:49 +0000 (16:24 -0700)]
fix memory leak (coverity-709375)
Dan Dennedy [Sun, 22 Jul 2012 23:13:50 +0000 (16:13 -0700)]
fix out-of-bounds read (coverity-709368 & 709369)
Dan Dennedy [Fri, 20 Jul 2012 16:29:45 +0000 (09:29 -0700)]
improve compatibility to compile composite sse2 (macports-35243)
Maksym Veremeyenko [Thu, 19 Jul 2012 10:23:09 +0000 (13:23 +0300)]
move mutex and deque initialization to producer init method
Maksym Veremeyenko [Thu, 19 Jul 2012 09:39:24 +0000 (12:39 +0300)]
fix leak of dv packets
Maksym Veremeyenko [Thu, 19 Jul 2012 08:09:35 +0000 (11:09 +0300)]
fix memleak if file fails to open
Dan Dennedy [Sat, 14 Jul 2012 21:02:00 +0000 (14:02 -0700)]
add define MELT_NOSDL to not use SDL_main()
This is helpful on OS X when using melt as a utility to prevent the
program from appearing in the Dock.
Dan Dennedy [Fri, 13 Jul 2012 17:02:22 +0000 (10:02 -0700)]
fix crash in avformat consumer when audio encoding fails
Dan Dennedy [Fri, 13 Jul 2012 04:19:56 +0000 (21:19 -0700)]
accept file:// prefix on MLT XML file
Dan Dennedy [Thu, 28 Jun 2012 06:15:01 +0000 (23:15 -0700)]
fix some LADSPA crashing on dlclose on some systems (
3538363 )
Dan Dennedy [Sun, 24 Jun 2012 16:46:34 +0000 (09:46 -0700)]
Merge pull request #3 from j-b-m/master
QImage module: fix Qt4 detection
Dan Dennedy [Sun, 24 Jun 2012 01:46:18 +0000 (18:46 -0700)]
add support for time string to playlist blanks
Dan Dennedy [Sat, 23 Jun 2012 23:12:28 +0000 (16:12 -0700)]
make alpha channel independent of lifetime of region frame
Dan Dennedy [Sat, 23 Jun 2012 23:02:47 +0000 (16:02 -0700)]
fix memory leak when using filter_only with region transition
Dan Dennedy [Sat, 23 Jun 2012 22:31:47 +0000 (15:31 -0700)]
improve readability
Dan Dennedy [Sat, 23 Jun 2012 22:24:32 +0000 (15:24 -0700)]
rename this to transition and frame
Dan Dennedy [Sat, 23 Jun 2012 22:19:51 +0000 (15:19 -0700)]
fix filters that need progress with region filter/transition
See for example, obscure filter, as used in demo/mlt_obscure.
Dan Dennedy [Sat, 23 Jun 2012 22:15:53 +0000 (15:15 -0700)]
fix race condition in region filter when parallel processing
based on patch from j-b-m
Dan Dennedy [Sat, 23 Jun 2012 20:50:30 +0000 (13:50 -0700)]
add support for audio scrubbing to audio-only consumers
Dan Dennedy [Fri, 22 Jun 2012 05:19:22 +0000 (22:19 -0700)]
change printfs in filter_jackrack to mlt_log_verbose
Dan Dennedy [Fri, 22 Jun 2012 04:22:31 +0000 (21:22 -0700)]
send jack silence on buffer underrun
This occurs with the sdl_preview or any of the audio-only consumers when
paused. Otherwise, jack just plays unset memory, which is usually
something worse than just noise.
Dan Dennedy [Fri, 22 Jun 2012 02:48:38 +0000 (19:48 -0700)]
fix loading xml file on windows
Dan Dennedy [Thu, 21 Jun 2012 05:24:15 +0000 (22:24 -0700)]
stop checking PTS if we are only using DTS
Jean-Baptiste Mardelle [Wed, 20 Jun 2012 20:31:23 +0000 (22:31 +0200)]
Fix Qt4 detection when Qt3 is installed
Dan Dennedy [Wed, 20 Jun 2012 04:09:48 +0000 (21:09 -0700)]
add mlt_producer_seek_time and mlt_producer_frame_time
Dan Dennedy [Wed, 20 Jun 2012 04:02:13 +0000 (21:02 -0700)]
add to .gitignore
Dan Dennedy [Wed, 20 Jun 2012 03:58:22 +0000 (20:58 -0700)]
add const-ness to some strings in specialized service classes
Dan Dennedy [Mon, 18 Jun 2012 20:05:03 +0000 (13:05 -0700)]
fix loading xml with producer not enclosed in playlist or multitrack
Dan Dennedy [Mon, 18 Jun 2012 17:34:50 +0000 (10:34 -0700)]
fix clang errors
Dan Dennedy [Mon, 18 Jun 2012 16:30:05 +0000 (09:30 -0700)]
Merge branch 'master' of github.com:mltframework/mlt
Dan Dennedy [Sun, 17 Jun 2012 05:56:31 +0000 (22:56 -0700)]
add support for AUDIODEV environment var to rtaudio
Dan Dennedy [Sun, 17 Jun 2012 05:12:03 +0000 (22:12 -0700)]
overhaul a/v sync and seeking in avformat producer
The new_seek property changed to use_pts. This consolidates old seek and
new seek code, improves a/v sync for more files, and improves seek
performance for AVCHD in general (including libav).
Dan Dennedy [Sat, 16 Jun 2012 19:53:43 +0000 (12:53 -0700)]
fix BSTR string conversion under Windows
Dan Dennedy [Tue, 5 Jun 2012 06:14:05 +0000 (23:14 -0700)]
fix crash when reporting error in decklink producer init
Dan Dennedy [Tue, 5 Jun 2012 06:13:13 +0000 (23:13 -0700)]
set interim version to 0.8.1
Dan Dennedy [Fri, 1 Jun 2012 20:51:32 +0000 (13:51 -0700)]
update ChangeLog for v0.8.0
Dan Dennedy [Fri, 1 Jun 2012 20:50:42 +0000 (13:50 -0700)]
set version to 0.8.0
Dan Dennedy [Fri, 1 Jun 2012 20:49:51 +0000 (13:49 -0700)]
add release notes for v0.8.0
Dan Dennedy [Fri, 1 Jun 2012 19:05:10 +0000 (12:05 -0700)]
Merge branch 'master' of github.com:mltframework/mlt
Dan Dennedy [Fri, 1 Jun 2012 18:58:41 +0000 (11:58 -0700)]
fix image format regression in avformat caching
Dan Dennedy [Fri, 1 Jun 2012 18:30:29 +0000 (11:30 -0700)]
remove unused alpha_cache member
Dan Dennedy [Fri, 1 Jun 2012 18:16:00 +0000 (11:16 -0700)]
fix video_delay when using new_seek (AVCHD)
Dan Dennedy [Fri, 1 Jun 2012 18:15:08 +0000 (11:15 -0700)]
fix a/v sync after recent change for faster AVCHD seeking
Dan Dennedy [Fri, 1 Jun 2012 15:45:17 +0000 (08:45 -0700)]
Revert "Revert "make speed of editing AVCHD tolerable""
This reverts commit
c02b411377f471c5c768dfb5f83171964c6c273a .
Dan Dennedy [Thu, 31 May 2012 07:21:41 +0000 (00:21 -0700)]
fix regression in build on 32-bit linux gcc 4.6.1
Dan Dennedy [Thu, 31 May 2012 05:12:59 +0000 (22:12 -0700)]
Revert "make speed of editing AVCHD tolerable"
This reverts commit
b17e3e9f4eadc0dc53ded8a14df2059bb642afb1 .
Dan Dennedy [Fri, 1 Jun 2012 18:58:41 +0000 (11:58 -0700)]
fix image format regression in avformat caching
Dan Dennedy [Fri, 1 Jun 2012 18:30:29 +0000 (11:30 -0700)]
remove unused alpha_cache member
Dan Dennedy [Fri, 1 Jun 2012 18:16:00 +0000 (11:16 -0700)]
fix video_delay when using new_seek (AVCHD)
Dan Dennedy [Fri, 1 Jun 2012 18:15:08 +0000 (11:15 -0700)]
fix a/v sync after recent change for faster AVCHD seeking
Dan Dennedy [Fri, 1 Jun 2012 15:45:17 +0000 (08:45 -0700)]
Revert "Revert "make speed of editing AVCHD tolerable""
This reverts commit
c02b411377f471c5c768dfb5f83171964c6c273a .
Dan Dennedy [Thu, 31 May 2012 07:21:41 +0000 (00:21 -0700)]
fix regression in build on 32-bit linux gcc 4.6.1
Jean-Baptiste Mardelle [Thu, 31 May 2012 06:27:04 +0000 (08:27 +0200)]
Fix indentation
Jean-Baptiste Mardelle [Thu, 31 May 2012 06:24:22 +0000 (08:24 +0200)]
Merge remote-tracking branch 'original/master'
Dan Dennedy [Thu, 31 May 2012 05:12:59 +0000 (22:12 -0700)]
Revert "make speed of editing AVCHD tolerable"
This reverts commit
b17e3e9f4eadc0dc53ded8a14df2059bb642afb1 .
Dan Dennedy [Wed, 30 May 2012 17:07:59 +0000 (10:07 -0700)]
Merge pull request #1 from eddrog/master
fix unique name problem in filter_jackrack