Cleaner fix to the "object is not attached" issue with modules loaded from cache
which weren't used by VLC. This now adds a new b_used flag to module_cache_t which is set to VLC_TRUE once we know that the cached version of the plugin is usable (and thus gets attached to something). If it's not usable, it wont be attached so we tell ModuleDelete() not to try dettaching it.
Patch by ILEoo to make the telnet interface work with "telnet" again (on linux). Looks ok according to the recv(2) manpage. Please fix if this is flawed.
Laurent Aimar [Sun, 25 Feb 2007 11:39:42 +0000 (11:39 +0000)]
Added vlc_b64_encode_binary (include/vlc_strings.h is not that a good place).
Use vlc_b64_encode_binary and remove ap_* in rtp.c
Fixed 2 invalid memory access and 1 stack corruption in rtp.c (Fixed
the report of rtp segfault with gcc 4.1 by xxcv)
Prevent these errors when using help flag
[00000001] main libvlc error: option daemon does not exist
[00000001] main libvlc error: option pidfile does not exist
The were due to the module_EndBand( p_libvlc ); on line 430 in libvlc-common.c . Please check that this is the correct way of doing it.
Felix Paul Kühne [Sat, 24 Feb 2007 16:40:34 +0000 (16:40 +0000)]
* commit Pierre's 2nd patch to enable weak symbols on OSX when linking vlc. This fixes the compilation of his locale-improvements and a few other problems when using the 10.3.9 SDK. Please check the next nightly on 10.3.x if you got access to it.
Felix Paul Kühne [Fri, 23 Feb 2007 20:09:13 +0000 (20:09 +0000)]
* added 2 boxes to the wizard to allow access to sout-transcode-soverlay with the GUI. needs further testing, but can't break anything. (forward-porting [18977], closes #1005
Laurent Aimar [Thu, 22 Feb 2007 20:43:28 +0000 (20:43 +0000)]
Fixed subtitle/osd memory leaks (subpicture_region_t->psz_text was not freed).
I think we have a potential bug with the way subpicture_region_t->p_style
is used.
Decoders allocate p_style memory in their context, so we don't free it in
spu_DestroyRegion. As vout object can live longer than decoder, I think
p_style might be used after the decoder has destroyed it.
Can someone, who has worked on osd/spu internal, comment ?
Jean-Paul Saman [Thu, 22 Feb 2007 11:22:48 +0000 (11:22 +0000)]
Build live555 libraries with -DUSE_SYSTEM_RANDOM=1 by default. This fixes a bug reported by Jason Gerecke (jgerecke at uoregon dot edu). The rationale from Jason:
In groupsock/inet.c: http://www.live555.com/liveMedia/doxygen/html/inet_8c-source.html a custom random generator is provided for systems which do not provide their own rand() or srand() functions. Other people have reported issues with this function segfaulting (never in conjuction with VLC however), possibly because of multithreading issues, and the fix issued by the Live555 developers was to provide an "#ifdef USE_SYSTEM_RANDOM" for builds on supporing systems (http://lists.live555.com/pipermail/live-devel/2003-November/000013.html).
Laurent Aimar [Wed, 21 Feb 2007 23:15:06 +0000 (23:15 +0000)]
Changed input_DestroyThread to take care of detaching, cleaning and destroying input.
(This way it matches input_CreateThread and fixes a memleak)
Control variables are now created even for preparse, only callback are not added.
(This fix use of uninitialized variables)
Laurent Aimar [Wed, 21 Feb 2007 21:31:36 +0000 (21:31 +0000)]
Improved vlc_UrlParse (close #1025)
We use vlc_UrlParse for "URL" without protocol... so it was using a part of
the URL as a protocol if it found ":/". Ensure to extract only valid protocol
at least.
- Use poll() instead of select to allow breaking the FD_SETSIZE barrier
- Poll the system clock only once per loop (yes, it DOES matter),
- Fix rare bug with TLS and multiple listening sockets,
- Do not try to read/write to client socket with no pending events.
...and of course introduce dozens of new bugs.
Laurent Aimar [Tue, 20 Feb 2007 22:52:12 +0000 (22:52 +0000)]
ffmpeg: ask a packetizer for audio too (needed since ffmpeg r6098,
fixed mpeg audio decoding)
vlc_demux.h: fixed COMMON_INIT_PACKETIZER (create a packetizer and not a decoder,
fixed mpeg audio packetizer)