This fixes a race between requesting mute and the aout actually muting.
There are still at least two known bugs with the mute widget:
- Qt tries to sets the LibVLC status when LibVLC status changes
(there is a hack around this for volume but not for mute).
- Qt tracks the playlist "mute" variable instead of the aout one.
aout: remove intricate volume/mute transaction system
Volume and mute states are now independant. There is no need to
update them together in a single transaction.
Furthermore, other processes can change the volume and/or mute state
of VLC playback streams asynchronously. Thus volume-up/volume-down
and mute-toggle are not atomic operations even when protected by the
volume lock. We would need to have toggle and up/down provided by the
to the output plugins. That is probably impossible and overkill.
So accept the small race condition and simplify the code.
David Fuhrmann [Tue, 3 Jul 2012 11:29:54 +0000 (13:29 +0200)]
macosx: change handling of arrow keys slightly
When the key is assigned to an main menu item: In this case the event
is never passed to the controls, so we want to handle it here for these
exeptional cases.
For all other cases: The event is ignored here and handled by the controls
(playlist, or video view, which also sends it to vlc core).
package/macosx: enhanced the codesign script to add a designated signature to enhance its compatibility
Note 3 things
- the included hashes are common knowledge, non-exploitable and hence don't constitute a security issue
- you need a valid Developer ID private key to create GateKeeper compatible signatures
- If you don't use VideoLAN's Dev ID, that's noticable but doesn't limit the app's behavior in any detail.
This commit also limits the signing process to the compiled lua scripts and no longer signs the entire lua folder since this would limit the usage experience and it isn't reasonable either.
David Fuhrmann [Sat, 30 Jun 2012 16:33:31 +0000 (18:33 +0200)]
macosx: improve accessibility support for black ui
The commit adds additional attributes to the black windows in order to correctly
link to the close / zoom / maximize buttons. This is needed to get some
tools using this api to work, in particular / e.g. jitouch.
input: do not override subtitles encoding if BOM is found (fixes #5239)
That horrible hack caused all subtitles to be parsed as Unicode if one
(but not necessarily all) opened subtitles started with a UTF-8 or
UTF-16 Byte Order Mark. If any other subtitle was neither in UTF-8 nor
in UTF-16 with a BOM, that hack failed.
This should not be needed (BOM is a zero-width character). If any
stream reader barks on a BOM, it really needs fixing on its own.
The subtitle demuxer was fixed in the previous commit.
In the case of transparent conversion from UTF-16 to UTF-8, the BOM
will be converted to UTF-8 as any other character. Thus the stream
reader can (correctly) detect a UTF-8 text stream.
If an UTF-8 BOM is found at the beginning of the text file, skip it
(it can confuse some parsers). Also mark the subtitle track explicitly
as UTF-8 encoded.
David Fuhrmann [Tue, 26 Jun 2012 20:50:05 +0000 (22:50 +0200)]
macosx: improve resize behaviour of splitview
Now, the sidebar will not will not resized while resizing the window.
Also, this commit sets a min width for the the sidebar. But it can
still be hidden, just drag the slider to the left.
Qt: PopupMenu: Stop crashing on VOut update. (fix #7016)
When calling a modal dialog, Qt switches to a new event loop.
The call may still have some event to process in its own queue,
and deleting it when doing the Vout update will have those events
refering to a no longer existing widget.
Rafaël Carré [Mon, 25 Jun 2012 20:16:52 +0000 (22:16 +0200)]
contrib: gpg-error: don't patch Makefile.am
Since 42a7f46de2 it is required to re-run gettextize because
we run autoreconf.
Unfortunately gettextize doesn't run in non interactive mode (this
is an advertised "feature").
This gpg-error patch will appear in the next release so it doesn't
need maintenance:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgpg-error.git;a=commit;h=c35dbfdaa2e30e08185e4a468278a29e2c48b500
Rafaël Carré [Mon, 25 Jun 2012 19:27:35 +0000 (21:27 +0200)]
omx: decode qualcomm-specific tiled nv12 format
Tested on HP Touchpad up to 1280x720
1920x1080 gives:
E/OMX-VDEC-1080P: ERROR: IP Requirements(#1: 2097152) Requested(#2: 4177920)
Which probably means that provided buffers are too small for the decoder
to operate
Martin Storsjö [Thu, 21 Jul 2011 11:06:07 +0000 (14:06 +0300)]
omxil: Only set the buffer size if it is smaller than what the codec suggested
This is required on HTC Sensation. That device uses a special
tiled pixel format, which probably contains a bit of padding, too.
The size that the omx codec suggests for the output port is bigger
than what VLC calculates, and we thus should keep the larger value
instead of overwriting it with what we calculated ourselves.
projects / vlc / log