avfilter/avf_showspectrum: use log10 instead of log()/...

This is likely more precise and conveys the intent better.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avfilter/vf_psnr: use log10 instead of log()/log(10)

This is likely more precise and conveys the intent better.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

swscale: rename sws_rgb2rgb_init to ff_sws_rgb2rgb_init

It is an internal swscale function and thus should not be exported.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

swscale: rename sws_context_class to ff_sws_context_class

It is an internal swscale symbol and thus should not be exported.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

They are not in public headers and not used outside of libavformat.

Reviewed-by: Hendrik Leppkes <h.leppkes@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

avfilter/af_volume: use log10 instead of log()/M_LN10

This is likely more precise and conveys the intent better.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avcodec/zmbvenc: use log2 instead of log()/M_LN2

This is likely more precise and conveys the intent better.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avcodec/nellymoserenc: use log2 instead of log()/M_LN2

This is likely more precise and conveys the intent better.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avcodec/snowenc: use log2 instead of log() / log(2...)

This is likely more precise and conveys the intent better.
The expression has also been accordingly simplified.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

doc/general.texi: fix SDX2 description

Signed-off-by: Paul B Mahol <onemda@gmail.com>

doc/general.texi: move Screenpresso to right section

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avformat: add DC STR demuxer

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avcodec: add ADPCM AICA decoder

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avformat: add 3dostr demuxer

Signed-off-by: Paul B Mahol <onemda@gmail.com>

avfilter/tremolo: fix wavetable buffer size

Signed-off-by: Kyle Swanson <k@ylo.ph>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avfilter/asrc_sine: fix options typos

Signed-off-by: Kyle Swanson <k@ylo.ph>
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Merge commit '8edaf625f3c38c695c33745822182e94e17d6e1b'

* commit '8edaf625f3c38c695c33745822182e94e17d6e1b':
  libopenh264enc: Count and warn about the number of skipped frames

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '9e14a992409348630ea96521411127418a92e8a3'

* commit '9e14a992409348630ea96521411127418a92e8a3':
  libopenh264enc: Add an option for controlling the frame skipping

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'b8deb7c34f755d5e3eee0b5930c3a6ad2dda96bc'

* commit 'b8deb7c34f755d5e3eee0b5930c3a6ad2dda96bc':
  opus: Do not call vector_fmul_scalar on zero samples

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '6dcd82290438eb810936de4febd0558b38a08ec5'

* commit '6dcd82290438eb810936de4febd0558b38a08ec5':
  opus: Buffer the samples from the correct offset

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'f3aff31e5f66a4f1c4e34ce4944f4a402aca61ed'

* commit 'f3aff31e5f66a4f1c4e34ce4944f4a402aca61ed':
  avpicture: Deprecate the single fields

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'cd0e08813a0484002b5defbf557c859f123953ae'

* commit 'cd0e08813a0484002b5defbf557c859f123953ae':
  avconv: support infinite loop for the loop option

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'a9a60106370f862e191dea58e748626da6a8fe97'

* commit 'a9a60106370f862e191dea58e748626da6a8fe97':
  avpacket: Provide an alloc and a free function for the struct

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '9b56d5c11488656254e9aed8d964ef2b7c2ff5e6'

* commit '9b56d5c11488656254e9aed8d964ef2b7c2ff5e6':
  avpacket: Deprecate av_dup_packet

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'd584533cf38141172e20bae5436629ee17c8ce50'

* commit 'd584533cf38141172e20bae5436629ee17c8ce50':
  avformat: Rework add_to_pktbuf

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

vp9: update timestamps in ref files using multiple invisible frames.

For the 10-show-existing-frame, the source file indeed has a timestamp
of 3 (or 100/33) for the second visible frame, so the fix appears to
work correctly. For the other, only the timebase is fixed, but again
appears to be correct now.

lavc/mjpegdec: honor skip_frame option

lavc/pngdec: honor skip_frame option

avfilter/showcqt: fix compilation with libswscale disabled

Signed-off-by: James Almer <jamrial@gmail.com>

avutil/audio_fifo: add av_warn_unused_result

This one should not trigger any warnings, but will be useful for future
robustness.

Strictly speaking, one could check the size after the call by examining
the structure instead of the return value. Such a use case is highly
unusual, and this commit may be easily reverted if there is a legitimate
need of such use.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

vp9_parser: don't overwrite cached timestamps with nopts.

avcodec/motion_est_template: replace qsort with AV_QSORT

This code is in a performance critical section. AV_QSORT is
substantially faster due to the inlining of the comparison callback.
Thus, the increase in performance is worth the increase in binary size.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avutil/ripemd: make rol macro more robust by adding parentheses

This ensures that the macro remains correct in the sense of allowing
expressions for value and bits, by placing the value and bits expressions within
parentheses.

Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

doc/encoders: fix "the their" typo

Signed-off-by: Lou Logan <lou@lrcd.com>

libopenh264enc: Count and warn about the number of skipped frames

Signed-off-by: Martin Storsjö <martin@martin.st>

libopenh264enc: Add an option for controlling the frame skipping

This allows enabling the frame skipping, which is required for the
encoder to properly hit the target bitrate.

Signed-off-by: Martin Storsjö <martin@martin.st>

doc/filters: Remove article redundancy

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

swr: do not reject channel layouts that use channel 63

Channel layouts are essentially uint64_t, and every value is valid.

opus: Do not call vector_fmul_scalar on zero samples

The x86 variant of this function crashes in that specific case.

CC: libav-devel@libav.org

opus: Buffer the samples from the correct offset

When not all the opus stream have the same amount of decoded samples
process the least amount and store what is left from the other streams.

Bug-Id: 909
CC: libav-stable@libav.org
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

lavu/aes: test CBC functionality

avcodec/png: read and write stereo3d frame side data information

Use optional sTER chunk defining side-by-side stereo pair
within "Extensions to the PNG 1.2 Specification", version 1.3.0.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

lavu/aes: align AVAES struct members

lavu/aes: add runtime dispatch for crypt function

lavu/aes: move AVAES to separate internal header

lavu: add AESNI CPU flag

ffprobe: Remove abort()

Found-by: Ganesh Ajjanagadde and wm4
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avutil/avstring: add av_warn_unused_result

This does not trigger any warnings, but adds robustness.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

avfilter/avf_showcqt: Fix ;;

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avfilter/avf_showcqt: rewrite showcqt and add features

add yuv444p, yuv422p, and yuv420p output format (lower cpu usage
on ffplay playback because it does not do format conversion)
custom size with size/s option (fullhd option is deprecated)
custom layout with bar_h, axis_h, and sono_h option
support rational frame rate (within fps/r/rate option)
relaxed frame rate restriction (support fractional sample step)
support all input sample rates
separate sonogram and bargraph volume (with volume/sono_v and
volume2/bar_v)
timeclamp option alias (timeclamp/tc)
fcount option
gamma option alias (gamma/sono_g and gamma2/bar_g)
support custom frequency range (basefreq and endfreq)
support drawing axis using external image file (axisfile option)
alias for disabling drawing to axis (text/axis)
possibility to optimize it using arch specific asm code

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avformat/img2enc: re enable atomic writes with split planes

They work now after fixing the implementation

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec: install avdct.h as public header

The commit 932ff70 introducing this header mentions it should be public.

Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

avpicture: Deprecate the single fields

Silence pointless warnings from gcc.

avformat/img2enc: Fix img2enc atomic implementation to work with split planes

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avformat/img2enc: Disable rename&atomic writing for non file protocol and split planes

For protocols other than local files ff_rename() is not implemented
For split planes support the implementation is simply wrong

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

mpegts: Fix FATE seek test

asfdec: fix FATE seek test

Replace remaining occurances of av_free_packet with av_packet_unref

Merge commit 'ce70f28a1732c74a9cd7fec2d56178750bd6e457'

* commit 'ce70f28a1732c74a9cd7fec2d56178750bd6e457':
  avpacket: Replace av_free_packet with av_packet_unref

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'a5d42043093a39636a1f4021a37dd9c612479f6f'

* commit 'a5d42043093a39636a1f4021a37dd9c612479f6f':
  avformat: Always return ref-counted AVPacket

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'f0ca6ffa0ae5d5564516ee7a18aa1e234751444a'

* commit 'f0ca6ffa0ae5d5564516ee7a18aa1e234751444a':
  avprobe: Unref the packet once it is used

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '9cbae3a7d57bd2b862c37fd8123bd1fba680e801'

* commit '9cbae3a7d57bd2b862c37fd8123bd1fba680e801':
  roqvideodec: use av_frame_copy

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '9f5d6f460ceeda8b4ac29b3249a49e275b64c706'

* commit '9f5d6f460ceeda8b4ac29b3249a49e275b64c706':
  hap: Set avctx.bits_per_coded_sample

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'fe66671bd5f446f8d0a9c70968ba8fe891efe028'

* commit 'fe66671bd5f446f8d0a9c70968ba8fe891efe028':
  cmdutils: Check for and report the correct codec capability

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '3c5cf2a31b4b29a8e4282cbe6a3f0617c14698b8'

* commit '3c5cf2a31b4b29a8e4282cbe6a3f0617c14698b8':
  screenpresso: Drop parameter change check

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '447b5b278c689b21bbb7b5747c8773145cbd9448'

* commit '447b5b278c689b21bbb7b5747c8773145cbd9448':
  mpegvideo_enc: Fix encoding videos with less frames than the delay of the encoder

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '27eeee76b2546fd313808997b3d07ba9cce94551'

* commit '27eeee76b2546fd313808997b3d07ba9cce94551':
  mpegvideo_enc: Merge ifs with identical conditions

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'f0a88d4d2a74534460f4a8b79c448bd5890dbd41'

* commit 'f0a88d4d2a74534460f4a8b79c448bd5890dbd41':
  mpegvideo_enc: Factor new_picture unref out

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '533a6198505edd1379e1cd722852350ae4a85acc'

* commit '533a6198505edd1379e1cd722852350ae4a85acc':
  innoHeim/Rsupport Screen Capture Codec decoder

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '233d2fa0443197df12b4f7823d591dad964149b3'

* commit '233d2fa0443197df12b4f7823d591dad964149b3':
  kvazaar: Add libkvazaar HEVC encoder

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

avformat/aiff: add ADP4 DVI ADPCM support

Signed-off-by: Paul B Mahol <onemda@gmail.com>

Merge commit '18f9308e6a96bbeb034ee5213a6d41e0b6c2ae74'

* commit '18f9308e6a96bbeb034ee5213a6d41e0b6c2ae74':
  mpjpeg: Cope with multipart lacking the initial CRLF

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '22f4d9c303ede1a240538fd105c97047db40dc86'

* commit '22f4d9c303ede1a240538fd105c97047db40dc86':
  img2enc: Make sure the images are atomically written

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '1ec72c6c68dbc78bf4ebb6f06c13316dc488bdfa'

* commit '1ec72c6c68dbc78bf4ebb6f06c13316dc488bdfa':
  libx264: Make sure the extradata are padded

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit '5ea5a24eb70646a9061b85af407fcbb5dd4f89fd'

* commit '5ea5a24eb70646a9061b85af407fcbb5dd4f89fd':
  movenc: Honor flush requests with delay_moov, when some tracks lack samples

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'e02dcdf6bb6835ef4b49986b85a67efcb3495a7f'

* commit 'e02dcdf6bb6835ef4b49986b85a67efcb3495a7f':
  rtsp: Allow $ as interleaved packet indicator before a complete response header

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Merge commit 'dca23ffbc7568c9af5c5fbaa86e6a0761ecae50c'

* commit 'dca23ffbc7568c9af5c5fbaa86e6a0761ecae50c':
  lavc: Deprecate AVPicture structure and related functions

Deprecation flag on AVPicture struct replaced by a comment, as it causes
excess deprecation warnings for every include of avcodec.h

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

doc/filters.texi: ebur128 grammar fix

Reviewed-by: Lou Logan <lou@lrcd.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

fix: assigning instead of comparing

Signed-off-by: AppChecker <support.appc@cnpo.ru>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec: disallow hwaccel with frame threads

HWAccels with frame threads are fundamentally flawed in avcodecs current
design, and there are several known problems ranging from image corruption
to driver crashes.

These problems come down to two design problems in the interaction of
threads and HWAccel decoding:

(1)
While avcodec prevents parallel decoding and as such simultaneous access
to the hardware accelerator from the decoding threads, it cannot account
for the user code and its access to the hardware surfaces and the hardware
itself.

This can result in image corruption or even driver crashes if the
user code locks image surfaces while they are being used by the decoder
threads as reference frames.

The current HWAccel API does not offer any way to ensure exclusive access
to the hardware or the surfaces if frame threading is used.

(2)
Initialization of the HWAccel with frame threads is non-trivial, and many
decoders had and still have issues that cause excess calls to the
get_format callback.

This will potentially cause duplicate HWAccel initialization, which in
extreme cases can even lead to driver crashes if the HWAccel is
re-initialized while the user code is actively accessing the hardware
surfaces associated with it, or lead to image corruption due to lost
reference frames.

While both of these issues are solvable, fixing (1) would at least require
a huge API redesign which would move a lot of complexity into the user
code.

The only reason the combination of frame threads and HWAccel was
considered useful is to allow a seamless fallback to multi-threaded
software decoding if the HWAccel is not available, however the issues
outlined above far outweigh this.

The proper solution for a fallback is to re-open the AVCodecContext with
threading enabled if the HWAccel failed, which is a practice commonly used
by various user applications using avcodec today already.

Reviewed-by: Gwenole Beauchesne <gb.devel@gmail.com>
Reviewed-by: wm4 <nfxjfg@googlemail.com>
Signed-off-by: Hendrik Leppkes <h.leppkes@gmail.com>

FATE: Increase FUZZ value on AAC LTP encoding test

Clang prerelease on Darwin is making the test fail.

srtenc: Reindent

drawutils: Reindent

avfilter: Reindent

avcodec: srtdec: Reindent

x86/vf_w3fdif: use aligned loads in w3fdif_complex_high

Found-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

FATE: Slightly increase thresholds on prediction AAC encoding tests

They barely fail on some systems by being off by 0.81.

opusdec: Don't run vector_fmul_scalar on zero length arrays

Fixes crashes on fuzzed files
Fixes Ticket4969 part2

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avcodec/opusdec: Fix extra samples read index

Fixes crash
Fixes Ticket4969 part 1

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

avfilter: add vibrato filter

Signed-off-by: Kyle Swanson <k@ylo.ph>

avconv: support infinite loop for the loop option

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

avpacket: Provide an alloc and a free function for the struct

Pave the way for having the size of the AVPacket struct not part
of the ABI.

avpacket: Deprecate av_dup_packet

As documented, `av_dup_packet` is broken by design, `av_packet_ref`
matches the AVFrame ref-counted API and can be safely used instead.

avformat: Rework add_to_pktbuf

Make it return an error and check its return value when it is used.
Simplify the usage by calling `av_packet_ref` internally when needed.

avpacket: Replace av_free_packet with av_packet_unref

`av_packet_unref` matches the AVFrame ref-counted API and can be used as
a drop in replacement.

Deprecate `av_free_packet`.

avformat: Always return ref-counted AVPacket

And drop the av_dup_packet from the input_thread.

avprobe: Unref the packet once it is used

Make sure it does not leak packets.

CC: libav-stable@libav.org

avcodec/options: remove a few more redundant "default" information

avcodec/options: remove redundant and wrong default information for skipcmp option

avcodec/avdct: remove redundant "default" information in options