]> git.sesse.net Git - stockfish/commit
Fix TB score output in UCI without using TB
authorShahin M. Shahin <41402573+peregrineshahin@users.noreply.github.com>
Fri, 17 Nov 2023 15:25:50 +0000 (18:25 +0300)
committerDisservin <disservin.social@gmail.com>
Thu, 14 Dec 2023 17:35:38 +0000 (18:35 +0100)
commit282e15bf75bd1142de96306b22424f0cd2bb8dfa
treea5e307d909094f77ade08845450b80090cfdefc3
parent36db936e769a2e7a95fc4032eec3b79251bbaef5
Fix TB score output in UCI without using TB

This is a rewrite of the fix introduced for
https://github.com/official-stockfish/Stockfish/issues/4413 in
https://github.com/official-stockfish/Stockfish/pull/4591 by @windfishballad it
targets only the relevant part of this issue that returns TB scores (CP 20000)
without using TB due to the downgrading of potentially false mates from the TT
to an optimal TB score.

the difference is that it is a much clearer code that introduces a separate
TB_VALUE constant to account for a correct distance from the TB_VALUE with
MAX_PLY.

the originally posted position in the issue does not trigger the problem
anymore, so here is a new position to test:
```
position fen 3k4/8/8/8/8/8/3BN3/3K4 w - - 0 1
go infinite
```

Passed non-regression STC:
https://tests.stockfishchess.org/tests/view/65578994136acbc57353b258
LLR: 2.96 (-2.94,2.94) <-1.75,0.25>
Total: 119264 W: 29993 L: 29863 D: 59408
Ptnml(0-2): 372, 13692, 31379, 13812, 377

Passed non-regression LTC:
https://tests.stockfishchess.org/tests/view/6558323f136acbc57353c1ca
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 237834 W: 58791 L: 58792 D: 120251
Ptnml(0-2): 193, 26200, 66111, 26241, 172

fixes https://github.com/official-stockfish/Stockfish/issues/4413
closes https://github.com/official-stockfish/Stockfish/pull/4591
closes https://github.com/official-stockfish/Stockfish/pull/4882

Bench: 1305821
src/search.cpp
src/types.h
src/uci.cpp