#include <KApplication>
#include <KUrlRequesterDialog>
#include <KMessageBox>
+#include <KStandardDirs>
#include <QTreeWidgetItem>
#include <QFile>
const int CLIPPLACEHOLDER = 2;
const int CLIPWRONGDURATION = 3;
const int PROXYMISSING = 4;
+const int SOURCEMISSING = 5;
const int LUMAMISSING = 10;
const int LUMAOK = 11;
enum TITLECLIPTYPE { TITLE_IMAGE_ELEMENT = 20, TITLE_FONT_ELEMENT = 21 };
-DocumentChecker::DocumentChecker(QDomNodeList infoproducers, QDomDocument doc):
+DocumentChecker::DocumentChecker(const QDomNodeList &infoproducers, const QDomDocument &doc):
m_info(infoproducers), m_doc(doc), m_dialog(NULL)
{
int max;
QDomNodeList documentProducers = m_doc.elementsByTagName("producer");
QList <QDomElement> wrongDurationClips;
+ // List clips whose proxy is missing
QList <QDomElement> missingProxies;
+ // List clips who have a working proxy but no source clip
+ QList <QDomElement> missingSources;
m_safeImages.clear();
m_safeFonts.clear();
max = m_info.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
e = m_info.item(i).toElement();
clipType = e.attribute("type").toInt();
if (clipType == COLOR) continue;
prodId = mltProd.attribute("id");
// Don't check slowmotion clips for now... (TODO?)
if (prodId.startsWith("slowmotion")) continue;
- if (prodId.contains("_")) prodId = prodId.section("_", 0, 0);
+ if (prodId.contains('_')) prodId = prodId.section('_', 0, 0);
if (prodId != id) continue;
if (mltDuration > 0 ) {
// We have several MLT producers for the same clip (probably track producers)
resource = e.attribute("resource");
if (e.hasAttribute("proxy")) {
QString proxyresource = e.attribute("proxy");
- if (!proxyresource.isEmpty() && proxyresource != "-" && !KIO::NetAccess::exists(KUrl(proxyresource), KIO::NetAccess::SourceSide, 0)) {
- // Missing clip found
- missingProxies.append(e);
+ if (!proxyresource.isEmpty() && proxyresource != "-") {
+ // clip has a proxy
+ if (!KIO::NetAccess::exists(KUrl(proxyresource), KIO::NetAccess::SourceSide, 0)) {
+ // Missing clip found
+ missingProxies.append(e);
+ }
+ else if (!KIO::NetAccess::exists(KUrl(resource), KIO::NetAccess::SourceSide, 0)) {
+ // clip has proxy but original clip is missing
+ missingSources.append(e);
+ continue;
+ }
}
}
if (clipType == SLIDESHOW) resource = KUrl(resource).directory();
if (!root.isEmpty()) root = KUrl(root).path(KUrl::AddTrailingSlash);
QDomNodeList trans = m_doc.elementsByTagName("transition");
max = trans.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QString luma = getProperty(trans.at(i).toElement(), "luma");
if (!luma.isEmpty() && !filesToCheck.contains(luma))
filesToCheck.append(luma);
}
// Check existence of luma files
- foreach (const QString lumafile, filesToCheck) {
+ foreach (const QString &lumafile, filesToCheck) {
filePath = lumafile;
if (!filePath.startsWith('/')) filePath.prepend(root);
if (!QFile::exists(filePath)) {
- if (m_missingClips.isEmpty() && missingLumas.isEmpty() && wrongDurationClips.isEmpty() && missingProxies.isEmpty())
+ if (m_missingClips.isEmpty() && missingLumas.isEmpty() && wrongDurationClips.isEmpty() && missingProxies.isEmpty() && missingSources.isEmpty())
return false;
m_dialog = new QDialog();
m_dialog->setFont(KGlobalSettings::toolBarFont());
m_ui.setupUi(m_dialog);
- foreach(const QString l, missingLumas) {
+ foreach(const QString &l, missingLumas) {
QTreeWidgetItem *item = new QTreeWidgetItem(m_ui.treeWidget, QStringList() << i18n("Luma file") << l);
item->setIcon(0, KIcon("dialog-close"));
item->setData(0, idRole, l);
m_ui.buttonBox->button(QDialogButtonBox::Ok)->setEnabled(false);
max = m_missingClips.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
e = m_missingClips.at(i).toElement();
QString clipType;
int t = e.attribute("type").toInt();
if (!m_ui.infoLabel->text().isEmpty()) m_ui.infoLabel->setText(m_ui.infoLabel->text() + ". ");
m_ui.infoLabel->setText(m_ui.infoLabel->text() + i18n("Missing proxies will be recreated after opening."));
}
+ if (missingSources.count() > 0) {
+ if (!m_ui.infoLabel->text().isEmpty()) m_ui.infoLabel->setText(m_ui.infoLabel->text() + ". ");
+ m_ui.infoLabel->setText(m_ui.infoLabel->text() + i18np("The project file contains a missing clip, you can still work with its proxy.", "The project file contains missing clips, you can still work with their proxies.", missingSources.count()));
+ }
m_ui.removeSelected->setEnabled(!m_missingClips.isEmpty());
- m_ui.recursiveSearch->setEnabled(!m_missingClips.isEmpty() || !missingLumas.isEmpty());
+ m_ui.recursiveSearch->setEnabled(!m_missingClips.isEmpty() || !missingLumas.isEmpty() || !missingSources.isEmpty());
m_ui.usePlaceholders->setEnabled(!m_missingClips.isEmpty());
m_ui.fixDuration->setEnabled(!wrongDurationClips.isEmpty());
max = wrongDurationClips.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
e = wrongDurationClips.at(i).toElement();
QString clipType;
int t = e.attribute("type").toInt();
item->setToolTip(0, i18n("Duration mismatch"));
}
- if (missingProxies.count() > 0) {
+ // Check missing proxies
+ max = missingProxies.count();
+ if (max > 0) {
QTreeWidgetItem *item = new QTreeWidgetItem(m_ui.treeWidget, QStringList() << i18n("Proxy clip"));
item->setIcon(0, KIcon("dialog-warning"));
- item->setText(1, i18n("%1 missing proxy clips, will be recreated on project opening", missingProxies.count()));
+ item->setText(1, i18n("%1 missing proxy clips, will be recreated on project opening", max));
item->setData(0, hashRole, e.attribute("file_hash"));
item->setData(0, statusRole, PROXYMISSING);
item->setToolTip(0, i18n("Missing proxy"));
}
- max = missingProxies.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
e = missingProxies.at(i).toElement();
- QString clipType;
QString realPath = e.attribute("resource");
QString id = e.attribute("id");
+ // Tell Kdenlive to recreate proxy
+ e.setAttribute("_replaceproxy", "1");
// Replace proxy url with real clip in MLT producers
QDomNodeList properties;
QDomElement mltProd;
if (property.attribute("name") == "resource") {
QString resource = property.firstChild().nodeValue();
QString suffix;
- if (slowmotion) suffix = "?" + resource.section('?', -1);
+ if (slowmotion) suffix = '?' + resource.section('?', -1);
property.firstChild().setNodeValue(realPath + suffix);
break;
}
}
}
- if (missingProxies.count() > 0) {
+ if (max > 0) {
+ // original doc was modified
+ QDomElement infoXml = m_doc.elementsByTagName("kdenlivedoc").at(0).toElement();
+ infoXml.setAttribute("modified", "1");
+ }
+
+ // Check clips with available proxies but missing original source clips
+ max = missingSources.count();
+ if (max > 0) {
+ QTreeWidgetItem *item = new QTreeWidgetItem(m_ui.treeWidget, QStringList() << i18n("Source clip"));
+ item->setIcon(0, KIcon("dialog-warning"));
+ item->setText(1, i18n("%1 missing source clips, you can only use the proxies", max));
+ item->setData(0, hashRole, e.attribute("file_hash"));
+ item->setData(0, statusRole, SOURCEMISSING);
+ item->setToolTip(0, i18n("Missing source clip"));
+ for (int i = 0; i < max; ++i) {
+ e = missingSources.at(i).toElement();
+ QString clipType;
+ QString realPath = e.attribute("resource");
+ QString id = e.attribute("id");
+ // Tell Kdenlive the source is missing
+ e.setAttribute("_missingsource", "1");
+ QTreeWidgetItem *subitem = new QTreeWidgetItem(item, QStringList() << i18n("Source clip"));
+ kDebug()<<"// Adding missing source clip: "<<realPath;
+ subitem->setIcon(0, KIcon("dialog-close"));
+ subitem->setText(1, realPath);
+ subitem->setData(0, hashRole, e.attribute("file_hash"));
+ subitem->setData(0, sizeRole, e.attribute("file_size"));
+ subitem->setData(0, statusRole, CLIPMISSING);
+ int t = e.attribute("type").toInt();
+ subitem->setData(0, typeRole, t);
+ subitem->setData(0, idRole, id);
+ }
+ }
+
+ if (max > 0) {
// original doc was modified
QDomElement infoXml = m_doc.elementsByTagName("kdenlivedoc").at(0).toElement();
infoXml.setAttribute("modified", "1");
connect(m_ui.usePlaceholders, SIGNAL(pressed()), this, SLOT(slotPlaceholders()));
connect(m_ui.removeSelected, SIGNAL(pressed()), this, SLOT(slotDeleteSelected()));
connect(m_ui.fixDuration, SIGNAL(pressed()), this, SLOT(slotFixDuration()));
- connect(m_ui.treeWidget, SIGNAL(itemDoubleClicked(QTreeWidgetItem *, int)), this, SLOT(slotEditItem(QTreeWidgetItem *, int)));
+ connect(m_ui.treeWidget, SIGNAL(itemDoubleClicked(QTreeWidgetItem*,int)), this, SLOT(slotEditItem(QTreeWidgetItem*,int)));
connect(m_ui.treeWidget, SIGNAL(itemSelectionChanged()), this, SLOT(slotCheckButtons()));
//adjustSize();
if (m_ui.treeWidget->topLevelItem(0)) m_ui.treeWidget->setCurrentItem(m_ui.treeWidget->topLevelItem(0));
DocumentChecker::~DocumentChecker()
{
- if (m_dialog) delete m_dialog;
+ delete m_dialog;
}
QString DocumentChecker::getProperty(QDomElement effect, const QString &name)
{
QDomNodeList params = effect.elementsByTagName("property");
- for (int i = 0; i < params.count(); i++) {
+ for (int i = 0; i < params.count(); ++i) {
QDomElement e = params.item(i).toElement();
if (e.attribute("name") == name) {
return e.firstChild().nodeValue();
return QString();
}
-void DocumentChecker::setProperty(QDomElement effect, const QString &name, const QString value)
+void DocumentChecker::setProperty(QDomElement effect, const QString &name, const QString &value)
{
QDomNodeList params = effect.elementsByTagName("property");
- for (int i = 0; i < params.count(); i++) {
+ for (int i = 0; i < params.count(); ++i) {
QDomElement e = params.item(i).toElement();
if (e.attribute("name") == name) {
e.firstChild().setNodeValue(value);
if (newpath.isEmpty()) return;
int ix = 0;
bool fixed = false;
- m_ui.recursiveSearch->setEnabled(false);
+ m_ui.recursiveSearch->setChecked(true);
+ qApp->processEvents();
QTreeWidgetItem *child = m_ui.treeWidget->topLevelItem(ix);
QDir searchDir(newpath);
while (child) {
- if (child->data(0, statusRole).toInt() == CLIPMISSING) {
+ if (child->data(0, statusRole).toInt() == SOURCEMISSING) {
+ for (int j = 0; j < child->childCount(); j++) {
+ QTreeWidgetItem *subchild = child->child(j);
+ QString clipPath = searchFileRecursively(searchDir, subchild->data(0, sizeRole).toString(), subchild->data(0, hashRole).toString());
+ if (!clipPath.isEmpty()) {
+ fixed = true;
+
+ subchild->setText(1, clipPath);
+ subchild->setIcon(0, KIcon("dialog-ok"));
+ subchild->setData(0, statusRole, CLIPOK);
+ }
+ }
+ }
+ else if (child->data(0, statusRole).toInt() == CLIPMISSING) {
QString clipPath = searchFileRecursively(searchDir, child->data(0, sizeRole).toString(), child->data(0, hashRole).toString());
if (!clipPath.isEmpty()) {
fixed = true;
child->setData(0, statusRole, CLIPOK);
}
} else if (child->data(0, statusRole).toInt() == LUMAMISSING) {
- QString fileName = searchLuma(child->data(0, idRole).toString());
+ QString fileName = searchLuma(searchDir, child->data(0, idRole).toString());
if (!fileName.isEmpty()) {
fixed = true;
child->setText(1, fileName);
ix++;
child = m_ui.treeWidget->topLevelItem(ix);
}
+ m_ui.recursiveSearch->setChecked(false);
m_ui.recursiveSearch->setEnabled(true);
if (fixed) {
// original doc was modified
}
-QString DocumentChecker::searchLuma(const QString &file) const
+QString DocumentChecker::searchLuma(const QDir &dir, const QString &file) const
{
KUrl searchPath(KdenliveSettings::mltpath());
+ QString fname = KUrl(file).fileName();
if (file.contains("PAL"))
searchPath.cd("../lumas/PAL");
else
searchPath.cd("../lumas/NTSC");
- QString result = searchPath.path(KUrl::AddTrailingSlash) + KUrl(file).fileName();
+ QString result = searchPath.path(KUrl::AddTrailingSlash) + fname;
if (QFile::exists(result))
return result;
// try to find luma in application path
searchPath.clear();
searchPath = KUrl(QCoreApplication::applicationDirPath());
searchPath.cd("../share/apps/kdenlive/lumas");
- result = searchPath.path(KUrl::AddTrailingSlash) + KUrl(file).fileName();
+ result = searchPath.path(KUrl::AddTrailingSlash) + fname;
if (QFile::exists(result))
return result;
- return QString();
+ // Try in Kdenlive's standard KDE path
+ result = KStandardDirs::locate("appdata", "lumas/" + fname);
+ if (!result.isEmpty()) return result;
+ // Try in user's chosen folder
+ return searchPathRecursively(dir, fname);
}
QString DocumentChecker::searchPathRecursively(const QDir &dir, const QString &fileName) const
if (!filesAndDirs.isEmpty()) return searchDir.absoluteFilePath(filesAndDirs.at(0));
searchDir.setNameFilters(QStringList());
filesAndDirs = searchDir.entryList(QDir::Dirs | QDir::Readable | QDir::Executable | QDir::NoDotAndDotDot);
- for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); i++) {
+ for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); ++i) {
foundFileName = searchPathRecursively(searchDir.absoluteFilePath(filesAndDirs.at(i)), fileName);
if (!foundFileName.isEmpty())
break;
QByteArray fileData;
QByteArray fileHash;
QStringList filesAndDirs = dir.entryList(QDir::Files | QDir::Readable);
- for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); i++) {
+ for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); ++i) {
QFile file(dir.absoluteFilePath(filesAndDirs.at(i)));
if (QString::number(file.size()) == matchSize) {
if (file.open(QIODevice::ReadOnly)) {
//kDebug() << filesAndDirs.at(i) << file.size() << fileHash.toHex();
}
filesAndDirs = dir.entryList(QDir::Dirs | QDir::Readable | QDir::Executable | QDir::NoDotAndDotDot);
- for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); i++) {
+ for (int i = 0; i < filesAndDirs.size() && foundFileName.isEmpty(); ++i) {
foundFileName = searchFileRecursively(dir.absoluteFilePath(filesAndDirs.at(i)), matchSize, matchHash);
if (!foundFileName.isEmpty())
break;
void DocumentChecker::slotEditItem(QTreeWidgetItem *item, int)
{
int t = item->data(0, typeRole).toInt();
- if (t == TITLE_FONT_ELEMENT) return;
+ if (t == TITLE_FONT_ELEMENT || t == UNKNOWN) return;
//|| t == TITLE_IMAGE_ELEMENT) {
KUrl url = KUrlRequesterDialog::getUrl(item->text(1), m_dialog, i18n("Enter new location for file"));
void DocumentChecker::acceptDialog()
{
- QDomElement e, property;
QDomNodeList producers = m_doc.elementsByTagName("producer");
QDomNodeList infoproducers = m_doc.elementsByTagName("kdenlive_producer");
- QDomNodeList properties;
int ix = 0;
// prepare transitions
QTreeWidgetItem *child = m_ui.treeWidget->topLevelItem(ix);
while (child) {
- int t = child->data(0, typeRole).toInt();
- if (child->data(0, statusRole).toInt() == CLIPOK) {
- QString id = child->data(0, idRole).toString();
- if (t == TITLE_IMAGE_ELEMENT) {
- // edit images embedded in titles
- for (int i = 0; i < infoproducers.count(); i++) {
- e = infoproducers.item(i).toElement();
- if (e.attribute("id") == id) {
- // Fix clip
- QString xml = e.attribute("xmldata");
- xml.replace(child->data(0, typeOriginalResource).toString(), child->text(1));
- e.setAttribute("xmldata", xml);
- break;
- }
- }
- for (int i = 0; i < producers.count(); i++) {
- e = producers.item(i).toElement();
- if (e.attribute("id").section('_', 0, 0) == id) {
- // Fix clip
- properties = e.childNodes();
- for (int j = 0; j < properties.count(); ++j) {
- property = properties.item(j).toElement();
- if (property.attribute("name") == "xmldata") {
- QString xml = property.firstChild().nodeValue();
- xml.replace(child->data(0, typeOriginalResource).toString(), child->text(1));
- property.firstChild().setNodeValue(xml);
- break;
- }
- }
- }
- }
- } else {
- // edit clip url
- for (int i = 0; i < infoproducers.count(); i++) {
- e = infoproducers.item(i).toElement();
- if (e.attribute("id") == id) {
- // Fix clip
- e.setAttribute("resource", child->text(1));
- e.setAttribute("name", KUrl(child->text(1)).fileName());
- break;
- }
+ if (child->data(0, statusRole).toInt() == SOURCEMISSING) {
+ for (int j = 0; j < child->childCount(); j++) {
+ fixClipItem(child->child(j), producers, infoproducers, trans);
+ }
+ }
+ else fixClipItem(child, producers, infoproducers, trans);
+ ix++;
+ child = m_ui.treeWidget->topLevelItem(ix);
+ }
+ //QDialog::accept();
+}
+
+void DocumentChecker::fixClipItem(QTreeWidgetItem *child, QDomNodeList producers, QDomNodeList infoproducers, QDomNodeList trans)
+{
+ QDomElement e, property;
+ QDomNodeList properties;
+ int t = child->data(0, typeRole).toInt();
+ if (child->data(0, statusRole).toInt() == CLIPOK) {
+ QString id = child->data(0, idRole).toString();
+ if (t == TITLE_IMAGE_ELEMENT) {
+ // edit images embedded in titles
+ for (int i = 0; i < infoproducers.count(); ++i) {
+ e = infoproducers.item(i).toElement();
+ if (e.attribute("id") == id) {
+ // Fix clip
+ QString xml = e.attribute("xmldata");
+ xml.replace(child->data(0, typeOriginalResource).toString(), child->text(1));
+ e.setAttribute("xmldata", xml);
+ break;
}
- for (int i = 0; i < producers.count(); i++) {
- e = producers.item(i).toElement();
- if (e.attribute("id").section('_', 0, 0) == id || e.attribute("id").section(':', 1, 1) == id) {
- // Fix clip
- properties = e.childNodes();
- for (int j = 0; j < properties.count(); ++j) {
- property = properties.item(j).toElement();
- if (property.attribute("name") == "resource") {
- QString resource = property.firstChild().nodeValue();
- if (resource.contains(QRegExp("\\?[0-9]+\\.[0-9]+(&strobe=[0-9]+)?$")))
- property.firstChild().setNodeValue(child->text(1) + '?' + resource.section('?', -1));
- else
- property.firstChild().setNodeValue(child->text(1));
- break;
- }
+ }
+ for (int i = 0; i < producers.count(); ++i) {
+ e = producers.item(i).toElement();
+ if (e.attribute("id").section('_', 0, 0) == id) {
+ // Fix clip
+ properties = e.childNodes();
+ for (int j = 0; j < properties.count(); ++j) {
+ property = properties.item(j).toElement();
+ if (property.attribute("name") == "xmldata") {
+ QString xml = property.firstChild().nodeValue();
+ xml.replace(child->data(0, typeOriginalResource).toString(), child->text(1));
+ property.firstChild().setNodeValue(xml);
+ break;
}
}
}
}
- } else if (child->data(0, statusRole).toInt() == CLIPPLACEHOLDER && t != TITLE_FONT_ELEMENT && t != TITLE_IMAGE_ELEMENT) {
- QString id = child->data(0, idRole).toString();
- for (int i = 0; i < infoproducers.count(); i++) {
+ } else {
+ // edit clip url
+ for (int i = 0; i < infoproducers.count(); ++i) {
e = infoproducers.item(i).toElement();
if (e.attribute("id") == id) {
// Fix clip
- e.setAttribute("placeholder", '1');
+ e.setAttribute("resource", child->text(1));
+ e.setAttribute("name", KUrl(child->text(1)).fileName());
+ e.removeAttribute("_missingsource");
break;
}
}
- } else if (child->data(0, statusRole).toInt() == LUMAOK) {
- for (int i = 0; i < trans.count(); i++) {
- QString luma = getProperty(trans.at(i).toElement(), "luma");
-
- kDebug() << "luma: " << luma;
- if (!luma.isEmpty() && luma == child->data(0, idRole).toString()) {
- setProperty(trans.at(i).toElement(), "luma", child->text(1));
- kDebug() << "replace with; " << child->text(1);
+ for (int i = 0; i < producers.count(); ++i) {
+ e = producers.item(i).toElement();
+ if (e.attribute("id").section('_', 0, 0) == id || e.attribute("id").section(':', 1, 1) == id) {
+ // Fix clip
+ properties = e.childNodes();
+ for (int j = 0; j < properties.count(); ++j) {
+ property = properties.item(j).toElement();
+ if (property.attribute("name") == "resource") {
+ QString resource = property.firstChild().nodeValue();
+ if (resource.contains(QRegExp("\\?[0-9]+\\.[0-9]+(&strobe=[0-9]+)?$")))
+ property.firstChild().setNodeValue(child->text(1) + '?' + resource.section('?', -1));
+ else
+ property.firstChild().setNodeValue(child->text(1));
+ break;
+ }
+ }
}
}
- } else if (child->data(0, statusRole).toInt() == LUMAMISSING) {
- for (int i = 0; i < trans.count(); i++) {
- QString luma = getProperty(trans.at(i).toElement(), "luma");
- if (!luma.isEmpty() && luma == child->data(0, idRole).toString()) {
- setProperty(trans.at(i).toElement(), "luma", QString());
- }
+ }
+ } else if (child->data(0, statusRole).toInt() == CLIPPLACEHOLDER && t != TITLE_FONT_ELEMENT && t != TITLE_IMAGE_ELEMENT) {
+ QString id = child->data(0, idRole).toString();
+ for (int i = 0; i < infoproducers.count(); ++i) {
+ e = infoproducers.item(i).toElement();
+ if (e.attribute("id") == id) {
+ // Fix clip
+ e.setAttribute("placeholder", '1');
+ break;
+ }
+ }
+ } else if (child->data(0, statusRole).toInt() == LUMAOK) {
+ for (int i = 0; i < trans.count(); ++i) {
+ QString luma = getProperty(trans.at(i).toElement(), "luma");
+ if (!luma.isEmpty() && luma == child->data(0, idRole).toString()) {
+ setProperty(trans.at(i).toElement(), "luma", child->text(1));
+ kDebug() << "replace with; " << child->text(1);
+ }
+ }
+ } else if (child->data(0, statusRole).toInt() == LUMAMISSING) {
+ for (int i = 0; i < trans.count(); ++i) {
+ QString luma = getProperty(trans.at(i).toElement(), "luma");
+ if (!luma.isEmpty() && luma == child->data(0, idRole).toString()) {
+ setProperty(trans.at(i).toElement(), "luma", QString());
}
}
- ix++;
- child = m_ui.treeWidget->topLevelItem(ix);
}
- //QDialog::accept();
}
void DocumentChecker::slotPlaceholders()
QString id = child->data(0, idRole).toString();
bool resetDuration = child->data(0, resetDurationRole).toInt();
- for (int i = 0; i < m_info.count(); i++) {
+ for (int i = 0; i < m_info.count(); ++i) {
QDomElement e = m_info.at(i).toElement();
if (e.attribute("id") == id) {
if (m_missingClips.contains(e)) {
for (int j = 0; j < documentProducers.count(); j++) {
QDomElement mltProd = documentProducers.at(j).toElement();
QString prodId = mltProd.attribute("id");
- if (prodId == id || prodId.startsWith(id + "_")) {
+ if (prodId == id || prodId.startsWith(id + '_')) {
EffectsList::removeProperty(mltProd, "length");
}
}
int ix = 0;
QTreeWidgetItem *child = m_ui.treeWidget->topLevelItem(ix);
while (child) {
- int status = child->data(0, statusRole).toInt();
- if (status == CLIPMISSING || status == LUMAMISSING || status == CLIPWRONGDURATION) {
+ int childStatus = child->data(0, statusRole).toInt();
+ if (childStatus == CLIPMISSING || childStatus == LUMAMISSING || childStatus == CLIPWRONGDURATION) {
status = false;
break;
}
if (!deletedLumas.isEmpty()) {
QDomElement e;
QDomNodeList transitions = m_doc.elementsByTagName("transition");
- foreach (QString lumaPath, deletedLumas) {
- for (int i = 0; i < transitions.count(); i++) {
+ foreach (const QString &lumaPath, deletedLumas) {
+ for (int i = 0; i < transitions.count(); ++i) {
e = transitions.item(i).toElement();
QString resource = EffectsList::property(e, "luma");
if (resource == lumaPath) EffectsList::removeProperty(e, "luma");
QDomNode mlt = m_doc.elementsByTagName("mlt").at(0);
QDomNode kdenlivedoc = m_doc.elementsByTagName("kdenlivedoc").at(0);
- for (int i = 0, j = 0; i < infoproducers.count() && j < deletedIds.count(); i++) {
+ for (int i = 0, j = 0; i < infoproducers.count() && j < deletedIds.count(); ++i) {
e = infoproducers.item(i).toElement();
if (deletedIds.contains(e.attribute("id"))) {
// Remove clip
kdenlivedoc.removeChild(e);
- i--;
+ --i;
j++;
}
}
- for (int i = 0; i < producers.count(); i++) {
+ for (int i = 0; i < producers.count(); ++i) {
e = producers.item(i).toElement();
if (deletedIds.contains(e.attribute("id").section('_', 0, 0)) || deletedIds.contains(e.attribute("id").section(':', 1, 1).section('_', 0, 0))) {
// Remove clip
mlt.removeChild(e);
- i--;
+ --i;
}
}
- for (int i = 0; i < playlists.count(); i++) {
+ for (int i = 0; i < playlists.count(); ++i) {
QDomNodeList entries = playlists.at(i).toElement().elementsByTagName("entry");
for (int j = 0; j < entries.count(); j++) {
e = entries.item(j).toElement();
}
}
-void DocumentChecker::checkMissingImagesAndFonts(QStringList images, QStringList fonts, const QString &id, const QString &baseClip)
+void DocumentChecker::checkMissingImagesAndFonts(const QStringList &images, const QStringList &fonts, const QString &id, const QString &baseClip)
{
QDomDocument doc;
foreach(const QString &img, images) {
projects / kdenlive / blobdiff