Minor optimization

[kdenlive] / src / jogshuttle.cpp

diff --git a/src/jogshuttle.cpp b/src/jogshuttle.cpp
index caba1eb5357cd9ecbf2dc9b856f17b1c81690464..36ea3cd0fb13dbfa193fe03471c1bdbe814e278c 100644 (file)
--- a/src/jogshuttle.cpp
+++ b/src/jogshuttle.cpp
@@ -34,7 +34,6 @@
 #include <errno.h>
 #include <string.h>
 #include <linux/input.h>
-#include <signal.h>
 
 #define DELAY 10
 
@@ -69,7 +68,7 @@
 #define JOG_STOP 10020
 #define MAX_SHUTTLE_RANGE 7
 
-void ShuttleThread::init(QObject *parent, QString device)
+void ShuttleThread::init(QObject *parent, const QString &device)
 {
     m_parent = parent;
     m_device = device;
@@ -85,11 +84,6 @@ bool ShuttleThread::isWorking()
     return m_isWorking;
 }
 
-void catcher(int sig)
-{
-   printf("   Signal catcher called for signal %d\n", sig);
-}
-
 void ShuttleThread::run()
 {
        kDebug() << "-------  STARTING SHUTTLE: " << m_device;
@@ -111,7 +105,7 @@ void ShuttleThread::run()
        fd_set             readset;
        struct timeval timeout;
 
-       int num_warnings, readResult = 0;
+       int num_warnings = 0, readResult = 0;
        int result, iof = -1;
 
        /* get fd settings */
@@ -271,7 +265,7 @@ void ShuttleThread::jog(unsigned int value)
 }
 
 
-JogShuttle::JogShuttle(QString device, QObject *parent) :
+JogShuttle::JogShuttle(const QString &device, QObject *parent) :
         QObject(parent)
 {
     initDevice(device);
@@ -282,7 +276,7 @@ JogShuttle::~JogShuttle()
        stopDevice();
 }
 
-void JogShuttle::initDevice(QString device)
+void JogShuttle::initDevice(const QString &device)
 {
     if (m_shuttleProcess.isRunning()) {
         if (device == m_shuttleProcess.m_device) return;
@@ -338,3 +332,5 @@ void JogShuttle::customEvent(QEvent* e)
 
 // #include "jogshuttle.moc"
 
+
+#include "jogshuttle.moc"