use const+reference

[kdenlive] / src / parameterplotter.cpp

diff --git a/src/parameterplotter.cpp b/src/parameterplotter.cpp
index 21bf09b715922d195448d28eacf20b7a38152943..c123be23e2925267a86cca089fe85bc2eb339c9b 100644 (file)
--- a/src/parameterplotter.cpp
+++ b/src/parameterplotter.cpp
@@ -38,6 +38,8 @@ ParameterPlotter::ParameterPlotter(QWidget *parent) :
     m_moveTimeline = true;
     m_newPoints = false;
     m_activeIndexPlot = -1;
+    m_max_y = 0;
+    m_min_y = 0;
 }
 /*
     <name>Lines</name>
@@ -81,20 +83,20 @@ void ParameterPlotter::setPointLists(const QDomElement& d, const QString& paramN
         QDomElement pa = namenode.item(i).toElement();
         QDomNode na = pa.firstChildElement("name");
 
-        m_parameterNameList << pa.attribute("namedesc").split(";");
+        m_parameterNameList << pa.attribute("namedesc").split(';');
         emit parameterList(m_parameterNameList);
 
         //max_y=pa.attributes().namedItem("max").nodeValue().toInt();
         //int val=pa.attributes().namedItem("value").nodeValue().toInt();
         QStringList defaults;
-        if (pa.attribute("start").contains(";"))
-            defaults = pa.attribute("start").split(";");
-        else if (pa.attribute("value").contains(";"))
-            defaults = pa.attribute("value").split(";");
-        else if (pa.attribute("default").contains(";"))
-            defaults = pa.attribute("default").split(";");
-        QStringList maxv = pa.attribute("max").split(";");
-        QStringList minv = pa.attribute("min").split(";");
+        if (pa.attribute("start").contains(';'))
+            defaults = pa.attribute("start").split(';');
+        else if (pa.attribute("value").contains(';'))
+            defaults = pa.attribute("value").split(';');
+        else if (pa.attribute("default").contains(';'))
+            defaults = pa.attribute("default").split(';');
+        QStringList maxv = pa.attribute("max").split(';');
+        QStringList minv = pa.attribute("min").split(';');
         for (int i = 0; i < maxv.size() && i < minv.size(); i++) {
             if (m_max_y < maxv[i].toInt()) m_max_y = maxv[i].toInt();
             if (m_min_y > minv[i].toInt()) m_min_y = minv[i].toInt();
@@ -248,7 +250,7 @@ void ParameterPlotter::mousePressEvent(QMouseEvent * event)
                     newpoints.append(QPointF(pt->x(), pt->y()));
                 }
                 p->clearPoints();
-                foreach(const QPointF qf, newpoints) {
+                foreach(const QPointF &qf, newpoints) {
                     p->addPoint(qf);
                 }
                 replacePlotObject(m_activeIndexPlot, p);