lavu/tx: require output argument to match input for inplace transforms

This simplifies some assembly code by a lot, by either saving a branch
or saving an entire duplicated function.

diff --git a/libavutil/tx.h b/libavutil/tx.h
index 983b5e9307c2ea4cb03245cebbcdfa6109f31a0d..bfc0c7f2a3c76255cff01e8337fd884e64414e33 100644 (file)
--- a/libavutil/tx.h
+++ b/libavutil/tx.h
@@ -103,8 +103,8 @@ typedef void (*av_tx_fn)(AVTXContext *s, void *out, void *in, ptrdiff_t stride);
  */
 enum AVTXFlags {
     /**
-     * Performs an in-place transformation on the input. The output parameter
-     * to av_tn_fn() will be ignored. May be unsupported or slower for some
+     * Performs an in-place transformation on the input. The output argument
+     * of av_tn_fn() MUST match the input. May be unsupported or slower for some
      * transform types.
      */
     AV_TX_INPLACE = 1ULL << 0,

diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
index f43173e920ed479e6c4415858dfb01b07dac3328..711013c35239d57c9a785cd59c60cbe9680bbf35 100644 (file)
--- a/libavutil/tx_template.c
+++ b/libavutil/tx_template.c
@@ -397,7 +397,6 @@ static void monolithic_fft(AVTXContext *s, void *_out, void *_in,
         FFTComplex tmp;
         int src, dst, *inplace_idx = s->inplace_idx;
 
-        out = in;
         src = *inplace_idx++;
 
         do {