#include "documentvalidator.h"
#include "definitions.h"
+#include "initeffects.h"
+#include "mainwindow.h"
#include <KDebug>
#include <KMessageBox>
#include <KApplication>
-#include <KLocale>
+#include <KLocalizedString>
+#include <KStandardDirs>
#include <QFile>
#include <QColor>
+#include <QString>
+#include <QDir>
+#include <QScriptEngine>
+#include <mlt++/Mlt.h>
-DocumentValidator::DocumentValidator(QDomDocument doc):
+#include <locale>
+
+
+DocumentValidator::DocumentValidator(const QDomDocument &doc, const KUrl &documentUrl):
m_doc(doc),
+ m_url(documentUrl),
m_modified(false)
{}
// Check if we're validating a Kdenlive project
if (kdenliveDoc.isNull())
return false;
+
+ QString rootDir = mlt.attribute("root");
+ if (rootDir == "$CURRENTPATH") {
+ // The document was extracted from a Kdenlive archived project, fix root directory
+ QString playlist = m_doc.toString();
+ playlist.replace("$CURRENTPATH", m_url.directory(KUrl::IgnoreTrailingSlash));
+ m_doc.setContent(playlist);
+ mlt = m_doc.firstChildElement("mlt");
+ kdenliveDoc = mlt.firstChildElement("kdenlivedoc");
+ }
+
+ // Previous MLT / Kdenlive versions used C locale by default
+ QLocale documentLocale = QLocale::c();
+
+ if (mlt.hasAttribute("LC_NUMERIC")) {
+ // Set locale for the document
+ const QString newLocale = setlocale(LC_NUMERIC, mlt.attribute("LC_NUMERIC").toUtf8().constData());
+ documentLocale = QLocale(mlt.attribute("LC_NUMERIC"));
+
+ // Make sure Qt locale and C++ locale have the same numeric separator, might not be the case
+ // With some locales since C++ and Qt use a different database for locales
+ char *separator = localeconv()->decimal_point;
+ if (newLocale.isEmpty()) {
+ // Requested locale not available, ask for install
+ KMessageBox::sorry(kapp->activeWindow(), i18n("The document was created in \"%1\" locale, which is not installed on your system. Please install that language pack. Until then, Kdenlive might not be able to correctly open the document.", mlt.attribute("LC_NUMERIC")));
+ }
+
+ if (separator != documentLocale.decimalPoint()) {
+ KMessageBox::sorry(kapp->activeWindow(), i18n("There is a locale conflict on your system. The document uses locale %1 which uses a \"%2\" as numeric separator (in system libraries) but Qt expects \"%3\". You might not be able to correctly open the project.", mlt.attribute("LC_NUMERIC"), separator, documentLocale.decimalPoint()));
+ kDebug()<<"------\n!!! system locale is not similar to Qt's locale... be prepared for bugs!!!\n------";
+ // HACK: There is a locale conflict, so set locale to at least have correct decimal point
+ if (strncmp(separator, ".", 1) == 0) documentLocale = QLocale::c();
+ else if (strncmp(separator, ",", 1) == 0) documentLocale = QLocale("fr_FR.UTF-8");
+ }
+ }
+
+ documentLocale.setNumberOptions(QLocale::OmitGroupSeparator);
+ if (documentLocale.decimalPoint() != QLocale().decimalPoint()) {
+ // If loading an older MLT file without LC_NUMERIC, set locale to C which was previously the default
+ if (!mlt.hasAttribute("LC_NUMERIC")) {
+ setlocale(LC_NUMERIC, "C");
+ }
+
+ QLocale::setDefault(documentLocale);
+ // locale conversion might need to be redone
+ initEffects::parseEffectFiles(setlocale(LC_NUMERIC, NULL));
+ }
+
+ bool ok;
+ double version = documentLocale.toDouble(kdenliveDoc.attribute("version"), &ok);
+ if (!ok) {
+ // Could not parse version number, there is probably a conflict in decimal separator
+ QLocale tempLocale = QLocale(mlt.attribute("LC_NUMERIC"));
+ version = tempLocale.toDouble(kdenliveDoc.attribute("version"), &ok);
+ if (!ok) version = kdenliveDoc.attribute("version").toDouble(&ok);
+ if (!ok) {
+ // Last try: replace comma with a dot
+ QString versionString = kdenliveDoc.attribute("version");
+ if (versionString.contains(',')) versionString.replace(',', '.');
+ version = versionString.toDouble(&ok);
+ if (!ok) kDebug()<<"// CANNOT PARSE VERSION NUMBER, ERROR!";
+ }
+ }
+
// Upgrade the document to the latest version
- if (!upgrade(kdenliveDoc.attribute("version").toDouble(), currentVersion))
+ if (!upgrade(version, currentVersion))
return false;
/*
// Looks like one MLT track is missing, remove the extra Kdenlive track if there is one.
if (tracksinfo.count() != tracks.count() - 1) {
// The Kdenlive tracks are not ok, clear and rebuild them
- QDomNode tinfo = kdenliveDoc.elementsByTagName("tracksinfo").at(0);
+ QDomNode tinfo = kdenliveDoc.firstChildElement("tracksinfo");
QDomNode tnode = tinfo.firstChild();
while (!tnode.isNull()) {
tinfo.removeChild(tnode);
tnode = tinfo.firstChild();
}
- for (int i = 1; i < tracks.count(); i++) {
+ for (int i = 1; i < tracks.count(); ++i) {
QString hide = tracks.at(i).toElement().attribute("hide");
QDomElement newTrack = m_doc.createElement("trackinfo");
if (hide == "video") {
}
+ updateEffects();
+
return true;
}
blank_tractor.appendChild(blank_track);
QDomNodeList kdenlivetracks = m_doc.elementsByTagName("kdenlivetrack");
- for (int i = 0; i < kdenlivetracks.count(); i++) {
+ for (int i = 0; i < kdenlivetracks.count(); ++i) {
blank_playlist = m_doc.createElement("playlist");
blank_playlist.setAttribute("id", "playlist" + QString::number(i));
westley.insertBefore(blank_playlist, QDomNode());
blank_track.setAttribute("hide", "video");
}
}
- } else for (int i = 0; i < max; i++) {
+ } else for (int i = 0; i < max; ++i) {
QDomNode n = playlists.at(i);
westley.insertBefore(n, QDomNode());
QDomElement pl = n.toElement();
// audio track mixing transitions should not be added to track view, so add required attribute
QDomNodeList transitions = m_doc.elementsByTagName("transition");
max = transitions.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QDomElement tr = transitions.at(i).toElement();
if (tr.attribute("combine") == "1" && tr.attribute("mlt_service") == "mix") {
QDomElement property = m_doc.createElement("property");
}
// move transitions after tracks
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
tractor.insertAfter(transitions.at(0), QDomNode());
}
// Fix filters format
QDomNodeList entries = m_doc.elementsByTagName("entry");
max = entries.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QString last_id;
int effectix = 0;
QDomNode m = entries.at(i).firstChild();
max = filters.count();
QString last_id;
int effectix = 0;
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QDomElement filt = filters.at(i).toElement();
QDomNamedNodeMap attrs = filt.attributes();
QString current_id = filt.attribute("kdenlive_id");
// fix slowmotion
QDomNodeList producers = westley.toElement().elementsByTagName("producer");
max = producers.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QDomElement prod = producers.at(i).toElement();
if (prod.attribute("mlt_service") == "framebuffer") {
QString slowmotionprod = prod.attribute("resource");
// This will get the xml producers:
producers = m_doc.elementsByTagName("producer");
max = producers.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QDomElement prod = producers.at(0).toElement();
// add resource also as a property (to allow path correction in setNewResource())
// TODO: will it work with slowmotion? needs testing
markers.insertAfter(mark, QDomNode());
}
prod.removeChild(m);
- } else if (prod.attribute("type").toInt() == TEXT) {
+ } else if (prod.attribute("type").toInt() == Text) {
// convert title clip
if (m.toElement().tagName() == "textclip") {
QDomDocument tdoc;
} else {
QDomNodeList wproducers = westley_element.elementsByTagName("producer");
int kmax = wproducers.count();
- for (int i = 0; i < kmax; i++) {
+ for (int i = 0; i < kmax; ++i) {
QDomElement wproducer = wproducers.at(i).toElement();
if (wproducer.isNull()) {
kWarning() << "Found producer in westley0, that was not a QDomElement";
if (wproducer.attribute("id") == "black") continue;
// We have to do slightly different things, depending on the type
kDebug() << "Converting producer element with type" << wproducer.attribute("type");
- if (wproducer.attribute("type").toInt() == TEXT) {
+ if (wproducer.attribute("type").toInt() == Text) {
kDebug() << "Found TEXT element in producer" << endl;
QDomElement kproducer = wproducer.cloneNode(true).toElement();
kproducer.setTagName("kdenlive_producer");
#endif
QDomNodeList elements = westley.childNodes();
max = elements.count();
- for (int i = 0; i < max; i++) {
+ for (int i = 0; i < max; ++i) {
QDomElement prod = elements.at(0).toElement();
westley0.insertAfter(prod, QDomNode());
}
QString tracksOrder = infoXml.attribute("tracks");
if (tracksOrder.isEmpty()) {
QDomNodeList tracks = m_doc.elementsByTagName("track");
- for (int i = 0; i < tracks.count(); i++) {
+ for (int i = 0; i < tracks.count(); ++i) {
QDomElement track = tracks.at(i).toElement();
if (track.attribute("producer") != "black_track") {
if (track.attribute("hide") == "video")
}
}
QDomElement tracksinfo = m_doc.createElement("tracksinfo");
- for (int i = 0; i < tracksOrder.size(); i++) {
+ for (int i = 0; i < tracksOrder.size(); ++i) {
QDomElement trackinfo = m_doc.createElement("trackinfo");
if (tracksOrder.data()[i] == 'a') {
trackinfo.setAttribute("type", "audio");
if (version <= 0.82) {
// Convert <westley />s in <mlt />s (MLT extreme makeover)
QDomNodeList westleyNodes = m_doc.elementsByTagName("westley");
- for (int i = 0; i < westleyNodes.count(); i++) {
+ for (int i = 0; i < westleyNodes.count(); ++i) {
QDomElement westley = westleyNodes.at(i).toElement();
westley.setTagName("mlt");
}
QDomNodeList kproducerNodes = m_doc.elementsByTagName("kdenlive_producer");
for (int i = 0; i < kproducerNodes.count() && convert != KMessageBox::No; ++i) {
QDomElement kproducer = kproducerNodes.at(i).toElement();
- if (kproducer.attribute("type").toInt() == TEXT) {
+ if (kproducer.attribute("type").toInt() == Text) {
QDomDocument data;
data.setContent(kproducer.attribute("xmldata"));
QDomNodeList items = data.firstChild().childNodes();
QDomNodeList kproducerNodes = m_doc.elementsByTagName("kdenlive_producer");
for (int i = 0; i < kproducerNodes.count(); ++i) {
QDomElement kproducer = kproducerNodes.at(i).toElement();
- if (kproducer.attribute("type").toInt() == TEXT) {
+ if (kproducer.attribute("type").toInt() == Text) {
QString data = kproducer.attribute("xmldata");
QString datafile = kproducer.attribute("resource");
if (!datafile.endsWith(".kdenlivetitle")) {
}
}
+ if (version <= 0.86) {
+ // Make sure we don't have avformat-novalidate producers, since it caused crashes
+ QDomNodeList producers = m_doc.elementsByTagName("producer");
+ int max = producers.count();
+ for (int i = 0; i < max; ++i) {
+ QDomElement prod = producers.at(i).toElement();
+ if (EffectsList::property(prod, "mlt_service") == "avformat-novalidate")
+ EffectsList::setProperty(prod, "mlt_service", "avformat");
+ }
+
+ // There was a mistake in Geometry transitions where the last keyframe was created one frame after the end of transition, so fix it and move last keyframe to real end of transition
+
+ // Get profile info (width / height)
+ int profileWidth;
+ int profileHeight;
+ QDomElement profile = m_doc.firstChildElement("profile");
+ if (profile.isNull()) profile = infoXml.firstChildElement("profileinfo");
+ if (profile.isNull()) {
+ // could not find profile info, set PAL
+ profileWidth = 720;
+ profileHeight = 576;
+ }
+ else {
+ profileWidth = profile.attribute("width").toInt();
+ profileHeight = profile.attribute("height").toInt();
+ }
+ QDomNodeList transitions = m_doc.elementsByTagName("transition");
+ max = transitions.count();
+ int out;
+ for (int i = 0; i < max; ++i) {
+ QDomElement trans = transitions.at(i).toElement();
+ out = trans.attribute("out").toInt() - trans.attribute("in").toInt();
+ QString geom = EffectsList::property(trans, "geometry");
+ Mlt::Geometry *g = new Mlt::Geometry(geom.toUtf8().data(), out, profileWidth, profileHeight);
+ Mlt::GeometryItem item;
+ if (g->next_key(&item, out) == 0) {
+ // We have a keyframe just after last frame, try to move it to last frame
+ if (item.frame() == out + 1) {
+ item.frame(out);
+ g->insert(item);
+ g->remove(out + 1);
+ EffectsList::setProperty(trans, "geometry", g->serialise());
+ }
+ }
+ delete g;
+ }
+ }
+
+ if (version <= 0.87) {
+ if (!m_doc.firstChildElement("mlt").hasAttribute("LC_NUMERIC")) {
+ m_doc.firstChildElement("mlt").setAttribute("LC_NUMERIC", "C");
+ }
+ }
// The document has been converted: mark it as modified
infoXml.setAttribute("version", currentVersion);
return true;
}
-QStringList DocumentValidator::getInfoFromEffectName(const QString oldName)
+QStringList DocumentValidator::getInfoFromEffectName(const QString &oldName)
{
QStringList info;
// Returns a list to convert old Kdenlive ladspa effects
{
return m_modified;
}
+
+void DocumentValidator::updateEffects()
+{
+ // WARNING: order by findDirs will determine which js file to use (in case multiple scripts for the same filter exist)
+ QMap <QString, KUrl> paths;
+#if QT_VERSION >= 0x040700
+ QMap <QString, QScriptProgram> scripts;
+#else
+ QMap <QString, QString> scripts;
+#endif
+ QStringList directories = KGlobal::dirs()->findDirs("appdata", "effects/update");
+ foreach (const QString &directoryName, directories) {
+ QDir directory(directoryName);
+ QStringList fileList = directory.entryList(QStringList() << "*.js", QDir::Files);
+ foreach (const QString &fileName, fileList) {
+ QString identifier = fileName;
+ // remove extension (".js")
+ identifier.chop(3);
+ paths.insert(identifier, KUrl(directoryName + fileName));
+ }
+ }
+
+ QDomNodeList effects = m_doc.elementsByTagName("filter");
+ int max = effects.count();
+ QStringList safeEffects;
+ for(int i = 0; i < max; ++i) {
+ QDomElement effect = effects.at(i).toElement();
+ QString effectId = EffectsList::property(effect, "kdenlive_id");
+ if (safeEffects.contains(effectId)) {
+ // Do not check the same effect twice if it is at the correct version
+ // (assume we don't have different versions of the same effect in a project file)
+ continue;
+ }
+ QString effectTag = EffectsList::property(effect, "tag");
+ QString effectVersionStr = EffectsList::property(effect, "version");
+ double effectVersion = effectVersionStr.isNull() ? -1 : effectVersionStr.toDouble();
+
+ QDomElement effectDescr = MainWindow::customEffects.getEffectByTag(QString(), effectId);
+ if (effectDescr.isNull()) {
+ effectDescr = MainWindow::videoEffects.getEffectByTag(effectTag, effectId);
+ }
+ if (effectDescr.isNull()) {
+ effectDescr = MainWindow::audioEffects.getEffectByTag(effectTag, effectId);
+ }
+ if (!effectDescr.isNull()) {
+ double serviceVersion = -1;
+ QDomElement serviceVersionElem = effectDescr.firstChildElement("version");
+ if (!serviceVersionElem.isNull()) {
+ serviceVersion = serviceVersionElem.text().toDouble();
+ }
+ if (serviceVersion != effectVersion && paths.contains(effectId)) {
+ if (!scripts.contains(effectId)) {
+ QFile scriptFile(paths.value(effectId).path());
+ if (!scriptFile.open(QIODevice::ReadOnly)) {
+ continue;
+ }
+#if QT_VERSION >= 0x040700
+ QScriptProgram scriptProgram(scriptFile.readAll());
+#else
+ QString scriptProgram = scriptFile.readAll();
+#endif
+ scriptFile.close();
+ scripts.insert(effectId, scriptProgram);
+ }
+
+ QScriptEngine scriptEngine;
+ scriptEngine.importExtension("qt.core");
+ scriptEngine.importExtension("qt.xml");
+ scriptEngine.evaluate(scripts.value(effectId));
+ QScriptValue updateRules = scriptEngine.globalObject().property("update");
+ if (!updateRules.isValid())
+ continue;
+ if (updateRules.isFunction()) {
+ QDomDocument scriptDoc;
+ scriptDoc.appendChild(scriptDoc.importNode(effect, true));
+
+ QString effectString = updateRules.call(QScriptValue(), QScriptValueList() << serviceVersion << effectVersion << scriptDoc.toString()).toString();
+
+ if (!effectString.isEmpty() && !scriptEngine.hasUncaughtException()) {
+ scriptDoc.setContent(effectString);
+ QDomNode updatedEffect = effect.ownerDocument().importNode(scriptDoc.documentElement(), true);
+ effect.parentNode().replaceChild(updatedEffect, effect);
+ m_modified = true;
+ }
+ } else {
+ m_modified = updateEffectParameters(effect.childNodes(), &updateRules, serviceVersion, effectVersion);
+ }
+
+ // set version number since MLT won't change it (only initially set it)
+ QDomElement versionElem = effect.firstChildElement("version");
+ if (EffectsList::property(effect, "version").isNull()) {
+ versionElem = effect.ownerDocument().createTextNode(QLocale().toString(serviceVersion)).toElement();
+ versionElem.setTagName("property");
+ versionElem.setAttribute("name", "version");
+ effect.appendChild(versionElem);
+ } else {
+ EffectsList::setProperty(effect, "version", QLocale().toString(serviceVersion));
+ }
+ }
+ else safeEffects.append(effectId);
+ }
+ }
+}
+
+bool DocumentValidator::updateEffectParameters(const QDomNodeList ¶meters, const QScriptValue* updateRules, const double serviceVersion, const double effectVersion)
+{
+ bool updated = false;
+ bool isDowngrade = serviceVersion < effectVersion;
+ for (int i = 0; i < parameters.count(); ++i) {
+ QDomElement parameter = parameters.at(i).toElement();
+ QScriptValue rules = updateRules->property(parameter.attribute("name"));
+ if (rules.isValid() && rules.isArray()) {
+ int rulesCount = rules.property("length").toInt32();
+ if (isDowngrade) {
+ // start with the highest version and downgrade step by step
+ for (int j = rulesCount - 1; j >= 0; --j) {
+ double version = rules.property(j).property(0).toNumber();
+ if (version <= effectVersion && version > serviceVersion) {
+ parameter.firstChild().setNodeValue(rules.property(j).property(1).call(QScriptValue(), QScriptValueList() << parameter.text() << isDowngrade).toString());
+ updated = true;
+ }
+ }
+ } else {
+ for (int j = 0; j < rulesCount; ++j) {
+ double version = rules.property(j).property(0).toNumber();
+ if (version > effectVersion && version <= serviceVersion) {
+ parameter.firstChild().setNodeValue(rules.property(j).property(1).call(QScriptValue(), QScriptValueList() << parameter.text() << isDowngrade).toString());
+ updated = true;
+ }
+ }
+ }
+ }
+ }
+ return updated;
+}
projects / kdenlive / blobdiff