]> git.sesse.net Git - kdenlive/commitdiff
projectlistview.cpp: check for null pointer
authorMikko Rapeli <mikko.rapeli@iki.fi>
Fri, 10 Aug 2012 12:17:13 +0000 (14:17 +0200)
committerJean-Baptiste Mardelle <jb@kdenlive.org>
Sun, 2 Sep 2012 09:40:49 +0000 (11:40 +0200)
Fixes Coverity CID 709291: Explicit null dereferenced (FORWARD_NULL)
Passing null variable "item" to function "FolderProjectItem::groupName() const", which dereferences it. [show details]
272                        props.insert("groupname", item->groupName());
...
Assigning: "item" = 0.
276                } else item = NULL;

src/projectlistview.cpp

index f5b8a8884c34d53092c8c7d20420766b3dec53c1..e4a2641b2323fc5484f33530f74a21b5a8cefa52 100644 (file)
@@ -266,7 +266,7 @@ void ProjectListView::dropEvent(QDropEvent *event)
                 if (it->type() == PROJECTCLIPTYPE) {
                     if (it->parent()) clone = (ProjectItem*) it->parent()->takeChild(it->parent()->indexOfChild(it));
                     else clone = (ProjectItem*) takeTopLevelItem(indexOfTopLevelItem(it));
-                    if (clone) {
+                    if (clone && item) {
                         item->addChild(clone);
                         QMap <QString, QString> props;
                         props.insert("groupname", item->groupName());