Minor optimization

diff --git a/src/abstractmonitor.h b/src/abstractmonitor.h
index b55fbd0f9d178025a5e905e06605295e9c803c4c..db7ab3a5a241f8138eddcfff01ab0616efc53408 100644 (file)
--- a/src/abstractmonitor.h
+++ b/src/abstractmonitor.h
@@ -89,7 +89,7 @@ class AbstractMonitor : public QWidget
     Q_OBJECT
 public:
     AbstractMonitor(Kdenlive::MONITORID id, MonitorManager *manager, QWidget *parent = 0);
-    Kdenlive::MONITORID id() {return m_id;};
+    Kdenlive::MONITORID id() {return m_id;}
     virtual ~AbstractMonitor();
     virtual AbstractRender *abstractRender() = 0;
     bool isActive() const;

diff --git a/src/managecapturesdialog.cpp b/src/managecapturesdialog.cpp
index 8a724ce4f117f8f54b412a81a1b756167e1fc74b..5467460c2ef514832e72ca1d54fb48dd7ef9d993 100644 (file)
--- a/src/managecapturesdialog.cpp
+++ b/src/managecapturesdialog.cpp
@@ -70,7 +70,7 @@ ManageCapturesDialog::~ManageCapturesDialog() {}
 void ManageCapturesDialog::slotCheckItemIcon()
 {
     int ct = 0;
-    int count = m_view.treeWidget->topLevelItemCount();
+    const int count = m_view.treeWidget->topLevelItemCount();
     while (ct < count) {
         QTreeWidgetItem *item = m_view.treeWidget->topLevelItem(ct);
         //QTreeWidgetItem *item = m_view.treeWidget->currentItem();
@@ -88,7 +88,7 @@ void ManageCapturesDialog::slotCheckItemIcon()
 
 void ManageCapturesDialog::slotRefreshButtons()
 {
-    int count = m_view.treeWidget->topLevelItemCount();
+    const int count = m_view.treeWidget->topLevelItemCount();
     bool enabled = false;
     for (int i = 0; i < count; ++i) {
         QTreeWidgetItem *item = m_view.treeWidget->topLevelItem(i);
@@ -104,7 +104,7 @@ void ManageCapturesDialog::slotDeleteCurrent()
 {
     QTreeWidgetItem *item = m_view.treeWidget->currentItem();
     if (!item) return;
-    int i = m_view.treeWidget->indexOfTopLevelItem(item);
+    const int i = m_view.treeWidget->indexOfTopLevelItem(item);
     m_view.treeWidget->takeTopLevelItem(i);
     kDebug() << "DELETING FILE: " << item->text(0);
     //KIO::NetAccess::del(KUrl(item->text(0)), this);
@@ -116,7 +116,7 @@ void ManageCapturesDialog::slotDeleteCurrent()
 
 void ManageCapturesDialog::slotToggle()
 {
-    int count = m_view.treeWidget->topLevelItemCount();
+    const int count = m_view.treeWidget->topLevelItemCount();
     for (int i = 0; i < count; ++i) {
         QTreeWidgetItem *item = m_view.treeWidget->topLevelItem(i);
         if (item) {
@@ -130,7 +130,7 @@ KUrl::List ManageCapturesDialog::importFiles()
 {
     KUrl::List result;
 
-    int count = m_view.treeWidget->topLevelItemCount();
+    const int count = m_view.treeWidget->topLevelItemCount();
     for (int i = 0; i < count; ++i) {
         QTreeWidgetItem *item = m_view.treeWidget->topLevelItem(i);
         if (item && item->checkState(0) == Qt::Checked)

diff --git a/src/monitor.cpp b/src/monitor.cpp
index c6b14fb61878dc34dc218a41eddbc77bd52f6afb..68f7b2495eb9957af5fe8393a494121cd40ddf67 100644 (file)
--- a/src/monitor.cpp
+++ b/src/monitor.cpp
@@ -386,7 +386,7 @@ void Monitor::updateMarkers(DocClipBase *source)
     }
 }
 
-void Monitor::setMarkers(QList <CommentedTime> markers)
+void Monitor::setMarkers(const QList<CommentedTime> &markers)
 {
     m_ruler->setMarkers(markers);
 }

diff --git a/src/monitor.h b/src/monitor.h
index c7821273f87f231cf22a1f95cf91395ca933bfff..5dc6f2a4eeb0bf49f65661b58adf3a83888b1509 100644 (file)
--- a/src/monitor.h
+++ b/src/monitor.h
@@ -86,7 +86,7 @@ public:
     void checkOverlay();
     void updateTimecodeFormat();
     void updateMarkers(DocClipBase *source);
-    void setMarkers(QList <CommentedTime> markers);
+    void setMarkers(const QList <CommentedTime> &markers);
     MonitorEditWidget *getEffectEdit();
     QWidget *container();
     void reloadProducer(const QString &id);