Use const'ref, change if(foo) delete foo => delete foo not necessary to check it...

Add explicit keyword when necessary

diff --git a/src/clipdurationdialog.cpp b/src/clipdurationdialog.cpp
index 69436e2619a44d1403b54d200d9ef554f503fca1..f761c02e581ba817e444472870c4bdbe19282b5d 100644 (file)
--- a/src/clipdurationdialog.cpp
+++ b/src/clipdurationdialog.cpp
@@ -27,7 +27,7 @@
 
 #include <QWheelEvent>
 
-ClipDurationDialog::ClipDurationDialog(AbstractClipItem *clip, Timecode tc, GenTime min, GenTime max, QWidget * parent):
+ClipDurationDialog::ClipDurationDialog(AbstractClipItem *clip, const Timecode &tc, const GenTime &min, const GenTime &max, QWidget * parent):
         QDialog(parent),
         m_clip(clip),
         m_min(min),

diff --git a/src/clipdurationdialog.h b/src/clipdurationdialog.h
index 27a8ee18c42376475f1db27b49f7ac7743964345..ea09744a7a715934d218ad8f9fc28d5c8eca7873 100644 (file)
--- a/src/clipdurationdialog.h
+++ b/src/clipdurationdialog.h
@@ -37,7 +37,7 @@ class ClipDurationDialog : public QDialog, public Ui::ClipDurationDialog_UI
     Q_OBJECT
 
 public:
-    ClipDurationDialog(AbstractClipItem *clip, Timecode tc, GenTime min, GenTime max, QWidget * parent = 0);
+    explicit ClipDurationDialog(AbstractClipItem *clip, const Timecode &tc, const GenTime &min, const GenTime &max, QWidget * parent = 0);
     ~ClipDurationDialog();
     GenTime startPos() const;
     GenTime cropStart() const;

diff --git a/src/clipitem.cpp b/src/clipitem.cpp
index 479c28c9397ae31e8f2448c504f4888975f4e113..e19ef61a3d9c1d635734fc5cb99f6817acdbc7d5 100644 (file)
--- a/src/clipitem.cpp
+++ b/src/clipitem.cpp
@@ -42,7 +42,7 @@
 
 static int FRAME_SIZE;
 
-ClipItem::ClipItem(DocClipBase *clip, ItemInfo info, double fps, double speed, int strobe, int frame_width, bool generateThumbs) :
+ClipItem::ClipItem(DocClipBase *clip, const ItemInfo& info, double fps, double speed, int strobe, int frame_width, bool generateThumbs) :
         AbstractClipItem(info, QRectF(), fps),
         m_clip(clip),
         m_startFade(0),

diff --git a/src/clipitem.h b/src/clipitem.h
index abc7aa954d00058add5d6499cff8968af05744d0..da52dbde672b7da8b9db799735f9106d959856f8 100644 (file)
--- a/src/clipitem.h
+++ b/src/clipitem.h
@@ -46,7 +46,7 @@ class ClipItem : public AbstractClipItem
     Q_OBJECT
 
 public:
-    ClipItem(DocClipBase *clip, ItemInfo info, double fps, double speed, int strobe, int frame_width, bool generateThumbs = true);
+    ClipItem(DocClipBase *clip, const ItemInfo &info, double fps, double speed, int strobe, int frame_width, bool generateThumbs = true);
     virtual ~ ClipItem();
     virtual void paint(QPainter *painter,
                        const QStyleOptionGraphicsItem *option,

diff --git a/src/clipmanager.cpp b/src/clipmanager.cpp
index 8a1c36471de531e781068be4d04f82516205c378..b764ee725986a73d17c95baf02f7353ce6a6b514 100644 (file)
--- a/src/clipmanager.cpp
+++ b/src/clipmanager.cpp
@@ -464,7 +464,7 @@ DocClipBase *ClipManager::getClipById(QString clipId)
     return NULL;
 }
 
-const QList <DocClipBase *> ClipManager::getClipByResource(QString resource)
+const QList <DocClipBase *> ClipManager::getClipByResource(const QString &resource)
 {
     QList <DocClipBase *> list;
     QString clipResource;
@@ -663,7 +663,7 @@ void ClipManager::slotAddXmlClipFile(const QString &name, const QDomElement &xml
     m_doc->commandStack()->push(command);
 }
 
-void ClipManager::slotAddColorClipFile(const QString &name, const QString &color, QString duration, const QString &group, const QString &groupId)
+void ClipManager::slotAddColorClipFile(const QString &name, const QString &color, const QString &duration, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     QDomElement prod = doc.createElement("producer");
@@ -982,7 +982,7 @@ bool ClipManager::isOnRemovableDevice(const KUrl &url)
     return volumeMatch;
 }
 
-void ClipManager::projectTreeThumbReady(const QString &id, int frame, QImage img, int type)
+void ClipManager::projectTreeThumbReady(const QString &id, int frame, const QImage &img, int type)
 {
     switch (type) {
       case 2:

diff --git a/src/clipmanager.h b/src/clipmanager.h
index 5165bbd4f8c6ec24fd7768c776330cc764212f79..2a06970b4100fa1ec2826876a98d6db2c86310df 100644 (file)
--- a/src/clipmanager.h
+++ b/src/clipmanager.h
@@ -99,10 +99,10 @@ Q_OBJECT public:
     void slotAddTextClipFile(const QString &titleName, int out, const QString &xml, const QString &group, const QString &groupId);
     void slotAddTextTemplateClip(QString titleName, const KUrl &path, const QString &group, const QString &groupId);
     void slotAddXmlClipFile(const QString &name, const QDomElement &xml, const QString &group, const QString &groupId);
-    void slotAddColorClipFile(const QString &name, const QString &color, QString duration, const QString &group, const QString &groupId);
+    void slotAddColorClipFile(const QString &name, const QString &color, const QString &duration, const QString &group, const QString &groupId);
     void slotAddSlideshowClipFile(QMap <QString, QString> properties, const QString &group, const QString &groupId);
     DocClipBase *getClipById(QString clipId);
-    const QList <DocClipBase *> getClipByResource(QString resource);
+    const QList <DocClipBase *> getClipByResource(const QString &resource);
     void slotDeleteClips(QStringList ids);
     void setThumbsProgress(const QString &message, int progress);
     void checkAudioThumbs();
@@ -125,7 +125,7 @@ Q_OBJECT public:
     int clipsCount() const;
     /** @brief remove a clip id from the queue list. */
     void stopThumbs(const QString &id);
-    void projectTreeThumbReady(const QString &id, int frame, QImage img, int type);
+    void projectTreeThumbReady(const QString &id, int frame, const QImage &img, int type);
 
 #if KDE_IS_VERSION(4,5,0)
     KImageCache* pixmapCache;

diff --git a/src/clipproperties.cpp b/src/clipproperties.cpp
index 2bc19e620b84b7d4a0a448472e8c5eee75d7db6a..6f5366c64d669e4c71be4d0c90c8cc9b185d133d 100644 (file)
--- a/src/clipproperties.cpp
+++ b/src/clipproperties.cpp
@@ -56,7 +56,7 @@ static const int METATAB = 6;
 static const int ADVANCEDTAB = 7;
 
 
-ClipProperties::ClipProperties(DocClipBase *clip, Timecode tc, double fps, QWidget * parent) :
+ClipProperties::ClipProperties(DocClipBase *clip, const Timecode &tc, double fps, QWidget * parent) :
     QDialog(parent)
     , m_clip(clip)
     , m_tc(tc)

diff --git a/src/clipproperties.h b/src/clipproperties.h
index 075e13f08b6473ad0b9cf352f8602c29e9616eb6..19b5bc7d57d475768ea11d5906890780c5b91604 100644 (file)
--- a/src/clipproperties.h
+++ b/src/clipproperties.h
@@ -47,7 +47,7 @@ class ClipProperties : public QDialog
     Q_OBJECT
 
 public:
-    ClipProperties(DocClipBase *clip, Timecode tc, double fps, QWidget * parent = 0);
+    ClipProperties(DocClipBase *clip, const Timecode &tc, double fps, QWidget * parent = 0);
     ClipProperties(QList <DocClipBase *>cliplist, Timecode tc, QMap <QString, QString> commonproperties, QWidget * parent);
     virtual ~ClipProperties();
     QMap <QString, QString> properties();

diff --git a/src/cliptranscode.cpp b/src/cliptranscode.cpp
index 9caf4e4a4f87148758091719c150c6e6fc06e3c6..664eb5fa4121b04774d9295997057aceb0d480d3 100644 (file)
--- a/src/cliptranscode.cpp
+++ b/src/cliptranscode.cpp
@@ -127,7 +127,7 @@ void ClipTranscode::slotStartTransCode()
     QStringList parameters;
     QString destination;
     QString params = ffmpeg_params->toPlainText().simplified();
-    if (m_urls.count() > 0 && urls_list->count() > 0) {
+    if (!m_urls.isEmpty() && urls_list->count() > 0) {
         // We are processing multiple clips
         source_url->setUrl(m_urls.takeFirst());
         destination = dest_url->url().path(KUrl::AddTrailingSlash) + source_url->url().fileName();

diff --git a/src/complexparameter.cpp b/src/complexparameter.cpp
index 7b4d5ff2f2a0ed74fabcbcb7de5a9c453c2e8a8b..da969101350f481378b79c1b88e04c2eb57575ea 100644 (file)
--- a/src/complexparameter.cpp
+++ b/src/complexparameter.cpp
@@ -114,7 +114,7 @@ void ComplexParameter::slotParameterChanged(const QString& text)
     updateButtonStatus();
 }
 
-void ComplexParameter::setupParam(const QDomElement d, const QString& paramName, int from, int to)
+void ComplexParameter::setupParam(const QDomElement &d, const QString& paramName, int from, int to)
 {
     m_param = d;
     m_ui.kplotwidget->setPointLists(d, paramName, from, to);
@@ -125,7 +125,7 @@ void ComplexParameter::itemSelectionChanged()
     //kDebug() << "drop";
 }
 
-void ComplexParameter::slotUpdateEffectParams(QDomElement e)
+void ComplexParameter::slotUpdateEffectParams(const QDomElement &e)
 {
     m_param = e;
     emit parameterChanged();

diff --git a/src/complexparameter.h b/src/complexparameter.h
index 8990605471b4b886313c9eda600e8f2717a57202..9c2338bae26cafd1cc599dd298b7bb6d81e2964e 100644 (file)
--- a/src/complexparameter.h
+++ b/src/complexparameter.h
@@ -45,8 +45,8 @@ public slots:
     void slotShowInTimeline();
     void slotParameterChanged(const QString&);
     void itemSelectionChanged();
-    void setupParam(const QDomElement, const QString& paramName, int, int);
-    void slotUpdateEffectParams(QDomElement e);
+    void setupParam(const QDomElement &, const QString& paramName, int, int);
+    void slotUpdateEffectParams(const QDomElement &e);
     void slotUpdateParameterList(const QStringList &);
 signals:
     void removeEffect(ClipItem*, QDomElement);

diff --git a/src/cornerswidget.cpp b/src/cornerswidget.cpp
index d31c091ddf2f1e03d42318cbb3d5002d80bfc568..aacebe356c934c4ce50b6639ac20b6d91ebd7fa6 100644 (file)
--- a/src/cornerswidget.cpp
+++ b/src/cornerswidget.cpp
@@ -36,7 +36,7 @@ inline int lerp( const int a, const int b, double t )
     return a + (b - a) * t;
 }
 
-CornersWidget::CornersWidget(Monitor *monitor, const QDomElement& e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) :
+CornersWidget::CornersWidget(Monitor *monitor, const QDomElement& e, int minFrame, int maxFrame, const Timecode &tc, int activeKeyframe, QWidget* parent) :
         KeyframeEdit(e, minFrame, maxFrame, tc, activeKeyframe, parent),
         m_monitor(monitor),
         m_showScene(true),

diff --git a/src/cornerswidget.h b/src/cornerswidget.h
index 1cad4610bea0c154809d102a11bc3a136e8e46ad..4c585cbb45e73eeb41c73cbcf3399b73cf31b65c 100644 (file)
--- a/src/cornerswidget.h
+++ b/src/cornerswidget.h
@@ -40,7 +40,7 @@ public:
      * @param isEffect true if used in an effect, false if used in a transition
      * @param factor Factor by which the parameters differ from the range 0-1
      * @param parent (optional) Parent widget */
-    explicit CornersWidget(Monitor *monitor, const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0);
+    explicit CornersWidget(Monitor *monitor, const QDomElement &e, int minFrame, int maxFrame, const Timecode &tc, int activeKeyframe, QWidget* parent = 0);
     virtual ~CornersWidget();
 
     virtual void addParameter(QDomElement e, int activeKeyframe = -1);

diff --git a/src/databackup/backupwidget.cpp b/src/databackup/backupwidget.cpp
index 2aafd7a14d3be7fb863b484198ef856e75719737..8ff35b07bc1032d90e643d2b3bd3538e73edea1f 100644 (file)
--- a/src/databackup/backupwidget.cpp
+++ b/src/databackup/backupwidget.cpp
@@ -99,7 +99,7 @@ void BackupWidget::slotDisplayBackupPreview()
         backup_preview->setPixmap(QPixmap());
         return;
     }
-    QString path = backup_list->currentItem()->data(Qt::UserRole).toString();
+    const QString path = backup_list->currentItem()->data(Qt::UserRole).toString();
     QPixmap pix(path + ".png");
     backup_preview->setPixmap(pix);
 }

diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp
index 938cdb7eac00f470c70ddaef524eac27a1cb3572..61632374a4731e89e32c12756190e0420ad39777 100644 (file)
--- a/src/docclipbase.cpp
+++ b/src/docclipbase.cpp
@@ -218,7 +218,7 @@ const QString DocClipBase::getProperty(const QString &prop) const
     return m_properties.value(prop);
 }
 
-void DocClipBase::setDuration(GenTime dur)
+void DocClipBase::setDuration(const GenTime &dur)
 {
     m_duration = dur;
     m_properties.insert("duration", QString::number((int) dur.frames(KdenliveSettings::project_fps())));
@@ -380,7 +380,7 @@ QList < CommentedTime > DocClipBase::commentedSnapMarkers() const
 }
 
 
-void DocClipBase::addSnapMarker(const CommentedTime marker)
+void DocClipBase::addSnapMarker(const CommentedTime &marker)
 {
     QList < CommentedTime >::Iterator it = m_snapMarkers.begin();
     for (it = m_snapMarkers.begin(); it != m_snapMarkers.end(); ++it) {
@@ -397,7 +397,7 @@ void DocClipBase::addSnapMarker(const CommentedTime marker)
     }
 }
 
-void DocClipBase::editSnapMarker(const GenTime & time, QString comment)
+void DocClipBase::editSnapMarker(const GenTime & time, const QString &comment)
 {
     QList < CommentedTime >::Iterator it;
     for (it = m_snapMarkers.begin(); it != m_snapMarkers.end(); ++it) {

diff --git a/src/docclipbase.h b/src/docclipbase.h
index 0e22c4dad85a311889bbc874d006f6e314a3f0b8..e4f90fceb480a993cd30de4005945edd627221e2 100644 (file)
--- a/src/docclipbase.h
+++ b/src/docclipbase.h
@@ -89,7 +89,7 @@ public:
     const GenTime & duration() const;
     const GenTime maxDuration() const;
     /** returns the duration of this clip */
-    void setDuration(GenTime dur);
+    void setDuration(const GenTime &dur);
 
     /** returns clip type (audio, text, image,...) */
     const CLIPTYPE & clipType() const;
@@ -271,8 +271,8 @@ public slots:
     GenTime findPreviousSnapMarker(const GenTime & currTime);
     GenTime hasSnapMarkers(const GenTime & time);
     QString deleteSnapMarker(const GenTime & time);
-    void editSnapMarker(const GenTime & time, QString comment);
-    void addSnapMarker(const CommentedTime marker);
+    void editSnapMarker(const GenTime & time, const QString &comment);
+    void addSnapMarker(const CommentedTime &marker);
     QList < GenTime > snapMarkers() const;
     QString markerComment(GenTime t) const;
     CommentedTime markerAt(GenTime t) const;

diff --git a/src/doubleparameterwidget.cpp b/src/doubleparameterwidget.cpp
index bcbcf509ea19bc4dece4f3c3957c59b20d80942c..ce8153a5074512f43c9e19eda11560288df873e2 100644 (file)
--- a/src/doubleparameterwidget.cpp
+++ b/src/doubleparameterwidget.cpp
@@ -31,7 +31,7 @@
 #include <KLocalizedString>
 
 
-DoubleParameterWidget::DoubleParameterWidget(const QString &name, double value, double min, double max, double defaultValue, const QString &comment, int id, const QString suffix, int decimals, QWidget *parent) :
+DoubleParameterWidget::DoubleParameterWidget(const QString &name, double value, double min, double max, double defaultValue, const QString &comment, int id, const QString &suffix, int decimals, QWidget *parent) :
         QWidget(parent)
 {
     setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Maximum);

diff --git a/src/doubleparameterwidget.h b/src/doubleparameterwidget.h
index 8d85c3ff4250556f37013485db8c5d76cb69f664..7dec64656eeba0b7bc4d76a103015f74a205b628 100644 (file)
--- a/src/doubleparameterwidget.h
+++ b/src/doubleparameterwidget.h
@@ -48,7 +48,7 @@ public:
     * @param comment A comment explaining the parameter. Will be shown for the tooltip.
     * @param suffix (optional) Suffix to display in spinbox
     * @param parent (optional) Parent Widget */
-    DoubleParameterWidget(const QString &name, double value, double min, double max, double defaultValue, const QString &comment, int id, const QString suffix = QString(), int decimals = 0, QWidget* parent = 0);
+    explicit DoubleParameterWidget(const QString &name, double value, double min, double max, double defaultValue, const QString &comment, int id, const QString &suffix = QString(), int decimals = 0, QWidget* parent = 0);
     ~DoubleParameterWidget();
 
     /** @brief Gets the parameter's value. */

diff --git a/src/dragvalue.cpp b/src/dragvalue.cpp
index cf59b1806f4d46d0633456894bc2d4bed1396da2..21a99aa6f452690de7bdcd96c749438211c4dca4 100644 (file)
--- a/src/dragvalue.cpp
+++ b/src/dragvalue.cpp
@@ -43,7 +43,7 @@
 #include <KGlobalSettings>
 
 
-DragValue::DragValue(const QString &label, double defaultValue, int decimals, double min, double max, int id, const QString suffix, bool showSlider, QWidget* parent) :
+DragValue::DragValue(const QString &label, double defaultValue, int decimals, double min, double max, int id, const QString &suffix, bool showSlider, QWidget* parent) :
         QWidget(parent),
         m_maximum(max),
         m_minimum(min),

diff --git a/src/dragvalue.h b/src/dragvalue.h
index cfd1f02ac6726e1972fc763c370efa89befcd763..eda130f82768408991ce1f14beaa6b5de7abd4dd 100644 (file)
--- a/src/dragvalue.h
+++ b/src/dragvalue.h
@@ -85,7 +85,7 @@ public:
     * @param suffix The suffix that will be displayed in the spinbox (for example '%')
     * @param showSlider If disabled, user can still drag on the label but no progress bar is shown
     */    
-    DragValue(const QString &label, double defaultValue, int decimals, double min = 0, double max = 100, int id = -1, const QString suffix = QString(), bool showSlider = true, QWidget* parent = 0);
+    explicit DragValue(const QString &label, double defaultValue, int decimals, double min = 0, double max = 100, int id = -1, const QString &suffix = QString(), bool showSlider = true, QWidget* parent = 0);
     virtual ~DragValue();
 
     /** @brief Returns the precision = number of decimals */

diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index 4479371ca38a59e78e13e389addb52ee5c56b281..874790ee676e8c576cc1e51f152f2c27f6a39f4a 100644 (file)
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -163,7 +163,7 @@ QString EffectsList::getEffectInfo(const QDomElement effect) const
 }
 
 // static
-bool EffectsList::hasKeyFrames(QDomElement effect)
+bool EffectsList::hasKeyFrames(const QDomElement &effect)
 {
     QDomNodeList params = effect.elementsByTagName("parameter");
     for (int i = 0; i < params.count(); i++) {
@@ -174,7 +174,7 @@ bool EffectsList::hasKeyFrames(QDomElement effect)
 }
 
 // static
-bool EffectsList::hasSimpleKeyFrames(QDomElement effect)
+bool EffectsList::hasSimpleKeyFrames(const QDomElement &effect)
 {
     QDomNodeList params = effect.elementsByTagName("parameter");
     for (int i = 0; i < params.count(); i++) {
@@ -185,7 +185,7 @@ bool EffectsList::hasSimpleKeyFrames(QDomElement effect)
 }
 
 // static
-bool EffectsList::hasGeometryKeyFrames(QDomElement effect)
+bool EffectsList::hasGeometryKeyFrames(const QDomElement &effect)
 {
     QDomNodeList params = effect.elementsByTagName("parameter");
     for (int i = 0; i < params.count(); ++i) {
@@ -233,7 +233,7 @@ void EffectsList::setParameter(QDomElement effect, const QString &name, const QS
 }
 
 // static
-QString EffectsList::parameter(QDomElement effect, const QString &name)
+QString EffectsList::parameter(const QDomElement &effect, const QString &name)
 {
     QDomNodeList params = effect.elementsByTagName("parameter");
     for (int i = 0; i < params.count(); i++) {
@@ -393,7 +393,7 @@ void EffectsList::updateIndexes(QDomNodeList effects, int startIndex)
     }
 }
 
-void EffectsList::enableEffects(QList <int> indexes, bool disable)
+void EffectsList::enableEffects(const QList <int>& indexes, bool disable)
 {
     QDomNodeList effects = m_baseElement.childNodes();
     QDomElement effect;

diff --git a/src/effectslist.h b/src/effectslist.h
index 7119448c2ab3546945939851e0abbbda90bd518b..9654b5bb6174fb19fe077afe770dc2c09ca3a482 100644 (file)
--- a/src/effectslist.h
+++ b/src/effectslist.h
@@ -72,11 +72,11 @@ public:
     QDomElement itemFromIndex(int ix) const;
     QDomElement insert(QDomElement effect);
     void updateEffect(QDomElement effect);
-    static bool hasKeyFrames(QDomElement effect);
-    static bool hasSimpleKeyFrames(QDomElement effect);
-    static bool hasGeometryKeyFrames(QDomElement effect);
+    static bool hasKeyFrames(const QDomElement &effect);
+    static bool hasSimpleKeyFrames(const QDomElement &effect);
+    static bool hasGeometryKeyFrames(const QDomElement &effect);
     static void setParameter(QDomElement effect, const QString &name, const QString &value);
-    static QString parameter(QDomElement effect, const QString &name);
+    static QString parameter(const QDomElement &effect, const QString &name);
     /** @brief Change the value of a 'property' element from the effect node. */
     static void setProperty(QDomElement effect, const QString &name, const QString &value);
     /** @brief Rename a 'property' element from the effect node. */
@@ -93,7 +93,7 @@ public:
     /** @brief Update all effects indexes to make sure they are 1, 2, 3, ... */
     void updateIndexes(QDomNodeList effects, int startIndex);
     /** @brief Enable / disable a list of effects */
-    void enableEffects(QList <int> indexes, bool disable);
+    void enableEffects(const QList<int> &indexes, bool disable);
 
 private:
     QDomElement m_baseElement;

diff --git a/src/effectstack/collapsibleeffect.cpp b/src/effectstack/collapsibleeffect.cpp
index 63f944e141b91b3d990767458ef7acc63ee3ebf3..21317971ab160aaa9f0b1b5a930d473ef1bc1c76 100644 (file)
--- a/src/effectstack/collapsibleeffect.cpp
+++ b/src/effectstack/collapsibleeffect.cpp
@@ -41,7 +41,7 @@
 #include <KApplication>
 
 
-CollapsibleEffect::CollapsibleEffect(const QDomElement &effect, const QDomElement &original_effect, ItemInfo info, EffectMetaInfo *metaInfo, bool lastEffect, QWidget * parent) :
+CollapsibleEffect::CollapsibleEffect(const QDomElement &effect, const QDomElement &original_effect, const ItemInfo &info, EffectMetaInfo *metaInfo, bool lastEffect, QWidget * parent) :
         AbstractCollapsibleWidget(parent),
         m_paramWidget(NULL),
         m_effect(effect),

diff --git a/src/effectstack/collapsibleeffect.h b/src/effectstack/collapsibleeffect.h
index ce4672c70390cf6546cf14383ef6eb43cee87e51..c73cf67bcf4cc0cda8be34b3651d4ea5633254f6 100644 (file)
--- a/src/effectstack/collapsibleeffect.h
+++ b/src/effectstack/collapsibleeffect.h
@@ -43,7 +43,7 @@ class CollapsibleEffect : public AbstractCollapsibleWidget
     Q_OBJECT
 
 public:
-    CollapsibleEffect(const QDomElement &effect, const QDomElement &original_effect, ItemInfo info, EffectMetaInfo *metaInfo, bool lastEffect, QWidget * parent = 0);
+    explicit CollapsibleEffect(const QDomElement &effect, const QDomElement &original_effect, const ItemInfo &info, EffectMetaInfo *metaInfo, bool lastEffect, QWidget * parent = 0);
     ~CollapsibleEffect();
     QLabel *title;
        

diff --git a/src/effectstack/collapsiblegroup.cpp b/src/effectstack/collapsiblegroup.cpp
index 8572b6eca47dabc979c96709260b0fbf6d11b13f..d0d5d3de570a064aa671487de72dfc39175432a9 100644 (file)
--- a/src/effectstack/collapsiblegroup.cpp
+++ b/src/effectstack/collapsiblegroup.cpp
@@ -53,7 +53,7 @@ void MyEditableLabel::mouseDoubleClickEvent ( QMouseEvent * e )
 }
 
 
-CollapsibleGroup::CollapsibleGroup(int ix, bool firstGroup, bool lastGroup, EffectInfo info, QWidget * parent) :
+CollapsibleGroup::CollapsibleGroup(int ix, bool firstGroup, bool lastGroup, const EffectInfo &info, QWidget * parent) :
         AbstractCollapsibleWidget(parent)
 {
     m_info.groupIndex = ix;

diff --git a/src/effectstack/collapsiblegroup.h b/src/effectstack/collapsiblegroup.h
index 226e904052c6ce59f00a11906cacc744bedae46d..b9ed52377ea8607cbef447e3f5967d7ae91a56a3 100644 (file)
--- a/src/effectstack/collapsiblegroup.h
+++ b/src/effectstack/collapsiblegroup.h
@@ -56,7 +56,7 @@ class CollapsibleGroup : public AbstractCollapsibleWidget
     Q_OBJECT
 
 public:
-    CollapsibleGroup(int ix, bool firstGroup, bool lastGroup, EffectInfo info, QWidget * parent = 0);
+    CollapsibleGroup(int ix, bool firstGroup, bool lastGroup, const EffectInfo &info, QWidget * parent = 0);
     ~CollapsibleGroup();
     void updateTimecodeFormat();
     void setActive(bool activate);

diff --git a/src/effectstack/parametercontainer.cpp b/src/effectstack/parametercontainer.cpp
index 953bdf5ab63887401b48f5c30a1bce5eee0add4f..67ab52010f4bc2604b6ad9fa1fd5c92130a9618c 100644 (file)
--- a/src/effectstack/parametercontainer.cpp
+++ b/src/effectstack/parametercontainer.cpp
@@ -95,7 +95,7 @@ class Fontval: public QWidget, public Ui::Fontval_UI
 };
 
 
-ParameterContainer::ParameterContainer(const QDomElement &effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent) :
+ParameterContainer::ParameterContainer(const QDomElement &effect, const ItemInfo &info, EffectMetaInfo *metaInfo, QWidget * parent) :
         m_keyframeEditor(NULL),
         m_geometryWidget(NULL),
         m_metaInfo(metaInfo),

diff --git a/src/effectstack/parametercontainer.h b/src/effectstack/parametercontainer.h
index 65c048b46a40d25cc7428f74fadd9b478aa1ed0f..db489b28aa9de717bb20bd6c86ef2d9c0a603ce2 100644 (file)
--- a/src/effectstack/parametercontainer.h
+++ b/src/effectstack/parametercontainer.h
@@ -59,7 +59,7 @@ class ParameterContainer : public QObject
     Q_OBJECT
 
 public:
-    ParameterContainer(const QDomElement &effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent = 0);
+    explicit ParameterContainer(const QDomElement &effect, const ItemInfo &info, EffectMetaInfo *metaInfo, QWidget * parent = 0);
     ~ParameterContainer();
     void updateTimecodeFormat();
     void updateProjectFormat(MltVideoProfile profile, Timecode t);

diff --git a/src/onmonitoritems/onmonitorcornersitem.cpp b/src/onmonitoritems/onmonitorcornersitem.cpp
index db1abb36887e488a246ebaaa99f8f4ab258cf315..9ff9fb7f98b96e33b48ba94da1bb0dcfe3a5b563 100644 (file)
--- a/src/onmonitoritems/onmonitorcornersitem.cpp
+++ b/src/onmonitoritems/onmonitorcornersitem.cpp
@@ -44,7 +44,7 @@ OnMonitorCornersItem::OnMonitorCornersItem(QGraphicsItem* parent) :
     setAcceptHoverEvents(true);
 }
 
-OnMonitorCornersItem::cornersActions OnMonitorCornersItem::getMode(QPointF pos, int *corner)
+OnMonitorCornersItem::cornersActions OnMonitorCornersItem::getMode(const QPointF &pos, int *corner)
 {
     *corner = -1;
     if (polygon().count() != 4)

diff --git a/src/onmonitoritems/onmonitorcornersitem.h b/src/onmonitoritems/onmonitorcornersitem.h
index 1e09069b38d29d764eea8abaef6f901715ae7ae0..be1ae58103b6d479967b2e01802f9e5a3fc820f1 100644 (file)
--- a/src/onmonitoritems/onmonitorcornersitem.h
+++ b/src/onmonitoritems/onmonitorcornersitem.h
@@ -35,7 +35,7 @@ public:
 
     enum cornersActions { Corner, Move, MoveSide, NoAction };
     /** @brief Gets The action mode for the area @param pos +- 4. */
-    cornersActions getMode(QPointF pos, int *corner);
+    cornersActions getMode(const QPointF &pos, int *corner);
 
     /** @brief Reimplemented to draw the handles. */
     virtual void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0 );

diff --git a/src/onmonitoritems/onmonitorrectitem.cpp b/src/onmonitoritems/onmonitorrectitem.cpp
index de1e661e76ee00607df494290360ba6320c9e4e5..d65ca995000e3ec2a3e4583685cc57ad6ad7f36c 100644 (file)
--- a/src/onmonitoritems/onmonitorrectitem.cpp
+++ b/src/onmonitoritems/onmonitorrectitem.cpp
@@ -42,7 +42,7 @@ OnMonitorRectItem::OnMonitorRectItem(const QRectF &rect, double dar, QGraphicsIt
     setAcceptHoverEvents(true);
 }
 
-rectActions OnMonitorRectItem::getMode(QPointF pos)
+rectActions OnMonitorRectItem::getMode(const QPointF &pos)
 {
     // Item mapped coordinates
     QPolygonF pol(rect().normalized());

diff --git a/src/onmonitoritems/onmonitorrectitem.h b/src/onmonitoritems/onmonitorrectitem.h
index 15e93941fc22c98eaa82f2186fc5c4ed7ec04f93..576c5a7c1c35abce59d3403b21bb487db946aece 100644 (file)
--- a/src/onmonitoritems/onmonitorrectitem.h
+++ b/src/onmonitoritems/onmonitorrectitem.h
@@ -38,7 +38,7 @@ public:
 
     /** @brief Gets The action mode for the area @param pos +- 4.
      * e.g. pos(0,0) returns ResizeTopLeft */
-    rectActions getMode(QPointF pos);
+    rectActions getMode(const QPointF &pos);
 
     /** @brief Reimplemented to draw the handles. */
     virtual void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0 );

diff --git a/src/projecttree/meltjob.cpp b/src/projecttree/meltjob.cpp
index 6ddaa28f0c0e70c457be80a5c156860178882267..5abe61769e70f82add50c890bc045cc345170633 100644 (file)
--- a/src/projecttree/meltjob.cpp
+++ b/src/projecttree/meltjob.cpp
@@ -35,7 +35,8 @@ static void consumer_frame_render(mlt_consumer, MeltJob * self, mlt_frame frame_
     self->emitFrameNumber((int) frame.get_position());
 }
 
-MeltJob::MeltJob(CLIPTYPE cType, const QString &id, const QStringList &parameters,  const QMap <QString, QString>&extraParams) : AbstractClipJob(MLTJOB, cType, id, parameters),
+MeltJob::MeltJob(CLIPTYPE cType, const QString &id, const QStringList &parameters,  const QMap <QString, QString>&extraParams)
+    : AbstractClipJob(MLTJOB, cType, id, parameters),
     addClipToProject(0),
     m_consumer(NULL),
     m_producer(NULL),
@@ -52,7 +53,7 @@ MeltJob::MeltJob(CLIPTYPE cType, const QString &id, const QStringList &parameter
     if (consum.contains(':')) m_dest = consum.section(':', 1);
 }
 
-void MeltJob::setProducer(Mlt::Producer *producer, KUrl url)
+void MeltJob::setProducer(Mlt::Producer *producer, const KUrl &url)
 {
     m_url = QString::fromUtf8(producer->get("resource"));
     if (m_url == "<playlist>" || m_url == "<tractor>" || m_url == "<producer>")
@@ -189,11 +190,11 @@ void MeltJob::startJob()
 
 MeltJob::~MeltJob()
 {
-    if (m_showFrameEvent) delete m_showFrameEvent;
-    if (m_filter) delete m_filter;
-    if (m_producer) delete m_producer;
-    if (m_consumer) delete m_consumer;
-    if (m_profile) delete m_profile;
+    delete m_showFrameEvent;
+    delete m_filter;
+    delete m_producer;
+    delete m_consumer;
+    delete m_profile;
 }
 
 const QString MeltJob::destination() const

diff --git a/src/projecttree/meltjob.h b/src/projecttree/meltjob.h
index 82326d81000a68219198d551d03e95a710815c58..6ff927ca3bba4f3918dc3ea2b919d68860ffb578 100644 (file)
--- a/src/projecttree/meltjob.h
+++ b/src/projecttree/meltjob.h
@@ -49,7 +49,7 @@ public:
     bool addClipToProject;
     const QString statusMessage();
     void setStatus(CLIPJOBSTATUS status);
-    void setProducer(Mlt::Producer *producer, KUrl url);
+    void setProducer(Mlt::Producer *producer, const KUrl &url);
     void emitFrameNumber(int pos);
     /** Make the job work on a project tree clip. */
     bool isProjectFilter() const;

diff --git a/src/rotoscoping/rotowidget.cpp b/src/rotoscoping/rotowidget.cpp
index 86080a29983091e1f3906f795a58a3d1fcb9afa7..127df07b68871608d73be0054ebc127d4bca7220 100644 (file)
--- a/src/rotoscoping/rotowidget.cpp
+++ b/src/rotoscoping/rotowidget.cpp
@@ -44,7 +44,7 @@ void tracking_finished(mlt_service *owner, RotoWidget *self, char *data)
         self->setSpline(QString(data));
 }
 
-RotoWidget::RotoWidget(const QString &data, Monitor *monitor, ItemInfo info, Timecode t, QWidget* parent) :
+RotoWidget::RotoWidget(const QString &data, Monitor *monitor, const ItemInfo &info, const Timecode &t, QWidget* parent) :
         QWidget(parent),
         m_monitor(monitor),
         m_showScene(true),

diff --git a/src/rotoscoping/rotowidget.h b/src/rotoscoping/rotowidget.h
index 090e98f27e170926575d9446f9eef6e9bec7fe71..99523b8b3063d1a8e51b28961987d6f55e197512 100644 (file)
--- a/src/rotoscoping/rotowidget.h
+++ b/src/rotoscoping/rotowidget.h
@@ -42,7 +42,7 @@ class RotoWidget : public QWidget
     Q_OBJECT
 
 public:
-    RotoWidget(const QString &data, Monitor *monitor, ItemInfo info, Timecode t, QWidget* parent = 0);
+    RotoWidget(const QString &data, Monitor *monitor, const ItemInfo &info, const Timecode &t, QWidget* parent = 0);
     virtual ~RotoWidget();
 
     /** @brief Returns the spline(s) in the JSON format used by filter_rotoscoping (MLT). */

diff --git a/src/scopes/scopemanager.cpp b/src/scopes/scopemanager.cpp
index a2e1dfd0103404ee824f8ba10f376d702d24f6e6..e03c4e73a58b68a79680973b98ff9c93920f8f0d 100644 (file)
--- a/src/scopes/scopemanager.cpp
+++ b/src/scopes/scopemanager.cpp
@@ -129,7 +129,7 @@ void ScopeManager::slotDistributeAudio(QVector<int16_t> sampleData, int freq, in
 
     checkActiveAudioScopes();
 }
-void ScopeManager::slotDistributeFrame(const QImage image)
+void ScopeManager::slotDistributeFrame(const QImage &image)
 {
 #ifdef DEBUG_SM
     qDebug() << "ScopeManager: Starting to distribute frame.";
@@ -158,7 +158,7 @@ void ScopeManager::slotDistributeFrame(const QImage image)
 }
 
 
-void ScopeManager::slotRequestFrame(const QString widgetName)
+void ScopeManager::slotRequestFrame(const QString &widgetName)
 {
 #ifdef DEBUG_SM
     qDebug() << "ScopeManager: New frame was requested by " << widgetName;

diff --git a/src/scopes/scopemanager.h b/src/scopes/scopemanager.h
index d4d98d434da2552363f00e7890a92c4e0246ec6e..8eace43d89d5265f9871a17f8e99eba7d359cbb7 100644 (file)
--- a/src/scopes/scopemanager.h
+++ b/src/scopes/scopemanager.h
@@ -115,12 +115,12 @@ private slots:
       */
     
     void slotCheckActiveScopes();
-    void slotDistributeFrame(const QImage image);
+    void slotDistributeFrame(const QImage &image);
     void slotDistributeAudio(QVector<int16_t> sampleData, int freq, int num_channels, int num_samples);
     /**
       Allows a scope to explicitly request a new frame, even if the scope's autoRefresh is disabled.
       */
-    void slotRequestFrame(const QString widgetName);
+    void slotRequestFrame(const QString &widgetName);
 
 
 };

diff --git a/src/simplekeyframes/simplekeyframewidget.cpp b/src/simplekeyframes/simplekeyframewidget.cpp
index 51651560e95e713ca6771fec23c8421a773dcd19..00fee2c919843d9c4e3bd50997ce708f554b6d6e 100644 (file)
--- a/src/simplekeyframes/simplekeyframewidget.cpp
+++ b/src/simplekeyframes/simplekeyframewidget.cpp
@@ -26,7 +26,7 @@
 #include <KIcon>
 #include <KLocale>
 
-SimpleKeyframeWidget::SimpleKeyframeWidget(Timecode t, int duration, QWidget *parent) :
+SimpleKeyframeWidget::SimpleKeyframeWidget(const Timecode &t, int duration, QWidget *parent) :
         QWidget(parent)
 {
     setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Preferred);

diff --git a/src/simplekeyframes/simplekeyframewidget.h b/src/simplekeyframes/simplekeyframewidget.h
index d031717fced398993c1b901e8cfc0266d0d5a56c..d9553ba64400553cf28148b3a5029a2040204b4e 100644 (file)
--- a/src/simplekeyframes/simplekeyframewidget.h
+++ b/src/simplekeyframes/simplekeyframewidget.h
@@ -34,7 +34,7 @@ class SimpleKeyframeWidget : public QWidget
     Q_OBJECT
 
 public:
-    SimpleKeyframeWidget(Timecode t, int duration, QWidget* parent = 0);
+    SimpleKeyframeWidget(const Timecode &t, int duration, QWidget* parent = 0);
     virtual ~SimpleKeyframeWidget();
 
     int getPosition();

diff --git a/src/stopmotion/stopmotion.cpp b/src/stopmotion/stopmotion.cpp
index 83060e089fb9b8d39f2d56bc59d6d61145fd084b..572664a96dfd12541591b59f4401bcd400057da9 100644 (file)
--- a/src/stopmotion/stopmotion.cpp
+++ b/src/stopmotion/stopmotion.cpp
@@ -678,7 +678,7 @@ void StopmotionWidget::slotPrepareThumbs()
 
 }
 
-void StopmotionWidget::slotCreateThumbs(QImage img, int ix)
+void StopmotionWidget::slotCreateThumbs(const QImage &img, int ix)
 {
     if (img.isNull()) {
         m_future = QtConcurrent::run(this, &StopmotionWidget::slotPrepareThumbs);

diff --git a/src/stopmotion/stopmotion.h b/src/stopmotion/stopmotion.h
index bbda1a6f4d8fbfe7885897dc78a5709c9c25842b..df5e0d2bd9ef0d9ca528a02e3520e5129ba7c23e 100644 (file)
--- a/src/stopmotion/stopmotion.h
+++ b/src/stopmotion/stopmotion.h
@@ -211,7 +211,7 @@ private slots:
     void slotGotHDMIMessage(const QString& message);
 
     /** @brief Create thumbnails for existing sequence frames. */
-    void slotCreateThumbs(QImage img, int ix);
+    void slotCreateThumbs(const QImage &img, int ix);
 
     /** @brief Prepare thumbnails creation. */
     void slotPrepareThumbs();

diff --git a/src/utils/resourcewidget.cpp b/src/utils/resourcewidget.cpp
index 9748b4e862a142ccbe001c9a62b35ce2d08c5f86..b106764ec1a3a4894d19fce86c33abb061110c40 100644 (file)
--- a/src/utils/resourcewidget.cpp
+++ b/src/utils/resourcewidget.cpp
@@ -191,7 +191,7 @@ void ResourceWidget::slotLoadThumb(const QString url)
 }
 
 
-void ResourceWidget::slotDisplayMetaInfo(QMap <QString, QString> metaInfo)
+void ResourceWidget::slotDisplayMetaInfo(const QMap<QString, QString> &metaInfo)
 {
     if (metaInfo.contains("license")) {
         parseLicense(metaInfo.value("license"));
@@ -211,7 +211,7 @@ void ResourceWidget::slotPlaySound()
 }
 
 
-void ResourceWidget::slotSaveItem(const QString originalUrl)
+void ResourceWidget::slotSaveItem(const QString &originalUrl)
 {
     //if (m_currentUrl.isEmpty()) return;
     QListWidgetItem *item = search_results->currentItem();
@@ -370,25 +370,25 @@ void ResourceWidget::slotOpenLink(const QUrl &url)
     }
 }
 
-void ResourceWidget::slotSetDescription(const QString desc)
+void ResourceWidget::slotSetDescription(const QString &desc)
 {
     m_desc = desc;
     updateLayout();
 }
 
-void ResourceWidget::slotSetMetadata(const QString desc)
+void ResourceWidget::slotSetMetadata(const QString &desc)
 {
     m_meta = desc;
     updateLayout();
 }
 
-void ResourceWidget::slotSetImage(const QString desc)
+void ResourceWidget::slotSetImage(const QString &desc)
 {
     m_image = QString("<img src=\"%1\" style=\"max-height:150px\" max-width=\"%2px\" />").arg(desc).arg((int) (info_browser->width() * 0.9));
     updateLayout();
 }
 
-void ResourceWidget::slotSetTitle(const QString desc)
+void ResourceWidget::slotSetTitle(const QString &desc)
 {
     m_title = desc;
     updateLayout();

diff --git a/src/utils/resourcewidget.h b/src/utils/resourcewidget.h
index 21f06af8f041b9287573e88fd393469a9760b6b3..1def7a907db3a5a4c557dc6759b21a45651ba89b 100644 (file)
--- a/src/utils/resourcewidget.h
+++ b/src/utils/resourcewidget.h
@@ -51,8 +51,8 @@ private slots:
     void slotStartSearch(int page = 0);
     void slotUpdateCurrentSound();
     void slotPlaySound();
-    void slotDisplayMetaInfo(QMap <QString, QString> metaInfo);
-    void slotSaveItem(const QString originalUrl = QString());
+    void slotDisplayMetaInfo(const QMap <QString, QString>& metaInfo);
+    void slotSaveItem(const QString &originalUrl = QString());
     void slotOpenUrl(const QString &url);
     void slotChangeService();
     void slotOnline();
@@ -63,10 +63,10 @@ private slots:
     void slotLoadThumb(const QString url);
     /** @brief A file download is finished */
     void slotGotFile(KJob *job);
-    void slotSetMetadata(const QString desc);
-    void slotSetDescription(const QString desc);
-    void slotSetImage(const QString desc);
-    void slotSetTitle(const QString desc);
+    void slotSetMetadata(const QString &desc);
+    void slotSetDescription(const QString &desc);
+    void slotSetImage(const QString &desc);
+    void slotSetTitle(const QString &desc);
     void slotSetMaximum(int max);
 
 private: