USe const'ref

diff --git a/src/titlewidget.cpp b/src/titlewidget.cpp
index 45f7580a0d3c8ae2fdea1e31adac25414507d72c..2a8f4969b70340b67c4fc3c117139339e73b89e3 100644 (file)
--- a/src/titlewidget.cpp
+++ b/src/titlewidget.cpp
@@ -588,7 +588,7 @@ QString TitleWidget::getTitleResourceFromName(const KUrl &projectUrl, const QStr
 }
 
 // static
-QStringList TitleWidget::extractImageList(QString xml)
+QStringList TitleWidget::extractImageList(const QString& xml)
 {
     QStringList result;
     if (xml.isEmpty()) return result;
@@ -603,7 +603,7 @@ QStringList TitleWidget::extractImageList(QString xml)
 }
 
 // static
-QStringList TitleWidget::extractFontList(QString xml)
+QStringList TitleWidget::extractFontList(const QString& xml)
 {
     QStringList result;
     if (xml.isEmpty()) return result;
@@ -1900,7 +1900,7 @@ int TitleWidget::duration() const
     return m_tc.getFrameCount(title_duration->text());
 }
 
-void TitleWidget::setXml(QDomDocument doc)
+void TitleWidget::setXml(const QDomDocument &doc)
 {
     int duration;
     m_count = m_titledocument.loadFromXml(doc, m_startViewport, m_endViewport, &duration, m_projectTitlePath);

diff --git a/src/titlewidget.h b/src/titlewidget.h
index 5da2d6ee53fd0f091f65617f95f16ffd5b9b49cf..16afcae5e84e39023bd701ad6f356cb5cc4aad87 100644 (file)
--- a/src/titlewidget.h
+++ b/src/titlewidget.h
@@ -63,10 +63,10 @@ public:
      * @param projectPath default path to save to or load from title documents
      * @param render project renderer
      * @param parent (optional) parent widget */
-    TitleWidget(const KUrl &url, Timecode tc, const QString &projectTitlePath, Render *render, QWidget *parent = 0);
+    explicit TitleWidget(const KUrl &url, Timecode tc, const QString &projectTitlePath, Render *render, QWidget *parent = 0);
     virtual ~TitleWidget();
     QDomDocument xml();
-    void setXml(QDomDocument doc);
+    void setXml(const QDomDocument& doc);
 
     /** @brief Finds the first available file name for a title document.
      * @deprecated With the titler module there's no need to save titles as images.
@@ -80,12 +80,12 @@ public:
     /** @brief Checks for the images referenced by a title clip.
      * @param xml XML data representing the title
      * @return list of the image files */
-    static QStringList extractImageList(QString xml);
+    static QStringList extractImageList(const QString &xml);
 
     /** @brief Checks for the fonts referenced by a title clip.
      * @param xml XML data representing the title
      * @return list of the fonts */
-    static QStringList extractFontList(QString xml);
+    static QStringList extractFontList(const QString &xml);
 
     /** @brief Builds a file name for a title document.
      * @deprecated With the titler module there's no need to save titles as images.

diff --git a/src/trackview.cpp b/src/trackview.cpp
index 4aceb76fd249047f20d50418b1a91c6cc8750f4b..b2303ecb6d429f756bbbbba555afd30777fcad9f 100644 (file)
--- a/src/trackview.cpp
+++ b/src/trackview.cpp
@@ -191,7 +191,7 @@ void TrackView::setDuration(int dur)
     m_ruler->setDuration(dur);
 }
 
-void TrackView::parseDocument(QDomDocument doc)
+void TrackView::parseDocument(const QDomDocument &doc)
 {
     //int cursorPos = 0;
     m_documentErrors.clear();

diff --git a/src/trackview.h b/src/trackview.h
index a629c81999d5d12f21815a15919edfe99278c3d8..b46ec00c0eef484d1af3a1cc922b2cbe58fd3e97 100644 (file)
--- a/src/trackview.h
+++ b/src/trackview.h
@@ -105,7 +105,7 @@ private:
     QString m_documentErrors;
     QList <QAction *> m_trackActions;
     
-    void parseDocument(QDomDocument doc);
+    void parseDocument(const QDomDocument &doc);
     int slotAddProjectTrack(int ix, QDomElement xml, bool locked, QDomNodeList producers);
     DocClipBase *getMissingProducer(const QString id) const;
     void adjustTrackHeaders();