Make class constructors with required args explicit [krazy 45/46] by Mikko Rapeli

diff --git a/src/abstractmonitor.h b/src/abstractmonitor.h
index 58fc10931cfdf3486f7e84a9c1112857ee47d926..5eea22735cad20db9623f2f896f17929975e5ba1 100644 (file)
--- a/src/abstractmonitor.h
+++ b/src/abstractmonitor.h
@@ -43,7 +43,7 @@ Q_OBJECT public:
      *  @param name A unique identifier for this renderer
      *  @param winid The parent widget identifier (required for SDL display). Set to 0 for OpenGL rendering
      *  @param profile The MLT profile used for the renderer (default one will be used if empty). */
-    AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), m_name(name) {};
+    explicit AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), m_name(name) {};
 
     /** @brief Destroy the MLT Renderer. */
     virtual ~AbstractRender() {};
@@ -117,7 +117,7 @@ class VideoContainer : public QFrame
 {
     Q_OBJECT
 public:
-    VideoContainer(AbstractMonitor *monitor, QWidget *parent = 0);
+    explicit VideoContainer(AbstractMonitor *monitor, QWidget *parent = 0);
     void switchFullScreen();
 
 protected:

diff --git a/src/archivewidget.h b/src/archivewidget.h
index bea13e5747c768d2b6fab96770b72d19a2c4de8f..a6f71944a1f89112f0d88acab367e4e9865b621b 100644 (file)
--- a/src/archivewidget.h
+++ b/src/archivewidget.h
@@ -55,7 +55,7 @@ class ArchiveWidget : public QDialog, public Ui::ArchiveWidget_UI
 public:
     ArchiveWidget(QString projectName, QDomDocument doc, QList <DocClipBase*> list, QStringList luma_list, QWidget * parent = 0);
     // Constructor for extracting widget
-    ArchiveWidget(const KUrl &url, QWidget * parent = 0);
+    explicit ArchiveWidget(const KUrl &url, QWidget * parent = 0);
     ~ArchiveWidget();
 
     QString extractedProjectFile();

diff --git a/src/beziercurve/beziersplinewidget.h b/src/beziercurve/beziersplinewidget.h
index a847cfd86567c4f15d9f933564e7cee2486e9f27..cddefef03e348c0c58ceade026f384956f98aaa6 100644 (file)
--- a/src/beziercurve/beziersplinewidget.h
+++ b/src/beziercurve/beziersplinewidget.h
@@ -34,7 +34,7 @@ class BezierSplineWidget : public QWidget
     
 public:
     /** @brief Sets up the UI and sets the spline to @param spline. */
-    BezierSplineWidget(const QString &spline, QWidget* parent = 0);
+    explicit BezierSplineWidget(const QString &spline, QWidget* parent = 0);
 
     /** @brief Returns the current spline. */
     QString spline();

diff --git a/src/choosecolorwidget.h b/src/choosecolorwidget.h
index 3f4179488a0f2116c6ffcec76f97d010aebf9145..24ab8cbc70004a62bbd74334529534647b9d8b0f 100644 (file)
--- a/src/choosecolorwidget.h
+++ b/src/choosecolorwidget.h
@@ -40,7 +40,7 @@ public:
     * @param text (optional) What the color will be used for
     * @param color (optional) initial color 
     * @param alphaEnabled (optional) Should transparent colors be enabled */
-    ChooseColorWidget(QString text = QString(), QString color = "0xffffffff", bool alphaEnabled = false, QWidget* parent = 0);
+    explicit ChooseColorWidget(QString text = QString(), QString color = "0xffffffff", bool alphaEnabled = false, QWidget* parent = 0);
 
     /** @brief Gets the choosen color. */
     QString getColor();

diff --git a/src/dragvalue.h b/src/dragvalue.h
index 49dc05551569ec86670e966b631455a56db59ffa..1794bc5f7beaa565e2c167c57143d65eceb0bb69 100644 (file)
--- a/src/dragvalue.h
+++ b/src/dragvalue.h
@@ -38,7 +38,7 @@ class CustomLabel : public QProgressBar
 {
     Q_OBJECT
 public:
-    CustomLabel(const QString &label, bool showSlider = true, int range = 1000, QWidget *parent = 0);
+    explicit CustomLabel(const QString &label, bool showSlider = true, int range = 1000, QWidget *parent = 0);
     void setProgressValue(double value);
     void setStep(double step);
     

diff --git a/src/dvdwizardvob.h b/src/dvdwizardvob.h
index aa024dd8d3494c6b14538b8a0473d7006f27ee7a..bc395019071794c744f2f034709be6742bb23874 100644 (file)
--- a/src/dvdwizardvob.h
+++ b/src/dvdwizardvob.h
@@ -34,7 +34,7 @@ class DvdWizardVob : public QWizardPage
     Q_OBJECT
 
 public:
-    DvdWizardVob(const QString &profile, QWidget * parent = 0);
+    explicit DvdWizardVob(const QString &profile, QWidget * parent = 0);
     virtual ~DvdWizardVob();
     virtual bool isComplete() const;
     QStringList selectedUrls() const;

diff --git a/src/effectstack/effectstackview2.h b/src/effectstack/effectstackview2.h
index 1db988249be19dc3b7a65de76bcafdd59064ebfe..eeb3aebf3ebe5f140571f2ba01ceea106dff51b4 100644 (file)
--- a/src/effectstack/effectstackview2.h
+++ b/src/effectstack/effectstackview2.h
@@ -39,7 +39,7 @@ class EffectStackView2 : public QWidget
     Q_OBJECT
 
 public:
-    EffectStackView2(Monitor *monitor, QWidget *parent = 0);
+    explicit EffectStackView2(Monitor *monitor, QWidget *parent = 0);
     virtual ~EffectStackView2();
 
     /** @brief Raises @param dock if a clip is loaded. */

diff --git a/src/effectstackedit.h b/src/effectstackedit.h
index 6e73aaf939ffb78f81880360b12cd78df88b118e..ca79ccca7b1fc0b15b15f312a019361918066a41 100644 (file)
--- a/src/effectstackedit.h
+++ b/src/effectstackedit.h
@@ -38,7 +38,7 @@ class EffectStackEdit : public QScrollArea
 {
     Q_OBJECT
 public:
-    EffectStackEdit(Monitor *monitor, QWidget *parent = 0);
+    explicit EffectStackEdit(Monitor *monitor, QWidget *parent = 0);
     ~EffectStackEdit();
     void updateProjectFormat(MltVideoProfile profile, Timecode t);
     static QMap<QString, QImage> iconCache;

diff --git a/src/encodingprofilesdialog.h b/src/encodingprofilesdialog.h
index 50b9a410c40375e5d8f86c65b82b6b86317a1450..60468f0dea1cbd3e9d439f2544ff737a4f95508e 100644 (file)
--- a/src/encodingprofilesdialog.h
+++ b/src/encodingprofilesdialog.h
@@ -30,7 +30,7 @@ class EncodingProfilesDialog : public QDialog, Ui::ManageEncodingProfile_UI
     Q_OBJECT
 
 public:
-    EncodingProfilesDialog(int profileType, QWidget * parent = 0);
+    explicit EncodingProfilesDialog(int profileType, QWidget * parent = 0);
     ~EncodingProfilesDialog();
 
 protected:

diff --git a/src/kis_curve_widget.h b/src/kis_curve_widget.h
index 421e5230d45f7ff5d9a606c43ba043e43b544636..200db10631c01cae46887da2408fce9bfb329aaf 100644 (file)
--- a/src/kis_curve_widget.h
+++ b/src/kis_curve_widget.h
@@ -56,7 +56,7 @@ public:
      * Create a new curve widget with a default curve, that is a straight
      * line from bottom-left to top-right.
      */
-    KisCurveWidget(QWidget *parent = 0, Qt::WFlags f = 0);
+    explicit KisCurveWidget(QWidget *parent = 0, Qt::WFlags f = 0);
 
     virtual ~KisCurveWidget();
 

diff --git a/src/lib/audio/audioEnvelope.h b/src/lib/audio/audioEnvelope.h
index 058acec2cf525bec17f3e8733a7a5e82c7f09836..1add9095161ffbd1973b14cbb0397c575bd29158 100644 (file)
--- a/src/lib/audio/audioEnvelope.h
+++ b/src/lib/audio/audioEnvelope.h
@@ -26,7 +26,7 @@ class QImage;
 class AudioEnvelope
 {
 public:
-    AudioEnvelope(Mlt::Producer *producer, int offset = 0, int length = 0);
+    explicit AudioEnvelope(Mlt::Producer *producer, int offset = 0, int length = 0);
     ~AudioEnvelope();
 
     /// Returns the envelope, calculates it if necessary.

diff --git a/src/monitoreditwidget.h b/src/monitoreditwidget.h
index 52bcb8c5a17b7907af634ea529ba3b518de48620..4df207ab0567dc433617b55836c82ff3da55ea5b 100644 (file)
--- a/src/monitoreditwidget.h
+++ b/src/monitoreditwidget.h
@@ -37,7 +37,7 @@ class MonitorEditWidget : public QWidget
     Q_OBJECT
 
 public:
-    MonitorEditWidget(Render *renderer, QWidget* parent = 0);
+    explicit MonitorEditWidget(Render *renderer, QWidget* parent = 0);
     virtual ~MonitorEditWidget();
 
     /** @brief Updates the necessary settings on a profile change. */

diff --git a/src/monitorscene.h b/src/monitorscene.h
index d850e5807c1a905418f4279bccfa4450996e6a8c..a6eb27e96b366e916146d848b1126bed6b6b6009 100644 (file)
--- a/src/monitorscene.h
+++ b/src/monitorscene.h
@@ -31,7 +31,7 @@ class MonitorScene : public QGraphicsScene
 {
     Q_OBJECT
 public:
-    MonitorScene(Render *renderer, QObject* parent = 0);
+    explicit MonitorScene(Render *renderer, QObject* parent = 0);
 
     /** @brief Sets m_view to this scenes view. */
     void setUp();

diff --git a/src/onmonitoritems/rotoscoping/bpointitem.h b/src/onmonitoritems/rotoscoping/bpointitem.h
index 536182bff3cd47bed35c95a0bd43058c55b66c42..4e2d0c4c5ab652a8e1167fb42ddf284232a9f0ea 100644 (file)
--- a/src/onmonitoritems/rotoscoping/bpointitem.h
+++ b/src/onmonitoritems/rotoscoping/bpointitem.h
@@ -29,7 +29,7 @@ class QGraphicsView;
 class BPointItem : public QAbstractGraphicsShapeItem
 {
 public:
-    BPointItem(BPoint point, QGraphicsItem* parent = 0);
+    explicit BPointItem(BPoint point, QGraphicsItem* parent = 0);
 
     BPoint getPoint();
     void setPoint(BPoint point);

diff --git a/src/onmonitoritems/rotoscoping/splineitem.h b/src/onmonitoritems/rotoscoping/splineitem.h
index fec4dfd1ee2f7d33c31342eb44550cd0de2b322e..d6b595c251fd10b5bd6b0a9d73c15bc4d8f088da 100644 (file)
--- a/src/onmonitoritems/rotoscoping/splineitem.h
+++ b/src/onmonitoritems/rotoscoping/splineitem.h
@@ -30,7 +30,7 @@ class SplineItem : public QObject, public QGraphicsPathItem
     Q_OBJECT
 
 public:
-    SplineItem(const QList <BPoint> &points, QGraphicsItem* parent = 0, QGraphicsScene *scene = 0);
+    explicit SplineItem(const QList <BPoint> &points, QGraphicsItem* parent = 0, QGraphicsScene *scene = 0);
 
     enum { Type = UserType + 10 };
 

diff --git a/src/profilesdialog.h b/src/profilesdialog.h
index d9f1c0d77898b3bca8ac34999ae791a84c5a6a83..18e26fe1c7906dbfc0c3e857325adb2d1f86dfb5 100644 (file)
--- a/src/profilesdialog.h
+++ b/src/profilesdialog.h
@@ -32,7 +32,7 @@ class ProfilesDialog : public QDialog
 public:
     ProfilesDialog(QWidget * parent = 0);
     /** @brief Using this constructor, the dialog only allows editing one profile. */
-    ProfilesDialog(QString profilePath, QWidget * parent = 0);
+    explicit ProfilesDialog(QString profilePath, QWidget * parent = 0);
 
     void fillList(const QString selectedProfile = QString());
     static QMap< QString, QString > getSettingsForProfile(const QString profileName);

diff --git a/src/scopes/abstractscopewidget.h b/src/scopes/abstractscopewidget.h
index 4fe726d959642f80bb16929b262e76175fe12eb2..95fbdfc7699a08ef149f1e9af38535442180fe0c 100644 (file)
--- a/src/scopes/abstractscopewidget.h
+++ b/src/scopes/abstractscopewidget.h
@@ -67,7 +67,7 @@ public:
             if mouse tracking is enabled.
       \see signalMousePositionChanged(): Emitted when mouse tracking is enabled
       */
-    AbstractScopeWidget(bool trackMouse = false, QWidget *parent = 0);
+    explicit AbstractScopeWidget(bool trackMouse = false, QWidget *parent = 0);
     virtual ~AbstractScopeWidget(); // Must be virtual because of inheritance, to avoid memory leaks
 
 

diff --git a/src/scopes/audioscopes/abstractaudioscopewidget.h b/src/scopes/audioscopes/abstractaudioscopewidget.h
index a3c352b7d50c7a401928fb3e893540ff182254f6..7ea9223dc518368687016029410bd73ed3ff77d3 100644 (file)
--- a/src/scopes/audioscopes/abstractaudioscopewidget.h
+++ b/src/scopes/audioscopes/abstractaudioscopewidget.h
@@ -31,7 +31,7 @@ class AbstractAudioScopeWidget : public AbstractScopeWidget
 {
     Q_OBJECT
 public:
-    AbstractAudioScopeWidget(bool trackMouse = false, QWidget *parent = 0);
+    explicit AbstractAudioScopeWidget(bool trackMouse = false, QWidget *parent = 0);
     virtual ~AbstractAudioScopeWidget();
 
 public slots:

diff --git a/src/scopes/colorscopes/abstractgfxscopewidget.h b/src/scopes/colorscopes/abstractgfxscopewidget.h
index 54e335ad9d3eeb40919e453878ef8b092cc47744..cd8d68e4980e8ba9fcf003765bb40ad2db9d3585 100644 (file)
--- a/src/scopes/colorscopes/abstractgfxscopewidget.h
+++ b/src/scopes/colorscopes/abstractgfxscopewidget.h
@@ -28,7 +28,7 @@ class AbstractGfxScopeWidget : public AbstractScopeWidget
     Q_OBJECT
 
 public:
-    AbstractGfxScopeWidget(bool trackMouse = false, QWidget *parent = 0);
+    explicit AbstractGfxScopeWidget(bool trackMouse = false, QWidget *parent = 0);
     virtual ~AbstractGfxScopeWidget(); // Must be virtual because of inheritance, to avoid memory leaks
 
 protected:

diff --git a/src/slideshowclip.h b/src/slideshowclip.h
index 69fc496fcbcfee1c950aa8b21a6541a62ddcffbd..b4114f997d677cdf52fc6a2636ec8ea3a88abee5 100644 (file)
--- a/src/slideshowclip.h
+++ b/src/slideshowclip.h
@@ -34,7 +34,7 @@ class SlideshowClip : public QDialog
     Q_OBJECT
 
 public:
-    SlideshowClip(Timecode tc, QWidget * parent = 0);
+    explicit SlideshowClip(Timecode tc, QWidget * parent = 0);
     virtual ~ SlideshowClip();
     /** return selected path for slideshow in MLT format */
     QString selectedPath();

diff --git a/src/smallruler.h b/src/smallruler.h
index 224ba63a5c7976f1bb2749683965efee2aefaed0..f3ccc7251493b0d2f956851b135dcead713de947 100644 (file)
--- a/src/smallruler.h
+++ b/src/smallruler.h
@@ -32,7 +32,7 @@ class SmallRuler : public QWidget
     Q_OBJECT
 
 public:
-    SmallRuler(MonitorManager *manager, QWidget *parent = 0);
+    explicit SmallRuler(MonitorManager *manager, QWidget *parent = 0);
     virtual void mousePressEvent(QMouseEvent * event);
     virtual void mouseMoveEvent(QMouseEvent * event);
     virtual void leaveEvent( QEvent * event );

diff --git a/src/stopmotion/capturehandler.h b/src/stopmotion/capturehandler.h
index b2ea249d35eb03698bc8139d49bcfb85706abac6..fe730a46bf534c24f7c25ff23431ca5cbd0b707b 100644 (file)
--- a/src/stopmotion/capturehandler.h
+++ b/src/stopmotion/capturehandler.h
@@ -28,7 +28,7 @@ class CaptureHandler : public QObject
 {
     Q_OBJECT
 public:
-    CaptureHandler(QVBoxLayout *lay, QWidget *parent = 0);
+    explicit CaptureHandler(QVBoxLayout *lay, QWidget *parent = 0);
     ~CaptureHandler();
     virtual void startPreview(int deviceId, int captureMode, bool audio = true) = 0;
     virtual void stopPreview() = 0;

diff --git a/src/timecodedisplay.h b/src/timecodedisplay.h
index 484841da3c4d957310f1b06cb5fc3143086686b7..e3ae03f7ca83eb361f425d3ed0be60d5ad6fadf0 100644 (file)
--- a/src/timecodedisplay.h
+++ b/src/timecodedisplay.h
@@ -41,7 +41,7 @@ public:
     /** @brief Constructor for the widget, sets value to 0.
     * @param t Timecode object used to setup correct input (frames or HH:MM:SS:FF)
     * @param parent parent Widget */
-    TimecodeDisplay(Timecode t, QWidget *parent = 0);
+    explicit TimecodeDisplay(Timecode t, QWidget *parent = 0);
 
     /** @brief Returns the minimum value, which can be entered.
     * default is 0 */

diff --git a/src/trackdialog.h b/src/trackdialog.h
index 317a651f4be7fa2b91685eb1fc895a6964541658..8adc9918f774819ac18da697cd71c42735f4cb1c 100644 (file)
--- a/src/trackdialog.h
+++ b/src/trackdialog.h
@@ -31,7 +31,7 @@ class TrackDialog : public QDialog, public Ui::AddTrack_UI
     Q_OBJECT
 
 public:
-    TrackDialog(KdenliveDoc *doc, QWidget * parent = 0);
+    explicit TrackDialog(KdenliveDoc *doc, QWidget * parent = 0);
 };
 
 

diff --git a/src/tracksconfigdialog.h b/src/tracksconfigdialog.h
index 3dcefa6dd0ee9a57abdea8e698cfe3f16c71c41d..53029ff24c04e2689f1afe71e9b878b1a756eecd 100644 (file)
--- a/src/tracksconfigdialog.h
+++ b/src/tracksconfigdialog.h
@@ -55,7 +55,7 @@ public:
     * @param doc the kdenlive document whose tracks to use
     * @param selected the track which should be selected by default
     * @param parent the parent widget */
-    TracksConfigDialog(KdenliveDoc * doc, int selected = -1, QWidget * parent = 0);
+    explicit TracksConfigDialog(KdenliveDoc * doc, int selected = -1, QWidget * parent = 0);
 
     /** @brief Returns the new list of tracks created from the table. */
     const QList <TrackInfo> tracksList();

diff --git a/src/transitionsettings.h b/src/transitionsettings.h
index 118d13b12baaffcae8fe6475b7ea2683e6402b0e..0fc869fa29d80c8d88842c887a6f37c9c879a768 100644 (file)
--- a/src/transitionsettings.h
+++ b/src/transitionsettings.h
@@ -33,7 +33,7 @@ class TransitionSettings : public QWidget, public Ui::TransitionSettings_UI
     Q_OBJECT
 
 public:
-    TransitionSettings(Monitor *monitor, QWidget* parent = 0);
+    explicit TransitionSettings(Monitor *monitor, QWidget* parent = 0);
     void raiseWindow(QWidget*);
     void updateProjectFormat(MltVideoProfile profile, Timecode t, const QList <TrackInfo> info);
     void updateTimecodeFormat();

diff --git a/src/utils/abstractservice.h b/src/utils/abstractservice.h
index cf514734127c1f7f4b0347b0559d0f7c4455eaed..250f3e587962d85646d2e70a3428ec3e394cd26c 100644 (file)
--- a/src/utils/abstractservice.h
+++ b/src/utils/abstractservice.h
@@ -58,7 +58,7 @@ class AbstractService : public QObject
     Q_OBJECT
 
 public:
-    AbstractService(QListWidget *listWidget, QObject * parent = 0);
+    explicit AbstractService(QListWidget *listWidget, QObject * parent = 0);
     ~AbstractService();
     /** @brief Get file extension for currently selected item. */
     virtual QString getExtension(QListWidgetItem *item);

diff --git a/src/utils/archiveorg.h b/src/utils/archiveorg.h
index 51c558f066a9186ba87b6c8c7389ab6c0b5b41da..e601c814f2745ce6a68f126dac3d7cfd154a05d8 100644 (file)
--- a/src/utils/archiveorg.h
+++ b/src/utils/archiveorg.h
@@ -34,7 +34,7 @@ class ArchiveOrg : public AbstractService
     Q_OBJECT
 
 public:
-    ArchiveOrg(QListWidget *listWidget, QObject * parent = 0);
+    explicit ArchiveOrg(QListWidget *listWidget, QObject * parent = 0);
     ~ArchiveOrg();
     virtual QString getExtension(QListWidgetItem *item);
     virtual QString getDefaultDownloadName(QListWidgetItem *item);

diff --git a/src/utils/freesound.h b/src/utils/freesound.h
index 88251a0ec3ba28f2168f36d8875dd23ef0b03e8c..04d3321920ccc89a644b31843b31537204a723ca 100644 (file)
--- a/src/utils/freesound.h
+++ b/src/utils/freesound.h
@@ -34,7 +34,7 @@ class FreeSound : public AbstractService
     Q_OBJECT
 
 public:
-    FreeSound(QListWidget *listWidget, QObject * parent = 0);
+    explicit FreeSound(QListWidget *listWidget, QObject * parent = 0);
     ~FreeSound();
     virtual QString getExtension(QListWidgetItem *item);
     virtual QString getDefaultDownloadName(QListWidgetItem *item);

diff --git a/src/utils/openclipart.h b/src/utils/openclipart.h
index 66f2556fc53aedd75ea1f15028fc8088575bdd62..1ba638c66d160bfdcf470b945f26022ea803f045 100644 (file)
--- a/src/utils/openclipart.h
+++ b/src/utils/openclipart.h
@@ -34,7 +34,7 @@ class OpenClipArt : public AbstractService
     Q_OBJECT
 
 public:
-    OpenClipArt(QListWidget *listWidget, QObject * parent = 0);
+    explicit OpenClipArt(QListWidget *listWidget, QObject * parent = 0);
     ~OpenClipArt();
     virtual QString getExtension(QListWidgetItem *item);
     virtual QString getDefaultDownloadName(QListWidgetItem *item);

diff --git a/src/utils/resourcewidget.h b/src/utils/resourcewidget.h
index ed2542768c07baeee3c12b9179873278bfb0ad9d..614538da21f1d86385cec3f8fb8b92e805b40fd4 100644 (file)
--- a/src/utils/resourcewidget.h
+++ b/src/utils/resourcewidget.h
@@ -42,7 +42,7 @@ class ResourceWidget : public QDialog, public Ui::FreeSound_UI
     Q_OBJECT
 
 public:
-    ResourceWidget(const QString & folder, QWidget * parent = 0);
+    explicit ResourceWidget(const QString & folder, QWidget * parent = 0);
     ~ResourceWidget();
 
 

diff --git a/src/wizard.h b/src/wizard.h
index ec430ec47f6f942fce1ec98b9d368eb95dfdb9f5..134009cba2bfc7e20d576062ad6586f9c49ece27 100644 (file)
--- a/src/wizard.h
+++ b/src/wizard.h
@@ -76,7 +76,7 @@ class Wizard : public QWizard
 {
     Q_OBJECT
 public:
-    Wizard(bool upgrade, QWidget * parent = 0);
+    explicit Wizard(bool upgrade, QWidget * parent = 0);
     void installExtraMimes(QString baseName, QStringList globs);
     void runUpdateMimeDatabase();
     void adjustSettings();