Still const'ref. Minor optimization

diff --git a/src/abstractclipitem.cpp b/src/abstractclipitem.cpp
index f56d05b07a1d23485deb33ee7482ae98d9b54ca5..966604cf34a1224a3b8135f4813f443858ed4b33 100644 (file)
--- a/src/abstractclipitem.cpp
+++ b/src/abstractclipitem.cpp
@@ -279,7 +279,7 @@ void AbstractClipItem::drawKeyFrames(QPainter *painter, const QTransform &transf
         x2 = br.right();
         if (limitedKeyFrames) {
             QMap<int, int>::const_iterator end = m_keyframes.constEnd();
-            end--;
+            --end;
             x2 = x1 + maxw * (end.key() - start);
             x1 += maxw * (m_keyframes.constBegin().key() - start);
         }

diff --git a/src/abstractgroupitem.cpp b/src/abstractgroupitem.cpp
index d3c873ad61f28b9d1a57e2fa66ca558fb915c889..e52a8a336f3736ca40600cbf422c77129c86aa45 100644 (file)
--- a/src/abstractgroupitem.cpp
+++ b/src/abstractgroupitem.cpp
@@ -107,7 +107,7 @@ QPainterPath AbstractGroupItem::transitionGroupShape(QPointF offset) const
     return groupShape(TRANSITIONWIDGET, offset);
 }
 
-QPainterPath AbstractGroupItem::groupShape(GRAPHICSRECTITEM type, QPointF offset) const
+QPainterPath AbstractGroupItem::groupShape(GRAPHICSRECTITEM type, const QPointF &offset) const
 {
     QPainterPath path;
     QList<QGraphicsItem *> children = childItems();
@@ -130,7 +130,7 @@ QPainterPath AbstractGroupItem::groupShape(GRAPHICSRECTITEM type, QPointF offset
     return path;
 }
 
-QPainterPath AbstractGroupItem::spacerGroupShape(GRAPHICSRECTITEM type, QPointF offset) const
+QPainterPath AbstractGroupItem::spacerGroupShape(GRAPHICSRECTITEM type, const QPointF &offset) const
 {
     QPainterPath path;
     QList<QGraphicsItem *> children = childItems();
@@ -212,7 +212,7 @@ QVariant AbstractGroupItem::itemChange(GraphicsItemChange change, const QVariant
         int xpos = projectScene()->getSnapPointForPos((int)(start.x() + newPos.x() - pos().x()), KdenliveSettings::snaptopoints());
 
         xpos = qMax(xpos, 0);
-        //kDebug()<<"GRP XPOS:"<<xpos<<", START:"<<start.x()<<",NEW:"<<newPos.x()<<"; SCENE:"<<scenePos().x()<<",POS:"<<pos().x();
+        //kDebug()<<"GRP XPOS:"<<xpos<<", START:"<<start.x()<<",NEW:"<<newPos.x()<<"; SCENE:"<<scenePos().x()<<",POS:"<<pos().x();
         newPos.setX((int)(pos().x() + xpos - (int) start.x()));
        QStringList lockedTracks = property("locked_tracks").toStringList();
         int proposedTrack = (property("y_absolute").toInt() + newPos.y()) / trackHeight;

diff --git a/src/abstractgroupitem.h b/src/abstractgroupitem.h
index 0f16f32e193f12ce6bbee1b1563581353b580930..e0103aa075f501df25c8e4a6e7429c2f432fc677 100644 (file)
--- a/src/abstractgroupitem.h
+++ b/src/abstractgroupitem.h
@@ -71,8 +71,8 @@ protected:
 
 private:
     void fixItemRect();
-    QPainterPath groupShape(GRAPHICSRECTITEM type, QPointF offset) const;
-    QPainterPath spacerGroupShape(GRAPHICSRECTITEM type, QPointF offset) const;
+    QPainterPath groupShape(GRAPHICSRECTITEM type, const QPointF &offset) const;
+    QPainterPath spacerGroupShape(GRAPHICSRECTITEM type, const QPointF &offset) const;
     /** Stores the original info of the items beeing resized. */
     QList <ItemInfo> m_resizeInfos;
 };

diff --git a/src/clipitem.cpp b/src/clipitem.cpp
index fb62f05397dc7861ab85c66147f58fde85108ef0..269e7a7642464eb5385f834c1595c9c95b07d362 100644 (file)
--- a/src/clipitem.cpp
+++ b/src/clipitem.cpp
@@ -648,7 +648,7 @@ void ClipItem::slotGetEndThumb()
 }
 
 
-void ClipItem::slotSetStartThumb(QImage img)
+void ClipItem::slotSetStartThumb(const QImage &img)
 {
     if (!img.isNull() && img.format() == QImage::Format_ARGB32) {
         QPixmap pix = QPixmap::fromImage(img);
@@ -659,7 +659,7 @@ void ClipItem::slotSetStartThumb(QImage img)
     }
 }
 
-void ClipItem::slotSetEndThumb(QImage img)
+void ClipItem::slotSetEndThumb(const QImage &img)
 {
     if (!img.isNull() && img.format() == QImage::Format_ARGB32) {
         QPixmap pix = QPixmap::fromImage(img);
@@ -690,12 +690,12 @@ void ClipItem::slotThumbReady(int frame, QImage img)
     }
 }
 
-void ClipItem::slotSetStartThumb(const QPixmap pix)
+void ClipItem::slotSetStartThumb(const QPixmap &pix)
 {
     m_startPix = pix;
 }
 
-void ClipItem::slotSetEndThumb(const QPixmap pix)
+void ClipItem::slotSetEndThumb(const QPixmap &pix)
 {
     m_endPix = pix;
 }

diff --git a/src/clipitem.h b/src/clipitem.h
index da52dbde672b7da8b9db799735f9106d959856f8..d71ebb5ecceb7ad84467c6ec8ac17e03efb45140 100644 (file)
--- a/src/clipitem.h
+++ b/src/clipitem.h
@@ -251,16 +251,16 @@ private slots:
     void slotGotAudioData();
     void slotPrepareAudioThumb(double pixelForOneFrame, int startpixel, int endpixel, int channels, int pixelHeight);
     void animate(qreal value);
-    void slotSetStartThumb(QImage img);
-    void slotSetEndThumb(QImage img);
+    void slotSetStartThumb(const QImage &img);
+    void slotSetEndThumb(const QImage &img);
     void slotThumbReady(int frame, QImage img);
     /** @brief The thumbnailer has finished to cache all required thumbs. */
     void slotGotThumbsCache();
 
 public slots:
     void slotFetchThumbs();
-    void slotSetStartThumb(const QPixmap pix);
-    void slotSetEndThumb(const QPixmap pix);
+    void slotSetStartThumb(const QPixmap &pix);
+    void slotSetEndThumb(const QPixmap &pix);
     void slotUpdateRange();
 
 signals:

diff --git a/src/clipmanager.cpp b/src/clipmanager.cpp
index 52aa612a266f062c1f66ea48f911d1f6e4e13e3a..80396991dc9d0065069d8d59d7e98d68950acf33 100644 (file)
--- a/src/clipmanager.cpp
+++ b/src/clipmanager.cpp
@@ -527,7 +527,7 @@ void ClipManager::slotAddClip(KIO::Job *job, const KUrl &, const KUrl &dst)
     slotAddClipList(KUrl::List () << dst, data);
 }
 
-void ClipManager::slotAddClipList(const KUrl::List urls, QMap <QString, QString> data)
+void ClipManager::slotAddClipList(const KUrl::List &urls, QMap <QString, QString> data)
 {
     QUndoCommand *addClips = new QUndoCommand();
     // Update list of removable volumes
@@ -641,7 +641,7 @@ void ClipManager::slotAddClipList(const KUrl::List urls, QMap <QString, QString>
     }
 }
 
-void ClipManager::slotAddClipFile(const KUrl &url, QMap <QString, QString> data)
+void ClipManager::slotAddClipFile(const KUrl &url, const QMap <QString, QString> &data)
 {
     slotAddClipList(KUrl::List(url), data);
 }

diff --git a/src/clipmanager.h b/src/clipmanager.h
index 2a06970b4100fa1ec2826876a98d6db2c86310df..b980f11ca1cacad0553789f764e5bc8a47d87eb2 100644 (file)
--- a/src/clipmanager.h
+++ b/src/clipmanager.h
@@ -88,14 +88,14 @@ Q_OBJECT public:
      * @param url file to add
      * @param group name of the group to insert the file in (can be empty)
      * @param groupId id of the group (if any) */
-    void slotAddClipFile(const KUrl &url, QMap <QString, QString> data);
+    void slotAddClipFile(const KUrl &url, const QMap<QString, QString> &data);
 
     /** @brief Adds a list of files to the project.
      * @param urls files to add
      * @param group name of the group to insert the files in (can be empty)
      * @param groupId id of the group (if any)
      * It checks for duplicated items and asks to the user for instructions. */
-    void slotAddClipList(const KUrl::List urls, QMap <QString, QString> data);
+    void slotAddClipList(const KUrl::List &urls, QMap <QString, QString> data);
     void slotAddTextClipFile(const QString &titleName, int out, const QString &xml, const QString &group, const QString &groupId);
     void slotAddTextTemplateClip(QString titleName, const KUrl &path, const QString &group, const QString &groupId);
     void slotAddXmlClipFile(const QString &name, const QDomElement &xml, const QString &group, const QString &groupId);

diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp
index 649eb65ab230faffb8ae617c5912f543884d0065..b0ff7ba2b11bcac1f04545bd562ab6b05087b179 100644 (file)
--- a/src/customtrackview.cpp
+++ b/src/customtrackview.cpp
@@ -5669,7 +5669,7 @@ void CustomTrackView::slotLoadClipMarkers(const QString &id)
     else delete command;
 }
 
-void CustomTrackView::addMarker(const QString &id, const CommentedTime marker)
+void CustomTrackView::addMarker(const QString &id, const CommentedTime &marker)
 {
     DocClipBase *base = m_document->clipManager()->getClipById(id);
     if (base == NULL) return;

diff --git a/src/customtrackview.h b/src/customtrackview.h
index ecdf17b6398726b5cffb6b7e0be432a0c0587477..0242a2119bf21f8f5e72d3badfddf155360581f2 100644 (file)
--- a/src/customtrackview.h
+++ b/src/customtrackview.h
@@ -76,7 +76,7 @@ public:
     void deleteClip(ItemInfo info, bool refresh = true);
     void slotDeleteClipMarker(const QString &comment, const QString &id, const GenTime &position);
     void slotDeleteAllClipMarkers(const QString &id);
-    void addMarker(const QString &id, const CommentedTime marker);
+    void addMarker(const QString &id, const CommentedTime &marker);
     void addData(const QString &id, const QString &key, const QString &data);
     void setScale(double scaleFactor, double verticalScale);
     void deleteClip(const QString &clipId);

diff --git a/src/databackup/backupwidget.h b/src/databackup/backupwidget.h
index bb6b87e13369b0d1cb2868f341ada1a6bf4f3b0e..1c71bbaeac7ac2097dc5f464d936bb0c9d33130f 100644 (file)
--- a/src/databackup/backupwidget.h
+++ b/src/databackup/backupwidget.h
@@ -51,8 +51,6 @@ private slots:
 
 private:
     QString m_projectWildcard;
-    
-signals:
 };
 
 

diff --git a/src/geometrywidget.cpp b/src/geometrywidget.cpp
index e49327dcc3ab2624f5b6501d65d6cfd0f0f48dcc..661b388d972e3b9d52336153ddd45ba6d0d93a66 100644 (file)
--- a/src/geometrywidget.cpp
+++ b/src/geometrywidget.cpp
@@ -328,7 +328,7 @@ QString GeometryWidget::getExtraValue(const QString &name) const
     return val;
 }
 
-void GeometryWidget::setupParam(const QDomElement elem, int minframe, int maxframe)
+void GeometryWidget::setupParam(const QDomElement &elem, int minframe, int maxframe)
 {
     m_inPoint = minframe;
     m_outPoint = maxframe;

diff --git a/src/geometrywidget.h b/src/geometrywidget.h
index fc5e245abe73b38d322b00b2ed4650d4359da96f..dceadd6d4320a1fd8cc6f1c70e0c9e018b0cbee7 100644 (file)
--- a/src/geometrywidget.h
+++ b/src/geometrywidget.h
@@ -66,7 +66,7 @@ public slots:
     * @param elem DomElement representing this effect parameter
     * @param minframe In point of the clip
     * @param maxframe Out point of the clip */
-    void setupParam(const QDomElement elem, int minframe, int maxframe);
+    void setupParam(const QDomElement &elem, int minframe, int maxframe);
     /** @brief Updates position of the local timeline to @param relTimelinePos.  */
     void slotSyncPosition(int relTimelinePos);
     void slotResetKeyframes();

diff --git a/src/onmonitoritems/rotoscoping/splineitem.cpp b/src/onmonitoritems/rotoscoping/splineitem.cpp
index fa3c54f9937b7ba6731e47edbe91037841484a66..563cd3760914ca1b37a8b21e6bf0b1930695473b 100644 (file)
--- a/src/onmonitoritems/rotoscoping/splineitem.cpp
+++ b/src/onmonitoritems/rotoscoping/splineitem.cpp
@@ -252,7 +252,7 @@ void SplineItem::hoverMoveEvent(QGraphicsSceneHoverEvent* event)
         unsetCursor();
 }
 
-int SplineItem::getClosestPointOnCurve(QPointF point, double *tFinal)
+int SplineItem::getClosestPointOnCurve(const QPointF &point, double *tFinal)
 {
     // TODO: proper minDiff
     qreal diff = 10000, param = 0;

diff --git a/src/onmonitoritems/rotoscoping/splineitem.h b/src/onmonitoritems/rotoscoping/splineitem.h
index d6b595c251fd10b5bd6b0a9d73c15bc4d8f088da..376c622344c854e5ecf064dd49ca084fba32383b 100644 (file)
--- a/src/onmonitoritems/rotoscoping/splineitem.h
+++ b/src/onmonitoritems/rotoscoping/splineitem.h
@@ -51,7 +51,7 @@ protected:
     virtual void hoverMoveEvent(QGraphicsSceneHoverEvent *event);
 
 private:
-    int getClosestPointOnCurve(QPointF point, double *tFinal);
+    int getClosestPointOnCurve(const QPointF &point, double *tFinal);
 
     bool m_closed;
     bool m_editing;

diff --git a/src/simplekeyframes/simplekeyframewidget.cpp b/src/simplekeyframes/simplekeyframewidget.cpp
index 00fee2c919843d9c4e3bd50997ce708f554b6d6e..af8e477e6cd3a33509090a7d6d7553eb04792bc0 100644 (file)
--- a/src/simplekeyframes/simplekeyframewidget.cpp
+++ b/src/simplekeyframes/simplekeyframewidget.cpp
@@ -98,7 +98,7 @@ void SimpleKeyframeWidget::slotSetPosition(int pos, bool update)
         emit positionChanged(pos);
 }
 
-int SimpleKeyframeWidget::getPosition()
+int SimpleKeyframeWidget::getPosition() const
 {
     return m_time->getValue();
 }

diff --git a/src/simplekeyframes/simplekeyframewidget.h b/src/simplekeyframes/simplekeyframewidget.h
index 5564e0aca81acde8c6eb84f280d1177054834281..edf6b3aa71edde17f1b9ebb4e082caefe518d012 100644 (file)
--- a/src/simplekeyframes/simplekeyframewidget.h
+++ b/src/simplekeyframes/simplekeyframewidget.h
@@ -37,7 +37,7 @@ public:
     explicit SimpleKeyframeWidget(const Timecode &t, int duration, QWidget* parent = 0);
     ~SimpleKeyframeWidget();
 
-    int getPosition();
+    int getPosition() const;
     void setKeyframes(const QList <int> &keyframes);
     void addKeyframe(int pos = -1);
 
@@ -60,7 +60,6 @@ private:
     QToolButton *m_buttonAddDelete;
     QToolButton *m_buttonPrevious;
     QToolButton *m_buttonNext;
-    //QToolButton *m_buttonSync;
     TimecodeDisplay *m_time;
 };