const ref

diff --git a/src/projectitem.cpp b/src/projectitem.cpp
index aeb4a870844154b04ff3439393eaa87725eee146..46ec6989dbd8d14a635ea8a25321e734024458d1 100644 (file)
--- a/src/projectitem.cpp
+++ b/src/projectitem.cpp
@@ -35,7 +35,7 @@ const int JobTypeRole = Qt::UserRole + 6;
 const int JobStatusMessage = Qt::UserRole + 7;
 const int itemHeight = 38;
 
-ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSize) :
+ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, const QSize &pixmapSize) :
         QTreeWidgetItem(parent, PROJECTCLIPTYPE),
         m_clip(clip),
         m_clipId(clip->getId()),
@@ -44,7 +44,7 @@ ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSi
     buildItem(pixmapSize);
 }
 
-ProjectItem::ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, QSize pixmapSize) :
+ProjectItem::ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, const QSize &pixmapSize) :
         QTreeWidgetItem(parent, PROJECTCLIPTYPE),
         m_clip(clip),
         m_clipId(clip->getId()),
@@ -101,7 +101,7 @@ bool ProjectItem::hasPixmap() const
     return m_pixmapSet;
 }
 
-void ProjectItem::setPixmap(const QPixmap p)
+void ProjectItem::setPixmap(const QPixmap& p)
 {
     m_pixmapSet = true;
     setData(0, Qt::DecorationRole, p);
@@ -295,7 +295,7 @@ bool ProjectItem::isProxyRunning() const
     return false;
 }
 
-bool ProjectItem::playlistHasProxies(const QString path)
+bool ProjectItem::playlistHasProxies(const QString& path)
 {
     kDebug()<<"// CHECKING FOR PROXIES";
     QFile file(path);

diff --git a/src/projectitem.h b/src/projectitem.h
index 6d07b1b83492929784e7e51e850804adaecaf32c..c33de17a994ca5dd39ad47b6a5856ed61d9cc4b2 100644 (file)
--- a/src/projectitem.h
+++ b/src/projectitem.h
@@ -41,8 +41,8 @@ class DocClipBase;
 class ProjectItem : public QTreeWidgetItem
 {
 public:
-    ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSize);
-    ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, QSize pixmapSize);
+    ProjectItem(QTreeWidget * parent, DocClipBase *clip, const QSize &pixmapSize);
+    ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, const QSize &pixmapSize);
     virtual ~ProjectItem();
     QDomElement toXml() const;
     int numReferences() const;
@@ -79,7 +79,7 @@ public:
     /** \brief Returns true if the thumbnail for this clip has been loaded. */
     bool hasPixmap() const;
     /** \brief Sets the thumbnail for this clip. */
-    void setPixmap(const QPixmap p);
+    void setPixmap(const QPixmap& p);
 
     virtual bool operator<(const QTreeWidgetItem &other)const {
         int column = treeWidget()->sortColumn();
@@ -96,7 +96,7 @@ private:
     /** @brief Setup basic properties */
     void buildItem(QSize pixmapSize);
     /** @brief Check if an xml project file has proxies */
-    bool playlistHasProxies(const QString path);
+    bool playlistHasProxies(const QString& path);
 };
 
 #endif

diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index 4744ff1ea373df2f850a1e3a7a0297978c8e27ef..9c74ef09852424a7bb58f98c20c3c73534e04d57 100644 (file)
--- a/src/projectlist.cpp
+++ b/src/projectlist.cpp
@@ -1496,7 +1496,7 @@ void ProjectList::getCachedThumbnail(ProjectItem *item)
     }
 }
 
-QPixmap ProjectList::roundedPixmap(QImage img)
+QPixmap ProjectList::roundedPixmap(const QImage &img)
 {
     QPixmap pix(img.width(), img.height());
     pix.fill(Qt::transparent);
@@ -1510,7 +1510,7 @@ QPixmap ProjectList::roundedPixmap(QImage img)
     return pix;
 }
 
-QPixmap ProjectList::roundedPixmap(QPixmap source)
+QPixmap ProjectList::roundedPixmap(const QPixmap &source)
 {
     QPixmap pix(source.width(), source.height());
     pix.fill(Qt::transparent);

diff --git a/src/projectlist.h b/src/projectlist.h
index 25a222d9949a56707e4fcac5245cb6f9936ef8d7..04a55f6c2c7767dbe460fc3f6d4d46b9c889ed6d 100644 (file)
--- a/src/projectlist.h
+++ b/src/projectlist.h
@@ -87,7 +87,7 @@ signals:
 namespace Mlt
 {
 class Producer;
-};
+}
 
 class ProjectItem;
 class ProjectListView;
@@ -426,8 +426,8 @@ private:
     /** @brief Start an MLT process job. */
     void processClipJob(QStringList ids, const QString&destination, bool autoAdd, QStringList jobParams, const QString &description, stringMap extraParams = stringMap());
     /** @brief Create rounded shape pixmap for project tree thumb. */
-    QPixmap roundedPixmap(QImage img);
-    QPixmap roundedPixmap(QPixmap source);
+    QPixmap roundedPixmap(const QImage &img);
+    QPixmap roundedPixmap(const QPixmap &source);
     /** @brief Extract a clip's metadata with the exiftool program. */
     void extractMetadata(DocClipBase *clip);
     /** @brief Add a special FFmpeg tag if clip matches some properties (for example set full_luma for Sony NEX camcorders. */

diff --git a/src/projectsettings.cpp b/src/projectsettings.cpp
index 6e32cb02b8de7fe1060cfed2b732cf339eb08a57..e963b288e131a4dd454513a7dd4743d6ef2fa7ae 100644 (file)
--- a/src/projectsettings.cpp
+++ b/src/projectsettings.cpp
@@ -35,7 +35,7 @@
 #include <QDir>
 #include <kmessagebox.h>
 
-ProjectSettings::ProjectSettings(ProjectList *projectlist, QMap <QString, QString> metadata, QStringList lumas, int videotracks, int audiotracks, const QString projectPath, bool readOnlyTracks, bool savedProject, QWidget * parent) :
+ProjectSettings::ProjectSettings(ProjectList *projectlist, QMap <QString, QString> metadata, QStringList lumas, int videotracks, int audiotracks, const QString &projectPath, bool readOnlyTracks, bool savedProject, QWidget * parent) :
     QDialog(parent), m_savedProject(savedProject), m_projectList(projectlist), m_lumas(lumas)
 {
     setupUi(this);

diff --git a/src/projectsettings.h b/src/projectsettings.h
index eb8de24da25c2038e98013b831490f8a73f1d4f9..7ff27296b4e67b9b843abbaeec3695e3f88873f7 100644 (file)
--- a/src/projectsettings.h
+++ b/src/projectsettings.h
@@ -32,7 +32,7 @@ class ProjectSettings : public QDialog, public Ui::ProjectSettings_UI
     Q_OBJECT
 
 public:
-    ProjectSettings(ProjectList *projectlist, QMap <QString, QString> metadata, QStringList lumas, int videotracks, int audiotracks, const QString projectPath, bool readOnlyTracks, bool unsavedProject, QWidget * parent = 0);
+    ProjectSettings(ProjectList *projectlist, QMap <QString, QString> metadata, QStringList lumas, int videotracks, int audiotracks, const QString& projectPath, bool readOnlyTracks, bool unsavedProject, QWidget * parent = 0);
     QString selectedProfile() const;
     KUrl selectedFolder() const;
     QPoint tracks();

diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp
index d2104d619807ebd76c27319947f17b542c5fc8d3..fbc9c11bec40b5ffa5e7cf885fba15896cd1fa07 100644 (file)
--- a/src/renderwidget.cpp
+++ b/src/renderwidget.cpp
@@ -1391,7 +1391,7 @@ void RenderWidget::refreshView(const QString &profile)
     }
 }
 
-KUrl RenderWidget::filenameWithExtension(KUrl url, QString extension)
+KUrl RenderWidget::filenameWithExtension(KUrl url, const QString &extension)
 {
     if (url.isEmpty()) url = KUrl(m_projectFolder);
     QString directory = url.directory(KUrl::AppendTrailingSlash | KUrl::ObeyTrailingSlash);

diff --git a/src/renderwidget.h b/src/renderwidget.h
index f742a1da78962158d1632836ace80d512025ae68..2c0002eb3604d0f7b95093d6b7edca574d77cc17 100644 (file)
--- a/src/renderwidget.h
+++ b/src/renderwidget.h
@@ -198,7 +198,7 @@ private:
     void parseProfiles(const QString &meta = QString(), const QString &group = QString(), const QString &profile = QString());
     void parseFile(const QString &exportFile, bool editable);
     void updateButtons();
-    KUrl filenameWithExtension(KUrl url, QString extension);
+    KUrl filenameWithExtension(KUrl url, const QString &extension);
     /** @brief Check if a job needs to be started. */
     void checkRenderStatus();
     void startRendering(RenderJobItem *item);

diff --git a/src/smallruler.cpp b/src/smallruler.cpp
index df28a8d90fec03fba3e19655535891207bfefb09..cc5d268066d3d46dc1ddd184af9ee8e31a2e150e 100644 (file)
--- a/src/smallruler.cpp
+++ b/src/smallruler.cpp
@@ -108,7 +108,7 @@ void SmallRuler::setZone(int start, int end)
     updatePixmap();
 }
 
-void SmallRuler::setMarkers(QList < CommentedTime > list)
+void SmallRuler::setMarkers(const QList<CommentedTime> &list)
 {
     m_markers = list;
     updatePixmap();

diff --git a/src/smallruler.h b/src/smallruler.h
index 0453a8c5ac23db08b1c508585cd3151be4bd6038..53ffbcf638b0145d53fa22cf5fbf2b91733b947a 100644 (file)
--- a/src/smallruler.h
+++ b/src/smallruler.h
@@ -41,7 +41,7 @@ public:
     void setZoneStart();
     void setZoneEnd();
     QPoint zone();
-    void setMarkers(QList < CommentedTime > list);
+    void setMarkers(const QList < CommentedTime >& list);
     void updatePalette();
     void refreshRuler();
 

diff --git a/src/subprojectitem.cpp b/src/subprojectitem.cpp
index eba677b17c9ee9d974d101806fd6b219fba0a4f6..0e76b352149c79a7500d9590f575d7e6558a79ed 100644 (file)
--- a/src/subprojectitem.cpp
+++ b/src/subprojectitem.cpp
@@ -77,7 +77,7 @@ QPoint SubProjectItem::zone() const
     return z;
 }
 
-void SubProjectItem::setZone(QPoint p)
+void SubProjectItem::setZone(const QPoint& p)
 {
     m_in = p.x();
     m_out = p.y();

diff --git a/src/subprojectitem.h b/src/subprojectitem.h
index d3efd85ad19c5a1c532535b59ee2a16db1333185..5b1d79128d177d1fa414067d9d778b3b262475a9 100644 (file)
--- a/src/subprojectitem.h
+++ b/src/subprojectitem.h
@@ -44,7 +44,7 @@ public:
     int numReferences() const;
     DocClipBase *referencedClip();
     QPoint zone() const;
-    void setZone(QPoint p);
+    void setZone(const QPoint &p);
     QString description() const;
     void setDescription(QString desc);
     static int itemDefaultHeight();

diff --git a/src/trackview.cpp b/src/trackview.cpp
index e88bfb794c2b810d59a2cea7e8c47763b8a31a16..4aceb76fd249047f20d50418b1a91c6cc8750f4b 100644 (file)
--- a/src/trackview.cpp
+++ b/src/trackview.cpp
@@ -39,7 +39,7 @@
 #include <QScrollBar>
 #include <QInputDialog>
 
-TrackView::TrackView(KdenliveDoc *doc, QList <QAction*> actions, bool *ok, QWidget *parent) :
+TrackView::TrackView(KdenliveDoc *doc, const QList<QAction *> &actions, bool *ok, QWidget *parent) :
     QWidget(parent),
     m_scale(1.0),
     m_projectTracks(0),

diff --git a/src/trackview.h b/src/trackview.h
index 3a936aa3f349f58f246c2aa4fddb860fdb828371..a629c81999d5d12f21815a15919edfe99278c3d8 100644 (file)
--- a/src/trackview.h
+++ b/src/trackview.h
@@ -50,7 +50,7 @@ class TrackView : public QWidget, public Ui::TimeLine_UI
     Q_OBJECT
 
 public:
-    explicit TrackView(KdenliveDoc *doc, QList <QAction *> actions, bool *ok, QWidget *parent = 0);
+    explicit TrackView(KdenliveDoc *doc, const QList <QAction *>& actions, bool *ok, QWidget *parent = 0);
     virtual ~ TrackView();
     void setEditMode(const QString & editMode);
     const QString & editMode() const;

diff --git a/src/transition.cpp b/src/transition.cpp
index ecdd7086ac2c1b9179e6089cba53f432527257bc..e8bfbd41011531d68f3a958a8cf968c91a5ef6c9 100644 (file)
--- a/src/transition.cpp
+++ b/src/transition.cpp
@@ -33,7 +33,7 @@
 #include <QPropertyAnimation>
 #endif
 
-Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params, bool automaticTransition) :
+Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, const QDomElement &params, bool automaticTransition) :
         AbstractClipItem(info, QRectF(), fps),
         m_forceTransitionTrack(false),
         m_automaticTransition(automaticTransition),

diff --git a/src/transition.h b/src/transition.h
index e779665512258ab55cf0ea70965724751461ccab..aa9a9cae16fa81c87c3dc5127136b6c683b13373 100644 (file)
--- a/src/transition.h
+++ b/src/transition.h
@@ -41,7 +41,7 @@ class Transition : public AbstractClipItem
     Q_OBJECT
 public:
 
-    Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params = QDomElement(), bool automaticTransition = false);
+    Transition(const ItemInfo &info, int transitiontrack, double fps, const QDomElement &params = QDomElement(), bool automaticTransition = false);
     virtual ~Transition();
     virtual void paint(QPainter *painter,
                        const QStyleOptionGraphicsItem *option,

diff --git a/src/transitionsettings.cpp b/src/transitionsettings.cpp
index fcd3d495435fd9f2583b3b2c1839003a6eb12e69..55655f3117d129d2b2d959a271e15a344a65efe2 100644 (file)
--- a/src/transitionsettings.cpp
+++ b/src/transitionsettings.cpp
@@ -69,7 +69,7 @@ TransitionSettings::TransitionSettings(Monitor *monitor, QWidget* parent) :
     connect(m_effectEdit, SIGNAL(parameterChanged(QDomElement,QDomElement,int)), this , SLOT(slotUpdateEffectParams(QDomElement,QDomElement)));
 }
 
-void TransitionSettings::updateProjectFormat(MltVideoProfile profile, Timecode t, const QList <TrackInfo> info)
+void TransitionSettings::updateProjectFormat(MltVideoProfile profile, Timecode t, const QList<TrackInfo> &info)
 {
     m_effectEdit->updateProjectFormat(profile, t);
     m_tracks = info;

diff --git a/src/transitionsettings.h b/src/transitionsettings.h
index f236f8495f1ed29e17ec2f290292aeeccb1ef61d..769e94ba5ba5b1b2ce86b8db93051fe0a3c2aa84 100644 (file)
--- a/src/transitionsettings.h
+++ b/src/transitionsettings.h
@@ -34,7 +34,7 @@ class TransitionSettings : public QWidget, public Ui::TransitionSettings_UI
 public:
     explicit TransitionSettings(Monitor *monitor, QWidget* parent = 0);
     void raiseWindow(QWidget*);
-    void updateProjectFormat(MltVideoProfile profile, Timecode t, const QList <TrackInfo> info);
+    void updateProjectFormat(MltVideoProfile profile, Timecode t, const QList <TrackInfo>& info);
     void updateTimecodeFormat();
     void setKeyframes(const QString &data, int maximum);