use const'ref

diff --git a/src/unicodedialog.cpp b/src/unicodedialog.cpp
index 328bb336eef892e2d73da2dc9b4563dd5bfeadd8..6f0dae0ccf12508c0dd293813bdacc42e87c4fed 100644 (file)
--- a/src/unicodedialog.cpp
+++ b/src/unicodedialog.cpp
@@ -179,10 +179,10 @@ QString UnicodeDialog::unicodeInfo(const QString &unicode)
     return infoText;
 }
 
-QString UnicodeDialog::validateText(QString text)
+QString UnicodeDialog::validateText(const QString &text)
 {
     QRegExp regex("([0-9]|[a-f])", Qt::CaseInsensitive, QRegExp::RegExp2);
-    QString newText = "";
+    QString newText;
     int pos = 0;
 
     switch (inputMethod) {
@@ -204,8 +204,8 @@ QString UnicodeDialog::validateText(QString text)
 
 void UnicodeDialog::updateOverviewChars(uint unicode)
 {
-    QString left = "";
-    QString right = "";
+    QString left;
+    QString right;
     uint i;
 
     for (i = 1; i <= 4; i++) {
@@ -233,7 +233,7 @@ void UnicodeDialog::clearOverviewChars()
     rightChars->setText("");
 }
 
-QString UnicodeDialog::nextUnicode(QString text, Direction direction)
+QString UnicodeDialog::nextUnicode(const QString &text, Direction direction)
 {
     uint value = 0;
     QString newText = "";

diff --git a/src/unicodedialog.h b/src/unicodedialog.h
index d689a8e3e78eb26efec0981cec811243e7ac8773..74f2cec04805d85ec90ce60e74856012858a5ffe 100644 (file)
--- a/src/unicodedialog.h
+++ b/src/unicodedialog.h
@@ -44,7 +44,7 @@ private:
     InputMethod inputMethod;
 
     /** \brief Validates text and removes all invalid characters (non-hex e.g.) */
-    QString validateText(QString text);
+    QString validateText(const QString &text);
     /** \brief Removes all leading zeros */
     QString trimmedUnicodeNumber(QString text);
     /** \brief Checks whether the given string is a control character */
@@ -53,7 +53,7 @@ private:
     bool controlCharacter(uint value);
 
     /** \brief Returns the next available unicode. */
-    QString nextUnicode(QString text, Direction direction);
+    QString nextUnicode(const QString &text, Direction direction);
 
     /** \brief Paints previous and next characters around current char */
     void updateOverviewChars(uint unicode);