add explicit keyword when necessary. Add const ref when necessary

diff --git a/src/cliptranscode.cpp b/src/cliptranscode.cpp
index 23f0f2770a35708d41ea3c1198373bbc030a09ce..9caf4e4a4f87148758091719c150c6e6fc06e3c6 100644 (file)
--- a/src/cliptranscode.cpp
+++ b/src/cliptranscode.cpp
@@ -27,7 +27,7 @@
 #include <KFileDialog>
 
 
-ClipTranscode::ClipTranscode(KUrl::List urls, const QString &params, const QStringList &postParams, const QString &description, bool automaticMode, QWidget * parent) :
+ClipTranscode::ClipTranscode(const KUrl::List &urls, const QString &params, const QStringList &postParams, const QString &description, bool automaticMode, QWidget * parent) :
         QDialog(parent), m_urls(urls), m_duration(0), m_automaticMode(automaticMode), m_postParams(postParams)
 {
     setFont(KGlobalSettings::toolBarFont());

diff --git a/src/cliptranscode.h b/src/cliptranscode.h
index 3b707ed7e86afad7ce1e3699bbeb367b862c79e3..a5addaa67b74bbbe280e8618412e0589af91477e 100644 (file)
--- a/src/cliptranscode.h
+++ b/src/cliptranscode.h
@@ -37,7 +37,7 @@ class ClipTranscode : public QDialog, public Ui::ClipTranscode_UI
     Q_OBJECT
 
 public:
-    ClipTranscode(KUrl::List urls, const QString &params, const QStringList &postParams, const QString &description, bool automaticMode = false, QWidget * parent = 0);
+    ClipTranscode(const KUrl::List &urls, const QString &params, const QStringList &postParams, const QString &description, bool automaticMode = false, QWidget * parent = 0);
     ~ClipTranscode();
 
 public slots:

diff --git a/src/complexparameter.cpp b/src/complexparameter.cpp
index da364e540e543fd6bd0af8be41d116160f9f6293..7b4d5ff2f2a0ed74fabcbcb7de5a9c453c2e8a8b 100644 (file)
--- a/src/complexparameter.cpp
+++ b/src/complexparameter.cpp
@@ -131,12 +131,12 @@ void ComplexParameter::slotUpdateEffectParams(QDomElement e)
     emit parameterChanged();
 }
 
-QDomElement ComplexParameter::getParamDesc()
+QDomElement ComplexParameter::getParamDesc() const
 {
     return m_param;
 }
 
-void ComplexParameter::slotUpdateParameterList(QStringList l)
+void ComplexParameter::slotUpdateParameterList(const QStringList &l)
 {
     kDebug() << l ;
     m_ui.parameterList->clear();

diff --git a/src/complexparameter.h b/src/complexparameter.h
index 8d3dc9fa30d87a3bcd65c28de0a3766d90f41002..8990605471b4b886313c9eda600e8f2717a57202 100644 (file)
--- a/src/complexparameter.h
+++ b/src/complexparameter.h
@@ -29,8 +29,8 @@ class ComplexParameter : public QWidget
     Q_OBJECT
 
 public:
-    ComplexParameter(QWidget *parent = 0);
-    QDomElement getParamDesc();
+    explicit ComplexParameter(QWidget *parent = 0);
+    QDomElement getParamDesc() const;
 private:
     Ui::KeyframeWidget_UI m_ui;
     QDomElement m_param;
@@ -47,7 +47,7 @@ public slots:
     void itemSelectionChanged();
     void setupParam(const QDomElement, const QString& paramName, int, int);
     void slotUpdateEffectParams(QDomElement e);
-    void slotUpdateParameterList(QStringList);
+    void slotUpdateParameterList(const QStringList &);
 signals:
     void removeEffect(ClipItem*, QDomElement);
     void updateClipEffect(ClipItem*, QDomElement);

diff --git a/src/definitions.h b/src/definitions.h
index dd22fbb4f2f0715a0fbb61e835f54e896beb11bf..cb61e83cd318c347d42fd3d8f7b7bd830b674c8c 100644 (file)
--- a/src/definitions.h
+++ b/src/definitions.h
@@ -265,7 +265,7 @@ class CommentedTime
 {
 public:
     CommentedTime(): t(GenTime(0)), type(0) {}
-    CommentedTime(const GenTime &time, QString comment, int markerType = 0)
+    CommentedTime(const GenTime &time, const QString& comment, int markerType = 0)
         : t(time), c(comment), type(markerType) { }
 
     QString comment()   const          {

diff --git a/src/documentchecker.cpp b/src/documentchecker.cpp
index 96f63c8dc79143ee7011c87c9f99212dc8f903a7..7504af20ed8c71071f76922672d70ad02e8137d4 100644 (file)
--- a/src/documentchecker.cpp
+++ b/src/documentchecker.cpp
@@ -432,7 +432,7 @@ bool DocumentChecker::hasErrorInClips()
 
 DocumentChecker::~DocumentChecker()
 {
-    if (m_dialog) delete m_dialog;
+    delete m_dialog;
 }
 
 

diff --git a/src/effectslistview.h b/src/effectslistview.h
index bba95eae48c38e93178f449c765410d5a2ac216d..c744d080d8f8c1f502abe7a946d62b55d2cd0bfc 100644 (file)
--- a/src/effectslistview.h
+++ b/src/effectslistview.h
@@ -45,7 +45,7 @@ class EffectsListView : public QWidget, public Ui::EffectList_UI
     Q_OBJECT
 
 public:
-    EffectsListView(QWidget *parent = 0);
+    explicit EffectsListView(QWidget *parent = 0);
 
     /** @brief Re-initializes the list of effects. */
     void reloadEffectList(QMenu *effectsMenu, KActionCategory *effectActions);

diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp
index 12380e128b18c201745ce8a71c348813b45e1b19..4ecf1c4a2086bd382d9ed2a34ee156695c71386e 100644 (file)
--- a/src/kdenlivedoc.cpp
+++ b/src/kdenlivedoc.cpp
@@ -1850,7 +1850,7 @@ const QMap <QString, QString> KdenliveDoc::metadata() const
     return m_documentMetadata;
 }
 
-void KdenliveDoc::setMetadata(const QMap <QString, QString> meta)
+void KdenliveDoc::setMetadata(const QMap<QString, QString> &meta)
 {
     setModified(true);
     m_documentMetadata = meta;

diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h
index 97df1eaca9379f95227f7f805da972431f04261d..286f8045ed74a818687abe4301c4ab6bc9d8dbb0 100644 (file)
--- a/src/kdenlivedoc.h
+++ b/src/kdenlivedoc.h
@@ -167,7 +167,7 @@ Q_OBJECT public:
     /** @brief Returns the document metadata (author, copyright, ...) */
     const QMap <QString, QString> metadata() const;
     /** @brief Set the document metadata (author, copyright, ...) */
-    void setMetadata(const QMap <QString, QString> meta);
+    void setMetadata(const QMap <QString, QString>& meta);
     
 private:
     KUrl m_url;

diff --git a/src/kthumb.h b/src/kthumb.h
index b3a2f52962a03e397dbc804142e9562d7102bec5..f7446ac37350b2222beccf6e0d56826680bbe949 100644 (file)
--- a/src/kthumb.h
+++ b/src/kthumb.h
@@ -53,7 +53,7 @@ class KThumb: public QObject
    Q_OBJECT 
 public:
 
-    KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent = 0);
+    explicit KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent = 0);
     ~KThumb();
     void setProducer(Mlt::Producer *producer);
     bool hasProducer() const;

diff --git a/src/monitormanager.h b/src/monitormanager.h
index ca2b573606d36ac341aecc8a0f42f30cd946175f..70eb597f1fe1641eb88e74880a7e64e5b7f71bbe 100644 (file)
--- a/src/monitormanager.h
+++ b/src/monitormanager.h
@@ -32,7 +32,7 @@ class MonitorManager : public QObject
     Q_OBJECT
 
 public:
-    MonitorManager(QWidget *parent = 0);
+    explicit MonitorManager(QWidget *parent = 0);
     void initMonitors(Monitor *clipMonitor, Monitor *projectMonitor, RecMonitor *recMonitor);
     void appendMonitor(AbstractMonitor *monitor);
     void removeMonitor(AbstractMonitor *monitor);

diff --git a/src/parameterplotter.h b/src/parameterplotter.h
index 522869036fb67a98a965366454f08d5f9375c95a..2961dcab1373a1d1f5f4ac0513e84c341c20b141 100644 (file)
--- a/src/parameterplotter.h
+++ b/src/parameterplotter.h
@@ -26,7 +26,7 @@ class ParameterPlotter : public KPlotWidget
 {
     Q_OBJECT
 public:
-    ParameterPlotter(QWidget *parent = 0);
+    explicit ParameterPlotter(QWidget *parent = 0);
     virtual ~ParameterPlotter() {}
     void setMoveX(bool);
     void setMoveY(bool);
@@ -36,7 +36,7 @@ public:
     bool isMoveY();
     bool isMoveTimeline();
     bool isNewPoints();
-    void replot(const QString& name = "");
+    void replot(const QString& name = QString());
 private:
     KPlotPoint* m_movepoint;
     int m_activeIndexPlot;