use const ref

remove not  necessary ";"
if(foo) delete foo; -> delete foo;

diff --git a/src/clipmanager.h b/src/clipmanager.h
index 9f093bf95d67643f636c8c72422a703814dc1b55..5165bbd4f8c6ec24fd7768c776330cc764212f79 100644 (file)
--- a/src/clipmanager.h
+++ b/src/clipmanager.h
@@ -71,7 +71,7 @@ public:
 namespace Mlt
 {
 class Producer;
-};
+}
 
 class ClipManager: public QObject
 {

diff --git a/src/colorpickerwidget.h b/src/colorpickerwidget.h
index 71e38af4ba2b76d10676424a56e01a8c75d39184..2401a2795d920efdd6b5f8810bffcf2100b7d1a9 100644 (file)
--- a/src/colorpickerwidget.h
+++ b/src/colorpickerwidget.h
@@ -58,7 +58,7 @@ class ColorPickerWidget : public QWidget
 
 public:
     /** @brief Sets up the widget. */
-    ColorPickerWidget(QWidget *parent = 0);
+    explicit ColorPickerWidget(QWidget *parent = 0);
     /** @brief Makes sure the event filter is removed. */
     virtual ~ColorPickerWidget();
 

diff --git a/src/cornerswidget.cpp b/src/cornerswidget.cpp
index 95654bdb7d2dbdd470943f5ae4541c97bc0b84c8..d31c091ddf2f1e03d42318cbb3d5002d80bfc568 100644 (file)
--- a/src/cornerswidget.cpp
+++ b/src/cornerswidget.cpp
@@ -36,7 +36,7 @@ inline int lerp( const int a, const int b, double t )
     return a + (b - a) * t;
 }
 
-CornersWidget::CornersWidget(Monitor *monitor, QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) :
+CornersWidget::CornersWidget(Monitor *monitor, const QDomElement& e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) :
         KeyframeEdit(e, minFrame, maxFrame, tc, activeKeyframe, parent),
         m_monitor(monitor),
         m_showScene(true),

diff --git a/src/cornerswidget.h b/src/cornerswidget.h
index d5d5fe860c187ffed81b5fe9d15124e485796a6b..1cad4610bea0c154809d102a11bc3a136e8e46ad 100644 (file)
--- a/src/cornerswidget.h
+++ b/src/cornerswidget.h
@@ -40,7 +40,7 @@ public:
      * @param isEffect true if used in an effect, false if used in a transition
      * @param factor Factor by which the parameters differ from the range 0-1
      * @param parent (optional) Parent widget */
-    CornersWidget(Monitor *monitor, QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0);
+    explicit CornersWidget(Monitor *monitor, const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0);
     virtual ~CornersWidget();
 
     virtual void addParameter(QDomElement e, int activeKeyframe = -1);

diff --git a/src/customtrackscene.cpp b/src/customtrackscene.cpp
index 1f8b40ae2f6de2f45f5e8483aa7c1a149b886aa7..ba243695662e66e75c014ea529fa097e65dfdfc6 100644 (file)
--- a/src/customtrackscene.cpp
+++ b/src/customtrackscene.cpp
@@ -50,7 +50,7 @@ double CustomTrackScene::getSnapPointForPos(double pos, bool doSnap)
     return GenTime(pos, m_document->fps()).frames(m_document->fps());
 }
 
-void CustomTrackScene::setSnapList(QList <GenTime> snaps)
+void CustomTrackScene::setSnapList(const QList <GenTime>& snaps)
 {
     m_snapPoints = snaps;
 }

diff --git a/src/customtrackscene.h b/src/customtrackscene.h
index ac402618d82379ab523c3da133de8ed8e6b6ea43..ade17bc57ad586c05afc7304f8dae9d97a1d5cbf 100644 (file)
--- a/src/customtrackscene.h
+++ b/src/customtrackscene.h
@@ -44,7 +44,7 @@ class CustomTrackScene : public QGraphicsScene
 public:
     explicit CustomTrackScene(KdenliveDoc *doc, QObject *parent = 0);
     virtual ~ CustomTrackScene();
-    void setSnapList(QList <GenTime> snaps);
+    void setSnapList(const QList <GenTime>& snaps);
     GenTime previousSnapPoint(GenTime pos) const;
     GenTime nextSnapPoint(GenTime pos) const;
     double getSnapPointForPos(double pos, bool doSnap = true);

diff --git a/src/definitions.h b/src/definitions.h
index 738e133de56cf35ccb80bd86fb6684c819c0e11a..dd22fbb4f2f0715a0fbb61e835f54e896beb11bf 100644 (file)
--- a/src/definitions.h
+++ b/src/definitions.h
@@ -86,7 +86,7 @@ public:
         isMute(0),
         isBlind(0),
         isLocked(0),
-        duration(0) {};
+        duration(0) {}
 };
 
 typedef QMap<QString, QString> stringMap;
@@ -103,7 +103,7 @@ public:
     /** cropDuration is the duration of the clip */
     GenTime cropDuration;
     int track;
-    ItemInfo() : track(0) {};
+    ItemInfo() : track(0) {}
 };
 
 class TransitionInfo {
@@ -121,7 +121,7 @@ public:
     TransitionInfo() :
         b_track(0),
         a_track(0),
-        forceTrack(0) {};
+        forceTrack(0) {}
 };
 
 class MltVideoProfile {
@@ -148,7 +148,7 @@ public:
         sample_aspect_den(0),
         display_aspect_num(0),
         display_aspect_den(0),
-        colorspace(0) {};
+        colorspace(0) {}
     bool operator==(const MltVideoProfile& point) const
     {
         if (!description.isEmpty() && point.description  == description) return true;
@@ -233,7 +233,7 @@ public:
     }
     void setParamValue(const QString &name, const QString &value) {
        bool found = false;
-        for (int i = 0; i < size(); i++)
+        for (int i = 0; i < size(); ++i)
             if (at(i).name() == name) {
                // update value
                replace(i, EffectParameter(name, value));
@@ -243,7 +243,7 @@ public:
     }
         
     QString paramValue(const QString &name, QString defaultValue = QString()) const {
-        for (int i = 0; i < size(); i++) {
+        for (int i = 0; i < size(); ++i) {
             if (at(i).name() == name) return at(i).value();
         }
         return defaultValue;
@@ -253,7 +253,7 @@ public:
         append(EffectParameter(name, value));
     }
     void removeParam(const QString &name) {
-        for (int i = 0; i < size(); i++)
+        for (int i = 0; i < size(); ++i)
             if (at(i).name() == name) {
                 removeAt(i);
                 break;

diff --git a/src/docclipbase.h b/src/docclipbase.h
index 4b85c0a160eb12eb3cbd2b7c026fb75043804cc1..0e22c4dad85a311889bbc874d006f6e314a3f0b8 100644 (file)
--- a/src/docclipbase.h
+++ b/src/docclipbase.h
@@ -43,7 +43,7 @@ class ClipManager;
 namespace Mlt
 {
 class Producer;
-};
+}
 
 struct CutZoneInfo {
     QPoint zone;
@@ -53,7 +53,8 @@ struct CutZoneInfo {
 
 class DocClipBase: public QObject
 {
-Q_OBJECT public:
+Q_OBJECT
+public:
     /** this enum determines the types of "feed" available within this clip. types must be non-exclusive
      * - e.g. if you can have audio and video separately, it should be possible to combin the two, as is
      *   done here. If a new clip type is added then it should be possible to combine it with both audio

diff --git a/src/documentchecker.cpp b/src/documentchecker.cpp
index 68fee92bc6a2b32ff0eae028e8ecd45ef61afe01..96f63c8dc79143ee7011c87c9f99212dc8f903a7 100644 (file)
--- a/src/documentchecker.cpp
+++ b/src/documentchecker.cpp
@@ -64,7 +64,7 @@ const int LUMAPLACEHOLDER = 12;
 
 enum TITLECLIPTYPE { TITLE_IMAGE_ELEMENT = 20, TITLE_FONT_ELEMENT = 21 };
 
-DocumentChecker::DocumentChecker(QDomNodeList infoproducers, QDomDocument doc):
+DocumentChecker::DocumentChecker(const QDomNodeList &infoproducers, const QDomDocument &doc):
     m_info(infoproducers), m_doc(doc), m_dialog(NULL)
 {
 

diff --git a/src/documentchecker.h b/src/documentchecker.h
index 58a23db0ce905ffd830661fc4aa4296df516f812..03c91ec1f093354c5de71faf5f5a219be0dbb0a5 100644 (file)
--- a/src/documentchecker.h
+++ b/src/documentchecker.h
@@ -34,7 +34,7 @@ class DocumentChecker: public QObject
     Q_OBJECT
 
 public:
-    explicit DocumentChecker(QDomNodeList infoproducers, QDomDocument doc);
+    explicit DocumentChecker(const QDomNodeList &infoproducers, const QDomDocument &doc);
     ~DocumentChecker();
     bool hasErrorInClips();
 

diff --git a/src/documentvalidator.cpp b/src/documentvalidator.cpp
index dea1e96794c49da2e27e727f5c7d178588d517c6..ec04f3852cbca08b28b3c89030670af11e35fa2a 100644 (file)
--- a/src/documentvalidator.cpp
+++ b/src/documentvalidator.cpp
@@ -40,7 +40,7 @@
 #include <locale>
 
 
-DocumentValidator::DocumentValidator(QDomDocument doc, KUrl documentUrl):
+DocumentValidator::DocumentValidator(const QDomDocument &doc, const KUrl &documentUrl):
         m_doc(doc),
         m_url(documentUrl),
         m_modified(false)
@@ -1174,7 +1174,7 @@ void DocumentValidator::updateEffects()
     }
 }
 
-bool DocumentValidator::updateEffectParameters(QDomNodeList parameters, const QScriptValue* updateRules, const double serviceVersion, const double effectVersion)
+bool DocumentValidator::updateEffectParameters(const QDomNodeList &parameters, const QScriptValue* updateRules, const double serviceVersion, const double effectVersion)
 {
     bool updated = false;
     bool isDowngrade = serviceVersion < effectVersion;

diff --git a/src/documentvalidator.h b/src/documentvalidator.h
index 70766ed5726be71d420ecbc22ad71c8f9a0f4e74..aaa3b3a96e7c786d0d0ba7d5d6c35ea57d14a4fc 100644 (file)
--- a/src/documentvalidator.h
+++ b/src/documentvalidator.h
@@ -32,7 +32,7 @@ class DocumentValidator
 {
 
 public:
-    DocumentValidator(QDomDocument doc, KUrl documentUrl);
+    DocumentValidator(const QDomDocument &doc, const KUrl &documentUrl);
     bool isProject() const;
     bool validate(const double currentVersion);
     bool isModified() const;
@@ -48,7 +48,7 @@ private:
     void updateEffects();
     /** @brief Updates the parameters according to the updateRules.
      * @see the related in README in effects/update */
-    bool updateEffectParameters(QDomNodeList parameters, const QScriptValue *updateRules, const double serviceVersion, const double effectVersion);
+    bool updateEffectParameters(const QDomNodeList &parameters, const QScriptValue *updateRules, const double serviceVersion, const double effectVersion);
 };
 
 #endif

diff --git a/src/dragvalue.cpp b/src/dragvalue.cpp
index 6a8eeb1ed7caa2abede043c404c88fad181cec8c..cf59b1806f4d46d0633456894bc2d4bed1396da2 100644 (file)
--- a/src/dragvalue.cpp
+++ b/src/dragvalue.cpp
@@ -139,8 +139,8 @@ DragValue::DragValue(const QString &label, double defaultValue, int decimals, do
 
 DragValue::~DragValue()
 {
-    if (m_intEdit) delete m_intEdit;
-    if (m_doubleEdit) delete m_doubleEdit;
+    delete m_intEdit;
+    delete m_doubleEdit;
     delete m_menu;
     //delete m_scale;
     //delete m_directUpdate;

diff --git a/src/dvdwizardvob.h b/src/dvdwizardvob.h
index b35fb45980559920357142bdf8e042d1d4f5e50d..2dd461f0cc07d1b5c969b2207a012904975e056f 100644 (file)
--- a/src/dvdwizardvob.h
+++ b/src/dvdwizardvob.h
@@ -44,7 +44,7 @@ class DvdTreeWidget : public QTreeWidget
 {
     Q_OBJECT
 public:
-    DvdTreeWidget(QWidget *parent);
+    explicit DvdTreeWidget(QWidget *parent);
 
 protected:
     virtual void dragEnterEvent(QDragEnterEvent * event );

diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp
index 76abe7a29242e72c5ae2c7301824b401656dd3f5..be6681497097c0f4ba5ec802e034a9f0903c2cb9 100644 (file)
--- a/src/effectstackedit.cpp
+++ b/src/effectstackedit.cpp
@@ -75,7 +75,7 @@ void EffectStackEdit::updateProjectFormat(MltVideoProfile profile, Timecode t)
     m_metaInfo.timecode = t;
 }
 
-void EffectStackEdit::setFrameSize(QPoint p)
+void EffectStackEdit::setFrameSize(const QPoint &p)
 {
     m_metaInfo.frameSize = p;
 }

diff --git a/src/effectstackedit.h b/src/effectstackedit.h
index bcc242d13e1de278fffcf8844031e465cd17f081..c210b32e416322baaf1a396d70b1265da7b12a32 100644 (file)
--- a/src/effectstackedit.h
+++ b/src/effectstackedit.h
@@ -44,7 +44,7 @@ public:
     *
     * Used to disable the effect, by setting disabled="1" */
     void updateParameter(const QString &name, const QString &value);
-    void setFrameSize(QPoint p);
+    void setFrameSize(const QPoint &p);
     /** @brief Tells the parameters to update their timecode format according to KdenliveSettings. */
     void updateTimecodeFormat();
     /** @brief Returns true if this effect wants to keep track of current position in clip. */
@@ -63,7 +63,7 @@ private:
     ParameterContainer *m_paramWidget;
 
 public slots:
-    /** @brief Called when an effect is selected, builds the UI for this effect. */
+    /** @brief Called when an effect is selected, builds the UI for this effect. */
     void transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect = true);
 
     /** @brief Pass position changes of the timeline cursor to the effects to keep their local timelines in sync. */

diff --git a/src/geometryval.cpp b/src/geometryval.cpp
index 2c52f685779f5ebdea333507bb47eaa163c5b95e..0d706894d028e7f283cb5f434830fe352c66266b 100644 (file)
--- a/src/geometryval.cpp
+++ b/src/geometryval.cpp
@@ -29,7 +29,7 @@
 #include <QTimer>
 
 
-Geometryval::Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint, QWidget* parent) :
+Geometryval::Geometryval(const MltVideoProfile &profile, Timecode t, const QPoint &frame_size, int startPoint, QWidget* parent) :
         QWidget(parent),
         m_profile(profile),
         m_paramRect(NULL),

diff --git a/src/geometryval.h b/src/geometryval.h
index 740d6dd3533d8f2a79cca05565961e27fe8acaaa..0e00447de808cb533ba1685eaa898d66ce6e1884 100644 (file)
--- a/src/geometryval.h
+++ b/src/geometryval.h
@@ -40,7 +40,7 @@ class Geometryval : public QWidget, public Ui::Geometryval
 {
     Q_OBJECT
 public:
-    explicit Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint = 0, QWidget* parent = 0);
+    explicit Geometryval(const MltVideoProfile &profile, Timecode t, const QPoint &frame_size, int startPoint = 0, QWidget* parent = 0);
     virtual ~Geometryval();
     QDomElement getParamDesc();
     QString getValue() const;

diff --git a/src/guide.cpp b/src/guide.cpp
index d26358b48ab1e25a649e2f0b6bfac4923143f5bd..3d44c627fad372ae530b15087f6b4c7f04094fe2 100644 (file)
--- a/src/guide.cpp
+++ b/src/guide.cpp
@@ -29,7 +29,7 @@
 #include <QGraphicsView>
 #include <QScrollBar>
 
-Guide::Guide(CustomTrackView *view, GenTime pos, QString label, double height) :
+Guide::Guide(CustomTrackView *view, GenTime pos, const QString &label, double height) :
         QGraphicsLineItem(),
         m_position(pos),
         m_label(label),

diff --git a/src/guide.h b/src/guide.h
index bcedf3af71c2c16710aae7d870ecd4de734da4b7..5e77c85763cfe2452083e54ec4cf73682ffe144c 100644 (file)
--- a/src/guide.h
+++ b/src/guide.h
@@ -34,7 +34,7 @@ class Guide : public QGraphicsLineItem
 {
 
 public:
-    Guide(CustomTrackView *view, GenTime pos, QString label, double height);
+    Guide(CustomTrackView *view, GenTime pos, const QString &label, double height);
     GenTime position() const;
     void updateGuide(const GenTime &newPos, const QString &comment = QString());
     QString label() const;

diff --git a/src/headertrack.cpp b/src/headertrack.cpp
index af95f277a4c2207c6e99819b94071303fac44681..d1d8f0f75a997814dcb4a16bec96a8ef23b689a8 100644 (file)
--- a/src/headertrack.cpp
+++ b/src/headertrack.cpp
@@ -33,7 +33,7 @@
 #include <QTimer>
 #include <QDomDocument>
 
-HeaderTrack::HeaderTrack(int index, TrackInfo info, int height, QList <QAction *> actions, QWidget *parent) :
+HeaderTrack::HeaderTrack(int index, TrackInfo info, int height, const QList <QAction *> &actions, QWidget *parent) :
         QWidget(parent),
         m_index(index),
         m_type(info.type),

diff --git a/src/headertrack.h b/src/headertrack.h
index 3b69acf071c1871a2e21ab16361936d8d5f7d61a..e262bb9cd619c4234d5d92b34ba42f047078ff87 100644 (file)
--- a/src/headertrack.h
+++ b/src/headertrack.h
@@ -32,7 +32,7 @@ class HeaderTrack : public QWidget, public Ui::TrackHeader_UI
     Q_OBJECT
 
 public:
-    HeaderTrack(int index, TrackInfo info, int height, QList <QAction *> actions, QWidget *parent = 0);
+    HeaderTrack(int index, TrackInfo info, int height, const QList <QAction *>& actions, QWidget *parent = 0);
     //virtual ~HeaderTrack();
     void setLock(bool lock);
     void adjustSize(int height);

diff --git a/src/jogshuttle.cpp b/src/jogshuttle.cpp
index ede869ea888c9c0c81211b437ecb6f47928a21c4..0e92cb42f12783e410a1013f8984e864ed909b53 100644 (file)
--- a/src/jogshuttle.cpp
+++ b/src/jogshuttle.cpp
@@ -68,7 +68,7 @@
 #define JOG_STOP 10020
 #define MAX_SHUTTLE_RANGE 7
 
-void ShuttleThread::init(QObject *parent, QString device)
+void ShuttleThread::init(QObject *parent, const QString &device)
 {
     m_parent = parent;
     m_device = device;

diff --git a/src/jogshuttle.h b/src/jogshuttle.h
index 9a6ecc0287c5dbb01483b724f49c492e6dc411c7..55b4472a1306db2c767856e14c15fd48481b83f4 100644 (file)
--- a/src/jogshuttle.h
+++ b/src/jogshuttle.h
@@ -34,7 +34,7 @@ class ShuttleThread : public QThread
 
 public:
     virtual void run();
-    void init(QObject *parent, QString device);
+    void init(QObject *parent, const QString &device);
     QObject *m_parent;
     int shuttlevalue;
     int shuttlecounter;

diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp
index 349ff08192d434eaf14d9e59c25d7c03feb9d963..37df421002c4230e5d215c8819adbb5915dd076d 100644 (file)
--- a/src/kdenlivedoc.cpp
+++ b/src/kdenlivedoc.cpp
@@ -58,7 +58,7 @@
 
 const double DOCUMENTVERSION = 0.88;
 
-KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, QMap <QString, QString> metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) :
+KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, const QString &profileName, QMap <QString, QString> properties, QMap <QString, QString> metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) :
     QObject(parent),
     m_autosave(NULL),
     m_url(url),

diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h
index 22aeac31b18014f2f12d306c5ebfb762073485bf..e0bbee1c7915821e95cce7e7b7bc67bb29b07c55 100644 (file)
--- a/src/kdenlivedoc.h
+++ b/src/kdenlivedoc.h
@@ -52,7 +52,7 @@ class KdenliveDoc: public QObject
 {
 Q_OBJECT public:
 
-    KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, QMap <QString, QString> metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0);
+    KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, const QString &profileName, QMap <QString, QString> properties, QMap <QString, QString> metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0);
     ~KdenliveDoc();
     QDomNodeList producersList();
     double fps() const;

diff --git a/src/kdenlivesettingsdialog.cpp b/src/kdenlivesettingsdialog.cpp
index d0e09e1d6f3fb937f9e2a78c190fb6e4ccb926d5..154bb0307ae99ec6edbcd40cbf8e99fea4eb5801 100644 (file)
--- a/src/kdenlivesettingsdialog.cpp
+++ b/src/kdenlivesettingsdialog.cpp
@@ -105,7 +105,7 @@ KdenliveSettingsDialog::KdenliveSettingsDialog(const QMap<QString, QString>& map
 #ifdef USE_V4L
 
     // Video 4 Linux device detection
-    for (int i = 0; i < 10; i++) {
+    for (int i = 0; i < 10; ++i) {
         QString path = "/dev/video" + QString::number(i);
         if (QFile::exists(path)) {
             QStringList deviceInfo = V4lCaptureHandler::getDeviceName(path);

diff --git a/src/keyframeedit.cpp b/src/keyframeedit.cpp
index 2ff4ec6be4d095382cfe38c2f7dddfb1e1fa91f0..a326d953f9398a30f2fdbb1957e47f0a6618cbf9 100644 (file)
--- a/src/keyframeedit.cpp
+++ b/src/keyframeedit.cpp
@@ -25,7 +25,7 @@
 
 #include <QHeaderView>
 
-KeyframeEdit::KeyframeEdit(QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) :
+KeyframeEdit::KeyframeEdit(const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) :
         QWidget(parent),
         m_min(minFrame),
         m_max(maxFrame),

diff --git a/src/keyframeedit.h b/src/keyframeedit.h
index 2da6b6d8e9da57e2d1c4567b0f7ab6262432b3ec..05bd599bd24ad9335356240b999ca3b111c135c3 100644 (file)
--- a/src/keyframeedit.h
+++ b/src/keyframeedit.h
@@ -80,7 +80,7 @@ class KeyframeEdit : public QWidget, public Ui::KeyframeEditor_UI
 {
     Q_OBJECT
 public:
-    explicit KeyframeEdit(QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0);
+    explicit KeyframeEdit(const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0);
     virtual ~KeyframeEdit();
     virtual void addParameter(QDomElement e, int activeKeyframe = -1);
     const QString getValue(const QString &name);

diff --git a/src/managecapturesdialog.cpp b/src/managecapturesdialog.cpp
index a8e6dc724f47057269127d4942a20533cc777652..7eed6c92e8054a8bcc403aedd49ee42c7743f82e 100644 (file)
--- a/src/managecapturesdialog.cpp
+++ b/src/managecapturesdialog.cpp
@@ -34,7 +34,7 @@
 #include <QTimer>
 
 
-ManageCapturesDialog::ManageCapturesDialog(KUrl::List files, QWidget * parent) :
+ManageCapturesDialog::ManageCapturesDialog(const KUrl::List &files, QWidget * parent) :
         QDialog(parent)
 {
     setFont(KGlobalSettings::toolBarFont());

diff --git a/src/managecapturesdialog.h b/src/managecapturesdialog.h
index dc0e1e784eb996a2a8ec132d2f600263f9bf5170..55fea3620a735997c04813e6a0500748102b1fda 100644 (file)
--- a/src/managecapturesdialog.h
+++ b/src/managecapturesdialog.h
@@ -33,7 +33,7 @@ class ManageCapturesDialog : public QDialog
     Q_OBJECT
 
 public:
-    explicit ManageCapturesDialog(KUrl::List files, QWidget * parent = 0);
+    explicit ManageCapturesDialog(const KUrl::List &files, QWidget * parent = 0);
     ~ManageCapturesDialog();
     KUrl::List importFiles();
 

diff --git a/src/markerdialog.h b/src/markerdialog.h
index 6a78e46827b40f297f05e9794a678aa57d49702f..710c6348b56448daff558f8a8ea1d383618fe632 100644 (file)
--- a/src/markerdialog.h
+++ b/src/markerdialog.h
@@ -1,4 +1,4 @@
-/***************************************************************************
+ /***************************************************************************
  *   Copyright (C) 2008 by Jean-Baptiste Mardelle (jb@kdenlive.org)        *
  *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *

diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h
index 91faa5baf4e8939cc97a7ff3c1bc7b45e696a295..f572636b91a2db4add72ee316f872a7a7d6ce3c6 100644 (file)
--- a/src/mltdevicecapture.h
+++ b/src/mltdevicecapture.h
@@ -1,4 +1,4 @@
-/***************************************************************************
+ /***************************************************************************
                          mltdevicecapture.h  -  description
                             -------------------
    begin                : Sun May 21 2011
@@ -62,7 +62,7 @@ Q_OBJECT public:
     bool sendFrameForAnalysis;
 
     /** @brief Someone needs us to send again a frame. */
-    void sendFrameUpdate() {};
+    void sendFrameUpdate() {}
     
     void emitFrameUpdated(Mlt::Frame&);
     void emitFrameNumber(double position);

diff --git a/src/noteswidget.h b/src/noteswidget.h
index ab9e8611dcb5a98d002e09c16188dae2f765b302..60eb7e98100a0f461a4a665efcedec00f7c04ca2 100644 (file)
--- a/src/noteswidget.h
+++ b/src/noteswidget.h
@@ -34,7 +34,7 @@ class NotesWidget : public KTextEdit
     Q_OBJECT
 
 public:
-    NotesWidget(QWidget * parent = 0);
+    explicit NotesWidget(QWidget * parent = 0);
     ~NotesWidget();
 
 protected:

diff --git a/src/positionedit.cpp b/src/positionedit.cpp
index c6aaae49e86a6dc5095b80d0580b1f76894954bd..78bcdd37c9eac0e240e35f701c01ba6f977b9307 100644 (file)
--- a/src/positionedit.cpp
+++ b/src/positionedit.cpp
@@ -25,7 +25,7 @@
 #include <QSlider>
 #include <QHBoxLayout>
 
-PositionEdit::PositionEdit(const QString name, int pos, int min, int max, const Timecode tc, QWidget* parent) :
+PositionEdit::PositionEdit(const QString &name, int pos, int min, int max, const Timecode tc, QWidget* parent) :
         QWidget(parent)
 {
     QHBoxLayout *layout = new QHBoxLayout(this);

diff --git a/src/positionedit.h b/src/positionedit.h
index 2c5f243b9f1ed2a5a1b778fb3f9e152825a5e4f3..ed22ba6ca0cc0df79df593b1b46bf578303cc44f 100644 (file)
--- a/src/positionedit.h
+++ b/src/positionedit.h
@@ -30,7 +30,7 @@ class PositionEdit : public QWidget
 {
     Q_OBJECT
 public:
-    explicit PositionEdit(const QString name, int pos, int min, int max, const Timecode tc, QWidget* parent = 0);
+    explicit PositionEdit(const QString &name, int pos, int min, int max, const Timecode tc, QWidget* parent = 0);
     virtual ~PositionEdit();
     int getPosition() const;
     void setPosition(int pos);