git.sesse.net Git - mlt/blob - src/modules/opengl/filter_movit_convert.cpp

   1 /*
   2  * filter_movit_convert.cpp
   3  * Copyright (C) 2013 Dan Dennedy <dan@dennedy.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License as published by
   7  * the Free Software Foundation; either version 2 of the License, or
   8  * (at your option) any later version.
   9  *
  10  * This program is distributed in the hope that it will be useful,
  11  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  12  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  13  * GNU General Public License for more details.
  14  *
  15  * You should have received a copy of the GNU General Public License
  16  * along with this program; if not, write to the Free Software Foundation,
  17  * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
  18  */
  19
  20 #include <framework/mlt.h>
  21 #include <string.h>
  22 #include <stdlib.h>
  23 #include <assert.h>
  24 #include <string>
  25
  26 #include "filter_glsl_manager.h"
  27 #include <movit/effect_chain.h>
  28 #include <movit/util.h>
  29 #include "mlt_movit_input.h"
  30 #include <mlt++/MltProducer.h>
  31 #include "mlt_flip_effect.h"
  32
  33 static void set_movit_parameters( GlslChain *chain, mlt_service service, mlt_frame frame );
  34
  35 static void yuv422_to_yuv422p( uint8_t *yuv422, uint8_t *yuv422p, int width, int height )
  36 {
  37         uint8_t *Y = yuv422p;
  38         uint8_t *U = Y + width * height;
  39         uint8_t *V = U + width * height / 2;
  40         int n = width * height / 2 + 1;
  41         while ( --n ) {
  42                 *Y++ = *yuv422++;
  43                 *U++ = *yuv422++;
  44                 *Y++ = *yuv422++;
  45                 *V++ = *yuv422++;
  46         }
  47 }
  48
  49 static int convert_on_cpu( mlt_frame frame, uint8_t **image, mlt_image_format *format, mlt_image_format output_format )
  50 {
  51         int error = 0;
  52         mlt_filter cpu_csc = (mlt_filter) mlt_properties_get_data( MLT_FRAME_PROPERTIES( frame ), "cpu_csc", NULL );
  53         if ( cpu_csc ) {
  54                 int (* save_fp )( mlt_frame self, uint8_t **image, mlt_image_format *input, mlt_image_format output )
  55                         = frame->convert_image;
  56                 frame->convert_image = NULL;
  57                 mlt_filter_process( cpu_csc, frame );
  58                 error = frame->convert_image( frame, image, format, output_format );
  59                 frame->convert_image = save_fp;
  60         } else {
  61                 error = 1;
  62         }
  63         return error;
  64 }
  65
  66 static void delete_chain( EffectChain* chain )
  67 {
  68         delete chain;
  69 }
  70
  71 static void get_format_from_properties( mlt_properties properties, ImageFormat* image_format, YCbCrFormat* ycbcr_format )
  72 {
  73         switch ( mlt_properties_get_int( properties, "colorspace" ) ) {
  74         case 601:
  75                 ycbcr_format->luma_coefficients = YCBCR_REC_601;
  76                 break;
  77         case 709:
  78         default:
  79                 ycbcr_format->luma_coefficients = YCBCR_REC_709;
  80                 break;
  81         }
  82
  83         switch ( mlt_properties_get_int( properties, "color_primaries" ) ) {
  84         case 601625:
  85                 image_format->color_space = COLORSPACE_REC_601_625;
  86                 break;
  87         case 601525:
  88                 image_format->color_space = COLORSPACE_REC_601_525;
  89                 break;
  90         case 709:
  91         default:
  92                 image_format->color_space = COLORSPACE_REC_709;
  93                 break;
  94         }
  95
  96         image_format->gamma_curve = GAMMA_REC_709;
  97
  98         if ( mlt_properties_get_int( properties, "force_full_luma" ) ) {
  99                 ycbcr_format->full_range = true;
 100         } else {
 101                 ycbcr_format->full_range = ( mlt_properties_get_int( properties, "full_luma" ) == 1 );
 102         }
 103
 104         // TODO: make new frame properties set by producers
 105         ycbcr_format->cb_x_position = ycbcr_format->cr_x_position = 0.0f;
 106         ycbcr_format->cb_y_position = ycbcr_format->cr_y_position = 0.5f;
 107 }
 108
 109 static void build_fingerprint( mlt_service service, mlt_frame frame, std::string *fingerprint )
 110 {
 111         if ( service == (mlt_service) -1 ) {
 112                 fingerprint->append( "input" );
 113                 return;
 114         }
 115
 116         Effect* effect = GlslManager::get_effect( service, frame );
 117         assert( effect );
 118         mlt_service input_a = GlslManager::get_effect_input( service, frame );
 119         fingerprint->push_back( '(' );
 120         build_fingerprint( input_a, frame, fingerprint );
 121         fingerprint->push_back( ')' );
 122
 123         mlt_frame frame_b;
 124         mlt_service input_b;
 125         GlslManager::get_effect_secondary_input( service, frame, &input_b, &frame_b );
 126         if ( input_b ) {
 127                 fingerprint->push_back( '(' );
 128                 build_fingerprint( input_b, frame_b, fingerprint );
 129                 fingerprint->push_back( ')' );
 130         }
 131
 132         fingerprint->push_back( '(' );
 133         fingerprint->append( mlt_properties_get( MLT_SERVICE_PROPERTIES( service ), "_unique_id" ) );
 134         bool disable = mlt_properties_get_int( MLT_SERVICE_PROPERTIES( service ), "movit.parms.int.disable" );
 135         if ( disable ) {
 136                 fingerprint->push_back( 'd' );
 137         }
 138         fingerprint->push_back( ')' );
 139 }
 140
 141 static Effect* build_movit_chain( mlt_service service, mlt_frame frame, GlslChain *chain )
 142 {
 143         if ( service == (mlt_service) -1 ) {
 144                 mlt_producer producer = mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) );
 145                 MltInput* input = GlslManager::get_input( producer, frame );
 146                 GlslManager::set_input( producer, frame, NULL );
 147                 chain->effect_chain->add_input( input );
 148                 chain->effects.insert(std::make_pair( MLT_SERVICE( producer ), input ) );
 149                 return input;
 150         }
 151
 152         Effect* effect = GlslManager::get_effect( service, frame );
 153         assert( effect );
 154         GlslManager::set_effect( service, frame, NULL );
 155
 156         mlt_service input_a = GlslManager::get_effect_input( service, frame );
 157         mlt_service input_b;
 158         mlt_frame frame_b;
 159         GlslManager::get_effect_secondary_input( service, frame, &input_b, &frame_b );
 160         Effect *effect_a = build_movit_chain( input_a, frame, chain );
 161
 162         if ( input_b ) {
 163                 Effect *effect_b = build_movit_chain( input_b, frame_b, chain );
 164                 chain->effect_chain->add_effect( effect, effect_a, effect_b );
 165         } else {
 166                 chain->effect_chain->add_effect( effect, effect_a );
 167         }
 168
 169         chain->effects.insert(std::make_pair( service, effect ) );
 170         return effect;
 171 }
 172
 173 static void dispose_movit_effects( mlt_service service, mlt_frame frame )
 174 {
 175         if ( service == (mlt_service) -1 ) {
 176                 mlt_producer producer = mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) );
 177                 delete GlslManager::get_input( producer, frame );
 178                 GlslManager::set_input( producer, frame, NULL );
 179                 return;
 180         }
 181
 182         delete GlslManager::get_effect( service, frame );
 183         GlslManager::set_effect( service, frame, NULL );
 184
 185         mlt_service input_a = GlslManager::get_effect_input( service, frame );
 186         mlt_service input_b;
 187         mlt_frame frame_b;
 188         GlslManager::get_effect_secondary_input( service, frame, &input_b, &frame_b );
 189         dispose_movit_effects( input_a, frame );
 190
 191         if ( input_b ) {
 192                 dispose_movit_effects( input_b, frame_b );
 193         }
 194 }
 195
 196 static void finalize_movit_chain( mlt_service leaf_service, mlt_frame frame )
 197 {
 198         GlslChain* chain = GlslManager::get_chain( leaf_service );
 199
 200         std::string new_fingerprint;
 201         build_fingerprint( leaf_service, frame, &new_fingerprint );
 202
 203         // Build the chain if needed.
 204         if ( !chain || new_fingerprint != chain->fingerprint ) {
 205                 mlt_log_debug( leaf_service, "=== CREATING NEW CHAIN (old chain=%p, leaf=%p, fingerprint=%s) ===\n", chain, leaf_service, new_fingerprint.c_str() );
 206                 mlt_profile profile = mlt_service_profile( leaf_service );
 207                 chain = new GlslChain;
 208                 chain->effect_chain = new EffectChain( profile->display_aspect_num, profile->display_aspect_den );
 209                 chain->fingerprint = new_fingerprint;
 210
 211                 build_movit_chain( leaf_service, frame, chain );
 212                 set_movit_parameters( chain, leaf_service, frame );
 213                 chain->effect_chain->add_effect( new Mlt::VerticalFlip );
 214
 215                 ImageFormat output_format;
 216                 output_format.color_space = COLORSPACE_sRGB;
 217                 output_format.gamma_curve = GAMMA_sRGB;
 218                 chain->effect_chain->add_output(output_format, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED);
 219                 chain->effect_chain->set_dither_bits(8);
 220                 chain->effect_chain->finalize();
 221
 222                 GlslManager::set_chain( leaf_service, chain );
 223         } else {
 224                 // Delete all the created Effect instances to avoid memory leaks.
 225                 dispose_movit_effects( leaf_service, frame );
 226         }
 227 }
 228
 229 static void set_movit_parameters( GlslChain *chain, mlt_service service, mlt_frame frame )
 230 {
 231         if ( service == (mlt_service) -1 ) {
 232                 mlt_producer producer = mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) );
 233                 MltInput* input = (MltInput *) chain->effects[ MLT_PRODUCER_SERVICE( producer ) ];
 234                 input->set_pixel_data( GlslManager::get_input_pixel_pointer( producer, frame ) );
 235                 return;
 236         }
 237
 238         Effect* effect = chain->effects[ service ];
 239         mlt_service input_a = GlslManager::get_effect_input( service, frame );
 240         set_movit_parameters( chain, input_a, frame );
 241
 242         mlt_service input_b;
 243         mlt_frame frame_b;
 244         GlslManager::get_effect_secondary_input( service, frame, &input_b, &frame_b );
 245         if ( input_b ) {
 246                 set_movit_parameters( chain, input_b, frame_b );
 247         }
 248
 249         mlt_properties properties = MLT_SERVICE_PROPERTIES( service );
 250         int count = mlt_properties_count( properties );
 251         for (int i = 0; i < count; ++i) {
 252                 const char *name = mlt_properties_get_name( properties, i );
 253                 if (strncmp(name, "movit.parms.float.", strlen("movit.parms.float.")) == 0) {
 254                         bool ok = effect->set_float(name + strlen("movit.parms.float."),
 255                                 mlt_properties_get_double( properties, name ));
 256                         assert(ok);
 257                 }
 258                 if (strncmp(name, "movit.parms.int.", strlen("movit.parms.int.")) == 0) {
 259                         bool ok = effect->set_int(name + strlen("movit.parms.int."),
 260                                 mlt_properties_get_int( properties, name ));
 261                         assert(ok);
 262                 }
 263                 if (strncmp(name, "movit.parms.vec3.", strlen("movit.parms.vec3.")) == 0 &&
 264                     strcmp(name + strlen(name) - 3, "[0]") == 0) {
 265                         float val[3];
 266                         char *name_copy = strdup(name);
 267                         char *index_char = name_copy + strlen(name_copy) - 2;
 268                         val[0] = mlt_properties_get_double( properties, name_copy );
 269                         *index_char = '1';
 270                         val[1] = mlt_properties_get_double( properties, name_copy );
 271                         *index_char = '2';
 272                         val[2] = mlt_properties_get_double( properties, name_copy );
 273                         index_char[-1] = '\0';
 274                         bool ok = effect->set_vec3(name_copy + strlen("movit.parms.vec3."), val);
 275                         assert(ok);
 276                         free(name_copy);
 277                 }
 278                 if (strncmp(name, "movit.parms.vec4.", strlen("movit.parms.vec4.")) == 0 &&
 279                     strcmp(name + strlen(name) - 3, "[0]") == 0) {
 280                         float val[4];
 281                         char *name_copy = strdup(name);
 282                         char *index_char = name_copy + strlen(name_copy) - 2;
 283                         val[0] = mlt_properties_get_double( properties, name_copy );
 284                         *index_char = '1';
 285                         val[1] = mlt_properties_get_double( properties, name_copy );
 286                         *index_char = '2';
 287                         val[2] = mlt_properties_get_double( properties, name_copy );
 288                         *index_char = '3';
 289                         val[3] = mlt_properties_get_double( properties, name_copy );
 290                         index_char[-1] = '\0';
 291                         bool ok = effect->set_vec4(name_copy + strlen("movit.parms.vec4."), val);
 292                         assert(ok);
 293                         free(name_copy);
 294                 }
 295         }
 296 }
 297
 298 static void dispose_pixel_pointers( mlt_service service, mlt_frame frame )
 299 {
 300         if ( service == (mlt_service) -1 ) {
 301                 mlt_producer producer = mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) );
 302                 mlt_pool_release( GlslManager::get_input_pixel_pointer( producer, frame ) );
 303                 return;
 304         }
 305
 306         mlt_service input_a = GlslManager::get_effect_input( service, frame );
 307         dispose_pixel_pointers( input_a, frame );
 308
 309         mlt_service input_b;
 310         mlt_frame frame_b;
 311         GlslManager::get_effect_secondary_input( service, frame, &input_b, &frame_b );
 312         if ( input_b ) {
 313                 dispose_pixel_pointers( input_b, frame_b );
 314         }
 315 }
 316
 317 static int movit_render( EffectChain *chain, mlt_frame frame, mlt_image_format *format, mlt_image_format output_format, int width, int height, uint8_t **image )
 318 {
 319         GlslManager* glsl = GlslManager::get_instance();
 320         int error;
 321         if ( output_format == mlt_image_glsl_texture ) {
 322                 error = glsl->render_frame_texture( chain, frame, width, height, image );
 323         }
 324         else {
 325                 error = glsl->render_frame_rgba( chain, frame, width, height, image );
 326                 if ( !error && output_format != mlt_image_rgb24a ) {
 327                         *format = mlt_image_rgb24a;
 328                         error = convert_on_cpu( frame, image, format, output_format );
 329                 }
 330         }
 331         return error;
 332 }
 333
 334 // Create an MltInput for an image with the given format and dimensions.
 335 static MltInput* create_input( mlt_properties properties, mlt_image_format format, int aspect_width, int aspect_height, int width, int height )
 336 {
 337         MltInput* input = new MltInput( aspect_width, aspect_height );
 338         if ( format == mlt_image_rgb24a || format == mlt_image_opengl ) {
 339                 // TODO: Get the color space if available.
 340                 input->useFlatInput( FORMAT_RGBA_POSTMULTIPLIED_ALPHA, width, height );
 341         }
 342         else if ( format == mlt_image_rgb24 ) {
 343                 // TODO: Get the color space if available.
 344                 input->useFlatInput( FORMAT_RGB, width, height );
 345         }
 346         else if ( format == mlt_image_yuv420p ) {
 347                 ImageFormat image_format;
 348                 YCbCrFormat ycbcr_format;
 349                 get_format_from_properties( properties, &image_format, &ycbcr_format );
 350                 ycbcr_format.chroma_subsampling_x = ycbcr_format.chroma_subsampling_y = 2;
 351                 input->useYCbCrInput( image_format, ycbcr_format, width, height );
 352         }
 353         else if ( format == mlt_image_yuv422 ) {
 354                 ImageFormat image_format;
 355                 YCbCrFormat ycbcr_format;
 356                 get_format_from_properties( properties, &image_format, &ycbcr_format );
 357                 ycbcr_format.chroma_subsampling_x = 2;
 358                 ycbcr_format.chroma_subsampling_y = 1;
 359                 input->useYCbCrInput( image_format, ycbcr_format, width, height );
 360         }
 361         return input;
 362 }
 363
 364 // Make a copy of the given image (allocated using mlt_pool_alloc) suitable
 365 // to pass as pixel pointer to an MltInput (created using create_input
 366 // with the same parameters), and return that pointer.
 367 static uint8_t* make_input_copy( mlt_image_format format, uint8_t *image, int width, int height )
 368 {
 369         int img_size = mlt_image_format_size( format, width, height, NULL );
 370         uint8_t* img_copy = (uint8_t*) mlt_pool_alloc( img_size );
 371         if ( format == mlt_image_yuv422 ) {
 372                 yuv422_to_yuv422p( image, img_copy, width, height );
 373         } else {
 374                 memcpy( img_copy, image, img_size );
 375         }
 376         return img_copy;
 377 }
 378
 379 static int convert_image( mlt_frame frame, uint8_t **image, mlt_image_format *format, mlt_image_format output_format )
 380 {
 381         // Nothing to do!
 382         if ( *format == output_format )
 383                 return 0;
 384
 385         mlt_properties properties = MLT_FRAME_PROPERTIES( frame );
 386
 387         mlt_log_debug( NULL, "filter_movit_convert: %s -> %s (%d)\n",
 388                 mlt_image_format_name( *format ), mlt_image_format_name( output_format ),
 389                 mlt_frame_get_position( frame ) );
 390
 391         // Use CPU if glsl not initialized or not supported.
 392         GlslManager* glsl = GlslManager::get_instance();
 393         if ( !glsl || !glsl->get_int("glsl_supported" ) )
 394                 return convert_on_cpu( frame, image, format, output_format );
 395
 396         // Do non-GL image conversions on a CPU-based image converter.
 397         if ( *format != mlt_image_glsl && output_format != mlt_image_glsl && output_format != mlt_image_glsl_texture )
 398                 return convert_on_cpu( frame, image, format, output_format );
 399
 400         int error = 0;
 401         int width = mlt_properties_get_int( properties, "width" );
 402         int height = mlt_properties_get_int( properties, "height" );
 403         GlslManager::get_instance()->lock_service( frame );
 404
 405         // If we're at the beginning of a series of Movit effects, store the input
 406         // sent into the chain.
 407         if ( output_format == mlt_image_glsl ) {
 408                 mlt_producer producer = mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) );
 409                 mlt_profile profile = mlt_service_profile( MLT_PRODUCER_SERVICE( producer ) );
 410                 MltInput *input = create_input( properties, *format, profile->width, profile->height, width, height );
 411                 GlslManager::set_input( producer, frame, input );
 412                 uint8_t *img_copy = make_input_copy( *format, *image, width, height );
 413                 GlslManager::set_input_pixel_pointer( producer, frame, img_copy );
 414
 415                 *image = (uint8_t *) -1;
 416                 mlt_frame_set_image( frame, *image, 0, NULL );
 417         }
 418
 419         // If we're at the _end_ of a series of Movit effects, render the chain.
 420         if ( *format == mlt_image_glsl ) {
 421                 mlt_service leaf_service = (mlt_service) *image;
 422
 423                 // Construct the chain unless we already have a good one.
 424                 finalize_movit_chain( leaf_service, frame );
 425
 426                 // Set per-frame parameters now that we know which Effect instances to set them on.
 427                 // (finalize_movit_chain may already have done this, though, but twice doesn't hurt.)
 428                 GlslChain *chain = GlslManager::get_chain( leaf_service );
 429                 set_movit_parameters( chain, leaf_service, frame );
 430
 431                 error = movit_render( chain->effect_chain, frame, format, output_format, width, height, image );
 432
 433                 dispose_pixel_pointers( leaf_service, frame );
 434         }
 435
 436         // If we've been asked to render some frame directly to a texture (without any
 437         // effects in-between), we create a new mini-chain to do so.
 438         if ( *format != mlt_image_glsl && output_format == mlt_image_glsl_texture ) {
 439                 // We might already have a texture from a previous conversion from mlt_image_glsl.
 440                 glsl_texture texture = (glsl_texture) mlt_properties_get_data( properties, "movit.convert.texture", NULL );
 441                 // XXX: requires a special property set on the frame by the app for now
 442                 // because we do not have reliable way to clear the texture property
 443                 // when a downstream filter has changed image.
 444                 if ( texture && mlt_properties_get_int( properties, "movit.convert.use_texture") ) {
 445                         *image = (uint8_t*) &texture->texture;
 446                         mlt_frame_set_image( frame, *image, 0, NULL );
 447                 } else {
 448                         // Use a separate chain to convert image in RAM to OpenGL texture.
 449                         // Use cached chain if available and compatible.
 450                         Mlt::Producer producer( mlt_producer_cut_parent( mlt_frame_get_original_producer( frame ) ) );
 451                         EffectChain *chain = (EffectChain*) producer.get_data( "movit.convert.chain" );
 452                         MltInput *input = (MltInput*) producer.get_data( "movit.convert.input" );
 453                         int w = producer.get_int( "movit.convert.width" );
 454                         int h = producer.get_int( "movit.convert.height" );
 455                         mlt_image_format f = (mlt_image_format) producer.get_int( "movit.convert.format" );
 456                         if ( !chain || !input || width != w || height != h || *format != f ) {
 457                                 chain = new EffectChain( width, height );
 458                                 input = create_input( properties, *format, width, height, width, height );
 459                                 chain->add_input( input );
 460                                 chain->add_effect( new Mlt::VerticalFlip() );
 461                                 ImageFormat movit_output_format;
 462                                 movit_output_format.color_space = COLORSPACE_sRGB;
 463                                 movit_output_format.gamma_curve = GAMMA_sRGB;
 464                                 chain->add_output(movit_output_format, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED);
 465                                 chain->set_dither_bits(8);
 466                                 chain->finalize();
 467                                 producer.set( "movit.convert.chain", chain, 0, (mlt_destructor) delete_chain );
 468                                 producer.set( "movit.convert.input", input, 0, NULL );
 469                                 producer.set( "movit.convert.width", width );
 470                                 producer.set( "movit.convert.height", height );
 471                                 producer.set( "movit.convert.format", *format );
 472                         }
 473
 474                         if ( *format == mlt_image_yuv422 ) {
 475                                 // We need to convert to planar, which make_input_copy() will do for us.
 476                                 uint8_t *planar = make_input_copy( *format, *image, width, height );
 477                                 input->set_pixel_data( planar );
 478                                 error = movit_render( chain, frame, format, output_format, width, height, image );
 479                                 mlt_pool_release( planar );
 480                         } else {
 481                                 input->set_pixel_data( *image );
 482                                 error = movit_render( chain, frame, format, output_format, width, height, image );
 483                         }
 484                 }
 485         }
 486
 487         GlslManager::get_instance()->unlock_service( frame );
 488
 489         mlt_properties_set_int( properties, "format", output_format );
 490         *format = output_format;
 491
 492         return error;
 493 }
 494
 495 static mlt_frame process( mlt_filter filter, mlt_frame frame )
 496 {
 497         // Set a default colorspace on the frame if not yet set by the producer.
 498         // The producer may still change it during get_image.
 499         // This way we do not have to modify each producer to set a valid colorspace.
 500         mlt_properties properties = MLT_FRAME_PROPERTIES(frame);
 501         if ( mlt_properties_get_int( properties, "colorspace" ) <= 0 )
 502                 mlt_properties_set_int( properties, "colorspace", mlt_service_profile( MLT_FILTER_SERVICE(filter) )->colorspace );
 503
 504         frame->convert_image = convert_image;
 505
 506         mlt_filter cpu_csc = (mlt_filter) mlt_properties_get_data( MLT_FILTER_PROPERTIES( filter ), "cpu_csc", NULL );
 507         mlt_properties_inc_ref( MLT_FILTER_PROPERTIES(cpu_csc) );
 508         mlt_properties_set_data( properties, "cpu_csc", cpu_csc, 0,
 509                 (mlt_destructor) mlt_filter_close, NULL );
 510
 511         return frame;
 512 }
 513
 514 static mlt_filter create_filter( mlt_profile profile, const char *effect )
 515 {
 516         mlt_filter filter;
 517         char *id = strdup( effect );
 518         char *arg = strchr( id, ':' );
 519         if ( arg != NULL )
 520                 *arg ++ = '\0';
 521
 522         // The swscale and avcolor_space filters require resolution as arg to test compatibility
 523         if ( !strcmp( effect, "avcolor_space" ) )
 524                 filter = mlt_factory_filter( profile, id, &profile->width );
 525         else
 526                 filter = mlt_factory_filter( profile, id, arg );
 527         if ( filter )
 528                 mlt_properties_set_int( MLT_FILTER_PROPERTIES( filter ), "_loader", 1 );
 529         free( id );
 530         return filter;
 531 }
 532
 533 extern "C" {
 534
 535 mlt_filter filter_movit_convert_init( mlt_profile profile, mlt_service_type type, const char *id, char *arg )
 536 {
 537         mlt_filter filter = NULL;
 538         GlslManager* glsl = GlslManager::get_instance();
 539
 540         if ( glsl && ( filter = mlt_filter_new() ) )
 541         {
 542 #ifdef WIN32
 543                 // XXX avcolor_space is crashing on Windows in this context!
 544                 mlt_filter cpu_csc = NULL;
 545 #else
 546                 mlt_filter cpu_csc = create_filter( profile, "avcolor_space" );
 547 #endif
 548                 if ( !cpu_csc )
 549                         cpu_csc = create_filter( profile, "imageconvert" );
 550                 if ( cpu_csc )
 551                         mlt_properties_set_data( MLT_FILTER_PROPERTIES( filter ), "cpu_csc", cpu_csc, 0,
 552                                 (mlt_destructor) mlt_filter_close, NULL );
 553                 filter->process = process;
 554         }
 555         return filter;
 556 }
 557
 558 }