Fix an issue where we'd add an unneeded bounce for mipmaps in some cases.

[movit] / colorspace_conversion_effect.h

diff --git a/colorspace_conversion_effect.h b/colorspace_conversion_effect.h
index b21f72e1a8b6b8782e332aedfaca2455d3f9644b..a59d4766a8ba3699b23723d6b87fd64cab4dc6c4 100644 (file)
--- a/colorspace_conversion_effect.h
+++ b/colorspace_conversion_effect.h
@@ -8,12 +8,14 @@
 // We don't do any fancy gamut mapping or similar; colors that are out-of-gamut
 // will simply stay out-of-gamut, and probably clip in the output stage.
 
-#include <string>
 #include <Eigen/Core>
+#include <string>
 
 #include "effect.h"
 #include "image_format.h"
 
+namespace movit {
+
 class ColorspaceConversionEffect : public Effect {
 private:
        // Should not be instantiated by end users.
@@ -21,11 +23,12 @@ private:
        friend class EffectChain;
 
 public:
-       virtual std::string effect_type_id() const { return "ColorspaceConversionEffect"; }
-       std::string output_fragment_shader();
+       std::string effect_type_id() const override { return "ColorspaceConversionEffect"; }
+       std::string output_fragment_shader() override;
 
-       virtual bool needs_srgb_primaries() const { return false; }
-       virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
+       bool needs_srgb_primaries() const override { return false; }
+       AlphaHandling alpha_handling() const override { return DONT_CARE_ALPHA_TYPE; }
+       bool strong_one_to_one_sampling() const override { return true; }
 
        // Get a conversion matrix from the given color space to XYZ.
        static Eigen::Matrix3d get_xyz_matrix(Colorspace space);
@@ -34,4 +37,6 @@ private:
        Colorspace source_space, destination_space;
 };
 
+}  // namespace movit
+
 #endif // !defined(_MOVIT_COLORSPACE_CONVERSION_EFFECT_H)