Set RMS limit much tighter, now that we have floating-point textures.

[movit] / test_util.cpp

diff --git a/test_util.cpp b/test_util.cpp
index 8fa67149d3ba19e86d0b34b194fc035792ad49f0..c8337d279966e5f0552530fd3107765f5835cb71 100644 (file)
--- a/test_util.cpp
+++ b/test_util.cpp
@@ -11,6 +11,27 @@ EffectChainTester::EffectChainTester(const float *data, unsigned width, unsigned
        : chain(width, height), width(width), height(height)
 {
        add_input(data, color_space, gamma_curve);
+
+       glGenTextures(1, &texnum);
+       check_error();
+       glBindTexture(GL_TEXTURE_2D, texnum);
+       check_error();
+       glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16F_ARB, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, NULL);
+       check_error();
+
+       glGenFramebuffers(1, &fbo);
+       check_error();
+       glBindFramebuffer(GL_FRAMEBUFFER, fbo);
+       check_error();
+       glFramebufferTexture2D(
+               GL_FRAMEBUFFER,
+               GL_COLOR_ATTACHMENT0,
+               GL_TEXTURE_2D,
+               texnum,
+               0);
+       check_error();
+       glBindFramebuffer(GL_FRAMEBUFFER, 0);
+       check_error();
 }
 
 Input *EffectChainTester::add_input(const float *data, ColorSpace color_space, GammaCurve gamma_curve)
@@ -33,9 +54,9 @@ void EffectChainTester::run(float *out_data, ColorSpace color_space, GammaCurve
        chain.add_output(format);
        chain.finalize();
 
-       glViewport(0, 0, width, height);
-       chain.render_to_screen();
+       chain.render_to_fbo(fbo, width, height);
 
+       glBindFramebuffer(GL_FRAMEBUFFER, fbo);
        glReadPixels(0, 0, width, height, GL_RED, GL_FLOAT, out_data);
 
        // Flip upside-down to compensate for different origin.
@@ -61,7 +82,7 @@ void expect_equal(const float *ref, const float *result, unsigned width, unsigne
        }
 
        const float largest_difference_limit = 1.5 / 255.0;
-       const float rms_limit = 0.5 / 255.0;
+       const float rms_limit = 0.2 / 255.0;
 
        EXPECT_LT(largest_difference, largest_difference_limit);