]> git.sesse.net Git - movit/commitdiff
Add a warning on FlatInput::set_texture_num() about sRGB behavior.
authorSteinar H. Gunderson <sgunderson@bigfoot.com>
Tue, 11 Apr 2017 19:55:10 +0000 (21:55 +0200)
committerSteinar H. Gunderson <sgunderson@bigfoot.com>
Tue, 11 Apr 2017 19:55:10 +0000 (21:55 +0200)
flat_input.h

index bcaca50012facb2dcfb3d77879b11d99cac9a456..06cc6ab1de270cb1476a86fdc5f27832446788c0 100644 (file)
@@ -138,6 +138,10 @@ public:
        // NOTE: The input does not take ownership of this texture; you are responsible
        // for releasing it yourself. In particular, if you call invalidate_pixel_data()
        // or anything calling it, the texture will silently be removed from the input.
        // NOTE: The input does not take ownership of this texture; you are responsible
        // for releasing it yourself. In particular, if you call invalidate_pixel_data()
        // or anything calling it, the texture will silently be removed from the input.
+       //
+       // NOTE: Doing this in a situation where can_output_linear_gamma() is true
+       // can yield unexpected results, as the downstream effect can expect the texture
+       // to be uploaded with the sRGB flag on.
        void set_texture_num(GLuint texture_num)
        {
                possibly_release_texture();
        void set_texture_num(GLuint texture_num)
        {
                possibly_release_texture();