In Theme::get_chain(), send InputState by reference instead of value.

It's ~2 kB, and we also don't have to fiddle as many refcounts around.
It's only once per channel per frame, though.

Found by Coverity Scan.

diff --git a/nageru/theme.cpp b/nageru/theme.cpp
index c926dd4591a63180f36c77d3a45afb17cc39b407..d28f5b2501030b0911b342a4124b95b1538e98c2 100644 (file)
--- a/nageru/theme.cpp
+++ b/nageru/theme.cpp
@@ -1217,7 +1217,7 @@ void Theme::register_class(const char *class_name, const luaL_Reg *funcs)
        assert(lua_gettop(L) == 0);
 }
 
-Theme::Chain Theme::get_chain(unsigned num, float t, unsigned width, unsigned height, InputState input_state) 
+Theme::Chain Theme::get_chain(unsigned num, float t, unsigned width, unsigned height, const InputState &input_state) 
 {
        Chain chain;
 

diff --git a/nageru/theme.h b/nageru/theme.h
index 0a239953baebf515f99c9b831e75ccdf6fc1b822..3d57750c9d9cd9ac39c272a1b66997637f15edbf 100644 (file)
--- a/nageru/theme.h
+++ b/nageru/theme.h
@@ -41,7 +41,7 @@ public:
                std::vector<RefCountedFrame> input_frames;
        };
 
-       Chain get_chain(unsigned num, float t, unsigned width, unsigned height, InputState input_state);
+       Chain get_chain(unsigned num, float t, unsigned width, unsigned height, const InputState &input_state);
 
        int get_num_channels() const { return num_channels; }
        int map_signal(int signal_num);