require Sesse::pr0n::Config_local;
};
- $VERSION = "v2.40";
+ $VERSION = "v2.41";
@ISA = qw(Exporter);
@EXPORT = qw(&error &dberror);
%EXPORT_TAGS = qw();
# Need to generate the cache; read in the image
my $magick = new Image::Magick;
my $info = Image::ExifTool::ImageInfo($fname);
-
- # NEF files aren't autodetected
- $fname = "NEF:$fname" if ($filename =~ /\.nef$/i);
+ my $err;
+
+ # ImageMagick can handle NEF files, but it does it by calling dcraw as a delegate.
+ # The delegate support is rather broken and causes very odd stuff to happen when
+ # more than one thread does this at the same time. Thus, we simply do it ourselves.
+ if ($filename =~ /\.nef$/) {
+ # this would suffice if ImageMagick gets to fix their handling
+ # $fname = "NEF:$fname";
+
+ open DCRAW, "-|", "dcraw", "-w", "-c", $fname
+ or error("dcraw: $!");
+ $err = $magick->Read(file => \*DCRAW);
+ close(DCRAW);
+ } else {
+ $err = $magick->Read($fname);
+ }
- my $err = $magick->Read($fname);
if ($err) {
$r->log->warn("$fname: $err");
$err =~ /(\d+)/;
# Use lanczos (sharper) for heavy scaling, mitchell (faster) otherwise
my $filter = 'Mitchell';
my $quality = 90;
+ my $sf = undef;
if ($width / $nwidth > 8.0 || $height / $nheight > 8.0) {
$filter = 'Lanczos';
- $quality = 80;
+ $quality = 85;
+ $sf = "1x1";
}
if ($xres != -1) {
# Strip EXIF tags etc.
$cimg->Strip();
- if (($nwidth >= 640 && $nheight >= 480) ||
- ($nwidth >= 480 && $nheight >= 640)) {
- $err = $cimg->write(filename=>$cachename, quality=>$quality, interlace=>'Plane');
- } else {
- $err = $cimg->write(filename=>$cachename, quality=>$quality);
+ {
+ my %parms = (
+ filename => $cachename,
+ quality => $quality
+ );
+ if (($nwidth >= 640 && $nheight >= 480) ||
+ ($nwidth >= 480 && $nheight >= 640)) {
+ $parms{'interlace'} = 'Plane';
+ }
+ if (defined($sf)) {
+ $parms{'sampling-factor'} = $sf;
+ }
+ $err = $cimg->write(%parms);
}
undef $cimg;