Do not assume that enum are signed

[stockfish] / src / bitboard.h

diff --git a/src/bitboard.h b/src/bitboard.h
index 140867fa94a466272d55be020451b0eb8b012f77..0cf0cd0a83021bb1d0a95abdc811287abc05dea2 100644 (file)
--- a/src/bitboard.h
+++ b/src/bitboard.h
@@ -21,9 +21,9 @@
 #ifndef BITBOARD_H_INCLUDED
 #define BITBOARD_H_INCLUDED
 
-#include "types.h"
+#include <string>
 
-extern Bitboard pext(Bitboard b, Bitboard mask);
+#include "types.h"
 
 namespace Bitboards {
 
@@ -119,11 +119,11 @@ inline int square_distance(Square s1, Square s2) {
 }
 
 inline int file_distance(Square s1, Square s2) {
-  return abs(file_of(s1) - file_of(s2));
+  return dist(file_of(s1), file_of(s2));
 }
 
 inline int rank_distance(Square s1, Square s2) {
-  return abs(rank_of(s1) - rank_of(s2));
+  return dist(rank_of(s1), rank_of(s2));
 }
 
 
@@ -243,6 +243,9 @@ FORCE_INLINE unsigned magic_index(Square s, Bitboard occ) {
   Bitboard* const Magics = Pt == ROOK ? RMagics : BMagics;
   unsigned* const Shifts = Pt == ROOK ? RShifts : BShifts;
 
+  if (HasPext)
+      return unsigned(_pext_u64(occ, Masks[s]));
+
   if (Is64Bit)
       return unsigned(((occ & Masks[s]) * Magics[s]) >> Shifts[s]);