Use incremental updates more often

[stockfish] / src / nnue / features / half_kp.h

diff --git a/src/nnue/features/half_kp.h b/src/nnue/features/half_kp.h
index 99842eea7777cd67fb84c1ac0c9d9d4a77945a4c..52a83eecf3b77bfa94b885a56bb6615e7496412d 100644 (file)
--- a/src/nnue/features/half_kp.h
+++ b/src/nnue/features/half_kp.h
@@ -41,7 +41,7 @@ namespace Eval::NNUE::Features {
     static constexpr IndexType kDimensions =
         static_cast<IndexType>(SQUARE_NB) * static_cast<IndexType>(PS_END);
     // Maximum number of simultaneously active features
     static constexpr IndexType kDimensions =
         static_cast<IndexType>(SQUARE_NB) * static_cast<IndexType>(PS_END);
     // Maximum number of simultaneously active features

-    static constexpr IndexType kMaxActiveDimensions = PIECE_ID_KING;
+    static constexpr IndexType kMaxActiveDimensions = 30; // Kings don't count

     // Trigger for full calculation instead of difference calculation
     static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kFriendKingMoved;
 
     // Trigger for full calculation instead of difference calculation
     static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kFriendKingMoved;
 


@@ -50,16 +50,12 @@ namespace Eval::NNUE::Features {
                                     IndexList* active);
 
     // Get a list of indices for recently changed features
                                     IndexList* active);
 
     // Get a list of indices for recently changed features

-    static void AppendChangedIndices(const Position& pos, Color perspective,
+    static void AppendChangedIndices(const Position& pos, const DirtyPiece& dp, Color perspective,

                                      IndexList* removed, IndexList* added);
 
                                      IndexList* removed, IndexList* added);
 

-    // Index of a feature for a given king position and another piece on some square
-    static IndexType MakeIndex(Square sq_k, PieceSquare p);
-

    private:
    private:

-    // Get pieces information
-    static void GetPieces(const Position& pos, Color perspective,
-                          PieceSquare** pieces, Square* sq_target_k);
+    // Index of a feature for a given king position and another piece on some square
+    static IndexType MakeIndex(Color perspective, Square s, Piece pc, Square sq_k);

   };
 
 }  // namespace Eval::NNUE::Features
   };
 
 }  // namespace Eval::NNUE::Features