Move best = MOVE_NONE;
};
+ struct FastMove {
+ FastMove() { clear(); }
+
+ inline void clear() {
+ expectedPosKey = 0;
+ pv3[0] = pv3[1] = pv3[2] = MOVE_NONE;
+ stableCnt = 0;
+ }
+
+ void update(Position& pos) {
+ // Keep track how many times in a row the PV stays stable 3 ply deep.
+ const std::vector<Move>& RMpv = RootMoves[0].pv;
+ if (RMpv.size() >= 3)
+ {
+ if (pv3[2] == RMpv[2])
+ stableCnt++;
+ else
+ stableCnt = 0, pv3[2] = RMpv[2];
+
+ if (!expectedPosKey || pv3[0] != RMpv[0] || pv3[1] != RMpv[1])
+ {
+ pv3[0] = RMpv[0], pv3[1] = RMpv[1];
+ StateInfo st[2];
+ pos.do_move(RMpv[0], st[0], pos.gives_check(RMpv[0], CheckInfo(pos)));
+ pos.do_move(RMpv[1], st[1], pos.gives_check(RMpv[1], CheckInfo(pos)));
+ expectedPosKey = pos.key();
+ pos.undo_move(RMpv[1]);
+ pos.undo_move(RMpv[0]);
+ }
+ }
+ else
+ clear();
+ }
+
+ Key expectedPosKey;
+ Move pv3[3];
+ int stableCnt;
+ } FM;
+
size_t PVIdx;
TimeManager TimeMgr;
double BestMoveChanges;
Value DrawValue[COLOR_NB];
HistoryStats History;
+ CounterMovesHistoryStats CounterMovesHistory;
GainsStats Gains;
MovesStats Countermoves, Followupmoves;
Depth depth;
Value bestValue, alpha, beta, delta;
+ // Init fastMove if the previous search generated a candidate and we now got the predicted position.
+ const Move fastMove = (FM.expectedPosKey == pos.key()) ? FM.pv3[2] : MOVE_NONE;
+ FM.clear();
+
std::memset(ss-2, 0, 5 * sizeof(Stack));
depth = DEPTH_ZERO;
TT.new_search();
History.clear();
+ CounterMovesHistory.clear();
Gains.clear();
Countermoves.clear();
Followupmoves.clear();
Signals.stop = true;
// Do we have time for the next iteration? Can we stop searching now?
- if (Limits.use_time_management() && !Signals.stop && !Signals.stopOnPonderhit)
+ if (Limits.use_time_management())
{
- // Take some extra time if the best move has changed
- if (depth > 4 * ONE_PLY && multiPV == 1)
- TimeMgr.pv_instability(BestMoveChanges);
-
- // Stop the search if only one legal move is available or all
- // of the available time has been used.
- if ( RootMoves.size() == 1
- || now() - SearchTime > TimeMgr.available_time())
+ if (!Signals.stop && !Signals.stopOnPonderhit)
{
- // If we are allowed to ponder do not stop the search now but
- // keep pondering until the GUI sends "ponderhit" or "stop".
- if (Limits.ponder)
- Signals.stopOnPonderhit = true;
- else
- Signals.stop = true;
+ // Take some extra time if the best move has changed
+ if (depth > 4 * ONE_PLY && multiPV == 1)
+ TimeMgr.pv_instability(BestMoveChanges);
+
+ // Stop the search if only one legal move is available or all
+ // of the available time has been used or we matched a fastMove
+ // from the previous search and just did a fast verification.
+ if ( RootMoves.size() == 1
+ || now() - SearchTime > TimeMgr.available_time()
+ || ( fastMove == RootMoves[0].pv[0]
+ && BestMoveChanges < 0.03
+ && 10 * (now() - SearchTime) > TimeMgr.available_time()))
+ {
+ // If we are allowed to ponder do not stop the search now but
+ // keep pondering until the GUI sends "ponderhit" or "stop".
+ if (Limits.ponder)
+ Signals.stopOnPonderhit = true;
+ else
+ Signals.stop = true;
+ }
}
+
+ // Update fast move stats.
+ FM.update(pos);
}
}
+ // Clear any candidate fast move that wasn't completely stable for at least
+ // the 6 final search iterations. (Independent of actual depth and thus TC.)
+ // Time condition prevents consecutive fast moves.
+ if (FM.stableCnt < 6 || now() - SearchTime < TimeMgr.available_time())
+ FM.clear();
+
// If skill level is enabled, swap best PV line with the sub-optimal one
if (skill.enabled())
std::swap(RootMoves[0], *std::find(RootMoves.begin(),
assert((ss-1)->currentMove != MOVE_NONE);
assert((ss-1)->currentMove != MOVE_NULL);
- MovePicker mp(pos, ttMove, History, pos.captured_piece_type());
+ MovePicker mp(pos, ttMove, History, CounterMovesHistory, pos.captured_piece_type());
CheckInfo ci(pos);
while ((move = mp.next_move<false>()) != MOVE_NONE)
Move followupmoves[] = { Followupmoves[pos.piece_on(prevOwnMoveSq)][prevOwnMoveSq].first,
Followupmoves[pos.piece_on(prevOwnMoveSq)][prevOwnMoveSq].second };
- MovePicker mp(pos, ttMove, depth, History, countermoves, followupmoves, ss);
+ MovePicker mp(pos, ttMove, depth, History, CounterMovesHistory, countermoves, followupmoves, ss);
CheckInfo ci(pos);
value = bestValue; // Workaround a bogus 'uninitialized' warning under gcc
improving = ss->staticEval >= (ss-2)->staticEval
continue;
moveCount = ++splitPoint->moveCount;
- splitPoint->spinlock.release();
+ splitPoint->mutex.unlock();
}
else
++moveCount;
&& moveCount >= FutilityMoveCounts[improving][depth])
{
if (SpNode)
- splitPoint->spinlock.acquire();
+ splitPoint->mutex.lock();
continue;
}
if (SpNode)
{
- splitPoint->spinlock.acquire();
+ splitPoint->mutex.lock();
if (bestValue > splitPoint->bestValue)
splitPoint->bestValue = bestValue;
}
if (predictedDepth < 4 * ONE_PLY && pos.see_sign(move) < VALUE_ZERO)
{
if (SpNode)
- splitPoint->spinlock.acquire();
+ splitPoint->mutex.lock();
continue;
}
// Step 18. Check for new best move
if (SpNode)
{
- splitPoint->spinlock.acquire();
+ splitPoint->mutex.lock();
bestValue = splitPoint->bestValue;
alpha = splitPoint->alpha;
}
if (value > alpha)
{
+ // Clear fast move if unstable.
+ if (PvNode && pos.key() == FM.expectedPosKey && (move != FM.pv3[2] || moveCount > 1))
+ FM.clear();
+
bestMove = SpNode ? splitPoint->bestMove = move : move;
if (PvNode && !RootNode) // Update pv even in fail-high case
// to search the moves. Because the depth is <= 0 here, only captures,
// queen promotions and checks (only if depth >= DEPTH_QS_CHECKS) will
// be generated.
- MovePicker mp(pos, ttMove, depth, History, to_sq((ss-1)->currentMove));
+ MovePicker mp(pos, ttMove, depth, History, CounterMovesHistory, to_sq((ss-1)->currentMove));
CheckInfo ci(pos);
// Loop through the moves until no moves remain or a beta cutoff occurs
if (is_ok((ss-1)->currentMove))
{
Square prevMoveSq = to_sq((ss-1)->currentMove);
- Countermoves.update(pos.piece_on(prevMoveSq), prevMoveSq, move);
+ Piece prevMovePiece = pos.piece_on(prevMoveSq);
+ Countermoves.update(prevMovePiece, prevMoveSq, move);
+
+ HistoryStats& cmh = CounterMovesHistory[prevMovePiece][prevMoveSq];
+ cmh.update(pos.moved_piece(move), to_sq(move), bonus);
+ for (int i = 0; i < quietsCnt; ++i)
+ {
+ Move m = quiets[i];
+ cmh.update(pos.moved_piece(m), to_sq(m), -bonus);
+ }
}
if (is_ok((ss-2)->currentMove) && (ss-1)->currentMove == (ss-1)->ttMove)
// If this thread has been assigned work, launch a search
while (searching)
{
- Threads.spinlock.acquire();
+ mutex.lock();
assert(activeSplitPoint);
-
SplitPoint* sp = activeSplitPoint;
- Threads.spinlock.release();
+ mutex.unlock();
Stack stack[MAX_PLY+4], *ss = stack+2; // To allow referencing (ss-2) and (ss+2)
Position pos(*sp->pos, this);
std::memcpy(ss-2, sp->ss-2, 5 * sizeof(Stack));
ss->splitPoint = sp;
- sp->spinlock.acquire();
+ sp->mutex.lock();
assert(activePosition == nullptr);
// After releasing the lock we can't access any SplitPoint related data
// in a safe way because it could have been released under our feet by
// the sp master.
- sp->spinlock.release();
+ sp->mutex.unlock();
// Try to late join to another split point if none of its slaves has
// already finished.
sp = bestSp;
// Recheck the conditions under lock protection
- Threads.spinlock.acquire();
- sp->spinlock.acquire();
+ sp->mutex.lock();
if ( sp->allSlavesSearching
- && sp->slavesMask.count() < MAX_SLAVES_PER_SPLITPOINT
- && can_join(sp))
+ && sp->slavesMask.count() < MAX_SLAVES_PER_SPLITPOINT)
{
- sp->slavesMask.set(idx);
- activeSplitPoint = sp;
- searching = true;
+ allocMutex.lock();
+
+ if (can_join(sp))
+ {
+ sp->slavesMask.set(idx);
+ activeSplitPoint = sp;
+ searching = true;
+ }
+
+ allocMutex.unlock();
}
- sp->spinlock.release();
- Threads.spinlock.release();
+ sp->mutex.unlock();
}
}
// Avoid races with notify_one() fired from last slave of the split point
- std::unique_lock<std::mutex> lk(mutex);
+ std::unique_lock<Mutex> lk(mutex);
// If we are master and all slaves have finished then exit idle_loop
if (this_sp && this_sp->slavesMask.none())
else if (Limits.nodes)
{
- Threads.spinlock.acquire();
-
int64_t nodes = RootPos.nodes_searched();
// Loop across all split points and sum accumulated SplitPoint nodes plus
// all the currently active positions nodes.
+ // FIXME: Racy...
for (Thread* th : Threads)
for (size_t i = 0; i < th->splitPointsSize; ++i)
{
SplitPoint& sp = th->splitPoints[i];
- sp.spinlock.acquire();
+ sp.mutex.lock();
nodes += sp.nodes;
if (sp.slavesMask.test(idx) && Threads[idx]->activePosition)
nodes += Threads[idx]->activePosition->nodes_searched();
- sp.spinlock.release();
+ sp.mutex.unlock();
}
- Threads.spinlock.release();
-
if (nodes >= Limits.nodes)
Signals.stop = true;
}
projects / stockfish / blobdiff