Fix broken last patch series

When a reference breaks things !

Here we take a reference (that is a pointer) to an
entry in a vector that changes below us --> BOOM !

References are essential but should be considered with
care in C++ because could lead to nasty surprises.

Restored functionality.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>

diff --git a/src/search.cpp b/src/search.cpp
index fdad3e51d50f9183c378f1aa1ded6205aa52d426..6678b32d5c39f58d88a97ce670c00d14acab0f8b 100644 (file)
--- a/src/search.cpp
+++ b/src/search.cpp
@@ -2744,7 +2744,7 @@ split_point_start: // At split points actual search starts from here
 
     for (i = 1; i <= n; i++)
     {
-        const RootMove& rm = this->at(i);
+        const RootMove rm = this->at(i);
         for (j = i; j > 0 && this->at(j - 1) < rm; j--)
             (*this)[j] = this->at(j - 1);