]> git.sesse.net Git - vlc/commitdiff
Fix dangerous use of qtu() on anonymous QString
authorRémi Denis-Courmont <remi@remlab.net>
Sat, 10 Apr 2010 17:20:52 +0000 (20:20 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Sat, 10 Apr 2010 17:20:52 +0000 (20:20 +0300)
modules/gui/qt4/main_interface.cpp

index edb494058d10d408bdbcf2c34abbd2a0354078d3..b7ed093b690aa08d073269463ca698316f81a6cd 100644 (file)
@@ -1003,9 +1003,9 @@ void MainInterface::dropEventPlay( QDropEvent *event, bool b_play )
     /* D&D of a subtitles file, add it on the fly */
     if( mimeData->urls().size() == 1 && THEMIM->getIM()->hasInput() )
     {
-        if( !input_AddSubtitle( THEMIM->getInput(),
-                 qtu( toNativeSeparators( mimeData->urls()[0].toLocalFile() ) ),
-                 true ) )
+        QString s = toNativeSeparators( mimeData->urls()[0].toLocalFile() );
+        if( s.length() > 0
+         && input_AddSubtitle( THEMIM->getInput(), qtu(s), true ) == 0 )
         {
             event->accept();
             return;