]> git.sesse.net Git - vlc/commitdiff
growl: fix pontential use after free (var_delcallbacl called to late).
authorRémi Duraffort <ivoire@videolan.org>
Sun, 28 Mar 2010 15:18:39 +0000 (17:18 +0200)
committerRémi Duraffort <ivoire@videolan.org>
Sun, 28 Mar 2010 15:18:39 +0000 (17:18 +0200)
modules/misc/notify/growl.m

index 52ad6f9043d9071deba0bf38bdd01e0426d02d4a..71ecdd1033e078797f4c26102bf55b7b56210358 100644 (file)
@@ -134,13 +134,13 @@ static void Close( vlc_object_t *p_this )
 {
     intf_sys_t *p_sys = ((intf_thread_t*)p_this)->p_sys;
 
+    var_DelCallback( pl_Get( p_this ), "item-current", ItemChange, p_this );
+
     CFRelease( p_sys->default_icon );
     CFRelease( p_sys->app_name );
     CFRelease( p_sys->notification_type );
     [p_sys->p_pool release];
     free( p_sys );
-
-    var_DelCallback( pl_Get( p_this ), "item-current", ItemChange, p_this );
 }
 
 /*****************************************************************************