/* URL / URI */
psz_meta = input_item_GetURL( p_item );
if( !EMPTY_STR( psz_meta ) )
- emit uriSet( QString( psz_meta ) );
+ emit uriSet( psz_meta );
else
{
free( psz_meta );
psz_meta = input_item_GetURI( p_item );
if( !EMPTY_STR( psz_meta ) )
- emit uriSet( QString( psz_meta ) );
+ emit uriSet( psz_meta );
}
free( psz_meta );
void enterEditMode();
signals:
- void uriSet( QString );
+ void uriSet( const QString& );
void editing();
};
backgroundLayout->setColumnStretch( 2, 1 );
CONNECT( THEMIM->getIM(), artChanged( QString ),
- this, updateArt( QString ) );
+ this, updateArt( const QString& ) );
}
BackgroundWidget::~BackgroundWidget()
label->show();
}
-void BackgroundWidget::updateArt( QString url )
+void BackgroundWidget::updateArt( const QString& url )
{
if( url.isEmpty() )
{
setContextMenuPolicy( Qt::ActionsContextMenu );
CONNECT( this, updateRequested(), this, doUpdate() );
CONNECT( THEMIM->getIM(), artChanged( QString ),
- this, doUpdate( QString ) );
+ this, doUpdate( const QString& ) );
setMinimumHeight( 128 );
setMinimumWidth( 128 );
removeAction( act );
}
-void CoverArtLabel::doUpdate( QString url )
+void CoverArtLabel::doUpdate( const QString& url )
{
QPixmap pix;
if( !url.isEmpty() && pix.load( url ) )
public slots:
void toggle(){ TOGGLEV( this ); }
- void updateArt( QString );
+ void updateArt( const QString& );
};
#if 0
private slots:
void doUpdate();
- void doUpdate(QString);
+ void doUpdate( const QString& );
signals:
void updateRequested();
#include <QCheckBox>
ConvertDialog::ConvertDialog( QWidget *parent, intf_thread_t *_p_intf,
- QString inputMRL )
+ const QString& inputMRL )
: QVLCDialog( parent, _p_intf )
{
setWindowTitle( qtr( "Convert" ) );
{
Q_OBJECT;
public:
- ConvertDialog( QWidget *, intf_thread_t *, QString );
+ ConvertDialog( QWidget *, intf_thread_t *, const QString& );
virtual ~ConvertDialog(){}
QString getMrl() {return mrl;}
BUTTONACT( stopShowing, dontShow() );
}
-void ErrorsDialog::addError( QString title, QString text )
+void ErrorsDialog::addError( const QString& title, const QString& text )
{
add( true, title, text );
}
add( false, title, text );
}*/
-void ErrorsDialog::add( bool error, QString title, QString text )
+void ErrorsDialog::add( bool error, const QString& title, const QString& text )
{
if( stopShowing->isChecked() ) return;
messages->textCursor().movePosition( QTextCursor::End );
}
virtual ~ErrorsDialog() {};
- void addError( QString, QString );
+ void addError( const QString&, const QString& );
/*void addWarning( QString, QString );*/
private:
ErrorsDialog( QWidget *parent, intf_thread_t * );
static ErrorsDialog *instance;
- void add( bool, QString, QString );
+ void add( bool, const QString&, const QString& );
QCheckBox *stopShowing;
QTextEdit *messages;
BUTTONACT( saveMetaButton, saveMeta() );
/* Let the MetaData Panel update the URI */
- CONNECT( MP, uriSet( QString ), uriLine, setText( QString ) );
+ CONNECT( MP, uriSet( const QString& ), uriLine, setText( const QString& ) );
CONNECT( MP, editing(), saveMetaButton, show() );
/* Display the buttonBar according to the Tab selected */
CONNECT( ui.Tab, currentChanged( int ), this, signalCurrent( int ) );
CONNECT( fileOpenPanel, mrlUpdated( QStringList, QString ),
- this, updateMRL( QStringList, QString ) );
+ this, updateMRL( const QStringList&, const QString& ) );
CONNECT( netOpenPanel, mrlUpdated( QStringList, QString ),
- this, updateMRL( QStringList, QString ) );
+ this, updateMRL( const QStringList&, const QString& ) );
CONNECT( discOpenPanel, mrlUpdated( QStringList, QString ),
- this, updateMRL( QStringList, QString ) );
+ this, updateMRL( const QStringList&, const QString& ) );
CONNECT( captureOpenPanel, mrlUpdated( QStringList, QString ),
- this, updateMRL( QStringList, QString ) );
+ this, updateMRL( const QStringList&, const QString& ) );
CONNECT( fileOpenPanel, methodChanged( QString ),
- this, newCachingMethod( QString ) );
+ this, newCachingMethod( const QString& ) );
CONNECT( netOpenPanel, methodChanged( QString ),
- this, newCachingMethod( QString ) );
+ this, newCachingMethod( const QString& ) );
CONNECT( discOpenPanel, methodChanged( QString ),
- this, newCachingMethod( QString ) );
+ this, newCachingMethod( const QString& ) );
CONNECT( captureOpenPanel, methodChanged( QString ),
- this, newCachingMethod( QString ) );
+ this, newCachingMethod( const QString& ) );
/* Advanced frame Connects */
CONNECT( ui.slaveCheckbox, toggled( bool ), this, updateMRL() );
}
/* Update the MRL */
-void OpenDialog::updateMRL( QStringList item, QString tempMRL )
+void OpenDialog::updateMRL( const QStringList& item, const QString& tempMRL )
{
optionsMRL = tempMRL;
itemsMRL = item;
ui.mrlLine->setText( itemsMRL.join( " " ) );
}
-void OpenDialog::newCachingMethod( QString method )
+void OpenDialog::newCachingMethod( const QString& method )
{
if( method != storedMethod ) {
storedMethod = method;
}
}
-QStringList OpenDialog::SeparateEntries( QString entries )
+QStringList OpenDialog::SeparateEntries( const QString& entries )
{
bool b_quotes_mode = false;
int i_action_flag;
bool b_pl;
- QStringList SeparateEntries( QString );
+ QStringList SeparateEntries( const QString& );
QPushButton *cancelButton, *selectButton;
QPushButton *playButton;
void cancel();
void close();
void toggleAdvancedPanel();
- void updateMRL( QStringList, QString );
+ void updateMRL( const QStringList&, const QString& );
void updateMRL();
- void newCachingMethod( QString );
+ void newCachingMethod( const QString& );
void signalCurrent( int );
void browseInputSlave();
};
layout->addWidget( label, 1, 0 );
layout->addWidget( edit, 1, 1, 1, -1 );
CONNECT( edit, textChanged( QString ),
- this, search( QString ) );
+ this, search( const QString& ) );
QDialogButtonBox *box = new QDialogButtonBox;
QPushButton *okButton = new QPushButton( qtr( "&Close" ), this );
}
}
-void PluginDialog::search( const QString qs )
+void PluginDialog::search( const QString& qs )
{
QList<QTreeWidgetItem *> items = treePlugins->findItems( qs, Qt::MatchContains );
items += treePlugins->findItems( qs, Qt::MatchContains, 1 );
QTreeWidget *treePlugins;
SearchLineEdit *edit;
private slots:
- void search( const QString );
+ void search( const QString& );
};
#endif
#include <QFileDialog>
#include <QToolButton>
-SoutDialog::SoutDialog( QWidget *parent, intf_thread_t *_p_intf, QString inputMRL )
+SoutDialog::SoutDialog( QWidget *parent, intf_thread_t *_p_intf, const QString& inputMRL )
: QVLCDialog( parent, _p_intf )
{
setWindowTitle( qtr( "Stream Output" ) );
{
Q_OBJECT;
public:
- SoutDialog( QWidget* parent, intf_thread_t *, QString mrl = "");
+ SoutDialog( QWidget* parent, intf_thread_t *, const QString& mrl = "");
virtual ~SoutDialog(){}
QString getMrl(){ return mrl; }
* to propagate there too
*/
DroppingController::DroppingController( intf_thread_t *_p_intf,
- QString line,
+ const QString& line,
QWidget *_parent )
: AbstractController( _p_intf, _parent )
{
parseAndCreate( line, controlLayout );
}
-void DroppingController::resetLine( QString line )
+void DroppingController::resetLine( const QString& line )
{
hide();
QLayoutItem *child;
{
Q_OBJECT;
public:
- DroppingController( intf_thread_t *, QString line, QWidget *parent = 0 );
+ DroppingController( intf_thread_t *, const QString& line, QWidget *parent = 0 );
QString getValue();
virtual ~DroppingController();
- void resetLine( QString );
+ void resetLine( const QString& );
protected:
virtual void createAndAddWidget( QBoxLayout *controlLayout, int i_index,
buttonType_e i_type, int i_option );