Add a secret --user-agent option to pass the application name

Currently, this is not used anywhere, but better have it for forward
compatibility. This is not as elegant as a dedicated libvlc function
call. But there is no other way to set a parameter before
libvlc_InternalInit() is called by libvlc_new(), short of changing the
libvlc_new() prototype (again). And that would probably be worse.

diff --git a/bin/vlc.c b/bin/vlc.c
index a77142419460a97040115ff2be5217960f9dc3d6..447b808d5438cf2e85f88cddc8a557dbac57ed82 100644 (file)
--- a/bin/vlc.c
+++ b/bin/vlc.c
@@ -154,10 +154,11 @@ int main( int i_argc, const char *ppsz_argv[] )
     sigdelset (&set, SIGCHLD);
 
     /* Note that FromLocale() can be used before libvlc is initialized */
-    const char *argv[i_argc + 3];
+    const char *argv[i_argc + 4];
     int argc = 0;
 
     argv[argc++] = "--no-ignore-config";
+    argv[argc++] = "--user-agent=\"VLC media player\"";
 #ifdef TOP_BUILDDIR
     argv[argc++] = FromLocale ("--plugin-path="TOP_BUILDDIR"/modules");
 #endif

diff --git a/src/libvlc-module.c b/src/libvlc-module.c
index bfcc201cb2d36b826019bf4b6d8e992ab0d9bc8a..ee131aeb7a660558308b6679ade5f1d1507c5d7d 100644 (file)
--- a/src/libvlc-module.c
+++ b/src/libvlc-module.c
@@ -2052,6 +2052,10 @@ vlc_module_begin ()
                    DATA_PATH_LONGTEXT, true )
         change_need_restart ()
 
+    add_string( "user-agent", "(LibVLC "VERSION")", NULL, "", "", true )
+        change_safe ()
+        change_private ()
+
     set_section( N_("Performance options"), NULL )
     add_obsolete_bool( "minimize-threads" )