]> git.sesse.net Git - vlc/commitdiff
qt4: Forgotten lock. Reported by ahoka.
authorPierre d'Herbemont <pdherbemont@videolan.org>
Wed, 16 Jul 2008 21:46:30 +0000 (23:46 +0200)
committerPierre d'Herbemont <pdherbemont@videolan.org>
Wed, 16 Jul 2008 21:46:30 +0000 (23:46 +0200)
Anyway this is broken, qt4 shouldn't assume that the playlist_item_t can't be deleted. We need to implement refcounting here, or a sound garbage collection. Refcounting would be safer.

modules/gui/qt4/components/playlist/playlist.cpp

index fcc6d2df72301f0556486923c694f9c0d427cbc6..1403fc0ab76aa002d8aff35cd9663875142cb134 100644 (file)
@@ -79,8 +79,10 @@ PlaylistWidget::PlaylistWidget( intf_thread_t *_p_i,
     leftW->addWidget( artContainer );
 
     /* Initialisation of the playlist */
+    PL_LOCK;
     playlist_item_t *p_root =
                   playlist_GetPreferredNode( THEPL, THEPL->p_local_category );
+    PL_UNLOCK;
 
     rightPanel = new StandardPLPanel( this, p_intf, THEPL, p_root );