]> git.sesse.net Git - vlc/commitdiff
macosx: Remove a weird already_locked bool. (that removes a runtime warning from...
authorPierre d'Herbemont <pdherbemont@videolan.org>
Sun, 6 Jul 2008 19:34:24 +0000 (21:34 +0200)
committerPierre d'Herbemont <pdherbemont@videolan.org>
Sun, 6 Jul 2008 19:36:03 +0000 (21:36 +0200)
modules/gui/macosx/embeddedwindow.h
modules/gui/macosx/embeddedwindow.m

index a300538294a29b7cb924f433d62c1c6f362533e4..39da8e9d6b9e670188d9af6978b75397810c3d30 100644 (file)
@@ -48,7 +48,6 @@
     NSView          * o_temp_view;
     /* set to yes if we are fullscreen and all animations are over */
     BOOL              b_fullscreen;
-    BOOL              b_animation_lock_alreadylocked;
     NSRecursiveLock * o_animation_lock;
 }
 
index 582f8ac7c9d6d4c19287f6e57524049c25b29255..4ce60e655c601168d7573930f2b10048f250d38b 100644 (file)
     /* Not fullscreen when we wake up */
     [o_btn_fullscreen setState: NO];
     b_fullscreen = NO;
-    /* Use a recursive lock to be able to trigger enter/leavefullscreen
-     * in middle of an animation, providing that the enter/leave functions
-     * are called from the same thread */
-    o_animation_lock = [[NSRecursiveLock alloc] init];
-    b_animation_lock_alreadylocked = NO;
 }
 
 - (void)controlTintChanged
     {
         /* We were already fullscreen nothing to do when NSAnimation
          * is not supported */
-        b_animation_lock_alreadylocked = NO;
         [self unlockFullscreenAnimation];
         return;
     }
     {
         /* Make sure we are hidden */
         [super orderOut: self];
-        b_animation_lock_alreadylocked = NO;
         [self unlockFullscreenAnimation];
         return;
     }
         [o_fullscreen_anim2 release];
     }
  
-     /* This is a recursive lock. If we are already in the middle of an animation we
-     * unlock it. We don't add an extra locking here, because enter/leavefullscreen
-     * are executed always in the same thread */
-    if (b_animation_lock_alreadylocked)
-        [self unlockFullscreenAnimation];
-    b_animation_lock_alreadylocked = YES;
-
     if ([screen isMainScreen])
         SetSystemUIMode( kUIModeAllHidden, kUIOptionAutoShowMenuBar);
 
     /* Don't do anything if o_fullscreen_window is already closed */
     if (!o_fullscreen_window)
     {
-        b_animation_lock_alreadylocked = NO;
         [self unlockFullscreenAnimation];
         return;
     }
         [o_fullscreen_anim2 release];
     }
 
-    /* This is a recursive lock. If we are already in the middle of an animation we
-     * unlock it. We don't add an extra locking here, because enter/leavefullscreen
-     * are executed always in the same thread */
-    if (b_animation_lock_alreadylocked)
-        [self unlockFullscreenAnimation];
-    b_animation_lock_alreadylocked = YES;
-
     frame = [[o_temp_view superview] convertRect: [o_temp_view frame] toView: nil]; /* Convert to Window base coord */
     frame.origin.x += [self frame].origin.x;
     frame.origin.y += [self frame].origin.y;
 
     [o_fullscreen_window release];
     o_fullscreen_window = nil;
-    b_animation_lock_alreadylocked = NO;
     [self unlockFullscreenAnimation];
 }