]> git.sesse.net Git - vlc/log
vlc
15 years agoFix previous commit
Rémi Denis-Courmont [Sun, 29 Jun 2008 20:21:53 +0000 (23:21 +0300)]
Fix previous commit

15 years agoCosmetics
Rémi Denis-Courmont [Sun, 29 Jun 2008 20:16:18 +0000 (23:16 +0300)]
Cosmetics

15 years agoAdded reget_buffer implementation for correct PTS for codec using it.
Laurent Aimar [Sun, 29 Jun 2008 19:08:20 +0000 (19:08 +0000)]
Added reget_buffer implementation for correct PTS for codec using it.
This allows playing of MS Video 1 file but it is not yet correct because
of the way VLC handles RGB (it won't work on big endian, and the colors
seem broken).

15 years agoAdd dirac video support to the ogg demuxer
Jonathan Rosser [Thu, 26 Jun 2008 17:04:48 +0000 (18:04 +0100)]
Add dirac video support to the ogg demuxer

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years agots demux: add support for dirac streams via registration_descriptor
David Flynn [Wed, 25 Jun 2008 12:44:58 +0000 (12:44 +0000)]
ts demux: add support for dirac streams via registration_descriptor

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years agoRTP: avoid loosing the first received packet
Rémi Denis-Courmont [Sun, 29 Jun 2008 17:41:33 +0000 (20:41 +0300)]
RTP: avoid loosing the first received packet

15 years agoCheck against too low sample rate and 0 channel count (avoid division by 0)
Laurent Aimar [Sun, 29 Jun 2008 16:23:12 +0000 (16:23 +0000)]
Check against too low sample rate and 0 channel count (avoid division by 0)

15 years agoCheck against 0 sample rate (returned by ffmpeg).
Laurent Aimar [Sun, 29 Jun 2008 16:22:19 +0000 (16:22 +0000)]
Check against 0 sample rate (returned by ffmpeg).

15 years agoschroedinger: fix warnings
Rémi Denis-Courmont [Sun, 29 Jun 2008 15:22:43 +0000 (18:22 +0300)]
schroedinger: fix warnings

15 years agoFix corner case memory leak
Rémi Denis-Courmont [Sun, 29 Jun 2008 15:21:10 +0000 (18:21 +0300)]
Fix corner case memory leak

15 years agoAnnounce libschroedinger support
Rémi Denis-Courmont [Sun, 29 Jun 2008 15:20:36 +0000 (18:20 +0300)]
Announce libschroedinger support

15 years agoIntroduce new codec module to decode dirac video via libschroedinger
Jonathan Rosser [Fri, 27 Jun 2008 16:17:16 +0000 (17:17 +0100)]
Introduce new codec module to decode dirac video via libschroedinger

Schroedinger is a fast decoder of the Dirac video codec.  This plugin
is currently the most complete dirac decoder (compared with ffmpeg or
codec/dirac.c) and should ideally be used in preference

- Input data blocks are handed over to schro which eventually free's them
  (avoids memcpy).  Freed by SchroBufferFree()
- Share picture storage between schro and vlc -- avoids memcpy of picture
  data after decoding.  Freed by SchroFrameFree()
- Autodetection of libschroedinger in configure.ac
  May be disabled with --disable-schroedinger
- Bumped decoding priority to 200, to beat libavcodec.c and dirac.c,
  this module does a better job than either of them.

- Remove potential memory leak when allocating pictures
- Always use p_block rather than priv in SchroBufferFree
- Performs pts interpolation for streams that do not have one pts per picture
- Set progressive, top_field_first and nb_fields on picture_t's properly
- Fix copyright date in header
- Reorder picture_pts_t structure for efficiency
- Print 64 bit types correctly with "%"PRId64
- No need to p_buffer->i_buffer=0 before buffer_Release()
- Work around schroedinger's lack of handling multiple parseunits per block
- Work around corrupt data produced by demux/ts.c after discontinuity
- Correctly reset decoder at Dirac END_OF_SEQUENCE
- Split decoding loop into two parts:
   - First, injecting [valid] parse units into the decoder
   - Second, itterating the decoder

Signed-off-by: David Flynn <davidf@woaf.net>
Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years agofailing test for libvlc_media_list_player added
Filippo Carone [Sun, 29 Jun 2008 12:34:55 +0000 (14:34 +0200)]
failing test for libvlc_media_list_player added

15 years ago*cough*
Felix Paul Kühne [Sat, 28 Jun 2008 22:37:29 +0000 (00:37 +0200)]
*cough*

15 years agoDon't try to use 10.5-only threading features on a 10.4u target. Fixes #1614 on OS X.
Felix Paul Kühne [Sat, 28 Jun 2008 22:34:37 +0000 (00:34 +0200)]
Don't try to use 10.5-only threading features on a 10.4u target. Fixes #1614 on OS X.

15 years agoDo not delete input variable, only remove callbacks (and all of them).
Laurent Aimar [Sat, 28 Jun 2008 22:20:12 +0000 (22:20 +0000)]
Do not delete input variable, only remove callbacks (and all of them).
Otherwise, every one would have to check the return value of var_Get ...

15 years agoSimplify.
Antoine Cellerier [Sat, 28 Jun 2008 22:20:01 +0000 (00:20 +0200)]
Simplify.

15 years agoFixed segfault when parsing wav file to check for dts/a52.
Laurent Aimar [Sat, 28 Jun 2008 22:12:00 +0000 (22:12 +0000)]
Fixed segfault when parsing wav file to check for dts/a52.

15 years agoFixed segfault on corrupted wav file.
Laurent Aimar [Sat, 28 Jun 2008 22:09:27 +0000 (22:09 +0000)]
Fixed segfault on corrupted wav file.

15 years agoRemove trailing spaces.
Antoine Cellerier [Sat, 28 Jun 2008 22:04:43 +0000 (00:04 +0200)]
Remove trailing spaces.

15 years agoFixed buffer size computation with non zero bits per sample mod 8.
Laurent Aimar [Sat, 28 Jun 2008 22:03:31 +0000 (22:03 +0000)]
Fixed buffer size computation with non zero bits per sample mod 8.

15 years agoFixed invalid unlock on invalid audio format.
Laurent Aimar [Sat, 28 Jun 2008 21:59:48 +0000 (21:59 +0000)]
Fixed invalid unlock on invalid audio format.

15 years agoDon't assert.
Antoine Cellerier [Sat, 28 Jun 2008 21:58:29 +0000 (23:58 +0200)]
Don't assert.

15 years agowav: fix integer underflow
Rémi Denis-Courmont [Sat, 28 Jun 2008 11:10:15 +0000 (14:10 +0300)]
wav: fix integer underflow
(cherry picked from commit 105335dd73917555335c03460aaa67fcdb9d4a55)

15 years agowav: fix integer overflow (CVE-2008-2430)
Rémi Denis-Courmont [Sat, 28 Jun 2008 11:00:57 +0000 (14:00 +0300)]
wav: fix integer overflow (CVE-2008-2430)

When i_size is sufficiently large, we would overflow malloc(), and then
overwrite the heap with stream_Read().

Bug reported by: Alin Rad Pop, Secunia Research.

(cherry-picked from commit 95e2f0ff579a5b987cbde9454aa1fc86080528e2)

15 years agoFixed use of freed memory every time rtmp access is probed/used.
Laurent Aimar [Sat, 28 Jun 2008 21:40:12 +0000 (21:40 +0000)]
Fixed use of freed memory every time rtmp access is probed/used.
(for example, on invalid file ...)

15 years agoCheck malloc return value.
Rémi Duraffort [Sat, 28 Jun 2008 21:33:03 +0000 (23:33 +0200)]
Check malloc return value.

15 years agofix error: lua playlist warning: Error while runing script
Ilkka Ollakka [Sat, 28 Jun 2008 21:22:21 +0000 (00:22 +0300)]
fix error: lua playlist warning: Error while runing script
   share/lua/meta/googleimage.lua, function fetch_art(): share/lua/meta/googleimage.lua:43: calling
   'stream' on bad self (string expected, got table)

15 years agoFix memleak when the codec can't be loaded.
Rémi Duraffort [Sat, 28 Jun 2008 21:14:41 +0000 (23:14 +0200)]
Fix memleak when the codec can't be loaded.

15 years agoNo need to patch FFmpeg's MMX code if we are on Darwin-ppc
Felix Paul Kühne [Sat, 28 Jun 2008 21:12:05 +0000 (23:12 +0200)]
No need to patch FFmpeg's MMX code if we are on Darwin-ppc

15 years agoDon't leak an object in case of an error.
Rémi Duraffort [Sat, 28 Jun 2008 21:03:03 +0000 (23:03 +0200)]
Don't leak an object in case of an error.

15 years agoRemove unused variables.
Rémi Duraffort [Sat, 28 Jun 2008 20:35:49 +0000 (22:35 +0200)]
Remove unused variables.

15 years agoFix compilation warning.
Rémi Duraffort [Sat, 28 Jun 2008 20:30:41 +0000 (22:30 +0200)]
Fix compilation warning.

15 years agoForgot this file
Rémi Denis-Courmont [Sat, 28 Jun 2008 20:02:17 +0000 (23:02 +0300)]
Forgot this file

15 years agoQt4: weak reference the video output...
Rémi Denis-Courmont [Sat, 28 Jun 2008 19:52:16 +0000 (22:52 +0300)]
Qt4: weak reference the video output...

...so we don't try to vout_Control() it after it's been destroyed.
We cannot yield the video output for real either, as it would prevent
it from being destroyed once it is not needed anymore.

15 years agoplaylist: release video outputs *once* - fixes #1593
Rémi Denis-Courmont [Sat, 28 Jun 2008 19:22:00 +0000 (22:22 +0300)]
playlist: release video outputs *once* - fixes #1593

Releasing other thread's references is not a very good idea...

15 years agoVLC_OBJECT_FILTER: remove
Rémi Denis-Courmont [Sat, 28 Jun 2008 18:46:26 +0000 (21:46 +0300)]
VLC_OBJECT_FILTER: remove

15 years agoVLC_OBJECT_DIALOGS: remove
Rémi Denis-Courmont [Sat, 28 Jun 2008 18:36:02 +0000 (21:36 +0300)]
VLC_OBJECT_DIALOGS: remove

15 years agovlc_object_create: assert that the object type is known
Rémi Denis-Courmont [Sat, 28 Jun 2008 18:34:42 +0000 (21:34 +0300)]
vlc_object_create: assert that the object type is known

15 years agoUse sizeof(vlc_object_t) as appropriate
Rémi Denis-Courmont [Sat, 28 Jun 2008 18:31:20 +0000 (21:31 +0300)]
Use sizeof(vlc_object_t) as appropriate

15 years agovout: use vlc_custom_create
Rémi Denis-Courmont [Sat, 28 Jun 2008 18:22:24 +0000 (21:22 +0300)]
vout: use vlc_custom_create

15 years agovlc_pthread_fatal: fix error message
Rémi Denis-Courmont [Sat, 28 Jun 2008 17:43:51 +0000 (20:43 +0300)]
vlc_pthread_fatal: fix error message

The error message was overriden to "Illegal seek"

15 years agoTypo
Rémi Denis-Courmont [Sat, 28 Jun 2008 17:25:33 +0000 (20:25 +0300)]
Typo

15 years agoRemove completely useless mutex
Rémi Denis-Courmont [Sat, 28 Jun 2008 17:23:37 +0000 (20:23 +0300)]
Remove completely useless mutex

15 years agoAvoid dummy error
Rémi Denis-Courmont [Sat, 28 Jun 2008 17:15:07 +0000 (20:15 +0300)]
Avoid dummy error

15 years agoRemove unused variable
Rémi Denis-Courmont [Sat, 28 Jun 2008 17:15:01 +0000 (20:15 +0300)]
Remove unused variable

15 years agoWe don't need the vlc_mutex_lock here.
Rémi Duraffort [Sat, 28 Jun 2008 17:00:05 +0000 (19:00 +0200)]
We don't need the vlc_mutex_lock here.

15 years agoMove intf-popupmenu and video-on-top variables from playlist to libvlc.
Antoine Cellerier [Sat, 28 Jun 2008 17:02:05 +0000 (19:02 +0200)]
Move intf-popupmenu and video-on-top variables from playlist to libvlc.
Should fix assertion errors.

15 years agoSmall fixes for ts_mux
Kaloyan Kovachev [Fri, 27 Jun 2008 11:00:49 +0000 (14:00 +0300)]
Small fixes for ts_mux

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years agoFix a few bugs in mosaic bridge.
Antoine Cellerier [Sat, 28 Jun 2008 14:09:05 +0000 (16:09 +0200)]
Fix a few bugs in mosaic bridge.

15 years agoRemove abusive error message
Rémi Denis-Courmont [Sat, 28 Jun 2008 12:36:38 +0000 (15:36 +0300)]
Remove abusive error message

15 years agoChunkFind: fix skipping very large chunks
Rémi Denis-Courmont [Sat, 28 Jun 2008 10:32:07 +0000 (13:32 +0300)]
ChunkFind: fix skipping very large chunks

15 years agouint is not standard (and breaks Win32) - use unsigned
Rémi Denis-Courmont [Sat, 28 Jun 2008 10:07:02 +0000 (13:07 +0300)]
uint is not standard (and breaks Win32) - use unsigned

15 years agoRemove unused parameter
Rémi Denis-Courmont [Sat, 28 Jun 2008 09:56:26 +0000 (12:56 +0300)]
Remove unused parameter

15 years agoFix format string
Rémi Denis-Courmont [Sat, 28 Jun 2008 09:53:35 +0000 (12:53 +0300)]
Fix format string

15 years agoFix function name clash
Rémi Denis-Courmont [Sat, 28 Jun 2008 09:49:56 +0000 (12:49 +0300)]
Fix function name clash

15 years agoABI break
Rémi Denis-Courmont [Sat, 28 Jun 2008 09:46:56 +0000 (12:46 +0300)]
ABI break

15 years agoUse the Scaletempo audio filter
Rov Juvano [Sun, 22 Jun 2008 16:09:27 +0000 (12:09 -0400)]
Use the Scaletempo audio filter

Scaletempo maintains the audio pitch when playback rate != 1.0 (i.e.
no chipmunk effect).  This fixes the pitch scaling caused by using the
resampler to handle playback rate.

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years agoAdd Scaletempo audio filter
Rov Juvano [Sun, 22 Jun 2008 16:09:27 +0000 (12:09 -0400)]
Add Scaletempo audio filter

Scaletempo maintains the audio pitch when playback rate != 1.0 (i.e.
no chipmunk effect).  This fixes the pitch scaling caused by using the
resampler to handle playback rate.

Ported from GStreamer.  Inspired by SoundTouch library by Olli Parviainen.

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>
15 years ago__EVEN: expansion-safety
Rémi Denis-Courmont [Sat, 28 Jun 2008 09:37:05 +0000 (12:37 +0300)]
__EVEN: expansion-safety

15 years agoNo reason to not use $(HOSTCONF) when possible.
Jean-Baptiste Kempf [Sat, 28 Jun 2008 06:48:14 +0000 (23:48 -0700)]
No reason to not use $(HOSTCONF) when possible.

15 years agoFix previous commit.
Jean-Baptiste Kempf [Sat, 28 Jun 2008 06:10:52 +0000 (23:10 -0700)]
Fix previous commit.

Stop the drinking... Sorry about that.

15 years agoHeaders for newer libdvdread have moved :D
Jean-Baptiste Kempf [Sat, 28 Jun 2008 06:00:52 +0000 (23:00 -0700)]
Headers for newer libdvdread have moved :D

15 years agodvdread headers can be in libdvdread now...
Jean-Baptiste Kempf [Sat, 28 Jun 2008 04:57:29 +0000 (06:57 +0200)]
dvdread headers can be in libdvdread now...

15 years agoDon't use a revision of FFmpeg with broken .pc... HEAD .pc seems to be
Jean-Baptiste Kempf [Sat, 28 Jun 2008 03:56:17 +0000 (05:56 +0200)]
Don't use a revision of FFmpeg with broken .pc... HEAD .pc seems to be
fixed.

15 years agoDon't make liba52 inside ffmpeg. What is the point.
Jean-Baptiste Kempf [Sat, 28 Jun 2008 03:54:30 +0000 (05:54 +0200)]
Don't make liba52 inside ffmpeg. What is the point.

15 years agoMrraaaah at dirac 0.10 when crosscompiling. A bit sharp but works.
Jean-Baptiste Kempf [Sat, 28 Jun 2008 00:48:55 +0000 (02:48 +0200)]
Mrraaaah at dirac 0.10 when crosscompiling. A bit sharp but works.

15 years agoLibdvdnav using HEAD.
Jean-Baptiste Kempf [Fri, 27 Jun 2008 23:56:59 +0000 (01:56 +0200)]
Libdvdnav using HEAD.

15 years agoLibdvdread compile fix.
Jean-Baptiste Kempf [Fri, 27 Jun 2008 23:40:18 +0000 (01:40 +0200)]
Libdvdread compile fix.

15 years agoUse libdvdread fork on the libdvdnav SVN.
Jean-Baptiste Kempf [Fri, 27 Jun 2008 23:32:50 +0000 (01:32 +0200)]
Use libdvdread fork on the libdvdnav SVN.

15 years agoContrib: add libschroedinger. Add some patches that would be dropped on next
Pavlov Konstantin [Mon, 23 Jun 2008 20:31:48 +0000 (00:31 +0400)]
Contrib: add libschroedinger. Add some patches that would be dropped on next
libschroedinger release.
Contrib: fix fluidsynth distclean target.

15 years agoNEWS: tell users about glide removal.
Pavlov Konstantin [Fri, 20 Jun 2008 20:56:04 +0000 (00:56 +0400)]
NEWS: tell users about glide removal.

15 years agouse strcasestr in input_MetaMatch too, so search is really case insensitive.
Ilkka Ollakka [Fri, 27 Jun 2008 14:23:54 +0000 (17:23 +0300)]
use strcasestr in input_MetaMatch too, so search is really case insensitive.

15 years agoCheck some invalid uses of pl_Yield()
Rémi Denis-Courmont [Fri, 27 Jun 2008 15:43:15 +0000 (18:43 +0300)]
Check some invalid uses of pl_Yield()

15 years agoRemove video output when input stops - fixes #1637
Rémi Denis-Courmont [Fri, 27 Jun 2008 15:31:27 +0000 (18:31 +0300)]
Remove video output when input stops - fixes #1637

15 years agoAdd dirac to the list of ffmpeg codecs (enabled decoding of raw dirac video).
Antoine Cellerier [Fri, 27 Jun 2008 14:03:58 +0000 (16:03 +0200)]
Add dirac to the list of ffmpeg codecs (enabled decoding of raw dirac video).

15 years agoDon't segfault when looking for art with the lua scripts. Thanks to ILEoo for spoting...
Antoine Cellerier [Fri, 27 Jun 2008 11:29:10 +0000 (13:29 +0200)]
Don't segfault when looking for art with the lua scripts. Thanks to ILEoo for spoting the bug.

15 years agoDon't release vout if it ain't present (eg. when audio is playing and
Ilkka Ollakka [Fri, 27 Jun 2008 11:29:41 +0000 (14:29 +0300)]
Don't release vout if it ain't present (eg. when audio is playing and
background image is only visible).

15 years agogive playlist to vlclua_playlist_add_internal instead of NULL, core doesn't like
Ilkka Ollakka [Fri, 27 Jun 2008 11:15:36 +0000 (14:15 +0300)]
give playlist to vlclua_playlist_add_internal instead of NULL, core doesn't like
NULL as playlist. fixes eg. youtube usage for me. Thou not sure if this
could be done some better way.

15 years agoFix warning
Rémi Denis-Courmont [Thu, 26 Jun 2008 16:05:13 +0000 (19:05 +0300)]
Fix warning

15 years agoWarn about buggy X11 connections
Rémi Denis-Courmont [Thu, 26 Jun 2008 16:00:37 +0000 (19:00 +0300)]
Warn about buggy X11 connections

15 years agoRemove unused variable
Rémi Denis-Courmont [Thu, 26 Jun 2008 15:54:05 +0000 (18:54 +0300)]
Remove unused variable

15 years agoBump version
Rémi Denis-Courmont [Thu, 26 Jun 2008 15:39:38 +0000 (18:39 +0300)]
Bump version

15 years agoRemove dummy $Id$
Rémi Denis-Courmont [Thu, 26 Jun 2008 15:38:55 +0000 (18:38 +0300)]
Remove dummy $Id$

15 years agoMerge branch 'master' of git@git.videolan.org:vlc
Ilkka Ollakka [Thu, 26 Jun 2008 07:38:53 +0000 (10:38 +0300)]
Merge branch 'master' of git@git.videolan.org:vlc

15 years agoSet strict-rc functionality as default if user hasn't
Ilkka Ollakka [Thu, 26 Jun 2008 07:32:52 +0000 (10:32 +0300)]
Set strict-rc functionality as default if user hasn't
defined quality based encoding, and remove strict-rc option
because it's not needed ( thou maybe someone needs vbr-transcoding
with some hint of bitrate without quality-based encoding ? )

Should fix transcoding bitrate bug and close ticket #1463

15 years agoFix hidding of fullscreen controller after leaving fullscreen
Lukas Durfina [Wed, 25 Jun 2008 12:25:44 +0000 (14:25 +0200)]
Fix hidding of fullscreen controller after leaving fullscreen

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
15 years agoA few OS X related clarifications and updates
Felix Paul Kühne [Wed, 25 Jun 2008 23:53:46 +0000 (01:53 +0200)]
A few OS X related clarifications and updates

15 years agoRemove Unicows.
Jean-Baptiste Kempf [Wed, 25 Jun 2008 20:54:04 +0000 (13:54 -0700)]
Remove Unicows.

If you don't like it, repair it or fork it :D
Or install debian. :D

15 years agoWin98 is dead.
Jean-Baptiste Kempf [Wed, 25 Jun 2008 20:52:55 +0000 (13:52 -0700)]
Win98 is dead.

15 years agoFix the update system now we can't close vlc and stop the download correctly.
Rémi Duraffort [Wed, 25 Jun 2008 20:38:44 +0000 (22:38 +0200)]
Fix the update system now we can't close vlc and stop the download correctly.
Should fixe #1635

15 years agoFix the update system, based on funman patch + some modifications.
Rémi Duraffort [Wed, 25 Jun 2008 19:54:20 +0000 (21:54 +0200)]
Fix the update system, based on funman patch + some modifications.

15 years agoWindows 98 is dead.
Jean-Baptiste Kempf [Wed, 25 Jun 2008 19:53:43 +0000 (12:53 -0700)]
Windows 98 is dead.

If you are unpleased about that, fix the core (threading and networking).

15 years agoMerge branch 'master' of git@git.videolan.org:vlc
Jean-Baptiste Kempf [Wed, 25 Jun 2008 19:49:51 +0000 (12:49 -0700)]
Merge branch 'master' of git@git.videolan.org:vlc

15 years agoNEWS and THANKS.
Jean-Baptiste Kempf [Wed, 25 Jun 2008 19:48:09 +0000 (12:48 -0700)]
NEWS and THANKS.

Mentions of FS controller and dropping support of old platform.

15 years agoAllow more than one use of the video widget
Rémi Denis-Courmont [Wed, 25 Jun 2008 19:29:49 +0000 (22:29 +0300)]
Allow more than one use of the video widget

However, I suspect the Qt4 interface will break if there is more than
one video output _at_the_same_time_

15 years agoQt4: small memory leak
Rémi Denis-Courmont [Wed, 25 Jun 2008 19:10:27 +0000 (22:10 +0300)]
Qt4: small memory leak

15 years agoRevert "Disable embedded window by default"
Rémi Denis-Courmont [Wed, 25 Jun 2008 19:06:07 +0000 (22:06 +0300)]
Revert "Disable embedded window by default"

This reverts commit 6214852830f1efc761af1181f5d777732efbc758.

15 years agoQt4: restore the fullscreen controller
Rémi Denis-Courmont [Wed, 25 Jun 2008 19:05:44 +0000 (22:05 +0300)]
Qt4: restore the fullscreen controller

15 years agoUse QPointer and QMutexLocker so we don't crash at Qt4 interface exit
Rémi Denis-Courmont [Wed, 25 Jun 2008 18:59:53 +0000 (21:59 +0300)]
Use QPointer and QMutexLocker so we don't crash at Qt4 interface exit