Fix a PHP5 typo.

[xml-template] / php5 / xml-template.php

diff --git a/php5/xml-template.php b/php5/xml-template.php
index 08c78ab57bcaf4998890628303b5790918c7eb99..54d1452dcc9ed2e14ce96b80d1ca66e1a4d57a60 100644 (file)
--- a/php5/xml-template.php
+++ b/php5/xml-template.php
@@ -11,19 +11,19 @@ function XML_Template_process_file($filename, $obj, $clean = 1)
 function XML_Template_process($node, $obj, $clean = 1)
 {
        if (is_a($obj, 'DOMNode')) {                          # overwrite
-               for ($i = 0; $i < $node->childNodes->length; ++$i) {
-                       $child = $node->childNodes->item($i);
+               while ($node->childNodes->length > 0) {
+                       $child = $node->childNodes->item(0);
                        $node->removeChild($child);
                }
 
                if (is_a($obj, 'DOMDocument')) {
-                       $obj = $obj->document_element();
+                       $obj = $obj->documentElement;
                }
 
-               $newobj = own_clone_node($obj, $node->ownerDocument);
-               $node->appendChild($newobj);
-
-               XML_Template_process($newobj, array(), $clean);
+               $frag = $node->ownerDocument->createDocumentFragment();
+               $frag->appendChild($node->ownerDocument->importNode($obj, true));
+               XML_Template_process($frag, array(), $clean);
+               $node->appendChild($frag);
        } else if (!is_array($obj)) {                         # overwrite
                for ($i = 0; $i < $node->childNodes->length; ++$i) {
                        $child = $node->childNodes->item($i);
@@ -43,14 +43,27 @@ function XML_Template_process($node, $obj, $clean = 1)
                                $attrs = $child->attributes;
 
                                if (isset($attrs)) {
+                                       $replace_child = 0;
                                        foreach ($child->attributes as $attr) {
                                                if ($attr->namespaceURI == 'http://template.sesse.net/' && $attr->name == 'id') {
                                                        $id = $attr->value;
                                                        if ($clean) {
                                                                $child->removeAttributeNode($attr);
+                                                               $replace_child = 1;
                                                        }
                                                }
                                        }
+
+                                       # This seems to be the only way to reliably get rid of the excess
+                                       # XML namespace declarations.
+                                       if ($replace_child == 1) {
+                                               $newchild = own_clone_element($child, $child->ownerDocument);
+                                               while ($child->childNodes->length > 0) {
+                                                       $newchild->appendChild($child->firstChild);
+                                               }
+                                               $node->replaceChild($newchild, $child);
+                                               $child = $newchild;
+                                       }
                                }
                        
                                # check all substitutions to see if we found anything
@@ -78,10 +91,11 @@ function XML_Template_process($node, $obj, $clean = 1)
                }
        } else {                                                # repeat
                $doc = $node->ownerDocument;
-               $frag = $doc->createElement("temporary-fragment");    # ugh
+               $frag = $doc->createDocumentFragment();
 
                while ($node->childNodes->length > 0) {
                        $child = $node->childNodes->item(0);
+                       $node->removeChild($child);
                        $frag->appendChild($child);
                }
 
@@ -91,26 +105,13 @@ function XML_Template_process($node, $obj, $clean = 1)
                        }
 
                        $newnode = own_clone_node($frag, $frag->ownerDocument);
-                       $node->appendChild($newnode);
                        XML_Template_process($newnode, $instance, $clean);
+
+                       $node->appendChild($newnode);
                        if ($clean) {
                                XML_Template_clean($newnode);
                        }
                }
-
-               # remove all the <fragment> tags
-               for ($i = 0; $i < $node->childNodes->length; ++$i) {
-                       $child = $node->childNodes->item($i);
-                       if ($child->localName != 'temporary-fragment') {
-                               continue;
-                       }
-                       while ($child->childNodes->length > 0) {
-                               $child2 = $child->childNodes->item(0);
-                               $node->appendChild($child2);
-                       }
-                       --$i;
-                       $node->removeChild($child);
-               }       
        }
 
        if ($clean) {
@@ -153,34 +154,23 @@ function XML_Template_alternate($tag, $array, $elems)
        return $array;
 }
                
-# Ideally, this would be "return $obj->clone_node(true)". But surprise, surprise,
-# PHP is buggy (at least both PHP4 and PHP5); it removes the prefix information
-# from all attributes during a clone. IOW, we'll have to clone evverything
-# ourselves.
+# Ideally, this would be "return $obj->clone_node(true)". But surprise,
+# surprise, PHP is buggy; it does not preserve the prefix information on
+# attributes properly during a clone. (PHP4 and PHP5 are broken in different
+# ways here...) IOW, we'll have to clone everything ourselves.
 function own_clone_node($node, $doc)
 {
        // we only need these two
-       if ($node->nodeType == XML_ELEMENT_NODE) {
-               $nsuri = $node->namespaceURI;
-               if (isset($nsuri)) {
-                       $newnode = $doc->createElementNS($node->namespaceURI, $node->nodeName, $node->prefix);
-               } else {
-                       $newnode = $doc->createElement($node->nodeName);
-               }
-               
-               $attrs = $node->attributes;
-               if (isset($attrs)) {
-                       foreach ($node->attributes as $attr) {
-                               $nsuri = $attr->namespaceURI;
-                               if (isset($nsuri)) {
-                                       $attr2 = $doc->createAttribute($attr->name);
-                               } else {
-                                       $attr2 = $doc->createAttributeNS($nsuri, $attr->prefix . ":" . $attr->name);
-                               }
-                               $attr2->value = $attr->value;
-                               $newnode->appendChild($attr2);
-                       }
+       if ($node->nodeType == XML_DOCUMENT_FRAG_NODE) {
+               $newnode = $doc->createDocumentFragment();
+
+               for ($i = 0; $i < $node->childNodes->length; ++$i) {
+                       $child = $node->childNodes->item($i);
+                       $newnode->appendChild(own_clone_node($child, $doc));
                }
+               return $newnode;
+       } else if ($node->nodeType == XML_ELEMENT_NODE) {
+               $newnode = own_clone_element($node, $doc);
                for ($i = 0; $i < $node->childNodes->length; ++$i) {
                        $child = $node->childNodes->item($i);
                        $newnode->appendChild(own_clone_node($child, $doc));
@@ -190,6 +180,34 @@ function own_clone_node($node, $doc)
                return $node->cloneNode(true);
        }
 }
+               
+function own_clone_element($node, $doc)
+{
+       $nsuri = $node->namespaceURI;
+       if (isset($nsuri) && $node->prefix != "default") {
+               $newnode = $doc->createElementNS($node->namespaceURI, $node->nodeName, $node->prefix);
+       
+               // remove useless empty text child
+               $newnode->removeChild($newnode->firstChild);
+       } else {
+               $newnode = $doc->createElement($node->localName);
+       }
+       
+       $attrs = $node->attributes;
+       if (isset($attrs)) {
+               foreach ($node->attributes as $attr) {
+                       $nsuri = $attr->namespaceURI;
+                       if (isset($nsuri) && $attr->prefix != "default") {
+                               $attr2 = $doc->createAttributeNS($nsuri, $attr->prefix . ":" . $attr->name);
+                       } else {
+                               $attr2 = $doc->createAttribute($attr->localName);
+                       }
+                       $attr2->value = $attr->value;
+                       $newnode->appendChild($attr2);
+               }
+       }
+       return $newnode;
+}
 
 function is_associative_array($arr)
 {