]> git.sesse.net Git - pkanalytics/commitdiff
Remove some repetition.
authorSteinar H. Gunderson <sgunderson@bigfoot.com>
Wed, 26 Jul 2023 22:23:29 +0000 (00:23 +0200)
committerSteinar H. Gunderson <sgunderson@bigfoot.com>
Wed, 26 Jul 2023 22:23:29 +0000 (00:23 +0200)
ultimate.js

index 292534f23dd1f25293c4dad28133d1e0cd4f08bb..27a79b9989db959dc14d35bd56b40ae04de26298 100644 (file)
@@ -750,59 +750,24 @@ function get_chosen_category() {
 
 function write_main_menu(chosen_category) {
        let elems = [];
-       if (chosen_category === 'general') {
-               let span = document.createElement('span');
-               span.innerText = 'General';
-               elems.push(span);
-       } else {
-               let a = document.createElement('a');
-               a.appendChild(document.createTextNode('General'));
-               a.setAttribute('href', '#general');
-               elems.push(a);
-       }
-
-       if (chosen_category === 'offense') {
-               let span = document.createElement('span');
-               span.innerText = 'Offense';
-               elems.push(span);
-       } else {
-               let a = document.createElement('a');
-               a.appendChild(document.createTextNode('Offense'));
-               a.setAttribute('href', '#offense');
-               elems.push(a);
-       }
-
-       if (chosen_category === 'defense') {
-               let span = document.createElement('span');
-               span.innerText = 'Defense';
-               elems.push(span);
-       } else {
-               let a = document.createElement('a');
-               a.appendChild(document.createTextNode('Defense'));
-               a.setAttribute('href', '#defense');
-               elems.push(a);
-       }
-
-       if (chosen_category === 'playing_time') {
-               let span = document.createElement('span');
-               span.innerText = 'Playing time';
-               elems.push(span);
-       } else {
-               let a = document.createElement('a');
-               a.appendChild(document.createTextNode('Playing time'));
-               a.setAttribute('href', '#playing_time');
-               elems.push(a);
-       }
-
-       if (chosen_category === 'per_point') {
-               let span = document.createElement('span');
-               span.innerText = 'Per point';
-               elems.push(span);
-       } else {
-               let a = document.createElement('a');
-               a.appendChild(document.createTextNode('Per point'));
-               a.setAttribute('href', '#per_point');
-               elems.push(a);
+       const categories = [
+               ['general', 'General'],
+               ['offense', 'Offense'],
+               ['defense', 'Defense'],
+               ['playing_time', 'Playing time'],
+               ['per_point', 'Per point']
+       ];
+       for (const [id, title] of categories) {
+               if (chosen_category === id) {
+                       let span = document.createElement('span');
+                       span.innerText = title;
+                       elems.push(span);
+               } else {
+                       let a = document.createElement('a');
+                       a.appendChild(document.createTextNode(title));
+                       a.setAttribute('href', '#' + id);
+                       elems.push(a);
+               }
        }
 
        document.getElementById('mainmenu').replaceChildren(...elems);