]> git.sesse.net Git - stockfish/commitdiff
Simplify functions to read/write network parameters
authorSebastian Buchwald <UniQP@web.de>
Wed, 25 Jan 2023 21:25:18 +0000 (22:25 +0100)
committerJoost VandeVondele <Joost.VandeVondele@gmail.com>
Sat, 28 Jan 2023 15:47:52 +0000 (16:47 +0100)
closes https://github.com/official-stockfish/Stockfish/pull/4358

No functional change

src/nnue/nnue_architecture.h

index c43a23c3f69847133258fa4b25876e8699bfcc03..508f3aae0a7ab18a3551693cff18aedcb682e9e0 100644 (file)
@@ -72,22 +72,20 @@ struct Network
 
   // Read network parameters
   bool read_parameters(std::istream& stream) {
-    if (!fc_0.read_parameters(stream)) return false;
-    if (!ac_0.read_parameters(stream)) return false;
-    if (!fc_1.read_parameters(stream)) return false;
-    if (!ac_1.read_parameters(stream)) return false;
-    if (!fc_2.read_parameters(stream)) return false;
-    return true;
+    return   fc_0.read_parameters(stream)
+          && ac_0.read_parameters(stream)
+          && fc_1.read_parameters(stream)
+          && ac_1.read_parameters(stream)
+          && fc_2.read_parameters(stream);
   }
 
-  // Read network parameters
+  // Write network parameters
   bool write_parameters(std::ostream& stream) const {
-    if (!fc_0.write_parameters(stream)) return false;
-    if (!ac_0.write_parameters(stream)) return false;
-    if (!fc_1.write_parameters(stream)) return false;
-    if (!ac_1.write_parameters(stream)) return false;
-    if (!fc_2.write_parameters(stream)) return false;
-    return true;
+    return   fc_0.write_parameters(stream)
+          && ac_0.write_parameters(stream)
+          && fc_1.write_parameters(stream)
+          && ac_1.write_parameters(stream)
+          && fc_2.write_parameters(stream);
   }
 
   std::int32_t propagate(const TransformedFeatureType* transformedFeatures)