const'ify

diff --git a/src/effectstack/effectstackview2.cpp b/src/effectstack/effectstackview2.cpp
index 45493e3f3279c070d2606b5aab83e8034fdb9469..2b55bbd735638e3ca090ba197751ed04d0157440 100644 (file)
--- a/src/effectstack/effectstackview2.cpp
+++ b/src/effectstack/effectstackview2.cpp
@@ -952,7 +952,7 @@ void EffectStackView2::dropEvent(QDropEvent *event)
     processDroppedEffect(doc.documentElement(), event);
 }
 
-void EffectStackView2::setKeyframes(const QString data, int maximum)
+void EffectStackView2::setKeyframes(const QString &data, int maximum)
 {
     for (int i = 0; i < m_effects.count(); i++) {
         if (m_effects.at(i)->isActive()) {

diff --git a/src/effectstack/effectstackview2.h b/src/effectstack/effectstackview2.h
index 85a2163d18763e6407d87c9b9189b7678baaee01..f6d2bad16af980b3c0ced5bc46536c24013a012d 100644 (file)
--- a/src/effectstack/effectstackview2.h
+++ b/src/effectstack/effectstackview2.h
@@ -76,7 +76,7 @@ public:
     static const QString getStyleSheet();
 
     /** @brief Import keyframes from the clip metadata */
-    void setKeyframes(const QString data, int maximum);
+    void setKeyframes(const QString &data, int maximum);
 
 protected:
     virtual void mouseMoveEvent(QMouseEvent * event);

diff --git a/src/effectstack/parametercontainer.cpp b/src/effectstack/parametercontainer.cpp
index be7b3965f1eaa60f43f6b67ecd72eedfa1362460..953bdf5ab63887401b48f5c30a1bce5eee0add4f 100644 (file)
--- a/src/effectstack/parametercontainer.cpp
+++ b/src/effectstack/parametercontainer.cpp
@@ -95,7 +95,7 @@ class Fontval: public QWidget, public Ui::Fontval_UI
 };
 
 
-ParameterContainer::ParameterContainer(QDomElement effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent) :
+ParameterContainer::ParameterContainer(const QDomElement &effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent) :
         m_keyframeEditor(NULL),
         m_geometryWidget(NULL),
         m_metaInfo(metaInfo),

diff --git a/src/effectstack/parametercontainer.h b/src/effectstack/parametercontainer.h
index aa0e2478854990e15cc58e397de5e277467fc3db..65c048b46a40d25cc7428f74fadd9b478aa1ed0f 100644 (file)
--- a/src/effectstack/parametercontainer.h
+++ b/src/effectstack/parametercontainer.h
@@ -47,7 +47,7 @@ class MySpinBox : public QSpinBox
     Q_OBJECT
 
 public:
-    MySpinBox(QWidget * parent = 0);
+    explicit MySpinBox(QWidget * parent = 0);
     
 protected:
     virtual void focusInEvent(QFocusEvent*);
@@ -59,7 +59,7 @@ class ParameterContainer : public QObject
     Q_OBJECT
 
 public:
-    ParameterContainer(QDomElement effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent = 0);
+    ParameterContainer(const QDomElement &effect, ItemInfo info, EffectMetaInfo *metaInfo, QWidget * parent = 0);
     ~ParameterContainer();
     void updateTimecodeFormat();
     void updateProjectFormat(MltVideoProfile profile, Timecode t);

diff --git a/src/projecttree/meltjob.cpp b/src/projecttree/meltjob.cpp
index 5ef79396ece7a375e9dbd4ebd9de9fd8fec4c227..6ddaa28f0c0e70c457be80a5c156860178882267 100644 (file)
--- a/src/projecttree/meltjob.cpp
+++ b/src/projecttree/meltjob.cpp
@@ -35,7 +35,7 @@ static void consumer_frame_render(mlt_consumer, MeltJob * self, mlt_frame frame_
     self->emitFrameNumber((int) frame.get_position());
 }
 
-MeltJob::MeltJob(CLIPTYPE cType, const QString &id, QStringList parameters,  QMap <QString, QString>extraParams) : AbstractClipJob(MLTJOB, cType, id, parameters),
+MeltJob::MeltJob(CLIPTYPE cType, const QString &id, const QStringList &parameters,  const QMap <QString, QString>&extraParams) : AbstractClipJob(MLTJOB, cType, id, parameters),
     addClipToProject(0),
     m_consumer(NULL),
     m_producer(NULL),

diff --git a/src/projecttree/meltjob.h b/src/projecttree/meltjob.h
index 22dd03448704a237b599b565177670e48309b22b..82326d81000a68219198d551d03e95a710815c58 100644 (file)
--- a/src/projecttree/meltjob.h
+++ b/src/projecttree/meltjob.h
@@ -41,7 +41,7 @@ class MeltJob : public AbstractClipJob
     Q_OBJECT
 
 public:
-    MeltJob(CLIPTYPE cType, const QString &id, QStringList parameters, stringMap extraParams = stringMap());
+    MeltJob(CLIPTYPE cType, const QString &id, const QStringList& parameters, const stringMap& extraParams = stringMap());
     virtual ~ MeltJob();
     const QString destination() const;
     void startJob();

diff --git a/src/projecttree/proxyclipjob.cpp b/src/projecttree/proxyclipjob.cpp
index 7ef2906f05acd8d9de293f976065701fc88de426..ca498f3d11271249cecb4ee0ef4b4ce27bb92e5f 100644 (file)
--- a/src/projecttree/proxyclipjob.cpp
+++ b/src/projecttree/proxyclipjob.cpp
@@ -25,7 +25,7 @@
 #include <KDebug>
 #include <KLocale>
 
-ProxyJob::ProxyJob(CLIPTYPE cType, const QString &id, QStringList parameters) : AbstractClipJob(PROXYJOB, cType, id, parameters),
+ProxyJob::ProxyJob(CLIPTYPE cType, const QString &id, const QStringList& parameters) : AbstractClipJob(PROXYJOB, cType, id, parameters),
     m_jobDuration(0),
     m_isFfmpegJob(true)
 {

diff --git a/src/projecttree/proxyclipjob.h b/src/projecttree/proxyclipjob.h
index beca4b1e926552c03fce921801315899793a5978..935c4fe92ca9e10a84c78e5f745f213aa15f1692 100644 (file)
--- a/src/projecttree/proxyclipjob.h
+++ b/src/projecttree/proxyclipjob.h
@@ -32,7 +32,7 @@ class ProxyJob : public AbstractClipJob
     Q_OBJECT
 
 public:
-    ProxyJob(CLIPTYPE cType, const QString &id, QStringList parameters);
+    ProxyJob(CLIPTYPE cType, const QString &id, const QStringList& parameters);
     virtual ~ ProxyJob();
     const QString destination() const;
     void startJob();

diff --git a/src/stopmotion/stopmotion.cpp b/src/stopmotion/stopmotion.cpp
index 866d6f273958b940588449d431a036c1adb617f2..83060e089fb9b8d39f2d56bc59d6d61145fd084b 100644 (file)
--- a/src/stopmotion/stopmotion.cpp
+++ b/src/stopmotion/stopmotion.cpp
@@ -139,7 +139,7 @@ void StopmotionMonitor::slotMouseSeek(int /*eventDelta*/, bool /*fast*/)
 {
 }
 
-StopmotionWidget::StopmotionWidget(MonitorManager *manager, const KUrl &projectFolder, QList< QAction* > actions, QWidget* parent) :
+StopmotionWidget::StopmotionWidget(MonitorManager *manager, const KUrl &projectFolder, const QList<QAction *> &actions, QWidget* parent) :
     QDialog(parent)
     , Ui::Stopmotion_UI()
     , m_projectFolder(projectFolder)

diff --git a/src/stopmotion/stopmotion.h b/src/stopmotion/stopmotion.h
index 7d89befd151a2ebc69741e2208f22fe1c6b0239a..bbda1a6f4d8fbfe7885897dc78a5709c9c25842b 100644 (file)
--- a/src/stopmotion/stopmotion.h
+++ b/src/stopmotion/stopmotion.h
@@ -92,7 +92,7 @@ public:
      * @param projectFolder The current project folder, where captured files will be stored.
      * @param actions The actions for this widget that can have a keyboard shortcut.
      * @param parent (optional) parent widget */
-    StopmotionWidget(MonitorManager *manager, const KUrl &projectFolder, QList< QAction* > actions, QWidget* parent = 0);
+    StopmotionWidget(MonitorManager *manager, const KUrl &projectFolder, const QList< QAction* > &actions, QWidget* parent = 0);
     virtual ~StopmotionWidget();
 
 protected:

diff --git a/src/v4l/v4lcapture.cpp b/src/v4l/v4lcapture.cpp
index d95bf702b5aff638990f28fb7173ca004cc05b4c..bee35725eddc7093bfbe82c8edbbe4d474fa6b48 100644 (file)
--- a/src/v4l/v4lcapture.cpp
+++ b/src/v4l/v4lcapture.cpp
@@ -44,7 +44,7 @@ V4lCaptureHandler::V4lCaptureHandler()
 
 //static
 
-QStringList V4lCaptureHandler::getDeviceName(QString input)
+QStringList V4lCaptureHandler::getDeviceName(const QString &input)
 {
 
     char *src = strdup(input.toUtf8().constData());

diff --git a/src/v4l/v4lcapture.h b/src/v4l/v4lcapture.h
index 915b517bb318899dcdc5b685be982e5bfac34d7d..9a742f651e62ce3df44bcffa3d889c6317ec2203 100644 (file)
--- a/src/v4l/v4lcapture.h
+++ b/src/v4l/v4lcapture.h
@@ -32,7 +32,7 @@ class V4lCaptureHandler
 
 public:
     V4lCaptureHandler();
-    static QStringList getDeviceName(QString input);
+    static QStringList getDeviceName(const QString &input);
 
 };
 

diff --git a/thumbnailer/westleypreview.cpp b/thumbnailer/westleypreview.cpp
index 91132787f6cef51f6431a56404eba5fbc70a346e..4fab7b4ecd71534d17e4fb9fcdffe2644c67482c 100644 (file)
--- a/thumbnailer/westleypreview.cpp
+++ b/thumbnailer/westleypreview.cpp
@@ -117,7 +117,7 @@ QImage MltPreview::getFrame(Mlt::Producer *producer, int framepos, int /*width*/
 }
 
 
-uint MltPreview::imageVariance(QImage image)
+uint MltPreview::imageVariance(const QImage &image)
 {
     if (image.isNull()) return 0;
     uint delta = 0;

diff --git a/thumbnailer/westleypreview.h b/thumbnailer/westleypreview.h
index ca974c4e7eb21c7f1e46fc57898dd86cb12e94e4..290146015f81b244794d3eaeea9438b470f60d88 100644 (file)
--- a/thumbnailer/westleypreview.h
+++ b/thumbnailer/westleypreview.h
@@ -41,7 +41,7 @@ public:
     virtual Flags flags() const;
 
 protected:
-    static uint imageVariance(QImage image);
+    static uint imageVariance(const QImage &image);
     QImage getFrame(Mlt::Producer* producer, int framepos, int width, int height);
 };