Use const'ref

diff --git a/plugins/sampleplugin/sampleplugin.cpp b/plugins/sampleplugin/sampleplugin.cpp
index d40395c0f5ee31c8f5a6b92ef38f1ab30905137b..de754d6cd1144cefba1140408cd4983066c4bed0 100644 (file)
--- a/plugins/sampleplugin/sampleplugin.cpp
+++ b/plugins/sampleplugin/sampleplugin.cpp
@@ -32,7 +32,7 @@
 #include <QInputDialog>
 #include <QProcess>
 
-QStringList SamplePlugin::generators(const QStringList producers) const
+QStringList SamplePlugin::generators(const QStringList &producers) const
 {
     QStringList result;
     if (producers.contains("pango")) result << i18n("Countdown");

diff --git a/plugins/sampleplugin/sampleplugin.h b/plugins/sampleplugin/sampleplugin.h
index 6c1667b18520b7c261084c106aade28f10e709f0..9f01f5e7bdd4e667193175367afda0b69b7e776b 100644 (file)
--- a/plugins/sampleplugin/sampleplugin.h
+++ b/plugins/sampleplugin/sampleplugin.h
@@ -34,7 +34,7 @@ class SamplePlugin : public QObject, public ClipGenerator
     Q_INTERFACES(ClipGenerator)
 
 public:
-    QStringList generators(const QStringList producers = QStringList()) const;
+    QStringList generators(const QStringList &producers = QStringList()) const;
     KUrl generatedClip(const QString &renderer, const QString &generator, const KUrl &projectFolder, const QStringList &lumaNames, const QStringList &lumaFiles, const double fps, const int width, const int height);
 };
 

diff --git a/renderer/renderjob.cpp b/renderer/renderjob.cpp
index b8b0704b79528185e649939b18b66106fe9bb311..60ba1df6be468195f0191ee4373ae4e93d3ceb47 100644 (file)
--- a/renderer/renderjob.cpp
+++ b/renderer/renderjob.cpp
@@ -32,7 +32,7 @@
 class SleepThread : QThread
 {
 public:
-    virtual void run() {};
+    virtual void run() {}
     static void msleep(unsigned long msecs) {
         QThread::msleep(msecs);
     }
@@ -118,7 +118,7 @@ RenderJob::RenderJob(bool erase, bool usekuiserver, int pid, const QString& rend
 
 RenderJob::~RenderJob()
 {
-    if (m_renderProcess) delete m_renderProcess;
+    delete m_renderProcess;
     if (m_enablelog) {
         m_logfile.close();
     }

diff --git a/src/beziercurve/beziersplineeditor.cpp b/src/beziercurve/beziersplineeditor.cpp
index eef766a8ad7512fbf61805e3dcede44e709f318f..89bcdd1eb35f4552ab53f143ed1c6cf603ba83bb 100644 (file)
--- a/src/beziercurve/beziersplineeditor.cpp
+++ b/src/beziercurve/beziersplineeditor.cpp
@@ -45,11 +45,10 @@ BezierSplineEditor::BezierSplineEditor(QWidget* parent) :
 
 BezierSplineEditor::~BezierSplineEditor()
 {
-    if (m_pixmapCache)
-        delete m_pixmapCache;
+    delete m_pixmapCache;
 }
 
-CubicBezierSpline BezierSplineEditor::spline()
+CubicBezierSpline BezierSplineEditor::spline() const
 {
     return m_spline;
 }

diff --git a/src/beziercurve/beziersplineeditor.h b/src/beziercurve/beziersplineeditor.h
index 19b091277a001f5cc9ec7f490f81c920e4e0986f..e601e8ed69defdd10b1a714a1914a0a03d7effa0 100644 (file)
--- a/src/beziercurve/beziersplineeditor.h
+++ b/src/beziercurve/beziersplineeditor.h
@@ -32,7 +32,7 @@ public:
     BezierSplineEditor(QWidget* parent = 0);
     virtual ~BezierSplineEditor();
 
-    CubicBezierSpline spline();
+    CubicBezierSpline spline() const;
     void setSpline(const CubicBezierSpline &spline);
 
     /** @brief Returns the selected point or else BPoint. */

diff --git a/src/beziercurve/beziersplinewidget.cpp b/src/beziercurve/beziersplinewidget.cpp
index 3fd59643ce3bd4ac6c16921b221ecd0554e5e24e..e4d5a322cd4ee6aeb4487819315f724691f0d3f9 100644 (file)
--- a/src/beziercurve/beziersplinewidget.cpp
+++ b/src/beziercurve/beziersplinewidget.cpp
@@ -97,7 +97,7 @@ BezierSplineWidget::BezierSplineWidget(const QString& spline, QWidget* parent) :
     m_ui.buttonShowAllHandles->setChecked(KdenliveSettings::bezier_showallhandles());
 }
 
-QString BezierSplineWidget::spline()
+QString BezierSplineWidget::spline() const
 {
     return m_edit.spline().toString();
 }

diff --git a/src/beziercurve/beziersplinewidget.h b/src/beziercurve/beziersplinewidget.h
index cddefef03e348c0c58ceade026f384956f98aaa6..6a224c3eee9c13e04ec2b5d04265338336008ff8 100644 (file)
--- a/src/beziercurve/beziersplinewidget.h
+++ b/src/beziercurve/beziersplinewidget.h
@@ -37,7 +37,7 @@ public:
     explicit BezierSplineWidget(const QString &spline, QWidget* parent = 0);
 
     /** @brief Returns the current spline. */
-    QString spline();
+    QString spline() const;
 
     /** The curvemodes refer to the usage of the spline.
      * As this widget is currently only used for frei0r.curves the modes are the channels this filter accepts. */

diff --git a/src/commands/addclipcutcommand.cpp b/src/commands/addclipcutcommand.cpp
index d5bf0829e9a1ebdb014e20a098256ba5e9c1a038..09920054d4733e3c196c64f5b2f3ef18263b7636 100644 (file)
--- a/src/commands/addclipcutcommand.cpp
+++ b/src/commands/addclipcutcommand.cpp
@@ -22,7 +22,7 @@
 
 #include <KLocale>
 
-AddClipCutCommand::AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString desc, bool newItem, bool remove, QUndoCommand * parent) :
+AddClipCutCommand::AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString& desc, bool newItem, bool remove, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_list(list),
         m_id(id),

diff --git a/src/commands/addclipcutcommand.h b/src/commands/addclipcutcommand.h
index 96f3239e1f18ee21bef13a02157842359ee71f7b..3fc2126409ca2830c4253e05e8888ccee3806af0 100644 (file)
--- a/src/commands/addclipcutcommand.h
+++ b/src/commands/addclipcutcommand.h
@@ -29,7 +29,7 @@ class ProjectList;
 class AddClipCutCommand : public QUndoCommand
 {
 public:
-    AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString desc, bool newItem, bool remove, QUndoCommand * parent = 0);
+    AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString &desc, bool newItem, bool remove, QUndoCommand * parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/addeffectcommand.cpp b/src/commands/addeffectcommand.cpp
index 5e09957c7890a8f253eabfeee1b16773dcb6bc48..e720caa15f0d53f3f0576c588e3e1efafe4b154a 100644 (file)
--- a/src/commands/addeffectcommand.cpp
+++ b/src/commands/addeffectcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-AddEffectCommand::AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement effect, bool doIt, QUndoCommand * parent) :
+AddEffectCommand::AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &effect, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_track(track),

diff --git a/src/commands/addeffectcommand.h b/src/commands/addeffectcommand.h
index f929dc57dc2160585428d5ab4da19223272549f3..5856a05ab6bc62b17d746ddbad3cf80d853d03d7 100644 (file)
--- a/src/commands/addeffectcommand.h
+++ b/src/commands/addeffectcommand.h
@@ -31,7 +31,7 @@ class CustomTrackView;
 class AddEffectCommand : public QUndoCommand
 {
 public:
-    AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement effect, bool doIt, QUndoCommand * parent = 0);
+    AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &effect, bool doIt, QUndoCommand * parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/addfoldercommand.cpp b/src/commands/addfoldercommand.cpp
index b5146d96419243f6b460f1069d4a713c5132fe1a..392a666d2efd89a52f87621196dbf362aa9ccf81 100644 (file)
--- a/src/commands/addfoldercommand.cpp
+++ b/src/commands/addfoldercommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-AddFolderCommand::AddFolderCommand(ProjectList *view, const QString folderName, const QString &clipId, bool doIt, QUndoCommand *parent) :
+AddFolderCommand::AddFolderCommand(ProjectList *view, const QString &folderName, const QString &clipId, bool doIt, QUndoCommand *parent) :
         QUndoCommand(parent),
         m_view(view),
         m_name(folderName),

diff --git a/src/commands/addfoldercommand.h b/src/commands/addfoldercommand.h
index 3028a18167624a3b9759c6d3afd11dea85c54ee9..c9e52c513d47239d2ad166c1ed46c6d683f64e91 100644 (file)
--- a/src/commands/addfoldercommand.h
+++ b/src/commands/addfoldercommand.h
@@ -28,7 +28,7 @@ class ProjectList;
 class AddFolderCommand : public QUndoCommand
 {
 public:
-    AddFolderCommand(ProjectList *view, const QString folderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0);
+    AddFolderCommand(ProjectList *view, const QString &folderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/addtimelineclipcommand.cpp b/src/commands/addtimelineclipcommand.cpp
index 2f309efc29ae47f55e4478f7c6e1393c586a2ba2..f6befebf427300fb67cfcc15f3caf40b8bd5428a 100644 (file)
--- a/src/commands/addtimelineclipcommand.cpp
+++ b/src/commands/addtimelineclipcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-AddTimelineClipCommand::AddTimelineClipCommand(CustomTrackView *view, QDomElement xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent) :
+AddTimelineClipCommand::AddTimelineClipCommand(CustomTrackView *view, const QDomElement &xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_clipInfo(info),

diff --git a/src/commands/addtimelineclipcommand.h b/src/commands/addtimelineclipcommand.h
index 7058473bf6535a9554161f8c68e12bb7f42aefa9..7d508c3957e6957622eb0d2352d104af9b703f93 100644 (file)
--- a/src/commands/addtimelineclipcommand.h
+++ b/src/commands/addtimelineclipcommand.h
@@ -34,7 +34,7 @@ class CustomTrackView;
 class AddTimelineClipCommand : public QUndoCommand
 {
 public:
-    AddTimelineClipCommand(CustomTrackView *view, QDomElement xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent = 0);
+    AddTimelineClipCommand(CustomTrackView *view, const QDomElement &xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/addtransitioncommand.cpp b/src/commands/addtransitioncommand.cpp
index c8acc6dc8aa30ae13a58752a3dfda588e47289f0..22912c325f9f5a9f1c06170c7dd271e6bfc60280 100644 (file)
--- a/src/commands/addtransitioncommand.cpp
+++ b/src/commands/addtransitioncommand.cpp
@@ -21,7 +21,7 @@
 
 #include <KLocale>
 
-AddTransitionCommand::AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, QDomElement params, bool remove, bool doIt, QUndoCommand * parent) :
+AddTransitionCommand::AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, const QDomElement &params, bool remove, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_info(info),

diff --git a/src/commands/addtransitioncommand.h b/src/commands/addtransitioncommand.h
index be6f6a19bc1d2c8c17be3201a099b7b4e8f1d598..5a5a6f547e720b87df305849137709226ac56e2d 100644 (file)
--- a/src/commands/addtransitioncommand.h
+++ b/src/commands/addtransitioncommand.h
@@ -32,7 +32,7 @@ class CustomTrackView;
 class AddTransitionCommand : public QUndoCommand
 {
 public:
-    AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, QDomElement params, bool remove, bool doIt, QUndoCommand * parent = 0);
+    AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, const QDomElement &params, bool remove, bool doIt, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/changeeffectstatecommand.cpp b/src/commands/changeeffectstatecommand.cpp
index ecc455cab0ab71c25915be6a6920ba460ef8f150..d62d02befaec9add87b024f90da82913c83610f0 100644 (file)
--- a/src/commands/changeeffectstatecommand.cpp
+++ b/src/commands/changeeffectstatecommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-ChangeEffectStateCommand::ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, QList <int> effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent) :
+ChangeEffectStateCommand::ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, const QList <int>& effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent) :
         QUndoCommand(parent),
         m_view(view),
         m_track(track),

diff --git a/src/commands/changeeffectstatecommand.h b/src/commands/changeeffectstatecommand.h
index 563ef523dcbf6b7496bcfaddc0faa76e0c17432d..ee2c7d0bfcc14c3ebcdeb5cbc14a23db24215ae2 100644 (file)
--- a/src/commands/changeeffectstatecommand.h
+++ b/src/commands/changeeffectstatecommand.h
@@ -31,7 +31,7 @@ class CustomTrackView;
 class ChangeEffectStateCommand : public QUndoCommand
 {
 public:
-    ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, QList <int> effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0);
+    ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, const QList <int>& effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/configtrackscommand.cpp b/src/commands/configtrackscommand.cpp
index f034eddedc5a8edca8c457487a9df6defd92b15d..bfa8b696365890b4f538ae036f1ba40785677da9 100644 (file)
--- a/src/commands/configtrackscommand.cpp
+++ b/src/commands/configtrackscommand.cpp
@@ -22,7 +22,7 @@
 #include "customtrackview.h"
 
 
-ConfigTracksCommand::ConfigTracksCommand(CustomTrackView* view, QList< TrackInfo > oldInfos, QList< TrackInfo > newInfos, QUndoCommand* parent) :
+ConfigTracksCommand::ConfigTracksCommand(CustomTrackView* view, const QList<TrackInfo> &oldInfos, const QList<TrackInfo> &newInfos, QUndoCommand* parent) :
         QUndoCommand(parent),
         m_view(view),
         m_oldInfos(oldInfos),

diff --git a/src/commands/configtrackscommand.h b/src/commands/configtrackscommand.h
index 9c13c3e012875ee66addb8c09ee3a729bc1bcbb2..6dd0a2edadaddd56a37e9a4cb877c37d17257606 100644 (file)
--- a/src/commands/configtrackscommand.h
+++ b/src/commands/configtrackscommand.h
@@ -31,7 +31,7 @@ class CustomTrackView;
 class ConfigTracksCommand : public QUndoCommand
 {
 public:
-    ConfigTracksCommand(CustomTrackView *view, QList <TrackInfo> oldInfos, QList <TrackInfo> newInfos, QUndoCommand * parent = 0);
+    ConfigTracksCommand(CustomTrackView *view, const QList <TrackInfo> &oldInfos, const QList <TrackInfo> &newInfos, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/editclipcommand.cpp b/src/commands/editclipcommand.cpp
index d65acfc509794290fdf2e8d860887cae2c5e1d40..153cac3fbfd9584bc5c70c6bade2c24a8a3c2206 100644 (file)
--- a/src/commands/editclipcommand.cpp
+++ b/src/commands/editclipcommand.cpp
@@ -22,7 +22,7 @@
 
 #include <KLocale>
 
-EditClipCommand::EditClipCommand(ProjectList *list, const QString &id, QMap <QString, QString> oldparams, QMap <QString, QString> newparams, bool doIt, QUndoCommand * parent) :
+EditClipCommand::EditClipCommand(ProjectList *list, const QString &id, const QMap <QString, QString> &oldparams, const QMap <QString, QString> &newparams, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_list(list),
         m_oldparams(oldparams),

diff --git a/src/commands/editclipcommand.h b/src/commands/editclipcommand.h
index 1f3afed38fe41e6300ef91d1500eac302952df2a..423f629884062b054946d0bf8038d573c7ffd7f2 100644 (file)
--- a/src/commands/editclipcommand.h
+++ b/src/commands/editclipcommand.h
@@ -30,7 +30,7 @@ class ProjectList;
 class EditClipCommand : public QUndoCommand
 {
 public:
-    EditClipCommand(ProjectList *list, const QString &id, QMap <QString, QString> oldparams, QMap <QString, QString> newparams, bool doIt, QUndoCommand * parent = 0);
+    EditClipCommand(ProjectList *list, const QString &id, const QMap <QString, QString> &oldparams, const QMap <QString, QString> &newparams, bool doIt, QUndoCommand * parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/editclipcutcommand.cpp b/src/commands/editclipcutcommand.cpp
index b6708f81c3549c00743765f25468e6b1907c948f..2d0f92f1cc495ba487e4b6d3aa3f03c1dbefc012 100644 (file)
--- a/src/commands/editclipcutcommand.cpp
+++ b/src/commands/editclipcutcommand.cpp
@@ -22,7 +22,7 @@
 
 #include <KLocale>
 
-EditClipCutCommand::EditClipCutCommand(ProjectList *list, const QString &id, const QPoint oldZone, const QPoint newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent) :
+EditClipCutCommand::EditClipCutCommand(ProjectList *list, const QString &id, const QPoint &oldZone, const QPoint &newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_list(list),
         m_id(id),

diff --git a/src/commands/editclipcutcommand.h b/src/commands/editclipcutcommand.h
index b8090aacdf01b66dd1f4edc61966558e0697c2cf..dbd2af98a0277104f60a2391a912f4cb3535c44f 100644 (file)
--- a/src/commands/editclipcutcommand.h
+++ b/src/commands/editclipcutcommand.h
@@ -31,7 +31,7 @@ class ProjectList;
 class EditClipCutCommand : public QUndoCommand
 {
 public:
-    EditClipCutCommand(ProjectList *list, const QString &id, const QPoint oldZone, const QPoint newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent = 0);
+    EditClipCutCommand(ProjectList *list, const QString &id, const QPoint &oldZone, const QPoint &newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/editeffectcommand.cpp b/src/commands/editeffectcommand.cpp
index 10654c182a7bbbce19bbbe68621d972e7bd4e276..841e129fc11e67c9352fa016478ee20e32172392 100644 (file)
--- a/src/commands/editeffectcommand.cpp
+++ b/src/commands/editeffectcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-EditEffectCommand::EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent) :
+EditEffectCommand::EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent) :
         QUndoCommand(parent),
         m_view(view),
         m_track(track),

diff --git a/src/commands/editeffectcommand.h b/src/commands/editeffectcommand.h
index 6129420ed532a5cbad8baaa2a7b9756b36cbf6b1..2c7719ea380f4b4ca3d6cb99243b7955b94e6eb5 100644 (file)
--- a/src/commands/editeffectcommand.h
+++ b/src/commands/editeffectcommand.h
@@ -31,7 +31,7 @@ class CustomTrackView;
 class EditEffectCommand : public QUndoCommand
 {
 public:
-    EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0);
+    EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0);
 
     virtual int id() const;
     virtual bool mergeWith(const QUndoCommand * command);

diff --git a/src/commands/editfoldercommand.cpp b/src/commands/editfoldercommand.cpp
index 6dbcd7fc95b343118c2a071d05f19dbaceee1ac4..1b569f16f7bd53b5c33b66f95db86e6ca4edc153 100644 (file)
--- a/src/commands/editfoldercommand.cpp
+++ b/src/commands/editfoldercommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-EditFolderCommand::EditFolderCommand(ProjectList *view, const QString newfolderName, const QString oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent) :
+EditFolderCommand::EditFolderCommand(ProjectList *view, const QString &newfolderName, const QString &oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent) :
         QUndoCommand(parent),
         m_view(view),
         m_name(newfolderName),

diff --git a/src/commands/editfoldercommand.h b/src/commands/editfoldercommand.h
index 96e9a3f1f776d0dfe010d54f832cddc6bd0dda34..644292922decdfd5bfdd29642153e2439a92402e 100644 (file)
--- a/src/commands/editfoldercommand.h
+++ b/src/commands/editfoldercommand.h
@@ -28,7 +28,7 @@ class ProjectList;
 class EditFolderCommand : public QUndoCommand
 {
 public:
-    EditFolderCommand(ProjectList *view, const QString newfolderName, const QString oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0);
+    EditFolderCommand(ProjectList *view, const QString &newfolderName, const QString &oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0);
 
     virtual void undo();
     virtual void redo();

diff --git a/src/commands/edittransitioncommand.cpp b/src/commands/edittransitioncommand.cpp
index dd3afe7da269871f6e9001db0b3e11bc10a7e43a..56ca9aecf2bd6864052fde9766be1dbd5fa0ea6b 100644 (file)
--- a/src/commands/edittransitioncommand.cpp
+++ b/src/commands/edittransitioncommand.cpp
@@ -20,7 +20,7 @@
 
 #include <KLocale>
 
-EditTransitionCommand::EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, bool doIt, QUndoCommand * parent) :
+EditTransitionCommand::EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_track(track),

diff --git a/src/commands/edittransitioncommand.h b/src/commands/edittransitioncommand.h
index eb3e96bba3550bc9777a109d6cffb50dec0e4b64..e331cd96057301a26e72530efd1e8f5f264b1ae1 100644 (file)
--- a/src/commands/edittransitioncommand.h
+++ b/src/commands/edittransitioncommand.h
@@ -28,7 +28,7 @@ class CustomTrackView;
 class EditTransitionCommand : public QUndoCommand
 {
 public:
-    EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, bool doIt, QUndoCommand * parent = NULL);
+    EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, bool doIt, QUndoCommand * parent = NULL);
 
     virtual int id() const;
     virtual bool mergeWith(const QUndoCommand * command);

diff --git a/src/commands/groupclipscommand.cpp b/src/commands/groupclipscommand.cpp
index 77010c16c763eb2ffbd697695a416c45c641278e..fa77295d0c36308fbeed320cce5ed5536098bee6 100644 (file)
--- a/src/commands/groupclipscommand.cpp
+++ b/src/commands/groupclipscommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-GroupClipsCommand::GroupClipsCommand(CustomTrackView *view, const QList <ItemInfo> clipInfos, const QList <ItemInfo> transitionInfos, bool group, QUndoCommand * parent) :
+GroupClipsCommand::GroupClipsCommand(CustomTrackView *view, const QList <ItemInfo> &clipInfos, const QList <ItemInfo>& transitionInfos, bool group, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_clips(clipInfos),

diff --git a/src/commands/groupclipscommand.h b/src/commands/groupclipscommand.h
index 5634e62e9a5549bb30a77ab713f0c1bd2f1b64b7..d1dd427bbf64c95344782f4e1adc8cc4bd58cebe 100644 (file)
--- a/src/commands/groupclipscommand.h
+++ b/src/commands/groupclipscommand.h
@@ -33,7 +33,7 @@ class CustomTrackView;
 class GroupClipsCommand : public QUndoCommand
 {
 public:
-    GroupClipsCommand(CustomTrackView *view, const QList <ItemInfo> clipInfos, const QList <ItemInfo> transitionInfos, bool group, QUndoCommand * parent = 0);
+    GroupClipsCommand(CustomTrackView *view, const QList <ItemInfo> &clipInfos, const QList <ItemInfo> &transitionInfos, bool group, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/insertspacecommand.cpp b/src/commands/insertspacecommand.cpp
index 7802a82b44e8bda170f6228cc0a95ab54b84ee59..3e5a784a3b5c8aa6cda6ae1b9df15be4e0d7f2de 100644 (file)
--- a/src/commands/insertspacecommand.cpp
+++ b/src/commands/insertspacecommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-InsertSpaceCommand::InsertSpaceCommand(CustomTrackView *view, QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent) :
+InsertSpaceCommand::InsertSpaceCommand(CustomTrackView *view, const QList<ItemInfo> &clipsToMove, const QList<ItemInfo> &transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_clipsToMove(clipsToMove),

diff --git a/src/commands/insertspacecommand.h b/src/commands/insertspacecommand.h
index 39b8d4c07334f31e20e8a079b6698f3b5bd98ea0..ab8d97dc8eaace3462765d74b2d96ebf4377813f 100644 (file)
--- a/src/commands/insertspacecommand.h
+++ b/src/commands/insertspacecommand.h
@@ -32,7 +32,7 @@ class CustomTrackView;
 class InsertSpaceCommand : public QUndoCommand
 {
 public:
-    InsertSpaceCommand(CustomTrackView *view, QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent = 0);
+    InsertSpaceCommand(CustomTrackView *view, const QList<ItemInfo> &clipsToMove, const QList<ItemInfo> &transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/moveeffectcommand.cpp b/src/commands/moveeffectcommand.cpp
index 43d502d7e07eca0e197fd93a65fcf5774afe40ba..c077128803d5e048199b9069d956e23eca13dc19 100644 (file)
--- a/src/commands/moveeffectcommand.cpp
+++ b/src/commands/moveeffectcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, QList <int> oldPos, int newPos, QUndoCommand * parent) :
+MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QList<int> &oldPos, int newPos, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_track(track),

diff --git a/src/commands/moveeffectcommand.h b/src/commands/moveeffectcommand.h
index bc1fd30f67305cdd6081e48a69a2ac9c888c1bda..e4aa6d707532b81bbec1cc15a5779fbe7a642b73 100644 (file)
--- a/src/commands/moveeffectcommand.h
+++ b/src/commands/moveeffectcommand.h
@@ -31,7 +31,7 @@ class CustomTrackView;
 class MoveEffectCommand : public QUndoCommand
 {
 public:
-    MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, QList <int> oldPos, int newPos, QUndoCommand * parent = 0);
+    MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QList <int> &oldPos, int newPos, QUndoCommand * parent = 0);
 
     virtual int id() const;
     virtual bool mergeWith(const QUndoCommand * command);

diff --git a/src/commands/movegroupcommand.cpp b/src/commands/movegroupcommand.cpp
index f22bdc95818546294e1462cb3eebf4de8a623e16..ecfe2519902aab2aebf0a334e1f0c7a9293445fa 100644 (file)
--- a/src/commands/movegroupcommand.cpp
+++ b/src/commands/movegroupcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-MoveGroupCommand::MoveGroupCommand(CustomTrackView *view, const QList <ItemInfo> startClip, const QList <ItemInfo> startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent) :
+MoveGroupCommand::MoveGroupCommand(CustomTrackView *view, const QList <ItemInfo> &startClip, const QList <ItemInfo> &startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_startClip(startClip),

diff --git a/src/commands/movegroupcommand.h b/src/commands/movegroupcommand.h
index c9550ea53aa1795dee460665c9e8992c5342e133..66f8d26e5e2dd77776ea307f0da8baf0a81f1189 100644 (file)
--- a/src/commands/movegroupcommand.h
+++ b/src/commands/movegroupcommand.h
@@ -30,7 +30,7 @@ class CustomTrackView;
 class MoveGroupCommand : public QUndoCommand
 {
 public:
-    MoveGroupCommand(CustomTrackView *view, const QList <ItemInfo> startClip, const QList <ItemInfo> startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent = 0);
+    MoveGroupCommand(CustomTrackView *view, const QList <ItemInfo> &startClip, const QList <ItemInfo> &startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/commands/razorclipcommand.cpp b/src/commands/razorclipcommand.cpp
index 4c6b5cbc9e88acefa65cbfd45f57a6a88ab85930..53257ebb40be78a8c6070f8717e0dc3c268f6621 100644 (file)
--- a/src/commands/razorclipcommand.cpp
+++ b/src/commands/razorclipcommand.cpp
@@ -23,7 +23,7 @@
 
 #include <KLocale>
 
-RazorClipCommand::RazorClipCommand(CustomTrackView *view, const ItemInfo info, EffectsList stack, const GenTime cutTime, bool doIt, QUndoCommand * parent) :
+RazorClipCommand::RazorClipCommand(CustomTrackView *view, const ItemInfo &info, EffectsList stack, const GenTime cutTime, bool doIt, QUndoCommand * parent) :
         QUndoCommand(parent),
         m_view(view),
         m_info(info),

diff --git a/src/commands/razorclipcommand.h b/src/commands/razorclipcommand.h
index b014318e6d6f6e1314e989eb100d1e114528b9e2..0da865ac68c00a28f48e37c8a5ec64112eeb9a15 100644 (file)
--- a/src/commands/razorclipcommand.h
+++ b/src/commands/razorclipcommand.h
@@ -33,7 +33,7 @@ class CustomTrackView;
 class RazorClipCommand : public QUndoCommand
 {
 public:
-    RazorClipCommand(CustomTrackView *view, const ItemInfo info, EffectsList stack, const GenTime cutTime, bool doIt = true, QUndoCommand * parent = 0);
+    RazorClipCommand(CustomTrackView *view, const ItemInfo &info, EffectsList stack, const GenTime cutTime, bool doIt = true, QUndoCommand * parent = 0);
     virtual void undo();
     virtual void redo();
 

diff --git a/src/interfaces.h b/src/interfaces.h
index 974ed3b6b82fb6be510268c5a388317df405e896..a1e279feaaed6d14c90ccc21146c70ffe14a404a 100644 (file)
--- a/src/interfaces.h
+++ b/src/interfaces.h
@@ -29,7 +29,7 @@ class ClipGenerator
 public:
     virtual ~ClipGenerator() {}
 
-    virtual QStringList generators(const QStringList  producers = QStringList()) const = 0;
+    virtual QStringList generators(const QStringList&  producers = QStringList()) const = 0;
     virtual KUrl generatedClip(const QString &renderer, const QString &generator, const KUrl &projectFolder, const QStringList &lumaNames, const QStringList &lumaFiles, const double fps, const int width, const int height) = 0;
 };