ei.value -= Sign[Us] * ThreatedByPawnPenalty[Piece];
// Bishop and knight outposts squares
- if ((Piece == BISHOP || Piece == KNIGHT) && pos.square_is_weak(s, Them))
+ if ((Piece == BISHOP || Piece == KNIGHT) && pos.square_is_weak(s, Us))
evaluate_outposts<Piece, Us>(pos, ei, s);
// Special patterns: trapped bishops on a7/h7/a2/h2
// Find the safe squares for our pieces inside the area defined by
// SpaceMask[us]. A square is unsafe if it is attacked by an enemy
// pawn, or if it is undefended and attacked by an enemy piece.
-
Bitboard safeSquares = SpaceMask[Us]
& ~pos.pieces(PAWN, Us)
& ~ei.attacked_by(Them, PAWN)
- & ~(~ei.attacked_by(Us) & ei.attacked_by(Them));
+ & (ei.attacked_by(Us) | ~ei.attacked_by(Them));
- // Find all squares which are at most three squares behind some friendly
- // pawn.
+ // Find all squares which are at most three squares behind some friendly pawn
Bitboard behindFriendlyPawns = pos.pieces(PAWN, Us);
behindFriendlyPawns |= (Us == WHITE ? behindFriendlyPawns >> 8 : behindFriendlyPawns << 8);
behindFriendlyPawns |= (Us == WHITE ? behindFriendlyPawns >> 16 : behindFriendlyPawns << 16);
Score weight_option(const std::string& mgOpt, const std::string& egOpt, Score internalWeight) {
- Score uciWeight = make_score(get_option_value_int(mgOpt), get_option_value_int(egOpt));
-
- // Convert to integer to prevent overflow
- int mg = mg_value(uciWeight);
- int eg = eg_value(uciWeight);
+ // Scale option value from 100 to 256
+ int mg = get_option_value_int(mgOpt) * 256 / 100;
+ int eg = get_option_value_int(egOpt) * 256 / 100;
- mg = (mg * 0x100) / 100;
- eg = (eg * 0x100) / 100;
- mg = (mg * mg_value(internalWeight)) / 0x100;
- eg = (eg * eg_value(internalWeight)) / 0x100;
- return make_score(mg, eg);
+ return apply_weight(make_score(mg, eg), internalWeight);
}
// init_safety() initizes the king safety evaluation, based on UCI
void init_safety() {
- int maxSlope = 30;
- int peak = 0x500;
- double a = 0.4;
- double b = 0.0;
+ const Value MaxSlope = Value(30);
+ const Value Peak = Value(1280);
Value t[100];
// First setup the base table
for (int i = 0; i < 100; i++)
{
- if (i < b)
- t[i] = Value(0);
- else
- t[i] = Value((int)(a * (i - b) * (i - b)));
- }
+ t[i] = Value(int(0.4 * i * i));
- for (int i = 1; i < 100; i++)
- {
- if (t[i] - t[i - 1] > maxSlope)
- t[i] = t[i - 1] + Value(maxSlope);
+ if (i > 0)
+ t[i] = Min(t[i], t[i - 1] + MaxSlope);
- if (t[i] > Value(peak))
- t[i] = Value(peak);
+ t[i] = Min(t[i], Peak);
}
// Then apply the weights and get the final KingDangerTable[] array