Pass the color for which the square is to be
considered weak, not the opposite.
It is more natural and intuitive in this way.
No functional change.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
ei.value -= Sign[Us] * ThreatedByPawnPenalty[Piece];
// Bishop and knight outposts squares
- if ((Piece == BISHOP || Piece == KNIGHT) && pos.square_is_weak(s, Them))
+ if ((Piece == BISHOP || Piece == KNIGHT) && pos.square_is_weak(s, Us))
evaluate_outposts<Piece, Us>(pos, ei, s);
// Special patterns: trapped bishops on a7/h7/a2/h2
}
inline bool Position::square_is_weak(Square s, Color c) const {
- return !(pieces(PAWN, c) & outpost_mask(opposite_color(c), s));
+ return !(pieces(PAWN, opposite_color(c)) & outpost_mask(c, s));
}
inline Key Position::get_key() const {