Release split point lock before to wake up
master thread. This seems to increase speed
in case "sleeping threads" are used:
After 7792 games with 4 threads at very fast TC (2"+0.05)
Mod vs Orig 1722 - 1627 - 4443 ELO +4 (+- 5.1)
No functional change.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
Stack ss[MAX_PLY_PLUS_2];
Position pos(*sp->pos, threadID);
Stack ss[MAX_PLY_PLUS_2];
Position pos(*sp->pos, threadID);
+ int master = sp->master;
memcpy(ss, sp->ss - 1, 4 * sizeof(Stack));
(ss+1)->sp = sp;
memcpy(ss, sp->ss - 1, 4 * sizeof(Stack));
(ss+1)->sp = sp;
sp->slavesMask &= ~(1ULL << threadID);
sp->nodes += pos.nodes_searched();
sp->slavesMask &= ~(1ULL << threadID);
sp->nodes += pos.nodes_searched();
- // Wake up master thread so to allow it to return from the idle loop in
- // case we are the last slave of the split point.
- if ( Threads.use_sleeping_threads()
- && threadID != sp->master
- && !Threads[sp->master].is_searching)
- Threads[sp->master].wake_up();
-
// After releasing the lock we cannot access anymore any SplitPoint
// related data in a reliably way becuase it could have been released
// under our feet by the sp master.
lock_release(sp->lock);
// After releasing the lock we cannot access anymore any SplitPoint
// related data in a reliably way becuase it could have been released
// under our feet by the sp master.
lock_release(sp->lock);
+
+ // Wake up master thread so to allow it to return from the idle loop in
+ // case we are the last slave of the split point.
+ if ( Threads.use_sleeping_threads()
+ && threadID != master
+ && !Threads[master].is_searching)
+ Threads[master].wake_up();
}
}
// In helpful master concept a master can help only a sub-tree of its split
}
}
// In helpful master concept a master can help only a sub-tree of its split
// Try to allocate available threads and ask them to start searching setting
// is_searching flag. This must be done under lock protection to avoid concurrent
// allocation of the same slave by another master.
// Try to allocate available threads and ask them to start searching setting
// is_searching flag. This must be done under lock protection to avoid concurrent
// allocation of the same slave by another master.
- lock_grab(sp->lock); // To protect sp->slaves_mask
for (int i = 0; i < activeThreads && !Fake; i++)
if (threads[i].is_available_to(master))
for (int i = 0; i < activeThreads && !Fake; i++)
if (threads[i].is_available_to(master))
masterThread.splitPoint = sp;
masterThread.activeSplitPoints++;
masterThread.splitPoint = sp;
masterThread.activeSplitPoints++;
- lock_release(sp->lock);
+ lock_release(sp->lock);
// Everything is set up. The master thread enters the idle loop, from which
// it will instantly launch a search, because its is_searching flag is set.
// Everything is set up. The master thread enters the idle loop, from which
// it will instantly launch a search, because its is_searching flag is set.
// We have returned from the idle loop, which means that all threads are
// finished. Note that setting is_searching and decreasing activeSplitPoints is
// done under lock protection to avoid a race with Thread::is_available_to().
// We have returned from the idle loop, which means that all threads are
// finished. Note that setting is_searching and decreasing activeSplitPoints is
// done under lock protection to avoid a race with Thread::is_available_to().
lock_grab(sp->lock); // To protect sp->nodes
lock_grab(sp->lock); // To protect sp->nodes
masterThread.is_searching = true;
masterThread.activeSplitPoints--;
masterThread.splitPoint = sp->parent;
pos.set_nodes_searched(pos.nodes_searched() + sp->nodes);
masterThread.is_searching = true;
masterThread.activeSplitPoints--;
masterThread.splitPoint = sp->parent;
pos.set_nodes_searched(pos.nodes_searched() + sp->nodes);
- lock_release(sp->lock);
+ lock_release(sp->lock);
Depth depth;
Value beta;
int nodeType;
Depth depth;
Value beta;
int nodeType;
int master;
Move threatMove;
int master;
Move threatMove;